[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> I'll take that up!
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 03:50:22 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode When run in FIPS mode CryptoTest.RsaPrivateKeyInputOutputPEM test fails as described in KUDU-3207 due to the use of PKCS #8 instead of the expected PKCS #1. This patch disables the test when run in FIPS mode until we can standardize the RSA private key format. Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Reviewed-on: http://gerrit.cloudera.org:8080/17051 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin --- M src/kudu/security/crypto-test.cc 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17051 ) Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Feb 2021 03:46:17 + Gerrit-HasComments: No
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> Sure. Go ahead.
Awesome. I just need a +2. :D
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 02:12:35 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> Instead of waiting for the gmock change, can we merge this and adjust all t
Sure. Go ahead.
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 01:30:06 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Grant Henke has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> I'll take that up!
Instead of waiting for the gmock change, can we merge this and adjust all tests
with a similar guard in a later patch as there are likely a few. At the moment
this test is break some of my scheduled FIPS runs (Which are not run as a part
of Apache Kudu).
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 01:22:23 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> Good find! I think this deserves a separate changelist on its own. Ideall
I'll take that up!
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 01:01:34 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Alexey Serbin has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@98
PS2, Line 98: Skip when run in FIPS mode due to different private key format.
nit: this comment looks like a comment explaining what's going on, but not TODO
per se
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
> Nit: It'd be good to bump googletest version to 1.10 and use the GTEST_SKIP
Good find! I think this deserves a separate changelist on its own. Ideally,
there should be 2 changelists:
* a changelist to bump GMOCK_VERSION from 1.8.0 to 1.10.0
* a changelist to replace all constructs like this and AllowSlowTests()
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 00:54:40 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Bankim Bhavsar has posted comments on this change. (
http://gerrit.cloudera.org:8080/17051 )
Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc
File src/kudu/security/crypto-test.cc:
http://gerrit.cloudera.org:8080/#/c/17051/2/src/kudu/security/crypto-test.cc@99
PS2, Line 99: if (FIPS_mode()) {
Nit: It'd be good to bump googletest version to 1.10 and use the GTEST_SKIP()
macro that'll mark the test as SKIPPED instead of PASSED for FIPS till the test
is fixed.
https://github.com/google/googletest/pull/1544
Thirdparty is still building for me with following change...
$ git diff
diff --git a/thirdparty/vars.sh b/thirdparty/vars.sh
index 6b8eab85f..ca034bd98 100644
--- a/thirdparty/vars.sh
+++ b/thirdparty/vars.sh
@@ -46,7 +46,7 @@ GLOG_VERSION=0.3.5
GLOG_NAME=glog-$GLOG_VERSION
GLOG_SOURCE=$TP_SOURCE_DIR/$GLOG_NAME
-GMOCK_VERSION=1.8.0
+GMOCK_VERSION=1.10.0
GMOCK_NAME=googletest-release-$GMOCK_VERSION
GMOCK_SOURCE=$TP_SOURCE_DIR/$GMOCK_NAME
--
To view, visit http://gerrit.cloudera.org:8080/17051
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88
Gerrit-Change-Number: 17051
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Attila Bukor
Gerrit-Reviewer: Bankim Bhavsar
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Feb 2021 00:47:04 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Hello Alexey Serbin, Attila Bukor, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/17051 to look at the new patch set (#2). Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode When run in FIPS mode CryptoTest.RsaPrivateKeyInputOutputPEM test fails as described in KUDU-3207 due to the use of PKCS #8 instead of the expected PKCS #1. This patch disables the test when run in FIPS mode until we can standardize the RSA private key format. Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 --- M src/kudu/security/crypto-test.cc 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/17051/2 -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Attila Bukor Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17051 Change subject: [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode .. [test] Skip CryptoTest.RsaPrivateKeyInputOutputPEM in FIPS mode When run in FIPS mode CryptoTest.RsaPrivateKeyInputOutputPEM test fails as described in KUDU-3207 due to the use of PKCS #8 instead of the expected PKCS #1. This patch disables the test when run in FIPS mode until we can standardize the RSA private key format. Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 --- M src/kudu/security/crypto-test.cc 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/17051/1 -- To view, visit http://gerrit.cloudera.org:8080/17051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2cf4a9286d1e3e9000c359fa69e27ef42d91ae88 Gerrit-Change-Number: 17051 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke
