[kudu-CR] [util] fix debug builds in macOS
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. [util] fix debug builds in macOS Prior to this patch, a debug build on macOS would fail with linker error like below: Undefined symbols for architecture x86_64: "kudu::HashAlgorithm_IsValid(int)", referenced from: kudu::BlockBloomFilterPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*) in block_bloom_filter.pb.cc.o kudu::BlockBloomFilterPB::set_hash_algorithm(kudu::HashAlgorithm) in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 and Undefined symbols for architecture x86_64: "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 and Undefined symbols for architecture x86_64: "kudu::tablet::TestCFileSet::kRatio", referenced from: kudu::tablet::TestCFileSet::WriteTestRowSet(int) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::FillBloomFilter(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::GetBloomFilterResult(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*) in cfile_set-test.cc.o ld: symbol(s) not found for architecture x86_64 This is a follow-up to 961888dd14e5bd306d3e5b741bc4443620617664. Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Reviewed-on: http://gerrit.cloudera.org:8080/15252 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M src/kudu/tablet/cfile_set-test.cc M src/kudu/util/CMakeLists.txt 2 files changed, 4 insertions(+), 2 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] fix debug builds in macOS
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt@29 PS1, Line 29: > Two dependencies are added: And yes, I tried to add only hash_proto, but it was not enough (see the second error message) -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:36:49 + Gerrit-HasComments: Yes
[kudu-CR] [util] fix debug builds in macOS
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt@29 PS1, Line 29: > Is pb_util_proto necessary? Also hash_proto already specifies protobuf so i Two dependencies are added: * hash_proto * pb_util_proto As you can see from the linker error messages, it was necessary to build it on macOS. I looked into the code, and indeed the auto-generated files contain the code from those two libraries. -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:34:41 + Gerrit-HasComments: Yes
[kudu-CR] [util] fix debug builds in macOS
Hello Kudu Jenkins, Adar Dembo, Bankim Bhavsar, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15252 to look at the new patch set (#2). Change subject: [util] fix debug builds in macOS .. [util] fix debug builds in macOS Prior to this patch, a debug build on macOS would fail with linker error like below: Undefined symbols for architecture x86_64: "kudu::HashAlgorithm_IsValid(int)", referenced from: kudu::BlockBloomFilterPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*) in block_bloom_filter.pb.cc.o kudu::BlockBloomFilterPB::set_hash_algorithm(kudu::HashAlgorithm) in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 and Undefined symbols for architecture x86_64: "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 and Undefined symbols for architecture x86_64: "kudu::tablet::TestCFileSet::kRatio", referenced from: kudu::tablet::TestCFileSet::WriteTestRowSet(int) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::FillBloomFilter(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::GetBloomFilterResult(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*) in cfile_set-test.cc.o ld: symbol(s) not found for architecture x86_64 This is a follow-up to 961888dd14e5bd306d3e5b741bc4443620617664. Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 --- M src/kudu/tablet/cfile_set-test.cc M src/kudu/util/CMakeLists.txt 2 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15252/2 -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] fix debug builds in macOS
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:35:15 + Gerrit-HasComments: No
[kudu-CR] [util] fix debug builds in macOS
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: Nothing to add to Bankim's questions. -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:24:26 + Gerrit-HasComments: No
[kudu-CR] [util] fix debug builds in macOS
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: > Uploaded patch set 1. Oh, it seems I declared victory too fast. There is another failure down the road: Undefined symbols for architecture x86_64: "kudu::tablet::TestCFileSet::kRatio", referenced from: kudu::tablet::TestCFileSet::WriteTestRowSet(int) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::FillBloomFilter(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*) in cfile_set-test.cc.o kudu::tablet::TestCFileSet::GetBloomFilterResult(int, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, kudu::BlockBloomFilter*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*, std::__1::vector >*) in cfile_set-test.cc.o ld: symbol(s) not found for architecture x86_64 Will post an update. -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:16:56 + Gerrit-HasComments: No
[kudu-CR] [util] fix debug builds in macOS
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15252 ) Change subject: [util] fix debug builds in macOS .. Patch Set 1: Code-Review+1 (1 comment) Thanks for fixing this, Alexey! http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15252/1/src/kudu/util/CMakeLists.txt@29 PS1, Line 29: Is pb_util_proto necessary? Also hash_proto already specifies protobuf so is that necessary too? -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Bankim Bhavsar Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 Feb 2020 05:16:03 + Gerrit-HasComments: Yes
[kudu-CR] [util] fix debug builds in macOS
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15252 Change subject: [util] fix debug builds in macOS .. [util] fix debug builds in macOS Prior to this patch, a debug build on macOS would fail with linker error like below: Undefined symbols for architecture x86_64: "kudu::HashAlgorithm_IsValid(int)", referenced from: kudu::BlockBloomFilterPB::MergePartialFromCodedStream(google::protobuf::io::CodedInputStream*) in block_bloom_filter.pb.cc.o kudu::BlockBloomFilterPB::set_hash_algorithm(kudu::HashAlgorithm) in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fhash_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 and Undefined symbols for architecture x86_64: "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::InitDefaults()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::TableStruct::InitDefaultsImpl() in block_bloom_filter.pb.cc.o "kudu::protobuf_kudu_2futil_2fpb_5futil_2eproto::AddDescriptors()", referenced from: kudu::protobuf_kudu_2futil_2fblock_5fbloom_5ffilter_2eproto::(anonymous namespace)::AddDescriptorsImpl() in block_bloom_filter.pb.cc.o ld: symbol(s) not found for architecture x86_64 This is a follow-up to 961888dd14e5bd306d3e5b741bc4443620617664. Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 --- M src/kudu/util/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/15252/1 -- To view, visit http://gerrit.cloudera.org:8080/15252 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48775a683bf47af5b97d44e14aa351eb54a69181 Gerrit-Change-Number: 15252 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
