[kudu-CR] Run the gradle build as a part of the gerrit tests

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: Run the gradle build as a part of the gerrit tests
..


Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Reviewed-on: http://gerrit.cloudera.org:8080/7651
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M build-support/jenkins/build-and-test.sh
1 file changed, 21 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7651

to look at the new patch set (#7).

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/7
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7651/6/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 385:   # Rerun the build using the Gradle build. 
> Clean up the trailing whitespace in this block of new code.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7651/6/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 385:   # Rerun the build using the Gradle build. 
Clean up the trailing whitespace in this block of new code.


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7651

to look at the new patch set (#6).

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/6
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 56: #   BUILD_JAVADefault: 1
> I think eventually we would switch to either maven or gradle and not contin
Sure, I'm fine with that too.


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Grant Henke has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 56: #   BUILD_JAVADefault: 1
> Update this comment to reflect that this builds the Java sources with Maven
I think eventually we would switch to either maven or gradle and not continue 
to have both since the maintenance of keeping them in sync is high. My though 
is to leave BUILD_JAVA generic and just have BUILD_GRADLE as an option until we 
swap completely.


Line 78: # Java tests.
> Hmm, but we're not using gradle to run tests, just to build. Is this intend
I can change this. Mainly a copy paste error.


Line 385:   # Rerun the build using the Gradle build. 
> Can we break this out of BUILD_JAVA so that you could run build-and-test.sh
See my other commend above. I think BUILD_JAVA should wrap BUILD_GRADLE since 
at some point we will remove maven and BUILD_JAVA will essentially become 
BUILD_GRADLE.


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Run the gradle build as a part of the gerrit tests
..


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7651/5/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

Line 56: #   BUILD_JAVADefault: 1
Update this comment to reflect that this builds the Java sources with Maven.


Line 75: # 
Gerrit flagged some extra whitespace here and below.


Line 78: # Java tests.
Hmm, but we're not using gradle to run tests, just to build. Is this intended 
to be a future-proof comment?


Line 385:   # Rerun the build using the Gradle build. 
Can we break this out of BUILD_JAVA so that you could run build-and-test.sh 
with BUILD_JAVA=0 and BUILD_GRADLE=1?


-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7651

to look at the new patch set (#5).

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 22 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/5
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/7651

to look at the new patch set (#4).

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/4
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Grant Henke has uploaded a new patch set (#2).

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 21 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Run the gradle build as a part of the gerrit tests

[Grant Henke (Code Review)]

Grant Henke has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7651

Change subject: Run the gradle build as a part of the gerrit tests
..

Run the gradle build as a part of the gerrit tests

Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
---
M build-support/jenkins/build-and-test.sh
1 file changed, 20 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/7651/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7651
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1430cbd05ff78a69f2439e3a8f90e1ddde83a8d7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke