[kudu-CR] tracing: gzip the trace JSON ajax response

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: tracing: gzip the trace JSON ajax response
..


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/server/tracing-path-handlers.cc
File src/kudu/server/tracing-path-handlers.cc:

PS3, Line 270: /tracing/json/end_recording_compressed
> Does it make sense to rely on Content-Encoding HTTP header field instead?
yea, I briefly considered that, but the way the web handler functions are 
currently registered, there's not actually any access to either retrieve or set 
any headers. I didn't want to scope-creep a small patch into redoing how web 
pages are registered/handled, so went with the "dumb" thing here. (also 
following what the upstream Chrome code does)


http://gerrit.cloudera.org:8080/#/c/4154/3/src/kudu/util/zlib.h
File src/kudu/util/zlib.h:

Line 22: #include "kudu/util/status.h"
> nit: consider including the header with Slice definition (kudu/util/slice.h
woops, will address these in a follow-up


-- 
To view, visit http://gerrit.cloudera.org:8080/4154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tracing: gzip the trace JSON ajax response

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: tracing: gzip the trace JSON ajax response
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG
Commit Message:

Line 18: version uses base64)
> nit: missing period
Done


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/server/tracing-path-handlers.cc
File src/kudu/server/tracing-path-handlers.cc:

Line 125: Status ZlibCompress(const string& input, stringstream* out) {
> maybe move this to some util place (don't feel strongly about it)
Done


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

Line 166: string ZlibUncompress(const faststring& compressed) {
> will do.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] tracing: gzip the trace JSON ajax response

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: tracing: gzip the trace JSON ajax response
..


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/4154/1//COMMIT_MSG
Commit Message:

Line 16: the server side. A corresponding commit on the JS side adds a slight
question: don't we need both of these commits together to avoid breaking 
pulling the trace?


Line 18: version uses base64)
nit: missing period


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/server/tracing-path-handlers.cc
File src/kudu/server/tracing-path-handlers.cc:

Line 125: Status ZlibCompress(const string& input, stringstream* out) {
maybe move this to some util place (don't feel strongly about it)


PS1, Line 262: kEndRecordingCompressed
oh, I see, we support both compressed and decompressed, so it won't break 
anything, is that it?


http://gerrit.cloudera.org:8080/#/c/4154/1/src/kudu/tserver/tablet_server-test.cc
File src/kudu/tserver/tablet_server-test.cc:

Line 166: string ZlibUncompress(const faststring& compressed) {
yeah, seems like if we have both compress and decompress this could be in util/ 
no?


-- 
To view, visit http://gerrit.cloudera.org:8080/4154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] tracing: gzip the trace JSON ajax response

[Todd Lipcon (Code Review)]

Hello Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4154

to review the following change.

Change subject: tracing: gzip the trace JSON ajax response
..

tracing: gzip the trace JSON ajax response

This enables gzipping of the actual trace which is sent back over HTTP
when using the tracing web page. I noticed that the traces can be quite
slow to receive, but given they often have a lot of repetitive text,
they are quite compressible.

The original Chrome implementation already did this, but I had ripped it
out for simplicity when importing the code. This simply adds it back on
the server side. A corresponding commit on the JS side adds a slight
tweak so that we can send back binary gzipped data (whereas the Chrome
version uses base64)

Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
---
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
M thirdparty/vars.sh
3 files changed, 103 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/54/4154/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4154
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8d5966e65b51576bf1460cb1ea8c2240ea88cbc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Mike Percy