Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

[Guangya Liu]

> On 九月 20, 2015, 6:46 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 486
> > 
> >
> > this method should be called suppress too.
> > 
> > 
> > to avoid conflict with the suppress marco, can you try putting that 
> > macro inside a "signals" namespace?

Vinod, I was planning to fix this in 
https://reviews.apache.org/r/38519/diff/1#1 , but the following code diff still 
does not work after apply to https://reviews.apache.org/r/38519

diff --git a/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 
b/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
index 7a79024..91076c0 100644
--- a/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
+++ b/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
@@ -23,10 +23,12 @@
 #include 
 #endif // __WINDOWS__
 
+namespace signals {
 
 #define suppress(signal) \
   if (os::signals::internal::Suppressor suppressor ## signal = \
   os::signals::internal::Suppressor(signal))
 
+} // namespace signals {
 
 #endif // __STOUT_OS_SIGNALS_HPP__
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 
b/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
index de86232..b1d11c3 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
@@ -40,7 +40,7 @@ TEST_F(OsSignalsTest, Suppress)
   const string data = "hello";
 
   // Let's make sure we can suppress SIGPIPE!
-  suppress(SIGPIPE) {
+  signals::suppress(SIGPIPE) {
 // Writing to a pipe that has been closed generates SIGPIPE.
 ASSERT_EQ(-1, write(pipes[1], data.c_str(), data.length()));
 
I was continually getting error of the following, any suggestions? Thanks.

In file included from 
../../3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp:28:0,
 from 
../../3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp:23,
 from 
../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:84,
 from 
../../3rdparty/libprocess/3rdparty/stout/include/stout/posix/net.hpp:39,
 from 
../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:59,
 from ../../3rdparty/libprocess/include/process/address.hpp:31,
 from ../../3rdparty/libprocess/include/process/pid.hpp:26,
 from ../../3rdparty/libprocess/include/process/latch.hpp:20,
 from ../../3rdparty/libprocess/include/process/future.hpp:33,
 from ../../include/mesos/authorizer/authorizer.hpp:28,
 from ../../src/local/local.cpp:26:
../../3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp:29:3: 
error: expected unqualified-id before 'if'
   if (os::signals::internal::Suppressor suppressor ## signal = \
   ^
../../src/master/master.hpp:832:8: note: in expansion of macro 'suppress'
   void suppress(Framework* framework);
^


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38514/#review99710
---


On 九月 19, 2015, 1:27 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38514/
> ---
> 
> (Updated 九月 19, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A comment from Vinod: After some discussion with other committers,
> most of them felt SUPPRESS is better than QUIESCE.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 89ddc10d5873cdf09bf5084c4869bc7c29933eab 
>   include/mesos/v1/scheduler/scheduler.proto 
> bc19b8dfb2ded26a30a28e7370f06816e0fb1999 
>   src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
>   src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
>   src/master/validation.cpp 0f3fc1a20b065a88712cceabab0ceffaec598533 
>   src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
>   src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 
> 
> Diff: https://reviews.apache.org/r/38514/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu:14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38516/#review99717
---

Ship it!


Ship It!

- Vinod Kone


On Sept. 21, 2015, 12:11 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38516/
> ---
> 
> (Updated Sept. 21, 2015, 12:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A comment from Vinod: After some discussion with other committers,
> most of them felt suppressOffers is better than quiesceOffers.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp 3fea47ffcc69531308068e2701502e481605b912 
>   include/mesos/scheduler.hpp 071f448153080bfcc967755157cf900994947484 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 
> d8acc4fe92fc8dfbd582b165fba24dac492c28d4 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 
> de88463da2f6833633542442a0d66370507c4018 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> ba4bc58f57b01ad3705438e1172bf6663e2a2446 
>   src/master/allocator/mesos/allocator.hpp 
> 904dc6220a1b722ca9c4582b91f98cad81eacc53 
>   src/master/allocator/mesos/hierarchical.hpp 
> d3496bcff6235adc3a6bb7de7b4c3d23d540cfa0 
>   src/master/master.cpp 6c0db210747c7d88179556abaade65743bd8cb3a 
>   src/master/metrics.hpp a3c0c0c18047298179b6d09c4126fe594c0b4eaf 
>   src/master/metrics.cpp 6bce80bace0c2ad01ec0b26de9ecbd401a597988 
>   src/python/interface/src/mesos/interface/__init__.py 
> cd60ead6c6519d7347aec1fd9315735af0fa818a 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.hpp 
> 04e3190949fba8e4675352636b0a649a033f702f 
>   src/python/native/src/mesos/native/mesos_scheduler_driver_impl.cpp 
> 10208b176c9b45d5c9afc096564e27403dcde695 
>   src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
>   src/tests/master_tests.cpp a044286d10bf1ab0676c7d403af59e0b1fea 
>   src/tests/mesos.hpp e1c06352736c339e8cd336811134054617df1fc6 
>   src/tests/metrics_tests.cpp 9b7f84a8c6b4f56f329577569041621a617aa0cb 
>   src/tests/scheduler_tests.cpp 0f892f9d423f0bc72cdab22452e0ad7965dda444 
> 
> Diff: https://reviews.apache.org/r/38516/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu:14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

[Vinod Kone]

> On Sept. 20, 2015, 6:46 p.m., Vinod Kone wrote:
> > src/master/http.cpp, line 486
> > 
> >
> > this method should be called suppress too.
> > 
> > 
> > to avoid conflict with the suppress marco, can you try putting that 
> > macro inside a "signals" namespace?
> 
> Guangya Liu wrote:
> Vinod, I was planning to fix this in 
> https://reviews.apache.org/r/38519/diff/1#1 , but the following code diff 
> still does not work after apply to https://reviews.apache.org/r/38519
> 
> diff --git 
> a/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp 
> b/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
> index 7a79024..91076c0 100644
> --- a/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
> +++ b/3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
> @@ -23,10 +23,12 @@
>  #include 
>  #endif // __WINDOWS__
>  
> +namespace signals {
>  
>  #define suppress(signal) \
>if (os::signals::internal::Suppressor suppressor ## signal = \
>os::signals::internal::Suppressor(signal))
>  
> +} // namespace signals {
>  
>  #endif // __STOUT_OS_SIGNALS_HPP__
> diff --git 
> a/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 
> b/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
> index de86232..b1d11c3 100644
> --- a/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
> +++ b/3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
> @@ -40,7 +40,7 @@ TEST_F(OsSignalsTest, Suppress)
>const string data = "hello";
>  
>// Let's make sure we can suppress SIGPIPE!
> -  suppress(SIGPIPE) {
> +  signals::suppress(SIGPIPE) {
>  // Writing to a pipe that has been closed generates SIGPIPE.
>  ASSERT_EQ(-1, write(pipes[1], data.c_str(), data.length()));
>  
> I was continually getting error of the following, any suggestions? Thanks.
> 
> In file included from 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp:28:0,
>  from 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp:23,
>  from 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:84,
>  from 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/posix/net.hpp:39,
>  from 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:59,
>  from 
> ../../3rdparty/libprocess/include/process/address.hpp:31,
>  from 
> ../../3rdparty/libprocess/include/process/pid.hpp:26,
>  from 
> ../../3rdparty/libprocess/include/process/latch.hpp:20,
>  from 
> ../../3rdparty/libprocess/include/process/future.hpp:33,
>  from ../../include/mesos/authorizer/authorizer.hpp:28,
>  from ../../src/local/local.cpp:26:
> 
> ../../3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp:29:3: 
> error: expected unqualified-id before 'if'
>if (os::signals::internal::Suppressor suppressor ## signal = \
>^
> ../../src/master/master.hpp:832:8: note: in expansion of macro 'suppress'
>void suppress(Framework* framework);
> ^

try putting "()" around the suppress function in master.cpp to avoid master 
expansion.

alternatively, the 'suppress' macro can be renamed to 'block'. cc @bmahler


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38514/#review99710
---


On Sept. 19, 2015, 1:27 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38514/
> ---
> 
> (Updated Sept. 19, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A comment from Vinod: After some discussion with other committers,
> most of them felt SUPPRESS is better than QUIESCE.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> 89ddc10d5873cdf09bf5084c4869bc7c29933eab 
>   include/mesos/v1/scheduler/scheduler.proto 
> bc19b8dfb2ded26a30a28e7370f06816e0fb1999 
>   src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
>   src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
>   src/master/validation.cpp 0f3fc1a20b065a88712cceabab0ceffaec598533 
>   src/sched/sched.cpp 84c2edb2c660f976fd57d1407dd2e9d5376500aa 
>   src/tests/scheduler_tests.cpp 

Re: Review Request 38519: Change function quiesce() to suppressRes()

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99718
---



src/master/http.cpp (line 486)


'suppressRes' is weird. this got to be 'suppress'. we need to figure out 
how to resolve the conflict with the macro.


- Vinod Kone


On Sept. 19, 2015, 1:26 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> ---
> 
> (Updated Sept. 19, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The reason that I was not using suppress() is because suppress is
> already defined in
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
>   src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e 
>   src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
> 
> Diff: https://reviews.apache.org/r/38519/diff/
> 
> 
> Testing
> ---
> 
> Platform: Ubuntu:14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99698
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 1:44 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 1:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99704
---

Ship it!


Thanks for the catch!! LGTM module the memory leak.


src/slave/containerizer/linux_launcher.cpp (line 199)


We need to free up the memory allocated above. It should be safe to do so 
after the clone call returns since it creates a new process.


- Kapil Arya


On Sept. 20, 2015, 12:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 12:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

(Updated Sept. 20, 2015, 4:08 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael 
Park.


Changes
---

Fix minor issues.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang

Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38457/
---

(Updated Sept. 21, 2015, 2:43 a.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Bugs: MESOS-3250
https://issues.apache.org/jira/browse/MESOS-3250


Repository: mesos


Description
---

A few third-party libraries (libev, gmock) do not have `make install`
commands available, so below we have to add our own "install" commands.

The reason is: if we do not, we get runtime library load problems on OS
X. In particular, `dydl` will look for these libraries at the prefix we
passed to `configure` (or in `/usr/local` if we did not pass a prefix
in), but since they don't have a `make install` step, they never get
placed in the prefix folder.

Our solution is to:
  (1) make a lib directory inside the Mesos folder for each of the
  libraries that has no install step, and
  (2) copy all such libraries into their respective directories.

(Note that step (1) is not only convenient, but important: make will add
a `lib` to the end of your prefix path when linking, and since the built
libraries end up in a `.libs` folder, it's not enough to simply pass the
build directory into `configure` as a prefix; so if we're going to move
the libraries, we might as well move them to a library folder.)


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 

Diff: https://reviews.apache.org/r/38457/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38540/#review99721
---


Patch looks great!

Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 2:41 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38540/
> ---
> 
> (Updated Sept. 21, 2015, 2:41 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Generate make batch file to build project in windows.
> 
> This commit is the product of two reviews; the first one[1], by
> haosdent, was lightly rebased by hausdorff to target a later HEAD, and
> then augmented to fix the broken Ubuntu 14.04 build that this commit
> caused. Other than those things, the review is functionally identical to
> the original, and all credit for the work should go to haosdent.
> 
> [1] Original review: https://reviews.apache.org/r/37275
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38540/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/#review99720
---

Ship it!


Ship It!

- haosdent huang


On Sept. 21, 2015, 2:33 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38538/
> ---
> 
> (Updated Sept. 21, 2015, 2:33 a.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3434
> https://issues.apache.org/jira/browse/MESOS-3434
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This was originally part of this review[1] by haosdent. It was split out
> and moved into the root folder by hausdorff, because we will later reuse
> it to build other third-party libraries on Windows that are not only in
> libprocess, and hence it belongs outside of the commits that touch
> libprocess.
> 
> But, the code is essentially haosdent's, so the credit should go to him.
> 
> [1] Original review: https://reviews.apache.org/r/37273
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/Common.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38538/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38541/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

As we prepare to add more third-party dependencies, it will be helpful
to have all the version information of our third-party dependencies in
one place, rather than scattered everywhere in the project.

This commit will introduce `Versions.cmake`, which will hold all this
information.


Diffs
-

  3rdparty/cmake/Versions.cmake PRE-CREATION 
  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 

Diff: https://reviews.apache.org/r/38541/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38542/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Currently we configure the version information of third-party
dependencies in the CMake build system from magic strings.

This commit will transition away from the magic string solution and
towards the variables we define in `Versions.cmake`.


Diffs
-

  3rdparty/libprocess/cmake/ProcessConfigure.cmake 
a5f8d399e151acad87bb72ecb1f7372b2c467423 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e 

Diff: https://reviews.apache.org/r/38542/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38542/#review99722
---


Patch looks great!

Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540, 
38541, 38542]

All tests passed.

- Mesos ReviewBot


On Sept. 21, 2015, 3:23 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38542/
> ---
> 
> (Updated Sept. 21, 2015, 3:23 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Currently we configure the version information of third-party
> dependencies in the CMake build system from magic strings.
> 
> This commit will transition away from the magic string solution and
> towards the variables we define in `Versions.cmake`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/cmake/ProcessConfigure.cmake 
> a5f8d399e151acad87bb72ecb1f7372b2c467423 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e 
> 
> Diff: https://reviews.apache.org/r/38542/diff/
> 
> 
> Testing
> ---
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the 
> following platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/
---

(Updated 九月 21, 2015, 5:02 a.m.)


Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.


Changes
---

rebase


Summary (updated)
-

WIP: Add explanatory comments for Allocator interface


Bugs: MESOS-2224
https://issues.apache.org/jira/browse/MESOS-2224


Repository: mesos


Description
---

Add explanatory comments for Allocator interface


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
c746ba51c9985365428e3caaae1327a4f9bfd7d3 
  3rdparty/libprocess/3rdparty/Makefile.am 
e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz 
0ade1be899f63a8749e06344f2b30b960648d05e 
  3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
e36f4b9aed50a75767d29306cb8d4974c4995156 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
2285ce9eaba668d5215c108849055fe92163da4d 
  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
bc167f1fa9e64f89138f131e726e7733c66da29c 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
88b6147fa47ebfcb6000de5b2f0891d4438d26bf 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
6f154cd5ab12e1d1dd64e56574d2186ae53ee66e 
  3rdparty/libprocess/3rdparty/versions.am 
98195b8eb60b2673d610d8ab7ea31103f137debf 
  3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
  3rdparty/libprocess/src/tests/metrics_tests.cpp 
8f15ee7e89e5346d306df71eb06a7161da13af48 
  docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
  include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
  include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
  include/mesos/v1/mesos.proto 58e5a6b7912d6f96d495a34d0913b9d27ad65fb5 
  src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
  src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
  src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
  src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
  src/master/http.cpp 8bb59355e3852617faccad8cc65e1f9dbd7988b4 
  src/master/maintenance.hpp a37412ff928b0313752ca45364c0ac9e14a0f70c 
  src/master/maintenance.cpp 5fe935886a029c7959e07b82ec20cb31b0e7055c 
  src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
  src/slave/containerizer/provisioner/docker/token_manager.cpp 
18b29c3d0ddf25fd3f4713c5de10aeec3b381df0 
  src/tests/fault_tolerance_tests.cpp c97bc4691f9bac4a8677e6d2247be96ee9674b57 
  src/tests/hierarchical_allocator_tests.cpp 
505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 
  src/tests/master_maintenance_tests.cpp 
9892bc329ff850f638e9f5e79d047efaf2fcb037 
  src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
  src/tests/monitor_tests.cpp 583e71183e7bc80608047bd8c323170ebfd95646 
  src/tests/rate_limiting_tests.cpp e512aa690413ee871b56011a9bb1292fa8ab8c33 
  src/tests/registrar_tests.cpp 5131b570e1b94431dfaea74d5f504a29e520b1f1 
  src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 

Diff: https://reviews.apache.org/r/37993/diff/


Testing
---


Thanks,

Guangya Liu

Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38540/
---

Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3434
https://issues.apache.org/jira/browse/MESOS-3434


Repository: mesos


Description
---

Generate make batch file to build project in windows.

This commit is the product of two reviews; the first one[1], by
haosdent, was lightly rebased by hausdorff to target a later HEAD, and
then augmented to fix the broken Ubuntu 14.04 build that this commit
caused. Other than those things, the review is functionally identical to
the original, and all credit for the work should go to haosdent.

[1] Original review: https://reviews.apache.org/r/37275


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 

Diff: https://reviews.apache.org/r/38540/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38539/
---

Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3434
https://issues.apache.org/jira/browse/MESOS-3434


Repository: mesos


Description
---

Add CMake macro VsBuildCommand in libprocess.

This commit is the product of two reviews; the first one[1], by
haosdent, was lightly rebased by hausdorff to target a later HEAD, and
then augmented to fix the broken Ubuntu 14.04 build that this commit
caused. Other than those things, the review is functionally identical to
the original, and all credit for the work should go to haosdent.

[1] Original review: https://reviews.apache.org/r/37273


Diffs
-

  3rdparty/libprocess/3rdparty/CMakeLists.txt 
b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
  3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/38539/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/
---

Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van 
Remoortere, and Joseph Wu.


Bugs: MESOS-3434
https://issues.apache.org/jira/browse/MESOS-3434


Repository: mesos


Description
---

This was originally part of this review[1] by haosdent. It was split out
and moved into the root folder by hausdorff, because we will later reuse
it to build other third-party libraries on Windows that are not only in
libprocess, and hence it belongs outside of the commits that touch
libprocess.

But, the code is essentially haosdent's, so the credit should go to him.

[1] Original review: https://reviews.apache.org/r/37273


Diffs
-

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/Common.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/38538/diff/


Testing
---

Compiled and ran made sure libprocess and stout tests ran and passed on the 
following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37993/#review99723
---


Bad patch!

Reviews applied: [37993]

Failed command: ./support/apply-review.sh -n -r 37993

Error:
 2015-09-21 05:27:48 URL:https://reviews.apache.org/r/37993/diff/raw/ 
[92103/92103] -> "37993.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/CMakeLists.txt:35
error: 3rdparty/libprocess/3rdparty/CMakeLists.txt: patch does not apply
error: patch failed: include/mesos/master/allocator.hpp:159
error: include/mesos/master/allocator.hpp: patch does not apply
error: patch failed: src/master/master.cpp:785
error: src/master/master.cpp: patch does not apply
error: patch failed: src/tests/master_maintenance_tests.cpp:1026
error: src/tests/master_maintenance_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 21, 2015, 5:02 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37993/
> ---
> 
> (Updated Sept. 21, 2015, 5:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, and Michael Park.
> 
> 
> Bugs: MESOS-2224
> https://issues.apache.org/jira/browse/MESOS-2224
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add explanatory comments for Allocator interface
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt 
> c746ba51c9985365428e3caaae1327a4f9bfd7d3 
>   3rdparty/libprocess/3rdparty/Makefile.am 
> e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/3rdparty/picojson-1.3.0.tar.gz 
> 0ade1be899f63a8749e06344f2b30b960648d05e 
>   3rdparty/libprocess/3rdparty/picojson-4f93734.tar.gz PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> e36f4b9aed50a75767d29306cb8d4974c4995156 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2285ce9eaba668d5215c108849055fe92163da4d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp 
> bc167f1fa9e64f89138f131e726e7733c66da29c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> 88b6147fa47ebfcb6000de5b2f0891d4438d26bf 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 
> 6f154cd5ab12e1d1dd64e56574d2186ae53ee66e 
>   3rdparty/libprocess/3rdparty/versions.am 
> 98195b8eb60b2673d610d8ab7ea31103f137debf 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> 8f15ee7e89e5346d306df71eb06a7161da13af48 
>   docs/mesos-c++-style-guide.md 570ea6873ffc2cc8ec190ec3aa81986e3f3cbc95 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 
>   include/mesos/v1/mesos.proto 58e5a6b7912d6f96d495a34d0913b9d27ad65fb5 
>   src/Makefile.am 834f69afe87a093c6d275916f7781d470535a728 
>   src/common/protobuf_utils.hpp 3817c6a3374b2e8f333784261a0c8edabf854fd9 
>   src/common/protobuf_utils.cpp 4dc58fed315d99fd9cdde49e91eab1f4947ef046 
>   src/docker/docker.cpp afcedf1f1a309bd0626c33ee25694ac1b43bdec7 
>   src/master/http.cpp 8bb59355e3852617faccad8cc65e1f9dbd7988b4 
>   src/master/maintenance.hpp a37412ff928b0313752ca45364c0ac9e14a0f70c 
>   src/master/maintenance.cpp 5fe935886a029c7959e07b82ec20cb31b0e7055c 
>   src/master/master.cpp ca4d5876dcd427964111428edc22d567ddaede0b 
>   src/slave/containerizer/provisioner/docker/token_manager.cpp 
> 18b29c3d0ddf25fd3f4713c5de10aeec3b381df0 
>   src/tests/fault_tolerance_tests.cpp 
> c97bc4691f9bac4a8677e6d2247be96ee9674b57 
>   src/tests/hierarchical_allocator_tests.cpp 
> 505b9de3d8d888c296f6103c80fe9f0ef1c2ca16 
>   src/tests/master_maintenance_tests.cpp 
> 9892bc329ff850f638e9f5e79d047efaf2fcb037 
>   src/tests/master_tests.cpp a477794df37c658b80d79dea8555b001415f7b6a 
>   src/tests/monitor_tests.cpp 583e71183e7bc80608047bd8c323170ebfd95646 
>   src/tests/rate_limiting_tests.cpp e512aa690413ee871b56011a9bb1292fa8ab8c33 
>   src/tests/registrar_tests.cpp 5131b570e1b94431dfaea74d5f504a29e520b1f1 
>   src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb 
> 
> Diff: https://reviews.apache.org/r/37993/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99705
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 4:08 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 4:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99708
---


Patch looks great!

Reviews applied: [38535]

All tests passed.

- Mesos ReviewBot


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> ---
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and 
> Michael Park.
> 
> 
> Bugs: MESOS-3474
> https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> dde552ff2a9d29c31f7676180fffa19d1fb0ba63 
> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> ---
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 37873: Add quiesce logic in allocator

[Vinod Kone]

> On Sept. 17, 2015, 9:42 p.m., Vinod Kone wrote:
> > src/tests/mesos.hpp, line 1608
> > 
> >
> > Needs a test for the scheduler driver. I've only see one for the http 
> > scheduler library.
> > 
> > Also, can you send a review for CHANGELOG and upgrades.md updates for 
> > 0.25.0? feel free to send that after this chain gets committed, to avoid 
> > making this chain even bigger.
> 
> Guangya Liu wrote:
> Vinod, I see that the CHANGELOG is now using 0.24.1 in release notes, so 
> I need to udpate QuiesceOffer to 0.24.1 CHANGELOG? Thanks.

No. Create a new CHANGELOG for 0.25.0 (WIP).


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37873/#review99450
---


On Sept. 18, 2015, 3:55 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37873/
> ---
> 
> (Updated Sept. 18, 2015, 3:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-3037
> https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add quiesce logic in allocator
> 
> 
> Diffs
> -
> 
>   include/mesos/master/allocator.hpp fb09e2a6502bc8c78ddcc8a595bcd9320da136ea 
>   src/master/allocator/mesos/allocator.hpp 
> 171548b2017a0b97124f052c21345668e274d117 
>   src/master/allocator/mesos/hierarchical.hpp 
> 3374d63b8311cf10b3108f56b7b167c12a9d7a37 
>   src/master/master.cpp 1c4e7af7448c05f54c1068d6496ed21c8c359ac5 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/37873/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/
---

(Updated Sept. 20, 2015, 5:04 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael 
Park.


Changes
---

Update according @karya reviews.


Bugs: MESOS-3474
https://issues.apache.org/jira/browse/MESOS-3474


Repository: mesos


Description
---

Fix ExamplesTest errors when user is root.


Diffs (updated)
-

  src/slave/containerizer/linux_launcher.cpp 
dde552ff2a9d29c31f7676180fffa19d1fb0ba63 

Diff: https://reviews.apache.org/r/38535/diff/


Testing
---

sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose


Thanks,

haosdent huang

Re: Review Request 37585: Maintenance primitives: Add a user doc.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37585/#review99711
---

Ship it!


fixed inline.


docs/maintenance.md (lines 139 - 140)


It wasn't clear at first what you meant by "this is not allowed", as you 
are stating a rule above.


- Joris Van Remoortere


On Sept. 19, 2015, 1:27 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37585/
> ---
> 
> (Updated Sept. 19, 2015, 1:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, 
> Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2083
> https://issues.apache.org/jira/browse/MESOS-2083
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Heavily based on the design doc 
> (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/).
> 
> Includes a diagram of the maintenance mode transitions.
> 
> 
> Diffs
> -
> 
>   docs/images/maintenance-primitives-modes.png PRE-CREATION 
>   docs/maintenance.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37585/diff/
> 
> 
> Testing
> ---
> 
> Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2
> Checked for markdown correctness.
> 
> 
> File Attachments
> 
> 
> Same as the image in the binary diff. (Uploaded for reviewer convenience.)
>   
> https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>