Re: Review Request 51079: Replaced gmock-1.7.0.tar.gz with a correct permissions version.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51079/
---

(Updated Aug. 14, 2016, 4:55 a.m.)


Review request for mesos, Kapil Arya and Till Toenshoff.


Bugs: MESOS-5925
https://issues.apache.org/jira/browse/MESOS-5925


Repository: mesos


Description
---

Some files' permissions in gmock-1.7.0.tar.gz are '0444/-r--r--r--',
which means owner don't have write permission on them. This breaks the
build of Mesos since Docker 1.12 on MacOS. This patch packaged
gmock-1.7.0.tar.gz with correct permissions.


Diffs (updated)
-

  3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 

Diff: https://reviews.apache.org/r/51079/diff/


Testing
---


Thanks,

haosdent huang

Review Request 51080: Replaced gperftools-2.5.tar.gz with a correct permissions version.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51080/
---

Review request for mesos, Kapil Arya and Till Toenshoff.


Bugs: MESOS-5925
https://issues.apache.org/jira/browse/MESOS-5925


Repository: mesos


Description
---

Some files' permissions in gperftools-2.5.tar.gz are
'0444/-r--r--r--', which means owner don't have write permission on
them. This breaks the build of Mesos since Docker 1.12 on MacOS. This
patch packaged gperftools-2.5.tar.gz with correct permissions.


Diffs
-

  3rdparty/gperftools-2.5.tar.gz 0002c837a204170dab9af9eec456333ea46a364d 

Diff: https://reviews.apache.org/r/51080/diff/


Testing
---


Thanks,

haosdent huang

Review Request 51079: Replaced gmock-1.7.0.tar.gz with a correct permissions version.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51079/
---

Review request for mesos, Kapil Arya and Till Toenshoff.


Bugs: MESOS-5925
https://issues.apache.org/jira/browse/MESOS-5925


Repository: mesos


Description
---

Some files' permissions in gmock-1.7.0.tar.gz are '0444/-r--r--r--',
which means owner don't have write permission on them. This breaks the
build of Mesos since Docker 1.12 on MacOS. This patch packaged
gmock-1.7.0.tar.gz with correct permissions.


Diffs
-

  3rdparty/gmock-1.7.0.tar.gz 09f5ea3ce95fab34c505367ae04965e01c8bb30d 

Diff: https://reviews.apache.org/r/51079/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

[Guangya Liu]

Thanks James, one question here: so what is the use case of non-shared
volumes for specific tasks, can you please show some detail here? From
Kubernetes Pod/Storage, I can see that all of the volumes are shared
objects, and different containers can select the volume that they want to
mount. One example is here:
https://github.com/kubernetes/kubernetes/blob/master/examples/volumes/iscsi/iscsi.yaml

Thanks,

Guangya

On Sun, Aug 14, 2016 at 7:09 AM, James DeFelice 
wrote:

> I'll let Jie comment on exactly how things get filled in. The use cases
> are: (a) shared volumes among a taskgroups's tasks; (b) non-shared
> (private) volumes for specific tasks in a taskgroup
>
> On Sat, Aug 13, 2016 at 7:07 PM, Guangya Liu  wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/51061/
>>
>> On 八月 13th, 2016, 10:18 p.m. UTC, *Guangya Liu* wrote:
>>
>> include/mesos/mesos.proto
>> 
>>  (Diff
>> revision 1)
>>
>> 1379
>>
>>  * 2) `NetworkInfo` must not be set inside task's resources.
>>
>> As we want to allow containers share a network namespace and volumes, so I 
>> think that we shoud also highlight Volume here.
>>
>> Another point is I think here you mean
>>
>> 2) `NetworkInfo` must not be set inside task's `ContainerInfo`.
>>
>> As the TaskInfo has a resources field, so using ContainerInfo or
>> container for above may be more clear?
>>
>> For the above, what about add a new item for Volume as following:
>>
>> 3) `Volume` can be set in both executor level and task level so as to share 
>> a volume between executor and task.
>>
>>
>> - Guangya
>>
>> On 八月 12th, 2016, 11:12 p.m. UTC, Vinod Kone wrote:
>> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin
>> Mahler, James DeFelice, and Jie Yu.
>> By Vinod Kone.
>>
>> *Updated 八月 12, 2016, 11:12 p.m.*
>> *Bugs: * MESOS-6036 
>> *Repository: * mesos
>> Description
>>
>> A scheduler can use the LAUNCH_GROUP offer operation to send a
>> `TaskGroup` to an executor.
>>
>> Testing
>>
>> make check
>>
>> Diffs
>>
>>- include/mesos/mesos.proto (af29dab2af4c28e257ad518c68d3f1af7cad0d06)
>>- include/mesos/v1/mesos.proto (a836f6e792944726ec6f8f66f77f4
>>03894377d05)
>>- src/common/resources.cpp (6b7af9179121efbdc5c29484eb042778bcea8288)
>>- src/master/master.cpp (0bd1a3490a86fede86a3f5f62ce4745b65aae258)
>>- src/v1/resources.cpp (03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998)
>>
>> View Diff 
>>
>
>
>
> --
> James DeFelice
> 585.241.9488 (voice)
> 650.649.6071 (fax)
>

Re: Review Request 50621: Libprocess reinit: Moved HttpProxy finalization and destruction.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50621/#review145717
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 12, 2016, 10:02 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50621/
> ---
> 
> (Updated Aug. 12, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moves the destructor code in `HttpProxy` into the `Process::finalize`
> function.  And changes the `HttpProxy`s termination logic to 
> terminate via `UPID` which guards against double-termination.
> 
> Removes some unused initialization code, too.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/50621/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing done later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 51049: Libprocess Reinit: Removed authorizer callback leaks.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51049/#review145716
---


Ship it!




Ship It!

- Vinod Kone


On Aug. 12, 2016, 10:02 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51049/
> ---
> 
> (Updated Aug. 12, 2016, 10:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `authorization_callbacks` were never being freed after being set
> or unset.  If you run the tests in repetition, this leaks memory.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/51049/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> (More testing done later in the chain)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/#review145715
---




3rdparty/libprocess/src/process.cpp (line 413)


`all` is a bit misleading since "gc" is not being terminated. can you just 
call it "terminate"? i know there is already a process specific overload. or 
maybe call it "finalize" ?



3rdparty/libprocess/src/process.cpp (line 1123)


s/`process_manager`/`process_manager->finalize()`/



3rdparty/libprocess/src/process.cpp (line 1132)


ha. you are calling it "finalizing" here.



3rdparty/libprocess/src/process.cpp (line 1136)


but all the processes are already terminated by this point? do you mean 
just the gc process my dereference it?



3rdparty/libprocess/src/process.cpp (line 1147)


do you  mean just the `gc` process?



3rdparty/libprocess/src/process.cpp (line 1163)


but process manager is cleaned up above?



3rdparty/libprocess/src/process.cpp (line 2397)


move this to #2403



3rdparty/libprocess/src/process.cpp (lines 2403 - 2410)


why do this here instead of #1155?



3rdparty/libprocess/src/process.cpp (line 2790)


add a TODO to return Try here?


- Vinod Kone


On Aug. 12, 2016, 9 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40266/
> ---
> 
> (Updated Aug. 12, 2016, 9 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Joris Van Remoortere, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-3910
> https://issues.apache.org/jira/browse/MESOS-3910
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `SocketManager` and `ProcessManager` are highly inter-dependent, 
> which requires some untangling in `process::finalize`.
> 
> * Logic originally found in `~ProcessManager` has been split into 
>   `ProcessManager::finalize` due to what happens during cleanup.
> * The future from `__s__->accept()` must be explicitly discarded as 
>   libevent does not detect a locally closed socket.
> * Terminating `HttpProxy`s must close the associated socket.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/process.cpp 
> 629f1644bc0a263972ec9efc41890c33f9406a34 
> 
> Diff: https://reviews.apache.org/r/40266/diff/
> 
> 
> Testing
> ---
> 
> `make check` (libev)
> `make check` (--enable-libevent --enable-ssl)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

[Qian Zhang]

> On Aug. 8, 2016, 11:17 p.m., Qian Zhang wrote:
> >
> 
> haosdent huang wrote:
> Hi, @qianzhang Because I think all the test cases are associate with 
> `CgroupsIsolator`, I think it would be better to update the test cases name 
> to make it more clear and exactly.

@haosdent, I agree we should change `RevocableCpuIsolatorTest` to 
`CgroupsIsolatorTest`, but I think we may not need to change the test name 
`ROOT_CGROUPS_RevocableCpu` to `ROOT_CGROUPS_CpuSubsystemRevocable`, 
`CpuSubsystem` is the name of an internal component, I think it may be better 
to not include it in the name of a test. Usually the name should describe a 
scenario that we want to test.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50733/#review145106
---


On Aug. 11, 2016, 10:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50733/
> ---
> 
> (Updated Aug. 11, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5973
> https://issues.apache.org/jira/browse/MESOS-5973
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed CgroupsCpushareIsolatorProcess.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6088c26d3465c3abb908495da3fa5b98c3062d16 
>   src/Makefile.am 33706e56189eb3f9a571d9aacf1050e188410d7c 
>   src/docker/docker.cpp e07c4aa723f57db7f8bc31d4af5d32a30ebf98f2 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp 
> 74982a610b6c0a74734165a0c6aa8c9f72f54deb 
>   src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp 
> 221e814a448c4b5df9dab98de597451a24e2b89c 
>   src/tests/containerizer/isolator_tests.cpp 
> 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
> 
> Diff: https://reviews.apache.org/r/50733/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50758/#review145713
---


Fix it, then Ship it!





src/tests/containerizer/isolator_tests.cpp (line 1598)


s/perf_events/perf_event/


- Qian Zhang


On Aug. 11, 2016, 10:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50758/
> ---
> 
> (Updated Aug. 11, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
> 
> Diff: https://reviews.apache.org/r/50758/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 50705: Changed master to allow partitioned slaves to reregister.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50705/
---

(Updated Aug. 13, 2016, 11:56 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Minor fixes.


Bugs: MESOS-4049
https://issues.apache.org/jira/browse/MESOS-4049


Repository: mesos


Description
---

The previous behavior was to shutdown partitioned agents that attempt to
reregister---unless the master has failed over, in which case the
reregistration is allowed (when running in "non-strict" mode).

The new behavior is always to allow partitioned agents to reregister.
This is part of a longer-term project to allow frameworks to define
their own policies for handling tasks running on partitioned agents.

In particular, if a framework has the PARTITION_AWARE capability, any
tasks running on the partitioned agent will continue to run after
reregistration. If the framework is not PARTITION_AWARE, any tasks that
were running on such an agent will be killed after the agent reregisters
(unless the master has failed over). This is for backward compatibility
with the previous ("non-strict") behavior. Note that regardless of the
PARTITION_AWARE capability, the agent will not be shutdown, which is a
change from the previous Mesos behavior.

This commit also changes the master so that if an agent is removed and
then the master receives a message from that agent, the master will no
longer attempt to shutdown the agent. This is consistent with the goal
of getting the master out of the business of shutting down agents that
we suspect are unhealthy. Such an agent will eventually realize it is
not registered with the master (e.g., because it won't receive any pings
from the master), which will cause it to reregister.


Diffs (updated)
-

  src/master/master.hpp 6decff6f4b9c3434de030fd5c06df4c683a7abad 
  src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
  src/tests/master_tests.cpp 398164d09b8ef14f916122ed8780023c4a3cd0f6 
  src/tests/partition_tests.cpp 0a72b345538ca3b9510fccf38ceb68ac71c2b473 

Diff: https://reviews.apache.org/r/50705/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

[Guangya Liu]

> On 八月 13, 2016, 10:18 p.m., Guangya Liu wrote:
> > include/mesos/mesos.proto, line 1379
> > 
> >
> > As we want to allow containers share a network namespace and volumes, 
> > so I think that we shoud also highlight `Volume` here.

Another point is I think here you mean 
```
2) `NetworkInfo` must not be set inside task's `ContainerInfo`. 
```
As the `TaskInfo` has a `resources` field, so using `ContainerInfo` or 
`container` for above may be more clear?

For the above, what about add a new item for `Volume` as following:
```

3) `Volume` can be set in both executor level and task level so as to share a 
volume between executor and task.
```


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51061/#review145710
---


On 八月 12, 2016, 11:12 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51061/
> ---
> 
> (Updated 八月 12, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, 
> James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-6036
> https://issues.apache.org/jira/browse/MESOS-6036
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A scheduler can use the LAUNCH_GROUP offer operation to send a
> `TaskGroup` to an executor.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 
> 
> Diff: https://reviews.apache.org/r/51061/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

[James DeFelice]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51061/#review145711
---




include/mesos/mesos.proto (line 1379)


There was some talk about allowing tasks to specify volumes if they wanted 
to use **unshared** volumes.



include/mesos/mesos.proto (line 1381)


I thought we were calling this TaskGroupInfo for consistency?


- James DeFelice


On Aug. 12, 2016, 11:12 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51061/
> ---
> 
> (Updated Aug. 12, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, 
> James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-6036
> https://issues.apache.org/jira/browse/MESOS-6036
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A scheduler can use the LAUNCH_GROUP offer operation to send a
> `TaskGroup` to an executor.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 
> 
> Diff: https://reviews.apache.org/r/51061/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51061: Added LAUNCH_GROUP offer operation.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51061/#review145710
---




include/mesos/mesos.proto (line 1379)


As we want to allow containers share a network namespace and volumes, so I 
think that we shoud also highlight `Volume` here.


- Guangya Liu


On 八月 12, 2016, 11:12 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51061/
> ---
> 
> (Updated 八月 12, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Hindman, Benjamin Mahler, 
> James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-6036
> https://issues.apache.org/jira/browse/MESOS-6036
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A scheduler can use the LAUNCH_GROUP offer operation to send a
> `TaskGroup` to an executor.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto af29dab2af4c28e257ad518c68d3f1af7cad0d06 
>   include/mesos/v1/mesos.proto a836f6e792944726ec6f8f66f77f403894377d05 
>   src/common/resources.cpp 6b7af9179121efbdc5c29484eb042778bcea8288 
>   src/master/master.cpp 0bd1a3490a86fede86a3f5f62ce4745b65aae258 
>   src/v1/resources.cpp 03ee0cb0bb5abe7fc1ae4cb47c5b6dbcd8d11998 
> 
> Diff: https://reviews.apache.org/r/51061/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51008/#review145709
---



Patch looks great!

Reviews applied: [50907, 50910, 50912, 51008]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 13, 2016, 8:15 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51008/
> ---
> 
> (Updated Aug. 13, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6032
> https://issues.apache.org/jira/browse/MESOS-6032
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added infrastructure for unit tests in the new python-based CLI.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/cli_new/pip-requirements.txt PRE-CREATION 
>   src/cli_new/tests/main.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51008/diff/
> 
> 
> Testing
> ---
> 
> GTEST_FILTER="" make -j check
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 51008: Added infrastructure for unit tests in the new python-based CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51008/
---

(Updated Aug. 13, 2016, 8:15 p.m.)


Review request for mesos, Haris Choudhary and Joseph Wu.


Changes
---

Fixed a small bug with the shebang path in the test executable.


Bugs: MESOS-6032
https://issues.apache.org/jira/browse/MESOS-6032


Repository: mesos


Description
---

Added infrastructure for unit tests in the new python-based CLI.


Diffs (updated)
-

  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/cli_new/pip-requirements.txt PRE-CREATION 
  src/cli_new/tests/main.py PRE-CREATION 

Diff: https://reviews.apache.org/r/51008/diff/


Testing
---

GTEST_FILTER="" make -j check


Thanks,

Kevin Klues

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

[Kevin Klues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50912/
---

(Updated Aug. 13, 2016, 8:15 p.m.)


Review request for mesos, Haris Choudhary and Joseph Wu.


Changes
---

Addressed Joseph's comments. Also fixed a small bug with the shebang path in 
the `mesos` executable.


Bugs: MESOS-6008
https://issues.apache.org/jira/browse/MESOS-6008


Repository: mesos


Description
---

Added the infrastructure for a new python-based CLI.


Diffs (updated)
-

  configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
  docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
  src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
  src/cli_new/README.md PRE-CREATION 
  src/cli_new/activate PRE-CREATION 
  src/cli_new/bin/config.py PRE-CREATION 
  src/cli_new/bin/main.py PRE-CREATION 
  src/cli_new/bin/mesos PRE-CREATION 
  src/cli_new/bootstrap PRE-CREATION 
  src/cli_new/deactivate PRE-CREATION 
  src/cli_new/lib/mesos/__init__.py PRE-CREATION 
  src/cli_new/lib/mesos/docopt.py PRE-CREATION 
  src/cli_new/lib/mesos/exceptions.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION 
  src/cli_new/lib/mesos/plugins/base.py PRE-CREATION 
  src/cli_new/lib/mesos/util.py PRE-CREATION 
  src/cli_new/mesos.bash_completion PRE-CREATION 
  src/cli_new/pip-requirements.txt PRE-CREATION 
  src/cli_new/pylint.config PRE-CREATION 

Diff: https://reviews.apache.org/r/50912/diff/


Testing
---

../configure --enable-new-cli
make -C src mesos
src/mesos


Thanks,

Kevin Klues

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

[Kevin Klues]

> On Aug. 12, 2016, 10:55 p.m., Joseph Wu wrote:
> > configure.ac, lines 1803-1806
> > 
> >
> > Can you add a comment saying that we already check for python > 2.6 
> > about 500 lines up (`--enable-python`)?

I decided to add another explicit check for python > 2.6 because it's not 
guaranteed that the user has specified the `--enable-python` flag while in this 
code block.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50912/#review145442
---


On Aug. 13, 2016, 8:15 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50912/
> ---
> 
> (Updated Aug. 13, 2016, 8:15 p.m.)
> 
> 
> Review request for mesos, Haris Choudhary and Joseph Wu.
> 
> 
> Bugs: MESOS-6008
> https://issues.apache.org/jira/browse/MESOS-6008
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the infrastructure for a new python-based CLI.
> 
> 
> Diffs
> -
> 
>   configure.ac f82c6314d65a8ea3eb118bab8e110063cae46121 
>   docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 
>   src/Makefile.am 1a9b083493612cf610b80ac5a1c11c29d6302933 
>   src/cli_new/README.md PRE-CREATION 
>   src/cli_new/activate PRE-CREATION 
>   src/cli_new/bin/config.py PRE-CREATION 
>   src/cli_new/bin/main.py PRE-CREATION 
>   src/cli_new/bin/mesos PRE-CREATION 
>   src/cli_new/bootstrap PRE-CREATION 
>   src/cli_new/deactivate PRE-CREATION 
>   src/cli_new/lib/mesos/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/docopt.py PRE-CREATION 
>   src/cli_new/lib/mesos/exceptions.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/__init__.py PRE-CREATION 
>   src/cli_new/lib/mesos/plugins/base.py PRE-CREATION 
>   src/cli_new/lib/mesos/util.py PRE-CREATION 
>   src/cli_new/mesos.bash_completion PRE-CREATION 
>   src/cli_new/pip-requirements.txt PRE-CREATION 
>   src/cli_new/pylint.config PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50912/diff/
> 
> 
> Testing
> ---
> 
> ../configure --enable-new-cli
> make -C src mesos
> src/mesos
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 51068: Prevent memory leaks

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51068/#review145706
---



Hi Aaron,

Awesome, thanks for your contribution! Two quick suggestions:

(1) Is there a workload/tool that repros the memory leak? e.g., it would be 
good to be able to say that "when you do X (e.g., run unit test X) under 
`valgrind --leak-check=full`, there was previously a memory leak of X bytes; 
with these changes, the leak is instead Y bytes."

(2) When contributing to Mesos, we try to encourage people to find a shepherd 
(Mesos committer) to work with to get your changes committed 
(https://mesos.apache.org/documentation/latest/submitting-a-patch/). I've 
pinged a few committers, so hopefully someone volunteers -- otherwise, you can 
find people in the `#dev` channel on Slack, IRC, or the dev mailing list.

- Neil Conway


On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51068/
> ---
> 
> (Updated Aug. 13, 2016, 8:08 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This should prevent any of the promises that are created in the various 
> ZookeeperProcess class methods from leaking memory.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 3f06000 
>   src/zookeeper/zookeeper.cpp e105377 
> 
> Diff: https://reviews.apache.org/r/51068/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>

Re: Review Request 51076: Removed slavePid from the containerizer launch API.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51076/#review145704
---



Patch looks great!

Reviews applied: [51074, 51075, 51076]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 13, 2016, 5:45 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51076/
> ---
> 
> (Updated Aug. 13, 2016, 5:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and 
> Kevin Klues.
> 
> 
> Bugs: MESOS-6020
> https://issues.apache.org/jira/browse/MESOS-6020
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed slavePid from the containerizer launch API.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.hpp 
> f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
>   src/slave/containerizer/composing.cpp 
> 36d891792380abb01180ccc63cf2cd05b16b9620 
>   src/slave/containerizer/containerizer.hpp 
> b108d68aa05d80febcb4f6cc2ba3cc3183acda4f 
>   src/slave/containerizer/containerizer.cpp 
> 2d59caf6555cb5866ef172d543c868e7f21c2f96 
>   src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
>   src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 6585356543efe8794ff711e0ee251a2e13a6adc2 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
>   src/slave/slave.hpp ffe4220c9289419ab1b1a2c1f499b6eac3c01e4b 
>   src/slave/slave.cpp 29ca07a40d4e1d75979259cbe4f113baab37035b 
>   src/tests/containerizer.hpp 76feedfdd381d92a1a19caca44e00630d7ecd281 
>   src/tests/containerizer.cpp 6f3950d0f4476d0872903b56dc2c7f95ae7e7ac5 
>   src/tests/containerizer/composing_containerizer_tests.cpp 
> e7619c15709e204d30fcc5b489873b5a8b717fab 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 4d852ad6b14934ae7ec691cc124c77bda9bb2c8d 
>   src/tests/containerizer/isolator_tests.cpp 
> 4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
>   src/tests/hook_tests.cpp a1c8685d7ae984a728f5225cae89e3c235b46266 
>   src/tests/mesos.hpp 59688dc9d1b16f20facf272085e65b3835f9a56e 
>   src/tests/slave_tests.cpp 787ec5b26fbf588a1148d2c54e03b93e7836de05 
> 
> Diff: https://reviews.apache.org/r/51076/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 51076: Removed slavePid from the containerizer launch API.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51076/
---

Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-6020
https://issues.apache.org/jira/browse/MESOS-6020


Repository: mesos


Description
---

Removed slavePid from the containerizer launch API.


Diffs
-

  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
36d891792380abb01180ccc63cf2cd05b16b9620 
  src/slave/containerizer/containerizer.hpp 
b108d68aa05d80febcb4f6cc2ba3cc3183acda4f 
  src/slave/containerizer/containerizer.cpp 
2d59caf6555cb5866ef172d543c868e7f21c2f96 
  src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
  src/slave/containerizer/mesos/containerizer.hpp 
6585356543efe8794ff711e0ee251a2e13a6adc2 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/slave.hpp ffe4220c9289419ab1b1a2c1f499b6eac3c01e4b 
  src/slave/slave.cpp 29ca07a40d4e1d75979259cbe4f113baab37035b 
  src/tests/containerizer.hpp 76feedfdd381d92a1a19caca44e00630d7ecd281 
  src/tests/containerizer.cpp 6f3950d0f4476d0872903b56dc2c7f95ae7e7ac5 
  src/tests/containerizer/composing_containerizer_tests.cpp 
e7619c15709e204d30fcc5b489873b5a8b717fab 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
4d852ad6b14934ae7ec691cc124c77bda9bb2c8d 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
  src/tests/hook_tests.cpp a1c8685d7ae984a728f5225cae89e3c235b46266 
  src/tests/mesos.hpp 59688dc9d1b16f20facf272085e65b3835f9a56e 
  src/tests/slave_tests.cpp 787ec5b26fbf588a1148d2c54e03b93e7836de05 

Diff: https://reviews.apache.org/r/51076/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 51075: Consolidated two executorEnvironment() calls in docker containerizer.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51075/
---

Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-6020
https://issues.apache.org/jira/browse/MESOS-6020


Repository: mesos


Description
---

Consolidated two executorEnvironment() calls in docker containerizer.


Diffs
-

  src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 

Diff: https://reviews.apache.org/r/51075/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 51074: Consolidated two containerizer::launch methods into one.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51074/
---

Review request for mesos, Benjamin Mahler, Artem Harutyunyan, Jie Yu, and Kevin 
Klues.


Bugs: MESOS-6021
https://issues.apache.org/jira/browse/MESOS-6021


Repository: mesos


Description
---

Consolidated two containerizer::launch methods into one.


Diffs
-

  src/slave/containerizer/composing.hpp 
f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4 
  src/slave/containerizer/composing.cpp 
36d891792380abb01180ccc63cf2cd05b16b9620 
  src/slave/containerizer/containerizer.hpp 
b108d68aa05d80febcb4f6cc2ba3cc3183acda4f 
  src/slave/containerizer/docker.hpp 43ca4317d608b3b43dd7bd0d1b55c721e7364885 
  src/slave/containerizer/docker.cpp 12bad2db03bcf755317c654f028b628c5c407a62 
  src/slave/containerizer/mesos/containerizer.hpp 
6585356543efe8794ff711e0ee251a2e13a6adc2 
  src/slave/containerizer/mesos/containerizer.cpp 
86a8d8a85b6a33c87798108cb65af85bb9bbbc77 
  src/slave/slave.cpp 29ca07a40d4e1d75979259cbe4f113baab37035b 
  src/tests/containerizer.hpp 76feedfdd381d92a1a19caca44e00630d7ecd281 
  src/tests/containerizer.cpp 6f3950d0f4476d0872903b56dc2c7f95ae7e7ac5 
  src/tests/containerizer/composing_containerizer_tests.cpp 
e7619c15709e204d30fcc5b489873b5a8b717fab 
  src/tests/containerizer/docker_containerizer_tests.cpp 
66adeec1411c71b269ff1d96c379968dab2a407a 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
4d852ad6b14934ae7ec691cc124c77bda9bb2c8d 
  src/tests/containerizer/isolator_tests.cpp 
4f047ae6b2e85e177e8b73d60b9dfca913c832a5 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
e3c8daab4fc688150a4f222e05f9b1bd9aee1912 
  src/tests/hook_tests.cpp a1c8685d7ae984a728f5225cae89e3c235b46266 
  src/tests/mesos.hpp 59688dc9d1b16f20facf272085e65b3835f9a56e 
  src/tests/slave_recovery_tests.cpp 59859f5bc249fbef916d6dfeafdc396a4c037117 
  src/tests/slave_tests.cpp 787ec5b26fbf588a1148d2c54e03b93e7836de05 

Diff: https://reviews.apache.org/r/51074/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 49854: Implemented `DevicesSubsystem`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49854/#review145700
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 11, 2016, 10:20 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49854/
> ---
> 
> (Updated Aug. 11, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5651
> https://issues.apache.org/jira/browse/MESOS-5651
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `DevicesSubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49854/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49853/#review145699
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 11, 2016, 10:19 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49853/
> ---
> 
> (Updated Aug. 11, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5047
> https://issues.apache.org/jira/browse/MESOS-5047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `PerfEventSubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49853/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 49851: Implemented `MemorySubsystem`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49851/#review145698
---


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 69 - 73)


I would suggest to move this method right after the `cleanup()` method.


- Qian Zhang


On Aug. 11, 2016, 10:19 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49851/
> ---
> 
> (Updated Aug. 11, 2016, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.
> 
> 
> Bugs: MESOS-5045
> https://issues.apache.org/jira/browse/MESOS-5045
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented `MemorySubsystem`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> b191b2a52a9645fc902a35ed52909b2142f0b4c0 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 2659252d8cffcefc233bc85fb4707c8147272737 
>   src/slave/containerizer/mesos/isolators/cgroups/constants.hpp 
> c45d88092f3fe497373dfeaa8346aef9126c7b8b 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp 
> 5f52a076a1fa3a21d886cb961ddeed5046a38d7c 
>   src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp 
> a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 
> 
> Diff: https://reviews.apache.org/r/49851/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 51069: Refactored `_commandHealthCheck` in health check.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51069/#review145697
---



Patch looks great!

Reviews applied: [36816, 49360, 51069]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 13, 2016, 8:47 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51069/
> ---
> 
> (Updated Aug. 13, 2016, 8:47 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored `_commandHealthCheck` in health check.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
>   src/health-check/health_checker.cpp 
> 45a5fe00a95a6e88b1990c1396e03082feb202bc 
> 
> Diff: https://reviews.apache.org/r/51069/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 51068: Prevent memory leaks

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51068/#review145696
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos ReviewBot


On Aug. 13, 2016, 8:08 a.m., Aaron Wood wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51068/
> ---
> 
> (Updated Aug. 13, 2016, 8:08 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This should prevent any of the promises that are created in the various 
> ZookeeperProcess class methods from leaking memory.
> 
> 
> Diffs
> -
> 
>   docs/contributors.yaml 3f06000 
>   src/zookeeper/zookeeper.cpp e105377 
> 
> Diff: https://reviews.apache.org/r/51068/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---

(Updated Aug. 13, 2016, 8:46 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
Jie Yu, and Timothy Chen.


Changes
---

Rebase.


Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533


Repository: mesos


Description
---

Supported HTTP/HTTPS in health check.


Diffs (updated)
-

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 

Diff: https://reviews.apache.org/r/36816/diff/


Testing
---


Thanks,

haosdent huang

Review Request 51069: Refactored `_commandHealthCheck` in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51069/
---

Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
Jie Yu, and Timothy Chen.


Repository: mesos


Description
---

Refactored `_commandHealthCheck` in health check.


Diffs
-

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 

Diff: https://reviews.apache.org/r/51069/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 49360: Supported TCP check in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/
---

(Updated Aug. 13, 2016, 8:47 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
Jie Yu, and Timothy Chen.


Changes
---

Rebase.


Bugs: MESOS-3567
https://issues.apache.org/jira/browse/MESOS-3567


Repository: mesos


Description
---

Supported TCP check in health check.


Diffs (updated)
-

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 

Diff: https://reviews.apache.org/r/49360/diff/


Testing
---


Thanks,

haosdent huang

Review Request 51068: Prevent memory leaks

[Aaron Wood]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51068/
---

Review request for mesos.


Repository: mesos


Description
---

This should prevent any of the promises that are created in the various 
ZookeeperProcess class methods from leaking memory.


Diffs
-

  docs/contributors.yaml 3f06000 
  src/zookeeper/zookeeper.cpp e105377 

Diff: https://reviews.apache.org/r/51068/diff/


Testing
---

make && make check


Thanks,

Aaron Wood

Re: Review Request 49360: Supported TCP check in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49360/
---

(Updated Aug. 13, 2016, 7:21 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
Jie Yu, and Timothy Chen.


Changes
---

Rebase.


Bugs: MESOS-3567
https://issues.apache.org/jira/browse/MESOS-3567


Repository: mesos


Description
---

Supported TCP check in health check.


Diffs (updated)
-

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 

Diff: https://reviews.apache.org/r/49360/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 13, 2016, 7:16 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing (updated)
---

This test is currently flaky in the SSL-enabled configurations and I've seen it 
produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 51053: Update leveldb to 1.19.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/#review145693
---


Ship it!




Ship It!

- haosdent huang


On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51053/
> ---
> 
> (Updated Aug. 12, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent 
> huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Leveldb in modern version is required to support s390x and arm64.
> It's also required to replace default byte-wise comparator
> with varint comparator in `src/log/leveldb.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 
>   3rdparty/leveldb-1.19.patch PRE-CREATION 
>   3rdparty/leveldb-1.19.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 
>   LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/51053/diff/
> 
> 
> Testing
> ---
> 
> make -j 8 distcheck
> benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---

(Updated Aug. 13, 2016, 6:47 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
Jie Yu, and Timothy Chen.


Changes
---

Address @alexr's comments.


Bugs: MESOS-2533
https://issues.apache.org/jira/browse/MESOS-2533


Repository: mesos


Description
---

Supported HTTP/HTTPS in health check.


Diffs (updated)
-

  src/health-check/health_checker.hpp b4548f385e6bdf12f6bbc402a5d59ba8e165b8a5 
  src/health-check/health_checker.cpp 45a5fe00a95a6e88b1990c1396e03082feb202bc 

Diff: https://reviews.apache.org/r/36816/diff/


Testing (updated)
---


Thanks,

haosdent huang

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

[haosdent huang]

> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote:
> > src/health-check/health_checker.hpp, line 280
> > 
> >
> > Do you think we should add "/" if the user has not specified anything?

Use "" instead, thx!


> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote:
> > src/health-check/health_checker.hpp, line 330
> > 
> >
> > Why do you need to discard original future here?

I saw we discard original future in every `after` callback. So I discard it 
here as well.


> On Aug. 11, 2016, 3:19 a.m., Alexander Rukletsov wrote:
> > src/health-check/health_checker.hpp, line 332
> > 
> >
> > It's unclear, what exactly is pending. How about: "CURL has not 
> > returned after " + stringify(timeout) + "; aborting"

I change to `"Aborting because curl has not returned after " + 
stringify(timeout))`


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review145451
---


On Aug. 7, 2016, 6:21 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36816/
> ---
> 
> (Updated Aug. 7, 2016, 6:21 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Gilbert Song, 
> Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-2533
> https://issues.apache.org/jira/browse/MESOS-2533
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Supported HTTP/HTTPS in health check.
> 
> 
> Diffs
> -
> 
>   src/health-check/health_checker.hpp 
> b28a9cf3c6c9217c0b2453ac6e34d88e1f648d61 
>   src/health-check/health_checker.cpp 
> 585a0b565d948cfa292bad818a710501a4ce0daf 
> 
> Diff: https://reviews.apache.org/r/36816/diff/
> 
> 
> Testing
> ---
> 
> * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and 
> HealthCheckTest.HealthyTaskNotMatchHttpStatuses
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 51053: Update leveldb to 1.19.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51053/#review145691
---



Patch looks great!

Reviews applied: [51053]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51053/
> ---
> 
> (Updated Aug. 12, 2016, 11:17 p.m.)
> 
> 
> Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, haosdent 
> huang, and Vinod Kone.
> 
> 
> Bugs: MESOS-970
> https://issues.apache.org/jira/browse/MESOS-970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Leveldb in modern version is required to support s390x and arm64.
> It's also required to replace default byte-wise comparator
> with varint comparator in `src/log/leveldb.cpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/Makefile.am 662146fade019e3085c00242dd74215ee91d6a70 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> eeb27860f6f95d297ccfe273ed76de5355b50ff8 
>   3rdparty/cmake/Versions.cmake e5cf7d00921c73e37b4bdaaa43874ab3a1d2f1fe 
>   3rdparty/leveldb-1.19.patch PRE-CREATION 
>   3rdparty/leveldb-1.19.tar.gz PRE-CREATION 
>   3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 
>   3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 
>   3rdparty/versions.am 08e47b6c93be51b0ea86f099f76e9d2a4a6ffd78 
>   LICENSE 7946d1d46174ff30459a33b3d0b44ab62672af0a 
>   src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 
>   src/python/native_common/ext_modules.py.in 
> 2d4a45efa224b32f80ace4542a00062c5ccb06d5 
> 
> Diff: https://reviews.apache.org/r/51053/diff/
> 
> 
> Testing
> ---
> 
> make -j 8 distcheck
> benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 50857: Modified a scheduler test to run with SSL enabled.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
---

(Updated Aug. 13, 2016, 6:16 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
---

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-

  src/tests/scheduler_tests.cpp ccd0f2f602a7a1a9a44b68fd0f59bdc8e0fa58b1 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
---

This test is currently flaky in the SSL-enabled configurations and will produce 
a segfault on my OSX machine after 50-100 repetitions. To reproduce, try:

`GTEST_REPEAT=1000 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Re: Review Request 51065: Changed hostname used for SSL cert creation in tests.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51065/
---

(Updated Aug. 13, 2016, 6:15 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

This changes the SSL helpers in libprocess to generate
certs using a hostname determined using the same address
that is advertised by libprocess. This assures that
validation of the certificates will succeed. The test
`SSLTest.BasicSameProcess` is also updated to accommodate
this change.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
83778bbfcc75f3f39b98d03a3580398e7d1062ea 
  3rdparty/libprocess/src/tests/ssl_tests.cpp 
a5ac03969694c4345c2c5004051b08b6d1da8555 

Diff: https://reviews.apache.org/r/51065/diff/


Testing
---

`make check` on Ubuntu 14.04


Thanks,

Greg Mann

Re: Review Request 50969: Made use of SSL flags to determine scheduler/executor scheme.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50969/
---

(Updated Aug. 13, 2016, 6:12 a.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Summary (updated)
-

Made use of SSL flags to determine scheduler/executor scheme.


Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description (updated)
---

This patch updates the HTTP scheduler and executor
libraries to use `process::network::openssl::flags()`
to determine whether or not SSL is enabled.


Diffs (updated)
-

  src/executor/executor.cpp d1ec817c53d0224a483fec545031016cf90620da 
  src/scheduler/scheduler.cpp 276ed10bd439c4a7830447bec5053292fb2ca4e7 

Diff: https://reviews.apache.org/r/50969/diff/


Testing
---

Tested after the following patch in this chain.


Thanks,

Greg Mann

Re: Review Request 50736: Added SSL support to libprocess HTTP request helpers.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50736/
---

(Updated Aug. 13, 2016, 6:10 a.m.)


Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
---

In order to test libprocess HTTP functionality with SSL
both enabled and disabled, the HTTP helper functions that
libprocess uses in tests must be parametrized by SSL
configuration.


Diffs (updated)
-

  3rdparty/libprocess/include/process/http.hpp 
404196bb198c1ff958b55d72fb29c5fe92dba429 
  3rdparty/libprocess/src/http.cpp 298bd460afdeccd18e201d8a505b961fd4cf3d3e 

Diff: https://reviews.apache.org/r/50736/diff/


Testing
---

Find testing information in the subsequent patch in this chain.


Thanks,

Greg Mann

Re: Review Request 50737: Parametrized libprocess HTTPTests by SSL configuration.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50737/
---

(Updated Aug. 13, 2016, 6:10 a.m.)


Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone.


Bugs: MESOS-5966
https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description
---

This patch parametrizes the HTTP tests in libprocess so
that they run with SSL both enabled and disabled when
the library was compiled with SSL support.


Diffs (updated)
-

  3rdparty/libprocess/src/tests/http_tests.cpp 
24b266df5f17e28e0c95326f5d1ea451952500e8 

Diff: https://reviews.apache.org/r/50737/diff/


Testing
---

Tested on OSX with `GTEST_REPEAT=100 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="*HTTPTest*" 3rdparty/libprocess/libprocess-tests`


Thanks,

Greg Mann