Re: Review Request 56722: Add a new operator API for `PRUNE_IMAGES`.

2017-06-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56722/
---

(Updated June 28, 2017, 3:45 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Add a new operator API for `PRUNE_IMAGES`.


Diffs
-

  include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
  include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 
  src/slave/http.hpp b03b728ae5a02760d2edc0691e9f6a871bc5a769 
  src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
  src/slave/validation.cpp 85c43cacf1361d269c28a7fe8bd1da8615949ec8 
  src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 


Diff: https://reviews.apache.org/r/56722/diff/3/


Testing (updated)
---

1. New unit test to trigger the new call.
2. Manually tested that images previous pulled but not running can be purged 
through new operator API call while active images (running or being pulled) are 
not affected.


Thanks,

Zhitao Li

Re: Review Request 56722: Add a new operator API for `PRUNE_IMAGES`.

2017-06-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56722/
---

(Updated June 28, 2017, 3:37 a.m.)


Review request for mesos, Gilbert Song, Jason Lai, and Jie Yu.


Changes
---

Rebase.

Fix comment.

Add unit test.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Add a new operator API for `PRUNE_IMAGES`.


Diffs (updated)
-

  include/mesos/agent/agent.proto 9bac9541acd24e1123ca5dd5925e2a1381d13b4a 
  include/mesos/v1/agent/agent.proto ea9282cf12fbe1c2ddeaa37223e4811685263734 
  src/slave/http.hpp b03b728ae5a02760d2edc0691e9f6a871bc5a769 
  src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
  src/slave/validation.cpp 85c43cacf1361d269c28a7fe8bd1da8615949ec8 
  src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 


Diff: https://reviews.apache.org/r/56722/diff/3/

Changes: https://reviews.apache.org/r/56722/diff/2-3/


Testing (updated)
---

New unit test to trigger the new call.


Thanks,

Zhitao Li

Review Request 60485: Fixed flaky PersistentVolumeEndpointsTest.ReserveAndSlaveRemoval.

2017-06-27 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60485/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-7725
https://issues.apache.org/jira/browse/MESOS-7725


Repository: mesos


Description
---

Fixed flaky PersistentVolumeEndpointsTest.ReserveAndSlaveRemoval.


Diffs
-

  src/tests/persistent_volume_endpoints_tests.cpp 
518bdf858096ec9bcfa4f899ead5a6c3d103c521 


Diff: https://reviews.apache.org/r/60485/diff/1/


Testing
---

`make check`


Thanks,

Neil Conway

Re: Review Request 60107: Finished object acceptor for tasks endpoint.

2017-06-27 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60107/
---

(Updated June 27, 2017, 10:30 p.m.)


Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Summary (updated)
-

Finished object acceptor for tasks endpoint.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description (updated)
---

Finished object acceptor for "/tasks" endpoint.

Added the query parameter support for that endpoint.
To query a task, you have to specify both framework_id
and task_id. Thus the query would look like
"/tasks?framework_id=[framework id];task_id=[task id]"


Diffs (updated)
-

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60107/diff/5/

Changes: https://reviews.apache.org/r/60107/diff/4-5/


Testing (updated)
---

Passed "make check"
Passed "GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48"
Passed "GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.TasksEndpoint" 
--gtest_repeat=1000 --gtest_break_on_failure"


Thanks,

Quinn Leng

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

2017-06-27 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review179051
---



For some isolators that depend on some specific cgroup isolator (e.g., gpu 
isolator), please update the code accordingly.


src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 116-117 (patched)


This logic is indeed very weird! I think the right approach is to make perf 
sampling a separate isolator that depends on cgroups perf_event subsystem being 
enabled (similar to gpu isolator depends on cgroups devices isolator).

The cgroups perf_event will simply just create the cgroup, but not 
performing sampling.


- Jie Yu


On June 26, 2017, 10:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60170/
> ---
> 
> (Updated June 26, 2017, 10:39 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Hao Yixin, Jason Lai, Jie Yu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch introduced a new agent isolation option 'cgroups', which
> represents all local machine supported cgroup subsystems will be
> turned on automatically.
> 
> Note that if this 'cgroups' option is specified in isolation, all
> other specified cgroup subsystems will be included.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9376d14d66f5dc7e91c7c0e9da253f5eb9347539 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> d7a95b2d49fd2ae743e2bffc25f15c4ce4b96f39 
> 
> 
> Diff: https://reviews.apache.org/r/60170/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 60482: Defined Git variables in CMake configure file.

2017-06-27 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60482/
---

Review request for mesos, Benjamin Bannier, Jeff Coffler, John Kordich, Joseph 
Wu, and Li Li.


Bugs: MESOS-7173
https://issues.apache.org/jira/browse/MESOS-7173


Repository: mesos


Description
---

This resolves MESOS-7173.


Diffs
-

  cmake/CompilationConfigure.cmake 3fa2e2f3b51a7a8dfe05085298f240019ff7b9c4 
  src/common/build_config.hpp.in 174d8aaba850d99ceeea965cd5faf0624c5051d6 


Diff: https://reviews.apache.org/r/60482/diff/1/


Testing
---

Built `mesos-agent` with CMake on Linux and started it with `GLOG_v=3`:

```
I0627 14:13:00.300671 75141 main.cpp:335] Git SHA: 
ed1c00e9b12dbdead54f3630188db8c510654075
```

It appears to be working.


Thanks,

Andrew Schwartzmeyer

Re: Review Request 60476: Fixed parameters in JNI call for disconnected event.

2017-06-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60476/#review179040
---


Ship it!




Ship It!

- Vinod Kone


On June 27, 2017, 6:18 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60476/
> ---
> 
> (Updated June 27, 2017, 6:18 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-7728
> https://issues.apache.org/jira/browse/MESOS-7728
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
> f4bf093954c9489e54f5332109052e1510409ce0 
> 
> 
> Diff: https://reviews.apache.org/r/60476/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

2017-06-27 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review179037
---



LGTM. Can you add some tests?


src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 109 (patched)


s/current/currently/


- Vinod Kone


On June 26, 2017, 10:39 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60170/
> ---
> 
> (Updated June 26, 2017, 10:39 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Hao Yixin, Jason Lai, Jie Yu, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch introduced a new agent isolation option 'cgroups', which
> represents all local machine supported cgroup subsystems will be
> turned on automatically.
> 
> Note that if this 'cgroups' option is specified in isolation, all
> other specified cgroup subsystems will be included.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 9376d14d66f5dc7e91c7c0e9da253f5eb9347539 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> d7a95b2d49fd2ae743e2bffc25f15c4ce4b96f39 
> 
> 
> Diff: https://reviews.apache.org/r/60170/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179032
---


Ship it!




Ship It!

- Benjamin Bannier


On June 27, 2017, 10:07 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 10:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/
---

(Updated June 27, 2017, 8:07 p.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.


Bugs: MESOS-4331
https://issues.apache.org/jira/browse/MESOS-4331


Repository: mesos


Description
---

The capitalization check caused rebases to fail for commits made with
`--fixup` and `--squash`. This change ignores the check for these cases.


Diffs (updated)
-

  support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 


Diff: https://reviews.apache.org/r/60216/diff/3/

Changes: https://reviews.apache.org/r/60216/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Andrew Schwartzmeyer 


> On June 27, 2017, 7:52 p.m., Benjamin Bannier wrote:
> > support/hooks/commit-msg
> > Lines 18 (patched)
> > 
> >
> > Could you make sure we only match at the beginning of the string, 
> > something like
> > 
> >if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then
> >
> > Note that I added some escaping here to deal with history expansion, 
> > could you please confirm that this is reasonable?
> 
> Benjamin Bannier wrote:
> Well, reviewboard swallowed my escaping,
> 
> if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then

Verified that we definitely want the `^`, and that `!` doesn't break it. I 
don't _think_ that Bash is going to expand history in the regular expansion, 
but user `!` is safer.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179028
---


On June 27, 2017, 7:41 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 7:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Benjamin Bannier 


> On June 27, 2017, 9:52 p.m., Benjamin Bannier wrote:
> > support/hooks/commit-msg
> > Lines 18 (patched)
> > 
> >
> > Could you make sure we only match at the beginning of the string, 
> > something like
> > 
> >if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then
> >
> > Note that I added some escaping here to deal with history expansion, 
> > could you please confirm that this is reasonable?

Well, reviewboard swallowed my escaping,

if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179028
---


On June 27, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 9:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review179028
---



Great idea, AFAICT this does what we want and is much simpler.


support/hooks/commit-msg
Lines 18 (patched)


Could you make sure we only match at the beginning of the string, something 
like

   if [[ "$FIRST_LINE" =~ ^(fixup|squash)! ]]; then
   
Note that I added some escaping here to deal with history expansion, could 
you please confirm that this is reasonable?


- Benjamin Bannier


On June 27, 2017, 9:41 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 9:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/
---

(Updated June 27, 2017, 7:41 p.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.


Bugs: MESOS-4331
https://issues.apache.org/jira/browse/MESOS-4331


Repository: mesos


Description
---

The capitalization check caused rebases to fail for commits made with
`--fixup` and `--squash`. This change ignores the check for these cases.


Diffs (updated)
-

  support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 


Diff: https://reviews.apache.org/r/60216/diff/2/

Changes: https://reviews.apache.org/r/60216/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

2017-06-27 Thread Andrew Schwartzmeyer 


> On June 20, 2017, 8:35 a.m., Benjamin Bannier wrote:
> > I think this does not work as is since we would e.g., still reject commits 
> > where the commit summary is longer than 72 chars, e.g., the following 
> > commit summary should be considered formally okay,
> > 
> > fixup fixup squash 
> > AAA.
> > 
> > One way to achieve that would be to e.g., treat the length check of the 
> > summary line separately from the description, but maybe you have a better 
> > idea.
> 
> Andrew Schwartzmeyer wrote:
> Oh, good catch. I'll ponder it.

So I ended up making this much simpler: if it starts with `fixup!` or `squash!` 
we exit the script. It is pointless to check the commit if it's a fixup or 
squash commit, since the actual commit that gets fixed up or squashed will be 
checked.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60216/#review178357
---


On June 27, 2017, 7:41 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60216/
> ---
> 
> (Updated June 27, 2017, 7:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.
> 
> 
> Bugs: MESOS-4331
> https://issues.apache.org/jira/browse/MESOS-4331
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The capitalization check caused rebases to fail for commits made with
> `--fixup` and `--squash`. This change ignores the check for these cases.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg 755309e70581835d01f53c1910b37b6cd3ea98ca 
> 
> 
> Diff: https://reviews.apache.org/r/60216/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 60476: Fixed parameters in JNI call for disconnected event.

2017-06-27 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60476/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-7728
https://issues.apache.org/jira/browse/MESOS-7728


Repository: mesos


Description
---

See summary.


Diffs
-

  src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 
f4bf093954c9489e54f5332109052e1510409ce0 


Diff: https://reviews.apache.org/r/60476/diff/1/


Testing
---


Thanks,

Alexander Rukletsov

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

2017-06-27 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review179000
---




src/slave/http.cpp
Lines 1334-1344 (patched)


Should we follow this pattern?

```
writer->field(
"reserved_resources_full",
[](JSON::ObjectWriter* writer) {
  foreachpair (const string& role,
   const Resources& resources,
   totalResources.reservations()) {

```



src/slave/http.cpp
Lines 1344 (patched)


Nit: Add one blank line below.



src/tests/reservation_endpoints_tests.cpp
Line 1739 (original), 1739 (patched)


Nit: Add one blank line below.


- haosdent huang


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 60474: WIP: Added support for moving RepeatedPtrField items to vector in conversion.

2017-06-27 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60474/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

This improves conversion from `RepeatedPtrField` to `vector` in 
`ProtobufProcess`, by moving items from one collection to another, when 
non-const message properties are used.


Diffs
-

  3rdparty/libprocess/include/process/protobuf.hpp 
ba6e6d6504250a2609b336f3e9854cfbe5da52ec 


Diff: https://reviews.apache.org/r/60474/diff/1/


Testing
---

make check


Thanks,

Dmitry Zhuk

Review Request 60473: WIP: Allowed use of mutable properties in protobuf message handlers.

2017-06-27 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60473/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Currently installing protobuf message handlers requires const accessors to 
message properties. This limits returned values usage to read-only, e.g. if 
this value needs to be stored somewhere, then a copy should be made. This patch 
allows specifying non-const accessors as well to provide read-write access to 
message properties, specifically to allow moving them into storage.


Diffs
-

  3rdparty/libprocess/include/process/protobuf.hpp 
ba6e6d6504250a2609b336f3e9854cfbe5da52ec 


Diff: https://reviews.apache.org/r/60473/diff/1/


Testing
---

make check


Thanks,

Dmitry Zhuk

Review Request 60472: WIP: Used variadic templates for protobuf handlers.

2017-06-27 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60472/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

This simplifies code of `ProtobufProcess` by replacing it with variadic 
templates implementation.


Diffs
-

  3rdparty/libprocess/include/process/protobuf.hpp 
ba6e6d6504250a2609b336f3e9854cfbe5da52ec 


Diff: https://reviews.apache.org/r/60472/diff/1/


Testing
---

make check


Thanks,

Dmitry Zhuk

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-27 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178996
---




src/webui/master/static/js/controllers.js
Lines 604 (patched)


`ng-repeat` support map, have you try

```
ng-repeat="(role, reservation) in $data"
```


- haosdent huang


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-27 Thread haosdent huang 


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 176 (patched)
> > 
> >
> > Should we use `*` here to keep consistent with other parts?
> 
> Andrei Budnik wrote:
> There is related discussion in the ticket, so it looks like we have 
> agreed on calling it "Unreserved".

> it looks like we have agreed on calling it "Unreserved".

It would be great that could post the link to that comment here.


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > 
> >
> > Is `|| 0` necessary here?
> 
> Andrei Budnik wrote:
> I think yes, because we might miss information about a specific role in 
> state.reserved_resources_allocated. E.g., we have both statically reserved 
> resources for both "ads" and "dyn" roles, but only one role is actually 
> allocated. Let's assume that resources from "dyn" role are used to launch 
> some task, while "ads" role isn't used, hence no item for "ads" in 
> state.reserved_resources_allocated exists. In the latter case 0 is used as a 
> default value.

Hmm, but

```
state.unreserved_resources_allocated.cpus | number
```

above would show `/0` as well.

Should we keep consistency since almost part use this pattern

```
  {{monitor.frameworks[framework.id].statistics.cpus_total_usage | 
number}} / {{framework.cpus | number}}
```


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
---


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> ---
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 
> 67bfd030649dd21840c16188a4964f814aa232d7 
> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/2/
> 
> 
> Testing
> ---
> 
> See screenshot.
> 
> 
> File Attachments
> 
> 
> agent.html
>   
> https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

2017-06-27 Thread Andrei Budnik 


> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1317-1318 (patched)
> > 
> >
> > Do we need this comment? Seems clear from the code

Fixed.


> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/slave/http.cpp
> > Lines 1322 (patched)
> > 
> >
> > I'm not sure that it makes sense to be filtering in this manner here, 
> > since the user is not viewing the framework or executor, but rather the 
> > resources allocated to roles. It seems like this should be doing role-based 
> > authorization instead, as is done in the master side role endpoint:
> > 
> > 
> > https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420

Fixed.


> On June 27, 2017, 10:39 a.m., Benjamin Mahler wrote:
> > src/tests/reservation_endpoints_tests.cpp
> > Lines 1747 (patched)
> > 
> >
> > This flag is deprecated now that we can persist role configuration 
> > within the registry, did you need to set this for the test to pass?

I'm getting following error without this flag: `Function call: 
error(0x7fff595959d8, @0x7facca60abd0 "Roles { role1 } are not present in the 
master's --roles")`


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review178867
---


On June 27, 2017, 5:10 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 27, 2017, 5:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

2017-06-27 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/
---

(Updated June 27, 2017, 5:10 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Updated agent webui page to display allocated resources per each role.


Diffs (updated)
-

  src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
  src/webui/master/static/js/controllers.js 
67bfd030649dd21840c16188a4964f814aa232d7 


Diff: https://reviews.apache.org/r/60370/diff/2/

Changes: https://reviews.apache.org/r/60370/diff/1-2/


Testing
---

See screenshot.


File Attachments


agent.html
  
https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png


Thanks,

Andrei Budnik

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

2017-06-27 Thread Andrei Budnik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/
---

(Updated June 27, 2017, 5:10 p.m.)


Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

The JSON key for this information is "reserved_resources_allocated"
and "unreserved_resources_allocated".


Diffs (updated)
-

  src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
  src/tests/reservation_endpoints_tests.cpp 
f710a188a7875c1cb847e39276b4b65332703ca5 


Diff: https://reviews.apache.org/r/60369/diff/2/

Changes: https://reviews.apache.org/r/60369/diff/1-2/


Testing
---

make check


Thanks,

Andrei Budnik

Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

2017-06-27 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60471/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added tests for pruneImages for containerizer and provisioner.


Diffs
-

  src/tests/containerizer/mesos_containerizer_tests.cpp 
d3a2bd7a9a91fe5c2c21066b1633289f36b6c8c5 
  src/tests/containerizer/provisioner_docker_tests.cpp 
920be77b16178a4458d72145020c015130799ec4 


Diff: https://reviews.apache.org/r/60471/diff/1/


Testing
---


Thanks,

Zhitao Li

Review Request 60467: Fixed race in configureSignal.

2017-06-27 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60467/
---

Review request for mesos, Anand Mazumdar and Avinash sridharan.


Bugs: MESOS-6345
https://issues.apache.org/jira/browse/MESOS-6345


Repository: mesos


Description
---

When multiple agents are spawned in a single process, they attempt to install 
signal handler concurrently, causing tests, such as 
`ExamplesTest.PersistentVolumeFramework` and 
`ExamplesTest.DynamicReservationFramework` randomly fail. This adds missing 
synchronization to `configureSignal` to resolve the issue.


Diffs
-

  src/slave/posix_signalhandler.hpp 49692b140662280b9e150654c5f336f1b920586f 


Diff: https://reviews.apache.org/r/60467/diff/1/


Testing
---

make check


Thanks,

Dmitry Zhuk

Re: Review Request 60414: Update documentation for framework bounding capabilities.

2017-06-27 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60414/#review178982
---



Patch looks great!

Reviews applied: [60409, 60410, 60411, 60412, 60413, 60414]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On June 24, 2017, 6:11 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60414/
> ---
> 
> (Updated June 24, 2017, 6:11 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7671
> https://issues.apache.org/jira/browse/MESOS-7671
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update documentation for framework bounding capabilities.
> 
> 
> Diffs
> -
> 
>   docs/linux_capabilities.md 30b9f0c67ef3004b814d931eebca935f8c82db94 
> 
> 
> Diff: https://reviews.apache.org/r/60414/diff/2/
> 
> 
> Testing
> ---
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 60397: WIP: Check perf version compatibility in tests with disabled coredumps.

2017-06-27 Thread James Peach 


> On June 27, 2017, 5:44 a.m., Benjamin Mahler wrote:
> > src/tests/environment.cpp
> > Line 542 (original), 542-548 (patched)
> > 
> >
> > Shouldn't this just be covered by `perf::suppported`?
> > 
> > Would also be great to include some additional context here, like a 
> > pointer to the ticket or mentioning that this is more likely if running 
> > within a docker image?
> 
> Andrei Budnik wrote:
> Ticket is [MESOS-7160](https://issues.apache.org/jira/browse/MESOS-7160).
> 
> What I've got from the description of the problem is that `perf 
> --version` segfaults on an incompatible kernel version.
> The solution for this problem is provided in this patch. Then, we have 
> found that it is more likely caused by incorrect `os::subprocess()` behavior. 
> So, I have suspicion that `perf --version` might never really cause 
> segfaults. I'm going to fix `os::subprocess()` and send a new patch. 
> Afterwards, if the problem reproduces after the fix, then I'll continue to 
> work on this patch.
> 
> `perf::suppported()` invokes `os::subprocess()` which calls `abort()` 
> when path to a binary is invalid. SIGABRT causes coredumps.

Both of these are true :) `perf` will crash with kernel version mismatches, and 
I strongly suspect there is a race in the process supervisor that can cause a 
similar symptom when `perf` is not installed.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178952
---


On June 26, 2017, 8:07 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60397/
> ---
> 
> (Updated June 26, 2017, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway.
> 
> 
> Bugs: MESOS-7160
> https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For autotools build, the docker-build script performs a 'distcheck'
> build. This type of build warns if any unexpected files are left in
> the build directory after an uninstall, mainly to detect broken
> uninstall Makefile rules. The return status of the build container is
> the result of the distcheck.
> This fixes an issue where in some dockerized configurations
> invocations of 'perf' segfaulted (producing a core file as a
> side-effect), where the failure case was already anticipated and
> handled by the caller.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5 
> 
> 
> Diff: https://reviews.apache.org/r/60397/diff/1/
> 
> 
> Testing
> ---
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> Needs to be confirmed by Apache CI, e.g., reviewbot.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60397: WIP: Check perf version compatibility in tests with disabled coredumps.

2017-06-27 Thread Andrei Budnik 


> On June 27, 2017, 5:44 a.m., Benjamin Mahler wrote:
> > src/tests/environment.cpp
> > Line 542 (original), 542-548 (patched)
> > 
> >
> > Shouldn't this just be covered by `perf::suppported`?
> > 
> > Would also be great to include some additional context here, like a 
> > pointer to the ticket or mentioning that this is more likely if running 
> > within a docker image?

Ticket is [MESOS-7160](https://issues.apache.org/jira/browse/MESOS-7160).

What I've got from the description of the problem is that `perf --version` 
segfaults on an incompatible kernel version.
The solution for this problem is provided in this patch. Then, we have found 
that it is more likely caused by incorrect `os::subprocess()` behavior. So, I 
have suspicion that `perf --version` might never really cause segfaults. I'm 
going to fix `os::subprocess()` and send a new patch. Afterwards, if the 
problem reproduces after the fix, then I'll continue to work on this patch.

`perf::suppported()` invokes `os::subprocess()` which calls `abort()` when path 
to a binary is invalid. SIGABRT causes coredumps.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60397/#review178952
---


On June 26, 2017, 8:07 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60397/
> ---
> 
> (Updated June 26, 2017, 8:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James Peach, and Neil Conway.
> 
> 
> Bugs: MESOS-7160
> https://issues.apache.org/jira/browse/MESOS-7160
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For autotools build, the docker-build script performs a 'distcheck'
> build. This type of build warns if any unexpected files are left in
> the build directory after an uninstall, mainly to detect broken
> uninstall Makefile rules. The return status of the build container is
> the result of the distcheck.
> This fixes an issue where in some dockerized configurations
> invocations of 'perf' segfaulted (producing a core file as a
> side-effect), where the failure case was already anticipated and
> handled by the caller.
> 
> 
> Diffs
> -
> 
>   src/tests/environment.cpp a7262cd97361b55ff31238341657e764df6c9ea5 
> 
> 
> Diff: https://reviews.apache.org/r/60397/diff/1/
> 
> 
> Testing
> ---
> 
> 1. make check (mac os x 10.12, fedora 25)
> 2. internal CI
> 
> Needs to be confirmed by Apache CI, e.g., reviewbot.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

2017-06-27 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60369/#review178867
---




src/slave/http.cpp
Lines 1317-1318 (patched)


Do we need this comment? Seems clear from the code



src/slave/http.cpp
Lines 1322 (patched)


I'm not sure that it makes sense to be filtering in this manner here, since 
the user is not viewing the framework or executor, but rather the resources 
allocated to roles. It seems like this should be doing role-based authorization 
instead, as is done in the master side role endpoint:


https://github.com/apache/mesos/blob/6b0ce8ff80e315fdfb22f0d7a2ed6d0947be7f11/src/master/http.cpp#L3363-L3420



src/tests/reservation_endpoints_tests.cpp
Lines 1747 (patched)


This flag is deprecated now that we can persist role configuration within 
the registry, did you need to set this for the test to pass?


- Benjamin Mahler


On June 22, 2017, 3:26 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60369/
> ---
> 
> (Updated June 22, 2017, 3:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The JSON key for this information is "reserved_resources_allocated"
> and "unreserved_resources_allocated".
> 
> 
> Diffs
> -
> 
>   src/slave/http.cpp cbbc1dc27cc90bac8d48cbbc84266c3d87490a3c 
>   src/tests/reservation_endpoints_tests.cpp 
> f710a188a7875c1cb847e39276b4b65332703ca5 
> 
> 
> Diff: https://reviews.apache.org/r/60369/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

2017-06-27 Thread Benjamin Mahler 


> On June 27, 2017, 10:29 a.m., Benjamin Mahler wrote:
> > It's ok for now, but our current approach means that only the help 
> > endpoints for those components that are run as part of this script will 
> > show up. So for example, if the cgroups isolator exposes some endpoints 
> > these will not be published to the website. I think longer term if we have 
> > the help stored in markdown we can avoid this issue.

Can you add a comment about it needing to work within docker hence the flags?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60438/#review178969
---


On June 26, 2017, 5:54 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60438/
> ---
> 
> (Updated June 26, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-7625
> https://issues.apache.org/jira/browse/MESOS-7625
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed agent flags to make this script work inside Docker container.
> This is needed because this script will be run as part of website
> publishing process which runs on ASF CI inside Docker.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213 
> 
> 
> Diff: https://reviews.apache.org/r/60438/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by running a CI job pointing to a branch containing this patch.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 60438: Updated endpoint help generator script to work inside Docker.

2017-06-27 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60438/#review178969
---


Ship it!




It's ok for now, but our current approach means that only the help endpoints 
for those components that are run as part of this script will show up. So for 
example, if the cgroups isolator exposes some endpoints these will not be 
published to the website. I think longer term if we have the help stored in 
markdown we can avoid this issue.

- Benjamin Mahler


On June 26, 2017, 5:54 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60438/
> ---
> 
> (Updated June 26, 2017, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-7625
> https://issues.apache.org/jira/browse/MESOS-7625
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed agent flags to make this script work inside Docker container.
> This is needed because this script will be run as part of website
> publishing process which runs on ASF CI inside Docker.
> 
> 
> Diffs
> -
> 
>   support/generate-endpoint-help.py 6eb2d41b35c5f064839c29a0ba8326c590a33213 
> 
> 
> Diff: https://reviews.apache.org/r/60438/diff/1/
> 
> 
> Testing
> ---
> 
> Tested by running a CI job pointing to a branch containing this patch.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 60233: Linted support/post-reviews.py.

2017-06-27 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60233/
---

(Updated June 27, 2017, 8:24 a.m.)


Review request for mesos, Benjamin Bannier and Joseph Wu.


Changes
---

Resolved issues.


Bugs: MESOS-6390
https://issues.apache.org/jira/browse/MESOS-6390


Repository: mesos


Description
---

This will allow us to use PyLint on the
entire support directory in the future.


Diffs (updated)
-

  support/post-reviews.py 410fb3371a3c46adbfd68c7584ffd6cf3b3010d1 


Diff: https://reviews.apache.org/r/60233/diff/3/

Changes: https://reviews.apache.org/r/60233/diff/2-3/


Testing
---

Added `support` to `source_dirs` in the PyLinter defined
in `mesos-style.py`. Linted until only acceptable errors
where displayed (e.g. due to the name of the file containing
a dash instead of an underscore).


Thanks,

Armand Grillet

Re: Review Request 60448: Forward declare CheckerProcess.

2017-06-27 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60448/#review178958
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 26, 2017, 10:18 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60448/
> ---
> 
> (Updated June 26, 2017, 10:18 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Rather than including "checker_process.hpp" in header files,
> forward declare CheckerProcess. This results in fewer visible
> symbols and hopefully some small improvement in build times.
> 
> 
> Diffs
> -
> 
>   src/checks/checker.hpp 6f65b4709a3420fc7f4ed885425cdc8192cbcfbf 
>   src/checks/health_checker.hpp dab366db45b11c6d300e9c8b82ce06565cec85a1 
>   src/checks/health_checker.cpp 26b2dafa1ee6dedee1c2217bcb3c3dcd727be5ef 
> 
> 
> Diff: https://reviews.apache.org/r/60448/diff/1/
> 
> 
> Testing
> ---
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>