Review Request 62322: Added initial doc for container volumes.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62322/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Added initial doc for container volumes.


Diffs
-

  docs/container-volume.md PRE-CREATION 
  docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62322/diff/1/


Testing
---


Thanks,

Jie Yu

Re: Review Request 62308: Added the description for the isolators section.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/#review185345
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62295', '62296', '62297', '62298', '62299', '62300', 
'62301', '62302', '62303', '62304', '62305', '62306', '62307', '62308']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (266 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (225 ms)
[--] 30 tests from ContentType/SchedulerTest (24840 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (880 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1086 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2049 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (136 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (156 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (330 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (355203 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62308/logs/mesos-tests-stderr.log):

```
I0913 22:49:43.881287 14368 master.cpp:8418] Removing framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b- (default)
I0913 22:49:43.881287 14368 master.cpp:3267] Deactivating framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b- (default)
I0913 22:49:43.882287 14892 hierarchical.cpp:412] Deactivated framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b-
I0913 22:49:43.882287  6672 slave.cpp:3235] Shutting down framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b-
I0913 22:49:43.882287 14368 master.cpp:8993] Updating the state of task 
7c9dd94b-c5c3-4724-ae89-57818dc91cd7 of framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 22:49:43.914865  6672 slave.cpp:5731] Shutting down executor 'default' of 
framework a559f1e1-31d8-4cac-a7b3-5f27e313087b- (via HTTP)
I0913 22:49:43.918866 14368 master.cpp:9087] Removing task 
7c9dd94b-c5c3-4724-ae89-57818dc91cd7 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b- on agent 
a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 
(mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.940208 14368 master.cpp:9116] Removing executor 'default' with 
resources [] of framework a559f1e1-31d8-4cac-a7b3-5f27e313087b- on agent 
a559f1e1-31d8-4cac-a7b3-5f27e313087b-S0 at slave(254)@10.3.1.7:62249 
(mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 22:49:43.944226 15196 hierarchical.cpp:355] Removed framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b-
E0913 22:49:43.945227  7064 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 22:49:43.946226  8788 scheduler.cpp:444] Re-detecting master
I0913 22:49:43.952226 11728 scheduler.cpp:470] New master detected at 
master@10.3.1.7:62249
I0913 22:49:43.960227  7064 slave.cpp:5407] Executor 'default' of framework 
a559f1e1-31d8-4cac-a7b3-5f27e313087b- exited with status 0
I0913 22:49:43.967227  7064 slave.cpp:5511] Cleaning up executor 'default' of 
framework a559f1e1-31d8-4cac-a7b3-5f27e313087b- (via HTTP)
W0913 22:49:43.970232 14348 

Review Request 62308: Added the description for the isolators section.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62308/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Added the description for the isolators section.


Diffs
-

  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62308/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62306: Added an index in the mesos containerizer doc about isolators.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62306/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Added an index in the mesos containerizer doc about isolators.


Diffs
-

  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62306/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62307: Added gpu/nvidia isolator to the index.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62307/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Added gpu/nvidia isolator to the index.


Diffs
-

  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62307/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62304: Moved linux capabilities isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62304/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved linux capabilities isolator doc to the isolators folder.


Diffs
-

  docs/container-image.md 5e680ce0bdc82a1e33646fd4773ec14f364c9036 
  docs/linux_capabilities.md d45c66cf3be12420d779ad44da7deaab7f6f9363 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62304/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62305: Moved posix rlimits isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62305/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved posix rlimits isolator doc to the isolators folder.


Diffs
-

  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 
  docs/posix_rlimits.md c2d1520f32b0ee55d66cc239f0c26a1b5b6c9dc9 


Diff: https://reviews.apache.org/r/62305/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62302: Moved docker volume isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62302/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved docker volume isolator doc to the isolators folder.


Diffs
-

  docs/docker-volume.md a8cb099e9c586a57793e0e40616165f710204d7c 
  docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62302/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62303: Moved IPC namespace isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62303/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved IPC namespace isolator doc to the isolators folder.


Diffs
-

  docs/isolators/namespaces-ipc.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62303/diff/1/


Testing
---


Thanks,

Jie Yu

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/#review185340
---



FAIL: The filename, directory name, or volume label syntax is incorrect.

Reviews applied: `['62246']`

Failed command: ``

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62246

- Mesos Reviewbot Windows


On Sept. 13, 2017, 6:01 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62246/
> ---
> 
> (Updated Sept. 13, 2017, 6:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds workaround for an incorrect docker file execution on
> Apache CI due to a docker bug, see:
> https://github.com/moby/moby/issues/9547
> Quote from the docker issue:
> The execution of `chmod +x b.sh` just prior to trying to running b.sh
> is leaving it in the 'Text file busy' state for long enough that then
> running it fails.
> 
> 
> Diffs
> -
> 
>   support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 
> 
> 
> Diff: https://reviews.apache.org/r/62246/diff/3/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Review Request 62298: Moved disk du isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62298/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved disk du isolator doc to the isolators folder.


Diffs
-

  docs/isolators/disk-du.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62298/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62300: Moved docker runtime isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62300/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved docker runtime isolator doc to the isolators folder.


Diffs
-

  docs/isolators/docker-runtime.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62300/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62301: Moved cgroups net_cls isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62301/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved cgroups net_cls isolator doc to the isolators folder.


Diffs
-

  docs/isolators/cgroups-net-cls.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62301/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62299: Moved xfs disk isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62299/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved xfs disk isolator doc to the isolators folder.


Diffs
-

  docs/isolators/disk-xfs.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62299/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62296: Moved shared filesystem isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62296/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved shared filesystem isolator doc to the isolators folder.


Diffs
-

  docs/isolators/filesystem-shared.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62296/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62295: Moved port mapping isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62295/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved port mapping isolator doc to the isolators folder.


Diffs
-

  docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242 
  docs/networking.md 713910a2afbbd9af8134e37151a3b942cda1ec80 
  docs/port-mapping-isolator.md 9b9869b27e3fc5fdd79b33d1d871290587f16748 


Diff: https://reviews.apache.org/r/62295/diff/1/


Testing
---


Thanks,

Jie Yu

Review Request 62297: Moved pid namespace isolator doc to the isolators folder.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62297/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

Moved pid namespace isolator doc to the isolators folder.


Diffs
-

  docs/isolators/namespaces-pid.md PRE-CREATION 
  docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74 


Diff: https://reviews.apache.org/r/62297/diff/1/


Testing
---


Thanks,

Jie Yu

Re: Review Request 62162: Revert usage of `-isystem` flag.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62162/#review185332
---



Bad patch!

Reviews applied: [62162, 62161, 62160]

Failed command: python support/apply-reviews.py -n -r 62161

Error:
2017-09-13 19:52:52 URL:https://reviews.apache.org/r/62161/diff/raw/ [993/993] 
-> "62161.patch" [1]
error: missing binary patch data for '3rdparty/boost-1.65.0.tar.gz'
error: binary patch does not apply to '3rdparty/boost-1.65.0.tar.gz'
error: 3rdparty/boost-1.65.0.tar.gz: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19383/console

- Mesos Reviewbot


On Sept. 12, 2017, 1:09 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62162/
> ---
> 
> (Updated Sept. 12, 2017, 1:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
> 
> 
> Diffs
> -
> 
>   configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a 
>   src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b 
> 
> 
> Diff: https://reviews.apache.org/r/62162/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62288: Added Log.Reader.catchup() method to Java bindings.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/#review185326
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62283', '62284', '62285', '62286', '62287', '62288']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (248 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (226 ms)
[--] 30 tests from ContentType/SchedulerTest (24808 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 
(1116 ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1090 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2299 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (134 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (150 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (347 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (344374 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62288/logs/mesos-tests-stderr.log):

```
I0913 18:45:50.223371 13212 master.cpp:8418] Removing framework 
da34803e-3bd4-4452-b689-b027db904b21- (default)
I0913 18:45:50.223371 13212 master.cpp:3267] Deactivating framework 
da34803e-3bd4-4452-b689-b027db904b21- (default)
I0913 18:45:50.224366 13132 hierarchical.cpp:412] Deactivated framework 
da34803e-3bd4-4452-b689-b027db904b21-
I0913 18:45:50.224366   200 slave.cpp:3235] Shutting down framework 
da34803e-3bd4-4452-b689-b027db904b21-
I0913 18:45:50.224366 13212 master.cpp:8993] Updating the state of task 
98825eed-960e-45e0-98a6-296ead18725d of framework 
da34803e-3bd4-4452-b689-b027db904b21- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 18:45:50.240365   200 slave.cpp:5731] Shutting down executor 'default' of 
framework da34803e-3bd4-4452-b689-b027db904b21- (via HTTP)
I0913 18:45:50.243367 13212 master.cpp:9087] Removing task 
98825eed-960e-45e0-98a6-296ead18725d with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework da34803e-3bd4-4452-b689-b027db904b21- on agent 
da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 
(mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.264569 13212 master.cpp:9116] Removing executor 'default' with 
resources [] of framework da34803e-3bd4-4452-b689-b027db904b21- on agent 
da34803e-3bd4-4452-b689-b027db904b21-S0 at slave(254)@10.3.1.7:60145 
(mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 18:45:50.267567 11540 hierarchical.cpp:355] Removed framework 
da34803e-3bd4-4452-b689-b027db904b21-
E0913 18:45:50.268566   200 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 18:45:50.269567 11540 scheduler.cpp:444] Re-detecting master
I0913 18:45:50.271569 11540 scheduler.cpp:470] New master detected at 
master@10.3.1.7:60145
I0913 18:45:50.289409   200 slave.cpp:5407] Executor 'default' of framework 
da34803e-3bd4-4452-b689-b027db904b21- exited with status 0
I0913 18:45:50.289567   200 slave.cpp:5511] Cleaning up executor 'default' of 
framework da34803e-3bd4-4452-b689-b027db904b21- (via HTTP)
I0913 18:45:50.292570   200 slave.cpp:5607] Cleaning up framework 
da34803e-3bd4-4452-b689-b027db904b21-

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62246/
---

(Updated Sept. 13, 2017, 6:01 p.m.)


Review request for mesos, Andrei Budnik, Alexander Rukletsov, and Joseph Wu.


Repository: mesos


Description
---

This patch adds workaround for an incorrect docker file execution on
Apache CI due to a docker bug, see:
https://github.com/moby/moby/issues/9547
Quote from the docker issue:
The execution of `chmod +x b.sh` just prior to trying to running b.sh
is leaving it in the 'Text file busy' state for long enough that then
running it fails.


Diffs (updated)
-

  support/docker-build.sh 6443e56be8bf1421b29afef059196a838100b8af 


Diff: https://reviews.apache.org/r/62246/diff/3/

Changes: https://reviews.apache.org/r/62246/diff/2-3/


Testing (updated)
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 62252: Added `process::Executor::execute()`.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62252/
---

(Updated Sept. 13, 2017, 5:34 p.m.)


Review request for mesos, Benjamin Hindman and Benjamin Mahler.


Changes
---

Addressed Ben's comments.


Bugs: MESOS-7970
https://issues.apache.org/jira/browse/MESOS-7970


Repository: mesos


Description
---

This patch adds a convenient interface to `process::Executor` to
asynchronously execute arbitrary functions.


Diffs (updated)
-

  3rdparty/libprocess/include/process/executor.hpp 
cd2f2f03cba8a435f142b31def9f89a6cd61af73 
  3rdparty/libprocess/src/tests/process_tests.cpp 
82efb2f8449e4cb13620cae1a49321fc42e2db60 


Diff: https://reviews.apache.org/r/62252/diff/3/

Changes: https://reviews.apache.org/r/62252/diff/2-3/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185310
---




src/docker/executor.cpp
Lines 160 (patched)


Consider moving this comment right after `LOG(INFO) << "Starting task " << 
taskId.get();`.



src/launcher/default_executor.cpp
Line 326 (original), 332 (patched)


Should we update the comment above?



src/launcher/default_executor.cpp
Lines 412 (patched)


Adding default constructor for `DefaultExecutor::Container` will help us to 
get rid of repeating `None()` and `false`.



src/launcher/executor.cpp
Line 1019 (original), 1023 (patched)


As you have moved
```c++
TaskStatus starting = createTaskStatus(taskId.get(), TASK_STARTING);
forward(starting);
```
after `taskData = TaskData(task);`, this change is not necessarry anymore 
and can be reverted.


- Andrei Budnik


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> ---
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
> https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185306
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62279']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (237 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (228 ms)
[--] 30 tests from ContentType/SchedulerTest (25341 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (943 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (967 
ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2005 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (142 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (367 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (354348 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stderr.log):

```
I0913 16:47:16.687176 14904 master.cpp:8418] Removing framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (default)
I0913 16:47:16.687176 14904 master.cpp:3267] Deactivating framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (default)
I0913 16:47:16.688171  9376 hierarchical.cpp:412] Deactivated framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
I0913 16:47:16.688171 13648 slave.cpp:3235] Shutting down framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
I0913 16:47:16.688171 14904 master.cpp:8993] Updating the state of task 
b7d108cf-9966-418e-8d2f-72106efcd3c3 of framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 16:47:16.698185 13648 slave.cpp:5731] Shutting down executor 'default' of 
framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (via HTTP)
I0913 16:47:16.702172 14904 master.cpp:9087] Removing task 
b7d108cf-9966-418e-8d2f-72106efcd3c3 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-S0 at slave(254)@10.3.1.5:51572 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 16:47:16.722234 14904 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-S0 at slave(254)@10.3.1.5:51572 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 16:47:16.726174  9376 hierarchical.cpp:355] Removed framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a-
E0913 16:47:16.726174 14148 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 16:47:16.728173 10748 scheduler.cpp:444] Re-detecting master
I0913 16:47:16.731173 14904 scheduler.cpp:470] New master detected at 
master@10.3.1.5:51572
I0913 16:47:16.743175 15300 slave.cpp:5407] Executor 'default' of framework 
1a69d5a5-49b5-4f9e-9d24-48ea047a414a- exited with status 0
I0913 16:47:16.743175 15300 slave.cpp:5511] Cleaning up executor 'default' of 
framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- (via HTTP)
W0913 16:47:16.743175 10748 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 1a69d5a5-49b5-4f9e-9d24-48ea047a414a- on agent 

Review Request 62288: Added Log.Reader.catchup() method to Java bindings.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62288/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

The new method is a wrapper for Log::Reader::catchup() method of the C++
Replicated Log API.


Diffs
-

  src/java/jni/org_apache_mesos_Log.cpp 
eb0f54be39dfced0dd75dcefa808850f22a34dc6 
  src/java/src/org/apache/mesos/Log.java 
f53d9ebeed3fc30e9e9dc642320e94da18eb8ca1 


Diff: https://reviews.apache.org/r/62288/diff/1/


Testing
---

Ran `make check`.


Thanks,

Ilya Pronin

Review Request 62284: Fixed code style issues.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62284/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

Fixed code style issues.


Diffs
-

  src/log/consensus.cpp 9b7463a2446a851fe1132a2c729b7ab213fa89b7 


Diff: https://reviews.apache.org/r/62284/diff/1/


Testing
---

N/A.


Thanks,

Ilya Pronin

Review Request 62287: Added Log::Reader::catchup() method.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62287/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

The new method launches the 'recoverMissing' process to catch-up the
local non-leaing replica and allow safe eventually consistent reads from
it.


Diffs
-

  include/mesos/log/log.hpp d92d7a0b982c1c4bc0fdedde19fe012a6523a224 
  src/log/log.hpp 24481aaae145301e7a8ea1c91b1c16e48ded4843 
  src/log/log.cpp dcb66f7dd5da5059925b7b731e83f7320f645030 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 


Diff: https://reviews.apache.org/r/62287/diff/1/


Testing
---

Added a test that verifies that it's possible to catch-up the lagging replica 
using the `Reader` and successfully read entries that were caught-up. Ran `make 
check`.


Thanks,

Ilya Pronin

Review Request 62283: Fixed a comment typo.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62283/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

Fixed a comment typo.


Diffs
-

  src/messages/log.proto ca740bd011147f8f48cc5dfcacefa5fdbd95ccd0 


Diff: https://reviews.apache.org/r/62283/diff/1/


Testing
---

N/A.


Thanks,

Ilya Pronin

Review Request 62285: Added tombstone flag to NOP log action.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62285/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

NOP action is used as a filler for holes in the "fill" procedure and as
the action in a response to a promise request for a truncated position.
The tombstone flag is introduced so that replicas are able to
distinguish the truncated action from a real NOP.


Diffs
-

  src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce 
  src/log/replica.cpp 39f2879b2e37c1ca9a9f987ce0a3b83e8dbc9b43 
  src/messages/log.proto ca740bd011147f8f48cc5dfcacefa5fdbd95ccd0 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 


Diff: https://reviews.apache.org/r/62285/diff/1/


Testing
---

Added a test that verifies that a replica correctly handles the tombstone NOP. 
Ran `make check`.


Thanks,

Ilya Pronin

Review Request 62286: Added recoverMissing log process.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62286/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7973
https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description
---

The process is used to "recover" a non-leading VOTING replica by running
the recovery protocol to find current begin and end positions of the log
and catching-up positions that are missing on the replica. This allows
following replicas to serve eventually consistent reads.


Diffs
-

  src/log/recover.hpp 94d6bb283ea82df607fcc72de05cda3b12ad5d2d 
  src/log/recover.cpp b366818767adb259ee6805f9978fd330b790a264 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 


Diff: https://reviews.apache.org/r/62286/diff/1/


Testing
---

Added tests that verify that the new recovery process correctly performs and 
produces meaningful result under various circumstances (recovered positions 
were truncated, replica was lagging far behind). Ran `make check`.


Thanks,

Ilya Pronin

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62197/#review185304
---




src/tests/mesos.hpp
Line 590 (original), 590 (patched)


Pass by const ref instead. I'll fix this while committing.


- Greg Mann


On Sept. 12, 2017, 11:49 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62197/
> ---
> 
> (Updated Sept. 12, 2017, 11:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Joerg Schad.
> 
> 
> Bugs: MESOS-7877
> https://issues.apache.org/jira/browse/MESOS-7877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These new overloads make it possible to specify a framework ID, executor
> resources as a proto, and the executor ID also as a proto.
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 444c75763aea995708db0b17eafee2d22c912554 
> 
> 
> Diff: https://reviews.apache.org/r/62197/diff/6/
> 
> 
> Testing
> ---
> 
> `make check` still passes on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review185303
---



FAIL: Mesos tests failed to build.

Reviews applied: `['62212', '62213']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213

Relevant logs:

- 
[mesos-tests-cmake-build-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-cmake-build-stdout.log):

```


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\checks\mesos-tcp-connect.vcxproj" (default target) (26) ->
  C:\mesos\mesos\src\checks\tcp_connect.cpp(93): warning C4244: 'initializing': 
conversion from 'SOCKET' to 'int', possible loss of data 
[C:\mesos\src\checks\mesos-tcp-connect.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\tests\test-helper.vcxproj" (default target) (28) ->
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\active_user_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\active_user_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\http_server_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\http_server_test_helper.cpp) 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\src\tests\resources_utils.cpp(93): warning C4267: 'argument': 
conversion from 'size_t' to 'int', possible loss of data 
[C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning 
C4996: 'GetVersionExW': was declared deprecated (compiling source file 
C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (23) ->
(ClCompile target) -> 
  C:\mesos\mesos\src\launcher\default_executor.cpp(556): error C2039: 
'launched': is not a member of 
'process::Owned' 
[C:\mesos\src\launcher\mesos-default-executor.vcxproj]

141 Warning(s)
1 Error(s)

Time Elapsed 00:38:21.06
```

- Mesos Reviewbot Windows


On Sept. 12, 2017, 9:58 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> ---
> 
> (Updated Sept. 12, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
> https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix unit tests that were broken by the additional TASK_STARTING update.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
>   src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
>   src/tests/command_executor_tests.cpp 
> f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp 
> 97e79792d3ea8023890ad2a705db47f2aeb419cf 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp 
> 38fef2d5f677f768a0533d1ac085b1197b3b764d 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 
> 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 
> 186b8333c02ba3b9257e19437c6d689761085362 
>   src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
>   src/tests/fault_tolerance_tests.cpp 
> 

Re: Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62282/#review185302
---


Ship it!




Ship It!

- Jie Yu


On Sept. 13, 2017, 3:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62282/
> ---
> 
> (Updated Sept. 13, 2017, 3:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When implementing 'operator==' for protobufs as a patter we typically
> first check that two 'optional' fields are set for both the left- and
> righthand side, and only then compare their values, e.g., given a
> definition
> 
> message Foo {
>   optional string bar = 1;
> }
> 
> we would implement 'operator==' similar to the following,
> 
>bool operator==(const Foo& lhs, const Foo& rhs)
>{
>if (lhs.has_bar() != rhs.has_bar()) {
>  return false;
>}
> 
>if (lhs.bar() != rhs.bar()) {
>  return false;
>}
> 
>return true;
>}
> 
> One reason for this is that it allows us to distinguish an unset field
> from a set field containing a default constructed value (if e.g.,
> above 'lhs.has_bar()' was 'false', 'lhs.bar()' would return an empty
> string).
> 
> This patch makes sure we use the same pattern when checking
> 'Resource::DiskInfo::Source' for equality.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
> 
> 
> Diff: https://reviews.apache.org/r/62282/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185301
---


Ship it!




Ship It!

- Alexander Rukletsov


On Sept. 13, 2017, 12:03 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62279/
> ---
> 
> (Updated Sept. 13, 2017, 12:03 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, 
> and Qian Zhang.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Processes terminated by `os::killtree` exit normally with a status code
> on windows, but killed by a signal on linux. Previously, we expected
> a process to be killed by a signal, which causes test failure on
> windows. Since we don't care about exact value of a returned status
> code in this test, this check was removed.
> 
> 
> Diffs
> -
> 
>   src/tests/default_executor_tests.cpp 
> 186b8333c02ba3b9257e19437c6d689761085362 
> 
> 
> Diff: https://reviews.apache.org/r/62279/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58048/
---

(Updated Sept. 13, 2017, 5:23 p.m.)


Review request for mesos, Jie Yu and Jan Schlicht.


Bugs: MESOS-7312
https://issues.apache.org/jira/browse/MESOS-7312


Repository: mesos


Description
---

Ids will allow to create distinguishable resources, e.g., of RAW or
BLOCK type. We also add a metadata field which can be used to expose
additional disk information.


Diffs (updated)
-

  include/mesos/mesos.proto fa475dcc3aa0b15ee4b2b740a24ab3c0b9a3274c 
  include/mesos/v1/mesos.proto dfba4181203e23f7eedf67c19379d031e0993fd5 
  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 
  src/tests/resources_tests.cpp 8a86efe60024d9e36294f0acb3f43bdd3f52f5bc 
  src/v1/resources.cpp a5cc15591b7611274148139c43465adae44c1dbb 


Diff: https://reviews.apache.org/r/58048/diff/6/

Changes: https://reviews.apache.org/r/58048/diff/5-6/


Testing
---

make check (OS X, Fedora25)


Thanks,

Benjamin Bannier

Review Request 62282: Fixed 'operator==' for 'Resource::DiskInfo::Source'.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62282/
---

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
---

When implementing 'operator==' for protobufs as a patter we typically
first check that two 'optional' fields are set for both the left- and
righthand side, and only then compare their values, e.g., given a
definition

message Foo {
  optional string bar = 1;
}

we would implement 'operator==' similar to the following,

   bool operator==(const Foo& lhs, const Foo& rhs)
   {
   if (lhs.has_bar() != rhs.has_bar()) {
 return false;
   }

   if (lhs.bar() != rhs.bar()) {
 return false;
   }

   return true;
   }

One reason for this is that it allows us to distinguish an unset field
from a set field containing a default constructed value (if e.g.,
above 'lhs.has_bar()' was 'false', 'lhs.bar()' would return an empty
string).

This patch makes sure we use the same pattern when checking
'Resource::DiskInfo::Source' for equality.


Diffs
-

  src/common/resources.cpp 14b600ca1577be4910164396c75b866b53439ade 


Diff: https://reviews.apache.org/r/62282/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier

Re: Review Request 62252: Added `process::Executor::execute()`.

[Chun-Hung Hsiao]

> On Sept. 13, 2017, 5:10 a.m., Benjamin Hindman wrote:
> > Thanks for taking this on Chun! A few high level comments to start.
> > 
> > (1) I don't think we need to implement a version of `execute()` that takes 
> > arguments that we'll apply to the function. With lambda captures we can 
> > easily and cleanly accomplish that and any of the corner cases will be 
> > cleanly solved for with C++14 which we should move too sooner rather than 
> > later. If folks really want that functionality I'd rather just see them use 
> > `std::bind()` and do `executor.execute(std::bind(f, arg1, arg2))`. It's not 
> > that many more characters and it greately simplifies your implementation!
> > 
> > (2) Given the simplification of (1) I feel like you probably don't need a 
> > separate `Executor::Process` class, and instead can just use `dispatch()` 
> > on the existing `process`. You should be able to simplify your SFINAE by 
> > leveraging the return type `dispatch()` since it already takes care of the 
> > `void` issue for you.

Thanks for your comments! (1) makes a lot sense to me and I also don't like the 
current approach of using macros. For (2), I don't think the way `dispatch()` 
taking care of `void` is what we want, because `dispatch(pid, f)` returns 
`void` if `f` returns `void` and thus we cannot wait on it. That's the 
intention of the `Executor::Process::execute` method: turning `void` to 
`Nothing`. Am I missing something?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62252/#review185261
---


On Sept. 12, 2017, 8:12 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62252/
> ---
> 
> (Updated Sept. 12, 2017, 8:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7970
> https://issues.apache.org/jira/browse/MESOS-7970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a convenient interface to `process::Executor` to
> asynchronously execute arbitrary functions.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/executor.hpp 
> cd2f2f03cba8a435f142b31def9f89a6cd61af73 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 82efb2f8449e4cb13620cae1a49321fc42e2db60 
> 
> 
> Diff: https://reviews.apache.org/r/62252/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/
---

(Updated Sept. 13, 2017, 2:52 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
---

Send task starting slightly later; initialize containers slightly earlier


Summary (updated)
-

Send TASK_STARTING from the built-in executors.


Bugs: MESOS-7941
https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
---

This gives schedulers more information about a tasks status,
in particular it gives a better estimate of a tasks start time
and helps differentiating between tasks stuck in TASK_STAGING
and tasks stuck in TASK_STARTING.


Diffs (updated)
-

  docs/high-availability-framework-guide.md 
73743aba31f9d0ca827d318e2ecb4752a91b1be0 
  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
  src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 


Diff: https://reviews.apache.org/r/62212/diff/2/

Changes: https://reviews.apache.org/r/62212/diff/1-2/


Testing
---


Thanks,

Benno Evers

Re: Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/#review185293
---



FAIL: Some Mesos tests failed.

Reviews applied: `['62279']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stdout.log):

```
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/0
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (263 ms)
[ RUN  ] ContentType/SchedulerTest.SchedulerReconnect/1
[   OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (266 ms)
[--] 30 tests from ContentType/SchedulerTest (25143 ms total)

[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (939 
ms)
[ RUN  ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[   OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 
(1083 ms)
[--] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2108 ms 
total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (137 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (331 ms 
total)

[--] Global test environment tear-down
[==] 627 tests from 66 test cases ran. (340096 ms total)
[  PASSED  ] 626 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ContentType/MasterAPITest.EventAuthorizationFiltering/1, where 
GetParam() = application/json

 1 FAILED TEST
  YOU HAVE 174 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62279/logs/mesos-tests-stderr.log):

```
I0913 14:14:05.771536 12776 master.cpp:8418] Removing framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (default)
I0913 14:14:05.771536 12776 master.cpp:3267] Deactivating framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (default)
I0913 14:14:05.772536 12440 hierarchical.cpp:412] Deactivated framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
I0913 14:14:05.772536 13824 slave.cpp:3235] Shutting down framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
I0913 14:14:05.772536 12776 master.cpp:8993] Updating the state of task 
cfceaa94-9706-4731-9e4b-cac83e493616 of framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0913 14:14:05.772536 13824 slave.cpp:5731] Shutting down executor 'default' of 
framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- (via HTTP)
I0913 14:14:05.790535 12776 master.cpp:9087] Removing task 
cfceaa94-9706-4731-9e4b-cac83e493616 with resources 
[{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
 of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-S0 at slave(254)@10.3.1.5:50507 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 14:14:05.805546 12776 master.cpp:9116] Removing executor 'default' with 
resources [] of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-S0 at slave(254)@10.3.1.5:50507 
(mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0913 14:14:05.817531 11872 hierarchical.cpp:355] Removed framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989-
E0913 14:14:05.817531 13484 scheduler.cpp:649] End-Of-File received from 
master. The master closed the event stream
I0913 14:14:05.819530 12440 scheduler.cpp:444] Re-detecting master
I0913 14:14:05.822530 12440 scheduler.cpp:470] New master detected at 
master@10.3.1.5:50507
I0913 14:14:05.833529 12440 slave.cpp:5407] Executor 'default' of framework 
9b811a3c-0f19-47ec-89f7-5dabbe09b989- exited with status 0
I0913 14:14:05.834529 12440 slave.cpp:5511] Cleaning up executor 'default' of 
framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- (via HTTP)
W0913 14:14:05.839529 13824 master.cpp:7021] Ignoring unknown exited executor 
'default' of framework 9b811a3c-0f19-47ec-89f7-5dabbe09b989- on agent 

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

[Andrei Budnik]

> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote:
> > src/docker/executor.cpp
> > Lines 141 (patched)
> > 
> >
> > Do we really need to send `TASK_STARTING`, if we know that right after 
> > sending `TASK_STARTING`, `launchTask` might send `TASK_FAILED`, e.g. in 
> > case of following checks:
> > ```c++
> > if (run.isSome()) {
> >  // ...
> >  status.set_state(TASK_FAILED);
> > }
> > ...
> > if (runOptions.isError()) {
> >  // ...
> >  status.set_state(TASK_FAILED);
> > }
> > ```
> > What is the semantics of `TASK_STARTING` - should an executor send it 
> > always and unconditionally, or can we omit `TASK_STARTING` when we are 
> > pretty sure that we won't be able to launch a task?
> > Omitting `TASK_STARTING` before sending `TASK_FAILED` might be a good 
> > optimization, if it's not important to send `TASK_STARTING` first.
> 
> Alexander Rukletsov wrote:
> Agree with Andrei: we should send task starting if we try to start the 
> task. If we know that starting will never succeed, we don't even try, hence 
> no task starting update : )
> 
> Benno Evers wrote:
> The previous documentation on `TASK_STARTING` was more of a loose 
> guideline, so I think we're de-facto deciding on the `TASK_STARTING` 
> semantics in this review. Intuitively, I find it most natural to have it mean 
> "the executor is now aware of the task and will attempt to start it", and not 
> to create any special cases.

We have agreed that `TASK_STARTING` must be sent whenever an executor receives 
`launchTask`. So, I'm dropping this `Fix it!`.


- Andrei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185156
---


On Sept. 11, 2017, 9:16 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> ---
> 
> (Updated Sept. 11, 2017, 9:16 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
> https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -
> 
>   docs/high-availability-framework-guide.md 
> 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 62279: Fixed failure of `DefaultExecutorTest.SigkillExecutor` test on windows.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62279/
---

Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, 
and Qian Zhang.


Repository: mesos


Description
---

Processes terminated by `os::killtree` exit normally with status code
on windows. This patch fixes expected status code of a killed task.


Diffs
-

  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 


Diff: https://reviews.apache.org/r/62279/diff/1/


Testing
---

internal CI


Thanks,

Andrei Budnik

Re: Review Request 61473: Do not kill non partition aware tasks.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61473/#review185268
---



FAIL: Failed to apply the current review.

Failed command: `python.exe .\support\apply-reviews.py -n -r 61473`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61473

Relevant logs:

- 
[apply-review-61473-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61473/logs/apply-review-61473-stderr.log):

```
Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 417, in 
main()
  File ".\support\apply-reviews.py", line 412, in main
reviewboard(options)
  File ".\support\apply-reviews.py", line 402, in reviewboard
apply_review(options)
  File ".\support\apply-reviews.py", line 160, in apply_review
commit_patch(options)
  File ".\support\apply-reviews.py", line 261, in commit_patch
message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 
655: ordinal not in range(128)
```

- Mesos Reviewbot Windows


On Sept. 11, 2017, 9:23 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61473/
> ---
> 
> (Updated Sept. 11, 2017, 9:23 p.m.)
> 
> 
> Review request for mesos, Vinod Kone and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7215
> https://issues.apache.org/jira/browse/MESOS-7215
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Master will not kill the tasks for non-Partition aware frameworks
> when an unreachable agent re-registers with the master.
> Master used to send a ShutdownFrameworkMessages to the agent
> to kill the tasks from non partition aware frameworks including the
> ones that are still registered which was problematic because the offer
> from this agent could still go to the same framework which could then
> launch new tasks. The agent would then receive tasks of the same
> framework and ignore them because it thinks the framework is shutting
> down. The framework is not shutting down of course, so from the master
> and the scheduler’s perspective the task is pending in STAGING forever
> until the next agent reregistration, which could happen much later.
> This commit fixes the problem by not shutting down the non-partition
> aware frameworks on such an agent.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
> 
> 
> Diff: https://reviews.apache.org/r/61473/diff/7/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>