Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/
---

(Updated April 28, 2018, 12:44 a.m.)


Review request for Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod 
Kone.


Repository: mesos


Description
---

These metrics count the number of times that the allocator has
filtered resources out of this framework's offer stream,
with separate metrics for different types of filtering.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
  src/master/allocator/mesos/hierarchical.cpp 
1000968be6a2935a4cac571414d7f06d7df7acf0 
  src/master/allocator/mesos/metrics.hpp 
6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 
5194f5b3b3f507b36f02300775230157db3dd477 


Diff: https://reviews.apache.org/r/66844/diff/5/

Changes: https://reviews.apache.org/r/66844/diff/4-5/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66858/#review202099
---



PASS: Mesos patch 66858 was successfully built and tested.

Reviews applied: `['66218', '66049', '66733', '66050', '66219', '66220', 
'66531', '66532', '66052', '66051', '66227', '66858']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66858

- Mesos Reviewbot Windows


On April 27, 2018, 10:07 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66858/
> ---
> 
> (Updated April 27, 2018, 10:07 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-4945
> https://issues.apache.org/jira/browse/MESOS-4945
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for validation of `GrowVolume` and `ShrinkVolume`.
> 
> 
> Diffs
> -
> 
>   src/tests/master_validation_tests.cpp 
> a5229610a81dfac9d358597135b63ee51de86659 
> 
> 
> Diff: https://reviews.apache.org/r/66858/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66828: Introduced a push-based gauge metric.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66828/#review202095
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66828/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James 
> Peach, and Vinod Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A push-based gauge differs from a pull-based gauge in that the
> client is responsible for pushing the latest value into the gauge
> whenever it changes. This can be challenging in some cases as it
> requires the client to have a good handle on when the gauge value
> changes (rather than just computing the current value when asked).
> 
> It is highly recommended to use push-based gauges if possible as
> they provide significant performance benefits over pull-based
> gauges. Pull-based gauge suffer from delays getting processed on
> the event queue of a `Process`, as well as incur computation cost
> on the `Process` each time the metrics are collected. Push-based
> gauges, on the other hand, incur no cost to the owning `Process`
> when metrics are collected, and instead incur a trivial cost when
> the `Process` pushes new values in.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
>   3rdparty/libprocess/include/process/metrics/push_gauge.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66828/diff/1/
> 
> 
> Testing
> ---
> 
> Test added in the subsequent patch.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66831/#review202097
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66831/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James 
> Peach, and Vinod Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Given `PushGauge`, it makes sense to explicitly distinguish the two
> gauge types and document the the caveats of `PullGauge`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
>   3rdparty/libprocess/include/process/metrics/gauge.hpp 
> 474f8e80b0128ae8d742a022733019351710ef48 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 
> 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721 
>   3rdparty/libprocess/include/process/metrics/pull_gauge.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/system.hpp 
> 6bd815daa27c069e25461e73fcc7327c4645e9fc 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> f2bd99bd289d728932b3206958902a99e436eaa7 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 17f288146c81b37a900b3df7d1797ba7bdfd00ca 
> 
> 
> Diff: https://reviews.apache.org/r/66831/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66832: Updated mesos source for Gauge -> PullGauge renaming.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66832/#review202098
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66832/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated mesos source for Gauge -> PullGauge renaming.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_framework.cpp f25324d198014146d380c1362ade4d9d5f0f9b7f 
>   src/examples/disk_full_framework.cpp 
> b6029dc5362ef57c9b24f182fadaa18fd5adee90 
>   src/examples/long_lived_framework.cpp 
> 53e3ec99d4081a12e2138e79154b07ad5d5ef503 
>   src/log/log.hpp be038d19d0066c52729246d68840a6e4e1d0c23f 
>   src/log/metrics.hpp b537e0a78cbae6f61f48bdfa63f2d91d88f777a3 
>   src/master/allocator/mesos/metrics.hpp 
> d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 
> 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
>   src/master/allocator/sorter/drf/metrics.hpp 
> 61568cb520826ab59d675824b212e0d3deb63764 
>   src/master/allocator/sorter/drf/metrics.cpp 
> ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 
>   src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
>   src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
>   src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 
>   src/master/registrar.cpp b0c281753d91d6b5abb1af065dec5e3feba0912f 
>   src/resource_provider/manager.cpp 68e1866986bfb91bf8355099ee1f0a2a86aba39a 
>   src/sched/sched.cpp b682d1b8a8a986edbda0bec9c940adb3f10f1c7e 
>   src/scheduler/scheduler.cpp c0dff5345cc1866f9a4dcab6cdeed3e7d815a348 
>   src/slave/containerizer/fetcher_process.hpp 
> 034fe34fea2928475774f3c67174af97a9ef37f3 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.hpp 
> d933af4e5a605f63d3c4bc584e82de7f3f80da55 
>   src/slave/gc_process.hpp 433b0e00fd30e1e43906cc436dfd58055910d699 
>   src/slave/metrics.hpp b771c4b54efb6a2ea841e99c16e098b33302ca89 
>   src/slave/metrics.cpp 44294af7cac29e462330d94217eed9f767972f0e 
>   src/slave/slave.hpp c35996bdd564075b9b8f1467e13e24a6531d022e 
> 
> 
> Diff: https://reviews.apache.org/r/66832/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66830: Added a test for PushGauge.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66830/#review202096
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66830/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test for PushGauge.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> f2bd99bd289d728932b3206958902a99e436eaa7 
> 
> 
> Diff: https://reviews.apache.org/r/66830/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66831: Renamed Gauge to PullGauge and documented differences to PushGauge.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66831/#review202094
---




3rdparty/libprocess/include/Makefile.am
Line 50 (original), 49-50 (patched)


Switch order


- Gilbert Song


On April 26, 2018, 2:54 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66831/
> ---
> 
> (Updated April 26, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos, Gaston Kleiman, Gilbert Song, Greg Mann, James 
> Peach, and Vinod Kone.
> 
> 
> Bugs: MESOS-8851
> https://issues.apache.org/jira/browse/MESOS-8851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Given `PushGauge`, it makes sense to explicitly distinguish the two
> gauge types and document the the caveats of `PullGauge`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/Makefile.am 
> cd2c3bc62df8de5b50ec2fa830b3e2634ba11e28 
>   3rdparty/libprocess/include/process/metrics/gauge.hpp 
> 474f8e80b0128ae8d742a022733019351710ef48 
>   3rdparty/libprocess/include/process/metrics/metric.hpp 
> 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721 
>   3rdparty/libprocess/include/process/metrics/pull_gauge.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/system.hpp 
> 6bd815daa27c069e25461e73fcc7327c4645e9fc 
>   3rdparty/libprocess/src/tests/metrics_tests.cpp 
> f2bd99bd289d728932b3206958902a99e436eaa7 
>   3rdparty/libprocess/src/tests/system_tests.cpp 
> 17f288146c81b37a900b3df7d1797ba7bdfd00ca 
> 
> 
> Diff: https://reviews.apache.org/r/66831/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

[Zhitao Li]

> On April 24, 2018, 9:05 p.m., Chun-Hung Hsiao wrote:
> > src/master/validation.cpp
> > Lines 2332 (patched)
> > 
> >
> > Can you add tests for this function in 
> > `src/tests/master_validation_tests.cpp`? To unblock this patch, it can be 
> > done in a follow-up one.

Done in https://reviews.apache.org/r/66858/.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/#review201887
---


On April 27, 2018, 12:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66050/
> ---
> 
> (Updated April 27, 2018, 12:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The new offer operations are implemented as speculative operations, but
> we will use validation to make them non-speculative on API level so that
> we can transition later without a breaking change.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
>   src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
>   src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66050/diff/14/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 66858: Added tests for validation of `GrowVolume` and `ShrinkVolume`.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66858/
---

Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-4945
https://issues.apache.org/jira/browse/MESOS-4945


Repository: mesos


Description
---

Added tests for validation of `GrowVolume` and `ShrinkVolume`.


Diffs
-

  src/tests/master_validation_tests.cpp 
a5229610a81dfac9d358597135b63ee51de86659 


Diff: https://reviews.apache.org/r/66858/diff/1/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66438: Windows: Made `libevent` use `int_fd` correctly.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66438/
---

(Updated April 27, 2018, 1:50 p.m.)


Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and 
Michael Park.


Changes
---

This fixes the SSL build.


Summary (updated)
-

Windows: Made `libevent` use `int_fd` correctly.


Bugs: MESOS-8675
https://issues.apache.org/jira/browse/MESOS-8675


Repository: mesos


Description (updated)
---

Due to the refactoring of `int_fd`, we have two corrections to make.

The first is an edge case where `libevent`, a third-party library,
requires a CRT integer file descriptor. Thus we duplicate the `int_fd`
and then explicitly allocate via `crt()`, which requires that we also
manually close it via `_close()`.

The second is an edge case where `libevent` uses its own type to
represent a `SOCKET` on Windows, in this case,
`evutil_socket_t` (which is actually just an `intptr_t`). While
`int_fd` has a constructor for this type, it is marked `explicit`, and
unfortunately also has an implicit constructor which takes an `int`.
This is a problem because the `intptr_t` can be silently converted to
an `int`, causing the `int_fd` abstraction to take on the wrong
form (a `HANDLE` instead of a `SOCKET`). So to avoid this implicit
conversion, we call the `intptr_t` constructor explicitly.

The alternative is to make the `intptr_t` constructor implicit, which
we wish to avoid, or to make the `int` constructor explicit, which we
can't do because we need to support `int` semantics such as
`int_fd fd = -1`.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 
4de161dbf9198e9c74b1e80838b8a5d52006a562 


Diff: https://reviews.apache.org/r/66438/diff/2/

Changes: https://reviews.apache.org/r/66438/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 66811: Added `libacl` as a dependency of stout.

[Andrew Schwartzmeyer]

> On April 27, 2018, 3:04 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 288 (patched)
> > 
> >
> > This file should not be committed together with the changes to stout 
> > (project split).

Why didn't the hooks catch this?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/#review202058
---


On April 26, 2018, 6:35 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66811/
> ---
> 
> (Updated April 26, 2018, 6:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `libacl` as a dependency of stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 
> 
> 
> Diff: https://reviews.apache.org/r/66811/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/
---

(Updated April 27, 2018, 8:42 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This struct will hold per-framework metrics tracked
by the allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
  src/master/allocator/mesos/hierarchical.cpp 
1000968be6a2935a4cac571414d7f06d7df7acf0 
  src/master/allocator/mesos/metrics.hpp 
d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
  src/master/allocator/mesos/metrics.cpp 
4892dbce65e2f7c12ba5105e28855ba6b6bf800e 


Diff: https://reviews.apache.org/r/66843/diff/4/

Changes: https://reviews.apache.org/r/66843/diff/3-4/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66531: Added new authorization for `ResizeVolume`.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66531/
---

(Updated April 27, 2018, 1:14 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-8748
https://issues.apache.org/jira/browse/MESOS-8748


Repository: mesos


Description
---

The new authorization action is modelled after `CreateVolume`, and will
be shared by both `GROW_VOLUME` and `SHRINK_VOLUME` operations and
corresponding operator APIs.


Diffs (updated)
-

  include/mesos/authorizer/acls.proto 8ef33210644e7d2924b402a3158b1b38c1fdb464 
  include/mesos/authorizer/authorizer.proto 
1508c01130013d74ed2b2574a2428f38e3d2c064 
  src/authorizer/local/authorizer.cpp c098ba9ded1b29a2e079cf09ab80b61f6fa4af05 
  src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 


Diff: https://reviews.apache.org/r/66531/diff/5/

Changes: https://reviews.apache.org/r/66531/diff/4-5/


Testing
---

Manually created ACL and verified that untrusted principals will not allow to 
grow/shrink volumes.
Also created unit test in next patch.


Thanks,

Zhitao Li

Re: Review Request 66051: Implemented operator API to grow and shrink persistent volume.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66051/
---

(Updated April 27, 2018, 1:09 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Updated after validation change.


Bugs: MESOS-8747
https://issues.apache.org/jira/browse/MESOS-8747


Repository: mesos


Description
---

These operator APIs is implemented as speculative for now, but
we plan to convert them to non-speculative in the future.


Diffs (updated)
-

  src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad 
  src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c 
  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66051/diff/15/

Changes: https://reviews.apache.org/r/66051/diff/14-15/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66532: Added test for authorization actions for `RESIZE_VOLUME`.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/
---

(Updated April 27, 2018, 1:08 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
---

use `Clock::settle()`.


Bugs: MESOS-8748
https://issues.apache.org/jira/browse/MESOS-8748


Repository: mesos


Description
---

Added test for authorization actions for `RESIZE_VOLUME`.


Diffs (updated)
-

  src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
  src/tests/persistent_volume_tests.cpp 
4edf781711d9efdb994114aeb6289b6af750b87a 


Diff: https://reviews.apache.org/r/66532/diff/6/

Changes: https://reviews.apache.org/r/66532/diff/5-6/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

> On April 25, 2018, 9:09 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 451 (patched)
> > 
> >
> > It's not 100% clear to me if these tests actually verify that the 
> > agent's resource checkpointing has occurred? IIUC, settling the clock after 
> > awaiting on the `ApplyOperationMessage` which applies the GROW or SHRINK 
> > may be sufficient to verify this?

They don't. I've rewrittent the comment.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201843
---


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> ---
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 501-505 (patched)
> > 
> >
> > ```
> > // Disk spaces will be merged if fixture parameter is `NONE`.
> > Bytes totalBytes = GetParam() == NONE ? MegaBytes(4096) : 
> > MegaBytes(2048);
> > ```
> > 
> > TBH I'm not a fan of conditioning on the fixture parameters. If a new 
> > fixture is created, this can be resolved by having only one disk in 
> > `getSlaveResources()` instead. But given the fact that we also do similar 
> > conditional branches in other tests, I can live with this.

I'll leave this as a TODO.


> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 823 (patched)
> > 
> >
> > This is not required.

New test has offers so this will be necessary.


> On April 25, 2018, 4:59 p.m., Chun-Hung Hsiao wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 853-855 (patched)
> > 
> >
> > This is essentially testing the same property as the last 
> > `EXPECT_FALSE` so we don't need it.

New test dropped this.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201969
---


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> ---
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

> On April 13, 2018, 9:43 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 455-459 (patched)
> > 
> >
> > Is this enforced somewhere in validation code? Can we check for 
> > expected behavior when a GROW/SHRINK operation is submitted for a MOUNT 
> > volume, rather than simply returning?
> 
> Zhitao Li wrote:
> I added validation in r/66050 so we drop shrink volume operation on 
> MOUNT. There is no logical path for triggering `GROW` on `MOUNT` disk type so 
> I'm not writing validation.
> 
> For testing, we can either keep the current structure and check that 
> `GROW`/`SHRINK` do not work on `MOUNT` (operation will be dropped), or take 
> Chun's suggestion to not test them for `MOUNT`. Please let me know.
> 
> Zhitao Li wrote:
> I think this will be the only test case which needs to skip `MOUNT`. It 
> also makes some sense because there is no logical starting point for a 
> framework to even construct a `GROW_VOLUME` message for `MOUNT`.
> 
> I still feel that the handling here could be better. we can discuss on 
> next patch revision.
> 
> Chun-Hung Hsiao wrote:
> I'm sorry for missing this reply. If we want to just skip `MOUNT`, I 
> prefer having a new fixture as a subclass of the original and make it only 
> parameterized against `NONE` and `PATH`; otherwise, how about doing proper 
> checks in `offersAfterGrow` based on the parameter:
> ```
> if (GetParam() == MOUNT) {
>   EXPECT_EQ(
>   allocatedResources(Resources(volume), frameworkInfo.roles(0)),
>   Resources(offer.resources()).persistentVolumes());
> } else {
>   EXPECT_TRUE(os::exists(volumePath));
>   EXPECT_SOME_EQ("abc", os::read(filePath));
> 
>   EXPECT_EQ(
>   allocatedResources(Resources(grownVolume), frameworkInfo.roles(0)),
>   Resources(offer.resources()).persistentVolumes());
> 
>   EXPECT_FALSE(
>   Resources(offer.resources()).contains(
>   allocatedResources(addition, frameworkInfo.roles(0;
> }
> ```
> My reason is that when seeing 
> `ROOT_MountDiskResource/PersistentVolumeTest.GrowVolume/0` passes really 
> means something is tested.

I'm going to leave this as a TODO for future improvement.


> On April 13, 2018, 9:43 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 541-542 (patched)
> > 
> >
> > Is this `Future` necessary? Since the task consumes the volume, it may 
> > be sufficient to await on the task status updates?
> 
> Zhitao Li wrote:
> Yes this is necessary if we do not launch task in this test. we need to 
> reliably know that `Allocator::updateAllocation` is called from master, and 
> this message happens before that, so this `Future` ensures allocator has 
> properly processed all operation conversions and next offer will contain the 
> host and updated resources.
> 
> Chun-Hung Hsiao wrote:
> I see. Here you're relying on the fact that when the 
> `ApplyOperationMessage` is processed on the slave, the master has already 
> speculatively applied the operation called `updatedAllocation`. However 
> `updateAllocation` is asynchronous so there is still a potential race between 
> `ApplyOperationMessage` and the actual allocation update.
> 
> I suggest instead of waiting for the internal message, let's do a 
> `Clock::settle();` before `Clock::advance(...)`. I just tested it locally.
> 
> Ditto for all the following awaits for `ApplyOperationMessage`.

`Clock::settle()` is not sufficient. What we need here is not confirming on 
agent processing, but confirming master has sent this to agent, because we 
reliably know that master has also called `allocatior::updateAllocation()` 
(which happens before this call). Otherwise allocator may not have correct view 
of resources.

Unfornately master -> allocator communication cannot be intecepted by 
`FUTURE...` so this is the closest thing I can find.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201109
---


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> ---
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -
> 
>   

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

> On April 25, 2018, 9:09 a.m., Greg Mann wrote:
> > src/tests/persistent_volume_tests.cpp
> > Lines 585-586 (patched)
> > 
> >
> > IIUC, the `Clock::settle()` here is ensuring that this test actually 
> > verifies that the agent's resources have been checkpointed?
> > 
> > If so, I would recommend:
> > 1) Add a comment explaining the reason for the settle.
> > 2) Place the settle after the await. I think the two orderings are 
> > equivalent, but I think it's more readable if the settle is after the await?
> 
> Chun-Hung Hsiao wrote:
> The await can be removed. See my comments above.

This is necessary to make sure that master -> allocator communication for 
`allocator::updateAllocation()` has happened.


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/#review201843
---


On April 27, 2018, 1:04 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66220/
> ---
> 
> (Updated April 27, 2018, 1:04 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-4965
> https://issues.apache.org/jira/browse/MESOS-4965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 4edf781711d9efdb994114aeb6289b6af750b87a 
> 
> 
> Diff: https://reviews.apache.org/r/66220/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66220: Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66220/
---

(Updated April 27, 2018, 1:04 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added tests for `GROW_VOLUME` and `SHRINK_VOLUME` operations.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
4edf781711d9efdb994114aeb6289b6af750b87a 


Diff: https://reviews.apache.org/r/66220/diff/8/

Changes: https://reviews.apache.org/r/66220/diff/7-8/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66050: Implemented grow and shrink of persistent volumes.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66050/
---

(Updated April 27, 2018, 12:24 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Review comments with better validation on chaining.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

The new offer operations are implemented as speculative operations, but
we will use validation to make them non-speculative on API level so that
we can transition later without a breaking change.


Diffs (updated)
-

  src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
  src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66050/diff/14/

Changes: https://reviews.apache.org/r/66050/diff/13-14/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66049: Added offer operation to grow and shrink persistent volumes.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66049/
---

(Updated April 27, 2018, 12:23 p.m.)


Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.


Changes
---

Fix build when grpc is enabled.


Bugs: MESOS-4965
https://issues.apache.org/jira/browse/MESOS-4965


Repository: mesos


Description
---

Added offer operation to grow and shrink persistent volumes.


Diffs (updated)
-

  include/mesos/mesos.proto 5bc4a80ad5278d20feced73dce755519515de505 
  include/mesos/v1/mesos.proto 5a4e733250831fa5fe86544aeb98dbc0a4f5afa6 
  src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b 
  src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 
  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/resource_provider/storage/provider.cpp 
8ca2d3a98858940e6e027becefb53c2f00b4ae43 
  src/tests/mesos.hpp 756a52189ea3336b203ea1d606e2ba17762d57aa 
  src/tests/persistent_volume_tests.cpp 
4edf781711d9efdb994114aeb6289b6af750b87a 
  src/tests/reservation_tests.cpp 5570df2e0b208512d0a0a3079a180e1acfe08f3d 


Diff: https://reviews.apache.org/r/66049/diff/12/

Changes: https://reviews.apache.org/r/66049/diff/11-12/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/#review202088
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66836/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use the stout wrapper instead of `::socket` so we have built-in error
> checking (and don't have to worry about types).
> 
> 
> Diffs
> -
> 
>   src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c 
> 
> 
> Diff: https://reviews.apache.org/r/66836/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66835/#review202087
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66835/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replaced `int` and `HANDLE` types with `int_fd`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.hpp 
> 0f66d6b49cbea9964457e890eff3cc7f1e058118 
> 
> 
> Diff: https://reviews.apache.org/r/66835/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66834: Windows: Specialized `flags::parse`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66834/#review202086
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66834/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Specialized `flags::parse`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/flags/parse.hpp 
> eb6d5272ffefcfe4fe7b97f9c7c7084893269b64 
> 
> 
> Diff: https://reviews.apache.org/r/66834/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66773/#review202085
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:21 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66773/
> ---
> 
> (Updated April 27, 2018, 4:21 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu.
> 
> 
> Bugs: MESOS-8275
> https://issues.apache.org/jira/browse/MESOS-8275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The functions `mode()`, `dev()`, and `inode()` are unused and do not
> make sense on Windows, so they were explicitly deleted. The function
> `mtime()` is used and has a logical mapping, `GetFileTime()`. However,
> Windows reports time differently from POSIX, so a conversion must also
> be performed such that the API `os::stat::mtime()` remains consistent
> with its POSIX version.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/permissions.hpp 
> 453e60c7268db516c2c94501e11a92fe8f490498 
>   3rdparty/stout/include/stout/os/windows/stat.hpp 
> c04953ee42f45dd80b6362fbeeddf4a0a20e7412 
>   3rdparty/stout/tests/os_tests.cpp 4221ecdcefb5602ece20cc90b13c3f17057fcb4d 
> 
> 
> Diff: https://reviews.apache.org/r/66773/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66822: Added per Framework Calls to metrics.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66822/
---

(Updated April 27, 2018, 11:51 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod 
Kone.


Repository: mesos


Description
---

Added per Framework Calls to metrics.


Diffs (updated)
-

  src/master/http.cpp 34c9023906eca94965acc994f20e888c1f47b962 
  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 


Diff: https://reviews.apache.org/r/66822/diff/3/

Changes: https://reviews.apache.org/r/66822/diff/2-3/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

[John Kordich via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66437/#review202081
---


Ship it!




Ship It!

- John Kordich


On April 27, 2018, 4:17 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66437/
> ---
> 
> (Updated April 27, 2018, 4:17 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, 
> and Michael Park.
> 
> 
> Bugs: MESOS-8675 and MESOS-8683
> https://issues.apache.org/jira/browse/MESOS-8675
> https://issues.apache.org/jira/browse/MESOS-8683
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After all the CRT APIs were replaced with Windows APIs, we no longer
> needed to support the semantics of an `int` file descriptor in
> general (in the sense of opening a CRT handle that's associated with
> the actual kernel object for the given `HANDLE`). There are specific
> use cases (usually third-party code) which still require a CRT
> int-like file descriptor, which the `crt()` function explicitly
> allocates (this allocation used to be done in the constructor).
> 
> Thus the entire `FD_CRT` type was removed from the `WindowsFD`
> abstraction. It still acts like an `int` in the sense that it can be
> constructed from one and compared to one. However, construction via
> `int` only supports the standard file descriptors 0, 1, and 2 for
> `stdin`, `stdout`, and `stderr`. Any other construction creates an
> `int_fd` which holds an `INVALID_HANDLE_VALUE`. When being compared to
> an `int`, the abstraction simply returns -1 if it is invalid (based on
> the result of the `is_valid()` method) or 0 if it is valid. This is to
> support the semantics of checking validity by something like
> `if (fd < 0)` or `if (fd == -1)`.
> 
> With the deletion of the `FD_CRT` type from `WindowsFD`, all the Stout
> APIs that switched on the type were simplified, with the last of the
> CRT code deleted.
> 
> Thanks to the introduction of the private `int get_valid()` function,
> and the removal of the `FD_CRT` type, the comparison operators became
> much simpler.
> 
> Several unit tests in the `FsTest` suite became cross-platform, with
> the `Close` test being simplified to test against an `int_fd`.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/close.hpp 
> ff635e44235d63888a210cd68d49f6678a851e31 
>   3rdparty/stout/include/stout/os/windows/dup.hpp 
> 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 
>   3rdparty/stout/include/stout/os/windows/fcntl.hpp 
> bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 
>   3rdparty/stout/include/stout/os/windows/fd.hpp 
> d7f8cdf1ad877eb55589bf5a9e75d295f91990a7 
>   3rdparty/stout/include/stout/os/windows/pipe.hpp 
> 365db9480f6258a03ef2e760a19abef8ab177e58 
>   3rdparty/stout/include/stout/os/windows/read.hpp 
> 8047ad590fcc46d3ec46b551472d8c518ae49cc1 
>   3rdparty/stout/include/stout/os/windows/socket.hpp 
> 259b05b8c85e399feaccec698d58b7d540cad368 
>   3rdparty/stout/include/stout/os/windows/write.hpp 
> 71006489918d9495d37d2fdfdca08b40b419481a 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> c190baa2230298e428d4034b90dccffb59b4e710 
>   3rdparty/stout/tests/os/socket_tests.cpp 
> 8ea0f1238e4293a5cd313b4ee38a920b381f4022 
> 
> 
> Diff: https://reviews.apache.org/r/66437/diff/6/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66820: Added framework metrics 'subscribed' and helpers.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/
---

(Updated April 27, 2018, 11:41 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod 
Kone.


Repository: mesos


Description
---

Added framework metrics 'subscribed' and helpers.


Diffs (updated)
-

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 


Diff: https://reviews.apache.org/r/66820/diff/3/

Changes: https://reviews.apache.org/r/66820/diff/2-3/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 66819: Added FrameworkMetrics struct in framework struct.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/
---

(Updated April 27, 2018, 11:39 a.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod 
Kone.


Repository: mesos


Description
---

Added FrameworkMetrics struct in framework struct.


Diffs (updated)
-

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 


Diff: https://reviews.apache.org/r/66819/diff/3/

Changes: https://reviews.apache.org/r/66819/diff/2-3/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/#review202078
---



Patch looks great!

Reviews applied: [66819, 66820, 66821, 66822, 66823, 66845, 66824, 66825, 
66846, 66847, 66841, 66842, 66843, 66844]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2018, 6:03 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66844/
> ---
> 
> (Updated April 27, 2018, 6:03 p.m.)
> 
> 
> Review request for Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These metrics count the number of times that the allocator has
> filtered resources out of this framework's offer stream,
> with separate metrics for different types of filtering.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1000968be6a2935a4cac571414d7f06d7df7acf0 
>   src/master/allocator/mesos/metrics.hpp 
> d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 
> 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
> 
> 
> Diff: https://reviews.apache.org/r/66844/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 66644: Remove unknown unreachable tasks when agent reregisters.

[Megha Sharma]

> On April 25, 2018, 10:39 p.m., Jiang Yan Xu wrote:
> >

Yan, Gaston, Please take another look. I have addressed your comments. Thanks!


- Megha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66644/#review201963
---


On April 25, 2018, 3:46 p.m., Megha Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66644/
> ---
> 
> (Updated April 25, 2018, 3:46 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: 8750
> https://issues.apache.org/jira/browse/8750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A RunTask messsage could get dropped for an agent while it's
> disconnected from the master and when such an agent goes unreachable
> then this dropped task gets added to the unreachable tasks.
> When the agent reregisters, tasks reported by it are removed from the 
> unreachableTasks bookkeeping on the master but since the
> agent doesn't know about the dropped task so it doesn't get removed
> from the unreachableTasks leading to a master check failure when
> this inconsistency is detected during framework removal.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
>   src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
>   src/tests/partition_tests.cpp 9138e5c745cf354a3573e1ab0b251d46702833cc 
> 
> 
> Diff: https://reviews.apache.org/r/66644/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66844/#review202075
---



PASS: Mesos patch 66844 was successfully built and tested.

Reviews applied: `['66819', '66820', '66821', '66822', '66823', '66845', 
'66824', '66825', '66846', '66847', '66841', '66842', '66843', '66844']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66844

- Mesos Reviewbot Windows


On April 27, 2018, 6:03 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66844/
> ---
> 
> (Updated April 27, 2018, 6:03 p.m.)
> 
> 
> Review request for Benjamin Mahler, Gaston Kleiman, Gilbert Song, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These metrics count the number of times that the allocator has
> filtered resources out of this framework's offer stream,
> with separate metrics for different types of filtering.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1000968be6a2935a4cac571414d7f06d7df7acf0 
>   src/master/allocator/mesos/metrics.hpp 
> d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
>   src/master/allocator/mesos/metrics.cpp 
> 4892dbce65e2f7c12ba5105e28855ba6b6bf800e 
> 
> 
> Diff: https://reviews.apache.org/r/66844/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66284/
---

(Updated April 27, 2018, 9:09 a.m.)


Review request for mesos, Jason Lai and James Peach.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

Tested `max_completion_time` support in docker executor.


Diffs (updated)
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
5e3dfdb537f52a85a82c6e8195e70a389b76aadf 


Diff: https://reviews.apache.org/r/66284/diff/4/

Changes: https://reviews.apache.org/r/66284/diff/3-4/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/
---

(Updated April 27, 2018, 3:44 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

This struct will hold per-framework metrics tracked
by the allocator.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
955ae3e6a9e3c790fb260311ec4b4ef725a826d3 
  src/master/allocator/mesos/hierarchical.cpp 
1000968be6a2935a4cac571414d7f06d7df7acf0 
  src/master/allocator/mesos/metrics.hpp 
d56a10b2d949180c081e7e285e8d60e6ea12ecfa 
  src/master/allocator/mesos/metrics.cpp 
4892dbce65e2f7c12ba5105e28855ba6b6bf800e 


Diff: https://reviews.apache.org/r/66843/diff/2/

Changes: https://reviews.apache.org/r/66843/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66842: Added counter metrics for offer filter durations.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66842/
---

(Updated April 27, 2018, 3:42 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

These per-framework metrics provide counts of the numbers
of filters set by each framework, bucketed according to
the 'refuse_seconds' duration.


Diffs (updated)
-

  src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 
  src/master/metrics.hpp 5414c4790f4606f910b0de81cbb08d398a0f3745 
  src/master/metrics.cpp 4cc96a1be532d6c7333a9fcdf8739d7640180777 


Diff: https://reviews.apache.org/r/66842/diff/2/

Changes: https://reviews.apache.org/r/66842/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66841: Added a hash function for 'Duration'.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66841/
---

(Updated April 27, 2018, 3:40 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and 
Vinod Kone.


Repository: mesos


Description
---

Added a hash function for 'Duration'.


Diffs (updated)
-

  3rdparty/stout/include/stout/duration.hpp 
42c43cda21c75fc3bef962af67c4a09df68a95af 


Diff: https://reviews.apache.org/r/66841/diff/2/

Changes: https://reviews.apache.org/r/66841/diff/1-2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66817/#review202068
---



Patch looks great!

Reviews applied: [8, 9, 66670, 66671, 66817]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 26, 2018, 5:18 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66817/
> ---
> 
> (Updated April 26, 2018, 5:18 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian 
> Zhang.
> 
> 
> Bugs: MESOS-8732
> https://issues.apache.org/jira/browse/MESOS-8732
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enforces all tests that start an agent to use composing
> containerizer. This is needed to make sure that composing containerizer
> is fairly covered by tests.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66817/diff/2/
> 
> 
> Testing
> ---
> 
> internal CI
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Re: Review Request 66817: Enabled composing containerizer as a default containerizer in tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66817/#review202063
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['8', '9', '66670', '66671', '66817']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66817

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66817/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (117 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1125 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (72 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (749 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (774 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (736 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (762 ms total)

[--] Global test environment tear-down
[==] 968 tests from 95 test cases ran. (439134 ms total)
[  PASSED  ] 967 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SlaveRecoveryTest/0.ReconnectExecutorRetry, where TypeParam = 
class mesos::internal::slave::MesosContainerizer

 1 FAILED TEST
  YOU HAVE 216 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66817/logs/mesos-tests-stderr.log):

```
I0427 14:15:51.970849 33240 master.cpp:10547] Updating the state of task 
d4116ce8-a699-4213-936f-22d951aa41c7 of framework 
c364cee9-61c2-4add-af5e-d28a12d125e6- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0427 14:15:51.970849 29488 slave.cpp:3919] Shutting down framework 
c364cee9-61c2-4add-af5e-d28a12d125e6-
I0427 14:15:51.971856 29488 slave.cpp:6616] Shutting down executor 
'd4116ce8-a699-4213-936f-22d951aa41c7' of framework 
c364cee9-61c2-4add-af5e-d28a12d125e6- at executor(1)@10.3.1.8:64793
I0427 14:15:51.9I0427 14:15:51.786846 34944 exec.cpp:162] Version: 1.6.0
I0427 14:15:51.815845 36688 exec.cpp:236] Executor registered on agent 
c364cee9-61c2-4add-af5e-d28a12d125e6-S0
I0427 14:15:51.819844 24648 executor.cpp:177] Received SUBSCRIBED event
I0427 14:15:51.824846 24648 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0427 14:15:51.825846 24648 executor.cpp:177] Received LAUNCH event
I0427 14:15:51.831847 24648 executor.cpp:649] Starting task 
d4116ce8-a699-4213-936f-22d951aa41c7
I0427 14:15:51.920850 24648 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0427 14:15:51.934856 24648 executor.cpp:662] Forked command at 31712
I0427 14:15:51.972856 13328 exec.cpp:445] Executor asked to shutdown
I0427 14:15:51.973839 10876 executor.cpp:177] Received SHUTDOWN event
I0427 14:15:51.973839 10876 executor.cpp:759] Shutting down
I0427 14:15:51.973839 10876 executor.cpp:869] Sending SIGTERM to process tree 
at pid 71856 29488 slave.cpp:919] Agent terminating
W0427 14:15:51.972856 29488 slave.cpp:3915] Ignoring shutdown framework 
c364cee9-61c2-4add-af5e-d28a12d125e6- because it is terminating
I0427 14:15:51.973839 33240 master.cpp:10646] Removing task 
d4116ce8-a699-4213-936f-22d951aa41c7 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework c364cee9-61c2-4add-af5e-d28a12d125e6- on 
agent c364cee9-61c2-4add-af5e-d28a12d125e6-S0 at slave(437)@10.3.1.8:64772 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0427 14:15:51.976850 33240 master.cpp:1296] Agent 
c364cee9-61c2-4add-af5e-d28a12d125e6-S0 at slave(437)@10.3.1.8:64772 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0427 14:15:51.976850 33240 master.cpp:3296] Disconnecting agent 
c364cee9-61c2-4add-af5e-d28a12d125e6-S0 at slave(437)@10.3.1.8:64772 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0427 14:15:51.976850 33240 master.cpp:3315] Deactivating agent 
c364cee9-61c2-4add-af5e-d28a12d125e6-S0 at slave(437)@10.3.1.8:64772 

Re: Review Request 66840: Added `libacl` into a few Dockerfiles.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202061
---


Ship it!




Ship It!

- Benjamin Bannier


On April 27, 2018, 10:30 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> ---
> 
> (Updated April 27, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds `libacl` into Dockerfiles for the images:
>   1. mesos/mesos-build
>   2. mesos/mesos-tidy
>   2. mesos/mesos-mini
> 
> 
> Diffs
> -
> 
>   support/mesos-build/centos-7.dockerfile 
> acdb44db281e9a156cbd684d2159ab4a5c65e8c4 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 
> 6d76090c466f84748df307888721d77a5f583290 
>   support/mesos-build/ubuntu-16.04.dockerfile 
> 0bbaa035f401c2c91e4e921cfe9abeb3953885a5 
>   support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 
>   support/packaging/centos/mesos.spec 
> 752c2aa24fba3226d5b1efa0d97a182b723e26c4 
> 
> 
> Diff: https://reviews.apache.org/r/66840/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 66849: Added missing test expectation.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/#review202060
---



Patch looks great!

Reviews applied: [66849]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2018, 10:15 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66849/
> ---
> 
> (Updated April 27, 2018, 10:15 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On master failover the scheduler will get disconnected. Add a test
> expectation for that. This silences a gmock warning.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 76c169567de6e0ef99c984a673cd69ce7725d6b6 
> 
> 
> Diff: https://reviews.apache.org/r/66849/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Before this patch the fixed tests emits a gmock warning about an unexpected 
> function call, with this patch the warning disappears.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 66849: Added missing test expectation.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/#review202059
---



PASS: Mesos patch 66849 was successfully built and tested.

Reviews applied: `['66849']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66849

- Mesos Reviewbot Windows


On April 27, 2018, 3:15 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66849/
> ---
> 
> (Updated April 27, 2018, 3:15 a.m.)
> 
> 
> Review request for mesos, Gaston Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> On master failover the scheduler will get disconnected. Add a test
> expectation for that. This silences a gmock warning.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 76c169567de6e0ef99c984a673cd69ce7725d6b6 
> 
> 
> Diff: https://reviews.apache.org/r/66849/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> Before this patch the fixed tests emits a gmock warning about an unexpected 
> function call, with this patch the warning disappears.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 66849: Added missing test expectation.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66849/
---

Review request for mesos, Gaston Kleiman and Greg Mann.


Repository: mesos


Description
---

On master failover the scheduler will get disconnected. Add a test
expectation for that. This silences a gmock warning.


Diffs
-

  src/tests/operation_reconciliation_tests.cpp 
76c169567de6e0ef99c984a673cd69ce7725d6b6 


Diff: https://reviews.apache.org/r/66849/diff/1/


Testing
---

`make check`

Before this patch the fixed tests emits a gmock warning about an unexpected 
function call, with this patch the warning disappears.


Thanks,

Benjamin Bannier

Re: Review Request 66811: Added `libacl` as a dependency of stout.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66811/#review202058
---




3rdparty/CMakeLists.txt
Lines 288 (patched)


This file should not be committed together with the changes to stout 
(project split).


- Benjamin Bannier


On April 27, 2018, 3:35 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66811/
> ---
> 
> (Updated April 27, 2018, 3:35 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `libacl` as a dependency of stout.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt b7362d2be75e4de06092f16698a784b7a78994cb 
>   3rdparty/stout/CMakeLists.txt 24a1f0acbee8a464fcc5159cf41d7e93aa8148fc 
>   3rdparty/stout/Makefile.am ef22a02a8a11326c6af19eb11d79eb82ff7861da 
>   3rdparty/stout/configure.ac 5a8c023de63e6b96b128cdfb472859a6f3e6ede5 
> 
> 
> Diff: https://reviews.apache.org/r/66811/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 66840: Added `libacl` into a few Dockerfiles.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/
---

(Updated April 27, 2018, 4:30 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Summary (updated)
-

Added `libacl` into a few Dockerfiles.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description (updated)
---

This commit adds `libacl` into Dockerfiles for the images:
  1. mesos/mesos-build
  2. mesos/mesos-tidy
  2. mesos/mesos-mini


Diffs (updated)
-

  support/mesos-build/centos-7.dockerfile 
acdb44db281e9a156cbd684d2159ab4a5c65e8c4 
  support/mesos-build/ubuntu-16.04-arm.dockerfile 
6d76090c466f84748df307888721d77a5f583290 
  support/mesos-build/ubuntu-16.04.dockerfile 
0bbaa035f401c2c91e4e921cfe9abeb3953885a5 
  support/mesos-tidy/Dockerfile f046a1410a3012509babb0558998f33b9e241c43 
  support/packaging/centos/mesos.spec 752c2aa24fba3226d5b1efa0d97a182b723e26c4 


Diff: https://reviews.apache.org/r/66840/diff/2/

Changes: https://reviews.apache.org/r/66840/diff/1-2/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202052
---




support/mesos-build/centos-7.dockerfile
Line 1 (original), 1 (patched)


It seems we need to update some more Docker setups:

* `support/packaging/*.dockerfile`
* `support/mesos-tidy/Dockerfile`

The first is used by the image `mesos/mesos-mini` while the second one 
produces `mesos/mesos-tidy` on dockerhub. After merging this patch we should 
rebuild and republish them.


- Benjamin Bannier


On April 27, 2018, 3:35 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> ---
> 
> (Updated April 27, 2018, 3:35 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.
> 
> 
> Diffs
> -
> 
>   support/mesos-build/centos-7.dockerfile 
> acdb44db281e9a156cbd684d2159ab4a5c65e8c4 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 
> 6d76090c466f84748df307888721d77a5f583290 
>   support/mesos-build/ubuntu-16.04.dockerfile 
> 0bbaa035f401c2c91e4e921cfe9abeb3953885a5 
> 
> 
> Diff: https://reviews.apache.org/r/66840/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 66820: Added framework metrics 'subscribed' and helpers.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66820/
---

(Updated April 26, 2018, 11:54 p.m.)


Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod 
Kone.


Repository: mesos


Description
---

Added framework metrics 'subscribed' and helpers.


Diffs (updated)
-

  src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828 
  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 
  src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2 
  src/master/metrics.cpp 894c04173d218ffd891d203254035fe4756cc8bb 


Diff: https://reviews.apache.org/r/66820/diff/2/

Changes: https://reviews.apache.org/r/66820/diff/1-2/


Testing
---


Thanks,

Gilbert Song

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66836/#review202050
---



Patch looks great!

Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 
66428, 66455, 66429, 66430, 66431, 66432, 66434, 66435, 66436, 66437, 66433, 
66438, 66439, 66440, 66442, 66443, 66444, 66445, 66578, 66641, 66773, 66790, 
66834, 66835, 66836]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 27, 2018, 4:22 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66836/
> ---
> 
> (Updated April 27, 2018, 4:22 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use the stout wrapper instead of `::socket` so we have built-in error
> checking (and don't have to worry about types).
> 
> 
> Diffs
> -
> 
>   src/checks/tcp_connect.cpp f5df732415b1e3ac02e9624909d822febe60fe8c 
> 
> 
> Diff: https://reviews.apache.org/r/66836/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 66840: Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66840/#review202049
---


Ship it!




Ship It!

- Gilbert Song


On April 26, 2018, 6:35 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66840/
> ---
> 
> (Updated April 26, 2018, 6:35 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8809
> https://issues.apache.org/jira/browse/MESOS-8809
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `libacl` into Dockerfiles for the `mesos/mesos-build` image.
> 
> 
> Diffs
> -
> 
>   support/mesos-build/centos-7.dockerfile 
> acdb44db281e9a156cbd684d2159ab4a5c65e8c4 
>   support/mesos-build/ubuntu-16.04-arm.dockerfile 
> 6d76090c466f84748df307888721d77a5f583290 
>   support/mesos-build/ubuntu-16.04.dockerfile 
> 0bbaa035f401c2c91e4e921cfe9abeb3953885a5 
> 
> 
> Diff: https://reviews.apache.org/r/66840/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>