Re: Review Request 68400: Exposed an XFS helper to find the block device for a given path.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68400/#review208013
---


Fix it, then Ship it!





src/tests/containerizer/xfs_quota_tests.cpp
Lines 347 (patched)


Should be `EXPECT_LE`.


- Chun-Hung Hsiao


On Aug. 24, 2018, 11:25 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68400/
> ---
> 
> (Updated Aug. 24, 2018, 11:25 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To manage persistent volumes in the `disk/xfs` isolator we need
> to keep track of the block device that hosts a given filesystem
> path. Expose the `getDeviceForPath` helper API to directly return
> this information.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e269eb5489ceed8937775a30b3420f7960ab4cd4 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> b691c76e94f686e1a866380dca99ef0fa18e2f49 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68400/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68398: Added `fs::used` helper API to stout.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68398/#review208012
---




3rdparty/stout/tests/os_tests.cpp
Lines 1154-1172 (patched)


It's probably more appropriate to put this in 
`3rdparty/stout/tests/os/filesystem_tests.cpp`:
```
#ifndef __WINDOWS__
TEST_F(FsTest, Used)
{
  ...
}
#endif // __WINDOWS__
```


- Chun-Hung Hsiao


On Aug. 24, 2018, 11:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68398/
> ---
> 
> (Updated Aug. 24, 2018, 11:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a `fs::used` API that returns the amount of used space on a
> given filesystem.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/fs.hpp 
> 269a4f50f1df8d68be9e11030f885cf2c254c9d8 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68398/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/#review208011
---



Patch looks great!

Reviews applied: [68529, 68530, 68531, 68532]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2018, 10:26 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68532/
> ---
> 
> (Updated Aug. 27, 2018, 10:26 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests were (partially) ported by implementing logic similar to
> the what's used on POSIX with `os::Fork` and `os::Exec` (which will
> not be implemented on Windows).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68532/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68400: Exposed an XFS helper to find the block device for a given path.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68400/#review208010
---


Ship it!




Ship It!

- Ilya Pronin


On Aug. 24, 2018, 4:25 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68400/
> ---
> 
> (Updated Aug. 24, 2018, 4:25 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To manage persistent volumes in the `disk/xfs` isolator we need
> to keep track of the block device that hosts a given filesystem
> path. Expose the `getDeviceForPath` helper API to directly return
> this information.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/xfs/utils.hpp 
> e269eb5489ceed8937775a30b3420f7960ab4cd4 
>   src/slave/containerizer/mesos/isolators/xfs/utils.cpp 
> b691c76e94f686e1a866380dca99ef0fa18e2f49 
>   src/tests/containerizer/xfs_quota_tests.cpp 
> 59ec182c1c3af3978156044f03d9e3d784d51fce 
> 
> 
> Diff: https://reviews.apache.org/r/68400/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/#review208009
---



PASS: Mesos patch 68532 was successfully built and tested.

Reviews applied: `['68529', '68530', '68531', '68532']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2246/mesos-review-68532

- Mesos Reviewbot Windows


On Aug. 27, 2018, 10:26 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68532/
> ---
> 
> (Updated Aug. 27, 2018, 10:26 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests were (partially) ported by implementing logic similar to
> the what's used on POSIX with `os::Fork` and `os::Exec` (which will
> not be implemented on Windows).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68532/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68399: Exposed a helper to access for the agent persistent volumes directories.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68399/#review208008
---


Ship it!




Ship It!

- Ilya Pronin


On Aug. 24, 2018, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68399/
> ---
> 
> (Updated Aug. 24, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `disk/xfs` isolator needs to scan persistent volumes at recovery
> time. Add a helper function to return the relevant set of directories.
> 
> 
> Diffs
> -
> 
>   src/slave/paths.hpp 015896453410a33923eed07b3e676be19af62a48 
>   src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 
> 
> 
> Diff: https://reviews.apache.org/r/68399/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68398: Added `fs::used` helper API to stout.

[Ilya Pronin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68398/#review208007
---


Fix it, then Ship it!




LGTM! Only 1 minor comment about the new test.


3rdparty/stout/tests/os_tests.cpp
Lines 1157-1164 (patched)


What if current directory is a different partition than `/`?


- Ilya Pronin


On Aug. 24, 2018, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68398/
> ---
> 
> (Updated Aug. 24, 2018, 4:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a `fs::used` API that returns the amount of used space on a
> given filesystem.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/fs.hpp 
> 269a4f50f1df8d68be9e11030f885cf2c254c9d8 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68398/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/
---

(Updated Aug. 27, 2018, 11:19 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.


Changes
---

Increased the memory to 1G so the libtool wrapper has enough memory to link the 
test plugin.


Repository: mesos


Description
---

Added cpus/mem to the resource provider config in SLRP tests.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
9b88d366df958d938a3a0cac4f64a937c6178ee3 


Diff: https://reviews.apache.org/r/68527/diff/3/

Changes: https://reviews.apache.org/r/68527/diff/2-3/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 68399: Exposed a helper to access for the agent persistent volumes directories.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68399/#review208005
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On Aug. 24, 2018, 11:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68399/
> ---
> 
> (Updated Aug. 24, 2018, 11:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `disk/xfs` isolator needs to scan persistent volumes at recovery
> time. Add a helper function to return the relevant set of directories.
> 
> 
> Diffs
> -
> 
>   src/slave/paths.hpp 015896453410a33923eed07b3e676be19af62a48 
>   src/slave/paths.cpp ed0b1276908f4990ce7a24c96aea20e8c79d3126 
> 
> 
> Diff: https://reviews.apache.org/r/68399/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68398: Added `fs::used` helper API to stout.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68398/#review208004
---


Ship it!




Ship It!

- Chun-Hung Hsiao


On Aug. 24, 2018, 11:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68398/
> ---
> 
> (Updated Aug. 24, 2018, 11:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Ilya Pronin, Jie Yu, Joseph Wu, 
> and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-5158
> https://issues.apache.org/jira/browse/MESOS-5158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a `fs::used` API that returns the amount of used space on a
> given filesystem.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/fs.hpp 
> 269a4f50f1df8d68be9e11030f885cf2c254c9d8 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68398/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/
---

(Updated Aug. 27, 2018, 3:26 p.m.)


Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Changes
---

Fixed failing test.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

These tests were (partially) ported by implementing logic similar to
the what's used on POSIX with `os::Fork` and `os::Exec` (which will
not be implemented on Windows).


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68532/diff/3/

Changes: https://reviews.apache.org/r/68532/diff/2-3/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/#review208003
---



PASS: Mesos patch 68527 was successfully built and tested.

Reviews applied: `['68527']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2245/mesos-review-68527

- Mesos Reviewbot Windows


On Aug. 27, 2018, 8:54 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68527/
> ---
> 
> (Updated Aug. 27, 2018, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cpus/mem to the resource provider config in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 9b88d366df958d938a3a0cac4f64a937c6178ee3 
> 
> 
> Diff: https://reviews.apache.org/r/68527/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/#review208001
---



Patch looks great!

Reviews applied: [68527]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2018, 8:54 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68527/
> ---
> 
> (Updated Aug. 27, 2018, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cpus/mem to the resource provider config in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 9b88d366df958d938a3a0cac4f64a937c6178ee3 
> 
> 
> Diff: https://reviews.apache.org/r/68527/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

[GitHub] jdef commented on a change in pull request #294: FaultDomain, conventions for additional hierarchy.

[GitBox]

jdef commented on a change in pull request #294: FaultDomain, conventions for 
additional hierarchy.
URL: https://github.com/apache/mesos/pull/294#discussion_r213123800
 
 

 ##
 File path: include/mesos/mesos.proto
 ##
 @@ -827,6 +827,18 @@ message ExecutorInfo {
  * in the same zone, in different zones in the same region, or in
  * different regions. Note that all masters in a given Mesos cluster
  * must be in the same region.
+ *
+ * Complex deployments may have additional levels of hierarchy: for example,
+ * multiple racks might be grouped together into "halls" and multiple DCs in
+ * the same geographical vicinity might be grouped together. As a convention,
+ * the recommended way to represent additional levels of hierarchy is via dot-
 
 Review comment:
   I realize that Mesos doesn't care. The goal of having a convention was to 
promote compatibility across frameworks and clusters that can handle additional 
levels of hierarchy. Consistency suffers w/o convention. This was the 
justification for adding the same commentary to the design doc, and it's just 
as relevant (and much easier to find) here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jdef commented on issue #294: FaultDomain, conventions for additional hierarchy.

[GitBox]

jdef commented on issue #294: FaultDomain, conventions for additional hierarchy.
URL: https://github.com/apache/mesos/pull/294#issuecomment-416376541
 
 
   Yes, please keep this open.
   
   On Mon, Aug 27, 2018 at 2:10 PM Greg Mann  wrote:
   
   > @jdef  would you like to keep this PR open?
   > Doing some grooming today.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or mute
   > the thread
   > 

   > .
   >
   
   
   -- 
   James DeFelice
   585.241.9488 (voice)
   650.649.6071 (fax)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/#review207998
---


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:29 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68532/
> ---
> 
> (Updated Aug. 27, 2018, 9:29 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests were (partially) ported by implementing logic similar to
> the what's used on POSIX with `os::Fork` and `os::Exec` (which will
> not be implemented on Windows).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/
---

(Updated Aug. 27, 2018, 2:29 p.m.)


Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Changes
---

Fixed build break.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

These tests were (partially) ported by implementing logic similar to
the what's used on POSIX with `os::Fork` and `os::Exec` (which will
not be implemented on Windows).


Diffs (updated)
-

  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68532/diff/2/

Changes: https://reviews.apache.org/r/68532/diff/1-2/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68529: Windows: Added notes for permanently disabled tests.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68529/#review207997
---


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:14 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68529/
> ---
> 
> (Updated Aug. 27, 2018, 9:14 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added notes for permanently disabled tests.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/filesystem_tests.cpp 
> 09d0a40a74a293dcf6eecde2a443281e4b8d9fe8 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> 3ca4099300c6288eb453ef04eb97d299adc5880d 
>   3rdparty/stout/tests/os/strerror_tests.cpp 
> 6a69d52a5b9ae93f3393ab17a3282ecb30ad90b0 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68529/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/#review207996
---


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:15 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68532/
> ---
> 
> (Updated Aug. 27, 2018, 9:15 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests were (partially) ported by implementing logic similar to
> the what's used on POSIX with `os::Fork` and `os::Exec` (which will
> not be implemented on Windows).
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68532/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68531: Windows: Ported `OsTest.Environment`.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68531/#review207995
---


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:15 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68531/
> ---
> 
> (Updated Aug. 27, 2018, 9:15 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This required replacing `os::raw::environment()` inline as it does not
> exist on Windows. Furthermore, it was also discovered that the
> documentation is incorrect, and that sometimes environment variables
> start with an equal sign. The fix is to simply look for the first
> equal sign excluding the first character, otherwise we end up with
> empty keys.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/os/windows/environment.hpp 
> 40eee59ac0b73ebe71b120e540ba7eace672ff4c 
>   3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 
> 
> 
> Diff: https://reviews.apache.org/r/68531/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 68530: Windows: Enabled `RemoveWithContinueOnError` test.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68530/#review207994
---


Ship it!




Ship It!

- Radhika Jandhyala


On Aug. 27, 2018, 9:14 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68530/
> ---
> 
> (Updated Aug. 27, 2018, 9:14 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-5813
> https://issues.apache.org/jira/browse/MESOS-5813
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test "just worked" after previous fixes.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/os/rmdir_tests.cpp 
> 3ca4099300c6288eb453ef04eb97d299adc5880d 
> 
> 
> Diff: https://reviews.apache.org/r/68530/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Review Request 68532: Windows: Ported `OsTest.Children, KillTree, ProcessExists`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68532/
---

Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

These tests were (partially) ported by implementing logic similar to
the what's used on POSIX with `os::Fork` and `os::Exec` (which will
not be implemented on Windows).


Diffs
-

  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68532/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 68531: Windows: Ported `OsTest.Environment`.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68531/
---

Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

This required replacing `os::raw::environment()` inline as it does not
exist on Windows. Furthermore, it was also discovered that the
documentation is incorrect, and that sometimes environment variables
start with an equal sign. The fix is to simply look for the first
equal sign excluding the first character, otherwise we end up with
empty keys.


Diffs
-

  3rdparty/stout/include/stout/os/windows/environment.hpp 
40eee59ac0b73ebe71b120e540ba7eace672ff4c 
  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68531/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 68530: Windows: Enabled `RemoveWithContinueOnError` test.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68530/
---

Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

This test "just worked" after previous fixes.


Diffs
-

  3rdparty/stout/tests/os/rmdir_tests.cpp 
3ca4099300c6288eb453ef04eb97d299adc5880d 


Diff: https://reviews.apache.org/r/68530/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Review Request 68529: Windows: Added notes for permanently disabled tests.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68529/
---

Review request for mesos, Akash Gupta, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-5813
https://issues.apache.org/jira/browse/MESOS-5813


Repository: mesos


Description
---

Windows: Added notes for permanently disabled tests.


Diffs
-

  3rdparty/stout/tests/os/filesystem_tests.cpp 
09d0a40a74a293dcf6eecde2a443281e4b8d9fe8 
  3rdparty/stout/tests/os/rmdir_tests.cpp 
3ca4099300c6288eb453ef04eb97d299adc5880d 
  3rdparty/stout/tests/os/strerror_tests.cpp 
6a69d52a5b9ae93f3393ab17a3282ecb30ad90b0 
  3rdparty/stout/tests/os_tests.cpp b80c34e8e84cab68de7c843c7eafefbd84c3328c 


Diff: https://reviews.apache.org/r/68529/diff/1/


Testing
---


Thanks,

Andrew Schwartzmeyer

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/#review207993
---


Ship it!




Ship It!

- Jie Yu


On Aug. 27, 2018, 8:54 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68527/
> ---
> 
> (Updated Aug. 27, 2018, 8:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cpus/mem to the resource provider config in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 9b88d366df958d938a3a0cac4f64a937c6178ee3 
> 
> 
> Diff: https://reviews.apache.org/r/68527/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/
---

(Updated Aug. 27, 2018, 8:54 p.m.)


Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.


Changes
---

Increased the memory.


Repository: mesos


Description
---

Added cpus/mem to the resource provider config in SLRP tests.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
9b88d366df958d938a3a0cac4f64a937c6178ee3 


Diff: https://reviews.apache.org/r/68527/diff/2/

Changes: https://reviews.apache.org/r/68527/diff/1-2/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/#review207991
---



PASS: Mesos patch 68527 was successfully built and tested.

Reviews applied: `['68527']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2244/mesos-review-68527

- Mesos Reviewbot Windows


On Aug. 27, 2018, 6:43 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68527/
> ---
> 
> (Updated Aug. 27, 2018, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added cpus/mem to the resource provider config in SLRP tests.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 9b88d366df958d938a3a0cac4f64a937c6178ee3 
> 
> 
> Diff: https://reviews.apache.org/r/68527/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/#review207989
---



Patch looks great!

Reviews applied: [68321, 68440, 68441, 68442, 68473]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2018, 5:44 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68473/
> ---
> 
> (Updated Aug. 27, 2018, 5:44 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the member functions of class ReadOnlyHandler into
> the new file `readonly_handler.cpp`. This follows the pattern
> established by `weights_handler.cpp` and `quota_handler.cpp`.
> 
> As part of this move, it was also necessary to move some JSON
> serialization that are used from both `master.cpp` and
> `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
> that can be used from both places.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
>   src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/readonly_handler.cpp PRE-CREATION 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68473/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> Internal CI run (Build #4249)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

[GitHub] mengzhugithub commented on issue #307: Generated a new bundle of Boost headers.

[GitBox]

mengzhugithub commented on issue #307: Generated a new bundle of Boost headers.
URL: https://github.com/apache/mesos/pull/307#issuecomment-416336482
 
 
   @greggomann It is update to date and mergable. The chain that uses the new 
boost bundle starts here in the review board: 
https://reviews.apache.org/r/68489/
   
   Previously I thought review board does not support binary files. But it 
looks like it does? I think we can either merge this PR or close this one and 
just work with the chain on the review board.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68527/
---

Review request for mesos, Benjamin Bannier, Benno Evers, and Jie Yu.


Repository: mesos


Description
---

Added cpus/mem to the resource provider config in SLRP tests.


Diffs
-

  src/tests/storage_local_resource_provider_tests.cpp 
9b88d366df958d938a3a0cac4f64a937c6178ee3 


Diff: https://reviews.apache.org/r/68527/diff/1/


Testing
---

make check


Thanks,

Chun-Hung Hsiao

[GitHub] greggomann commented on issue #307: Generated a new bundle of Boost headers.

[GitBox]

greggomann commented on issue #307: Generated a new bundle of Boost headers.
URL: https://github.com/apache/mesos/pull/307#issuecomment-416317076
 
 
   @mengzhugithub what's the current status of this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #303: Expose new metrics for memory usage in the container.

[GitBox]

greggomann commented on issue #303: Expose new metrics for memory usage in the 
container.
URL: https://github.com/apache/mesos/pull/303#issuecomment-416316830
 
 
   @fcuny were you going to continue this work on ReviewBoard?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #294: FaultDomain, conventions for additional hierarchy.

[GitBox]

greggomann commented on issue #294: FaultDomain, conventions for additional 
hierarchy.
URL: https://github.com/apache/mesos/pull/294#issuecomment-416316351
 
 
   @jdef would you like to keep this PR open? Doing some grooming today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #285: mesos.scheduler and mesos.executor seem to cause errors, changing to mesos.native

[GitBox]

greggomann commented on issue #285: mesos.scheduler and mesos.executor seem to 
cause errors, changing to mesos.native
URL: https://github.com/apache/mesos/pull/285#issuecomment-416315895
 
 
   @tillt would you have cycles to see if this is still an issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #266: Tasks docs

[GitBox]

greggomann commented on issue #266: Tasks docs
URL: https://github.com/apache/mesos/pull/266#issuecomment-416315095
 
 
   Closing due to inactivity - reopen if still relevant, thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #266: Tasks docs

[GitBox]

greggomann closed pull request #266: Tasks docs
URL: https://github.com/apache/mesos/pull/266
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/endpoints/master/tasks.json.md 
b/docs/endpoints/master/tasks.json.md
index f9553d7bde..033e90a6bd 100644
--- a/docs/endpoints/master/tasks.json.md
+++ b/docs/endpoints/master/tasks.json.md
@@ -24,6 +24,8 @@ Lists known tasks.
 The information shown might be filtered based on the user
 accessing the endpoint.
 
+Filtering via the query parameters is available starting Mesos version 1.4.0.
+
 Query parameters:
 
 >framework_id=VALUE   Only return tasks belonging to the framework 
 > with this ID.
@@ -41,4 +43,4 @@ enabled.
 This endpoint might be filtered based on the user accessing it.
 For example a user might only see the subset of tasks they are
 allowed to view.
-See the authorization documentation for details.
\ No newline at end of file
+See the authorization documentation for details.
diff --git a/docs/endpoints/master/tasks.md b/docs/endpoints/master/tasks.md
index 019a14bb6c..658b30c9de 100644
--- a/docs/endpoints/master/tasks.md
+++ b/docs/endpoints/master/tasks.md
@@ -24,6 +24,8 @@ Lists known tasks.
 The information shown might be filtered based on the user
 accessing the endpoint.
 
+Filtering via the query parameters is available starting Mesos version 1.4.0.
+
 Query parameters:
 
 >framework_id=VALUE   Only return tasks belonging to the framework 
 > with this ID.
@@ -41,4 +43,4 @@ enabled.
 This endpoint might be filtered based on the user accessing it.
 For example a user might only see the subset of tasks they are
 allowed to view.
-See the authorization documentation for details.
\ No newline at end of file
+See the authorization documentation for details.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #283: Ignore acknowledge for task status update, received out of order.

[GitBox]

greggomann commented on issue #283: Ignore acknowledge for task status update, 
received out of order.
URL: https://github.com/apache/mesos/pull/283#issuecomment-416314625
 
 
   @vargup do you know if this is still an issue? Is there an associated JIRA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andschwa commented on issue #289: Fixtestflags

[GitBox]

andschwa commented on issue #289: Fixtestflags
URL: https://github.com/apache/mesos/pull/289#issuecomment-416314557
 
 
   Thanks @radhikaj! Closing as we got this in over ReviewBoard and closed 
MESOS-8857.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andschwa closed pull request #289: Fixtestflags

[GitBox]

andschwa closed pull request #289: Fixtestflags
URL: https://github.com/apache/mesos/pull/289
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/3rdparty/libprocess/src/tests/CMakeLists.txt 
b/3rdparty/libprocess/src/tests/CMakeLists.txt
index 1b2d75d2b5..8c1353b442 100644
--- a/3rdparty/libprocess/src/tests/CMakeLists.txt
+++ b/3rdparty/libprocess/src/tests/CMakeLists.txt
@@ -87,14 +87,25 @@ target_link_libraries(libprocess-tests PRIVATE 
process-interface)
 # NOTE: This is for the generated gRPC headers.
 target_include_directories(libprocess-tests PRIVATE 
${CMAKE_CURRENT_BINARY_DIR})
 
-target_compile_definitions(
-  libprocess-tests PRIVATE
-  BUILD_DIR="${CMAKE_CURRENT_BINARY_DIR}")
+if (CMAKE_GENERATOR MATCHES "Visual Studio")
+  target_compile_definitions(
+libprocess-tests PRIVATE
+BUILD_DIR="${CMAKE_CURRENT_BINARY_DIR}/$")
+else ()
+  target_compile_definitions(
+libprocess-tests PRIVATE
+BUILD_DIR="${CMAKE_CURRENT_BINARY_DIR}")
+endif ()
 
 add_executable(test-linkee EXCLUDE_FROM_ALL test_linkee.cpp)
 target_link_libraries(test-linkee PRIVATE process-interface)
 add_dependencies(libprocess-tests test-linkee)
 
+if (WIN32)
+  add_executable(test-echo EXCLUDE_FROM_ALL test_echo.cpp)
+  add_dependencies(libprocess-tests test-echo)
+endif ()
+
 if (ENABLE_SSL)
   add_executable(ssl-client EXCLUDE_FROM_ALL ssl_client.cpp)
   target_link_libraries(ssl-client PRIVATE process-interface)
diff --git a/3rdparty/libprocess/src/tests/subprocess_tests.cpp 
b/3rdparty/libprocess/src/tests/subprocess_tests.cpp
index 269918e7f7..2127429e44 100644
--- a/3rdparty/libprocess/src/tests/subprocess_tests.cpp
+++ b/3rdparty/libprocess/src/tests/subprocess_tests.cpp
@@ -782,10 +782,35 @@ TEST_F(SubprocessTest, Flags)
 
   string out = path::join(os::getcwd(), "stdout");
 
+#ifdef __WINDOWS__
+  // The Windows version of `echo` is a built-in of the command
+  // prompt, and it simply reproduces the entire command line string.
+  // However, the flags class (and thus this test) is expecting the
+  // semantics of a native binary interpreting the command line
+  // arguments via the Windows API `CommandLineToArgv`. When a regular
+  // Windows application (in contrast to `echo`) gets command line
+  // arguments, the text is processed automatically by
+  // `CommandLineToArgv`, which converts the command line string into
+  // an array. For example, this is the output of `echo`:
+  //
+  //> cmd.exe /c echo "--s3=\"geek\""
+  //"--s3=\"geek\""
+  //
+  // With `test-echo.exe`, a small native binary that just prints its
+  // arguments, the output is:
+  //
+  // > test-echo.exe "--s3=\"geek\""
+  // --s3="geek"
+  //
+  // This is the behavior expected by the test as the POSIX version of
+  // `echo` is a native binary.
+  string test_exe_path = path::join(BUILD_DIR, "test-echo.exe");
+#endif
+
   Try s = subprocess(
 #ifdef __WINDOWS__
-  os::Shell::name,
-  {os::Shell::arg0, os::Shell::arg1, "echo"},
+ test_exe_path,
+ { test_exe_path },
 #else
   "/bin/echo",
   vector(1, "echo"),
@@ -831,18 +856,10 @@ TEST_F(SubprocessTest, Flags)
   EXPECT_EQ(flags.i, flags2.i);
   EXPECT_EQ(flags.s, flags2.s);
   EXPECT_EQ(flags.s2, flags2.s2);
-  // TODO(andschwa): Fix the `flags.load()` or `stringify_args` logic.
-  // Currently, this gets escaped to `"\"--s3=\\\"geek\\\"\""` because
-  // it has double quotes in it. See MESOS-8857.
-#ifndef __WINDOWS__
   EXPECT_EQ(flags.s3, flags2.s3);
-#endif // __WINDOWS__
   EXPECT_EQ(flags.d, flags2.d);
   EXPECT_EQ(flags.y, flags2.y);
-  // TODO(andschwa): Same problem as above.
-#ifndef __WINDOWS__
   EXPECT_EQ(flags.j, flags2.j);
-#endif // __WINDOWS__
 
   for (int i = 1; i < argc; i++) {
 ::free(argv[i]);
diff --git a/3rdparty/libprocess/src/tests/test_echo.cpp 
b/3rdparty/libprocess/src/tests/test_echo.cpp
new file mode 100644
index 00..30592f8c31
--- /dev/null
+++ b/3rdparty/libprocess/src/tests/test_echo.cpp
@@ -0,0 +1,28 @@
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License
+
+// This process provides a target for testing flags
+// in libprocess.
+// It prints out argv separated by spaces.
+
+#include 
+
+int main(int argc, char** argv)
+{
+  printf("\n");
+  for (int i 

[GitHub] greggomann closed pull request #290: Integrated mesos fetcher with libarchive.

[GitBox]

greggomann closed pull request #290: Integrated mesos fetcher with libarchive.
URL: https://github.com/apache/mesos/pull/290
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 3837a31562..0eb5247704 100644
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -24,6 +24,7 @@ endif ()
 
 # TODO(andschwa): Move each URL to the dependency itself.
 set(BOOST_URL   ${FETCH_URL}/boost-${BOOST_VERSION}.tar.gz)
+set(BZIP2_URL   ${FETCH_URL}/bzip2-${BZIP2_VERSION}.tar.gz)
 set(CONCURRENTQUEUE_URL 
${FETCH_URL}/concurrentqueue-${CONCURRENTQUEUE_VERSION}.tar.gz)
 set(CSI_URL ${FETCH_URL}/csi-${CSI_VERSION}.tar.gz)
 set(ELFIO_URL   ${FETCH_URL}/elfio-${ELFIO_VERSION}.tar.gz)
@@ -35,8 +36,10 @@ set(JEMALLOC_URL
${FETCH_URL}/jemalloc-${JEMALLOC_VERSION}.tar.gz)
 set(PICOJSON_URL${FETCH_URL}/picojson-${PICOJSON_VERSION}.tar.gz)
 set(PROTOBUF_URL${FETCH_URL}/protobuf-${PROTOBUF_VERSION}.tar.gz)
 set(LEVELDB_URL ${FETCH_URL}/leveldb-${LEVELDB_VERSION}.tar.gz)
+set(LIBARCHIVE_URL  ${FETCH_URL}/libarchive-${LIBARCHIVE_VERSION}.tar.gz)
 set(LIBEV_URL   ${FETCH_URL}/libev-${LIBEV_VERSION}.tar.gz)
 set(NVML_URL${FETCH_URL}/nvml-${NVML_VERSION}.tar.gz)
+set(XZ_URL  ${FETCH_URL}/xz-${XZ_VERSION}.tar.gz)
 set(ZOOKEEPER_URL   ${FETCH_URL}/zookeeper-${ZOOKEEPER_VERSION}.tar.gz)
 
 # NOTE: libevent doesn't come rebundled, so this URL is always the same. But,
@@ -752,6 +755,84 @@ else ()
 endif ()
 
 
+# bzip2: A Massively Spiffy Yet Delicately Unobtrusive Compression Library.
+# https://bzip.org
+##
+if (WIN32)
+  EXTERNAL(bzip2 ${BZIP2_VERSION} ${CMAKE_CURRENT_BINARY_DIR})
+  add_library(bzip2 STATIC IMPORTED)
+  add_dependencies(bzip2 ${BZIP2_TARGET})
+
+  set_target_properties(
+bzip2 PROPERTIES
+INTERFACE_INCLUDE_DIRECTORIES "${BZIP2_ROOT};${BZIP2_ROOT}-build")
+
+  set_target_properties(
+bzip2 PROPERTIES
+IMPORTED_LOCATION_DEBUG 
${BZIP2_ROOT}-build/Debug/bzip2${BZIP2_SHARED}${LIBRARY_SUFFIX}
+IMPORTED_LOCATION_RELEASE 
${BZIP2_ROOT}-build/Release/bzip2${BZIP2_SHARED}${LIBRARY_SUFFIX}
+IMPORTED_IMPLIB_DEBUG 
${BZIP2_ROOT}-build/Debug/bzip2${CMAKE_IMPORT_LIBRARY_SUFFIX}
+IMPORTED_IMPLIB_RELEASE 
${BZIP2_ROOT}-build/Release/bzip2${CMAKE_IMPORT_LIBRARY_SUFFIX})
+
+  PATCH_CMD(BZIP2_PATCH_CMD bzip2-${BZIP2_VERSION}.patch)
+
+  MAKE_INCLUDE_DIR(bzip2)
+  GET_BYPRODUCTS(bzip2)
+
+  set(BZIP2_CMAKE_ARGS
+${CMAKE_FORWARD_ARGS}
+-DBZIP2_INSTALL_DIR=${BZIP2_ROOT}-lib)
+
+  ExternalProject_Add(
+${BZIP2_TARGET}
+PREFIX${BZIP2_CMAKE_ROOT}
+BUILD_BYPRODUCTS  ${BZIP2_BYPRODUCTS}
+PATCH_COMMAND ${BZIP2_PATCH_CMD}
+CMAKE_ARGS${BZIP2_CMAKE_ARGS}
+INSTALL_DIR   ${BZIP2_ROOT}-lib
+URL   ${BZIP2_URL}
+URL_HASH  ${BZIP2_HASH})
+endif ()
+
+# xz: A Massively Spiffy Yet Delicately Unobtrusive Compression Library.
+# https://tukaani.org/xz/
+##
+if (WIN32)
+  EXTERNAL(xz ${XZ_VERSION} ${CMAKE_CURRENT_BINARY_DIR})
+  add_library(xz STATIC IMPORTED)
+  add_dependencies(xz ${XZ_TARGET})
+
+  set_target_properties(
+xz PROPERTIES
+INTERFACE_INCLUDE_DIRECTORIES "${XZ_ROOT};${XZ_ROOT}-build")
+
+  set_target_properties(
+xz PROPERTIES
+IMPORTED_LOCATION_DEBUG 
${XZ_ROOT}-build/Debug/lzma${XZ_SHARED}${LIBRARY_SUFFIX}
+IMPORTED_LOCATION_RELEASE 
${XZ_ROOT}-build/Release/lzma${XZ_SHARED}${LIBRARY_SUFFIX}
+IMPORTED_IMPLIB_DEBUG 
${XZ_ROOT}-build/Debug/lzma${CMAKE_IMPORT_LIBRARY_SUFFIX}
+IMPORTED_IMPLIB_RELEASE 
${XZ_ROOT}-build/Release/lzma${CMAKE_IMPORT_LIBRARY_SUFFIX})
+
+  PATCH_CMD(XZ_PATCH_CMD xz-${XZ_VERSION}.patch)
+
+  MAKE_INCLUDE_DIR(xz)
+  GET_BYPRODUCTS(xz)
+
+  set(XZ_CMAKE_ARGS
+${CMAKE_FORWARD_ARGS}
+-DXZ_INSTALL_DIR=${XZ_ROOT}-lib)
+
+  ExternalProject_Add(
+${XZ_TARGET}
+PREFIX${XZ_CMAKE_ROOT}
+BUILD_BYPRODUCTS  ${XZ_BYPRODUCTS}
+PATCH_COMMAND ${XZ_PATCH_CMD}
+CMAKE_ARGS${XZ_CMAKE_ARGS}
+INSTALL_DIR   ${XZ_ROOT}-lib
+URL   ${XZ_URL}
+URL_HASH  ${XZ_HASH})
+endif ()
+
 # zlib: A Massively Spiffy Yet Delicately Unobtrusive Compression Library.
 # https://zlib.net
 ##
@@ -824,6 +905,67 @@ set_target_properties(
   zlib PROPERTIES
   INTERFACE_COMPILE_DEFINITIONS HAVE_LIBZ)
 
+# libarchive: Multi-format archive and compression library.
+# https://github.com/libarchive/libarchive
+##

[GitHub] greggomann commented on issue #290: Integrated mesos fetcher with libarchive.

[GitBox]

greggomann commented on issue #290: Integrated mesos fetcher with libarchive.
URL: https://github.com/apache/mesos/pull/290#issuecomment-416314242
 
 
   Closing since the associated RRs have landed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #270: Update presentations.md

[GitBox]

greggomann closed pull request #270: Update presentations.md
URL: https://github.com/apache/mesos/pull/270
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/presentations.md b/docs/presentations.md
index e0c1c3aadd..ea4449142c 100644
--- a/docs/presentations.md
+++ b/docs/presentations.md
@@ -136,3 +136,7 @@ _(Listed in date descending order)_
 ## Automated Machine Learning Pipeline with Mesos 
([Video](https://www.packtpub.com/big-data-and-business-intelligence/automated-machine-learning-pipeline-mesos-integrated-course))
 Karl Whitford
 Packt (November 2017)
+
+## Docker, Apache Mesos & DCOS: Run and manage cloud datacenter 
([Video](https://www.packtpub.com/networking-and-servers/docker-apache-mesos-dcos-run-and-manage-cloud-datacenter-video))
+Manuj Aggarwal
+Packt (January 2018) 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #255: Add curl examples to operator-http-api

[GitBox]

greggomann commented on issue #255: Add curl examples to operator-http-api
URL: https://github.com/apache/mesos/pull/255#issuecomment-416312676
 
 
   @nhandler we were reviewing PRs today and came across this one - do you have 
a cycle to update real quick?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #221: Fixed a bug in the logging of cni isolator.

[GitBox]

greggomann closed pull request #221: Fixed a bug in the logging of cni isolator.
URL: https://github.com/apache/mesos/pull/221
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
b/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
index 3aecd8c5a2..08d3548c05 100644
--- a/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
+++ b/src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
@@ -33,6 +33,7 @@
 #include 
 
 #include "common/protobuf_utils.hpp"
+#include "common/status_utils.hpp"
 
 #include "linux/fs.hpp"
 #include "linux/ns.hpp"
@@ -1994,11 +1995,14 @@ int NetworkCniIsolatorSetup::execute()
   return EXIT_FAILURE;
 }
 
-if (os::spawn("ifconfig", {"ifconfig", "lo", "up"}) != 0) {
-  cerr << "Failed to bring up the loopback interface in the new "
-   << "network namespace of pid " << flags.pid.get()
-   << ": " << os::strerror(errno) << endl;
-  return EXIT_FAILURE;
+int spawn = os::spawn("ifconfig", {"ifconfig", "lo", "up"});
+
+if (spawn != 0) {
+cerr << "Failed to bring up the loopback interface in the new "
+ << "network namespace of pid " << flags.pid.get() << ": "
+ << (spawn < 0 ? "Failed to fork or wait process" :
+ WSTRINGIFY(spawn)) << endl;
+return EXIT_FAILURE;
 }
   }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #221: Fixed a bug in the logging of cni isolator.

[GitBox]

greggomann commented on issue #221: Fixed a bug in the logging of cni isolator.
URL: https://github.com/apache/mesos/pull/221#issuecomment-416312190
 
 
   Closing since the related RR has landed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #69: update module doc: add parameter -c to build command

[GitBox]

greggomann commented on issue #69: update module doc:  add parameter -c to 
build command
URL: https://github.com/apache/mesos/pull/69#issuecomment-416311662
 
 
   Closing due to inactivity - please rebase and reopen if still relevant, 
thanks!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #69: update module doc: add parameter -c to build command

[GitBox]

greggomann closed pull request #69: update module doc:  add parameter -c to 
build command
URL: https://github.com/apache/mesos/pull/69
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/modules.md b/docs/modules.md
index b8693c0577..23fc23dd86 100644
--- a/docs/modules.md
+++ b/docs/modules.md
@@ -272,7 +272,7 @@ mesos::modules::Module 
org_apache_mesos_TestModule(
   The following assumes that Mesos is installed in the standard location, i.e.
   the Mesos dynamic library and header files are available.
 
-g++ -lmesos -fpic -o test_module.o test_module.cpp
+g++ -lmesos -fpic -c -o test_module.o test_module.cpp
 $ gcc -shared -o libtest_module.so test_module.o
 
 ### Testing a modules


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #190: Ensure curl is present on Ubuntu

[GitBox]

greggomann commented on issue #190: Ensure curl is present on Ubuntu
URL: https://github.com/apache/mesos/pull/190#issuecomment-416310846
 
 
   @rukletsov do you have cycles to take a look and see if this is still an 
issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #205: Clarify existence of FrameworkID in SUBSCRIBE calls.

[GitBox]

greggomann commented on issue #205: Clarify existence of FrameworkID in 
SUBSCRIBE calls.
URL: https://github.com/apache/mesos/pull/205#issuecomment-416310451
 
 
   @vinodkone could you take a look?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #191: Adding support for s390x architecture

[GitBox]

greggomann closed pull request #191: Adding support for s390x architecture
URL: https://github.com/apache/mesos/pull/191
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/linux/ldcache.cpp b/src/linux/ldcache.cpp
index 6260496672..9c2ec8263f 100644
--- a/src/linux/ldcache.cpp
+++ b/src/linux/ldcache.cpp
@@ -114,17 +114,15 @@ struct HeaderNew
   // and align to 8 byte boundary.
 };
 
-
 struct EntryNew
 {
-  int16_t flags;// Flags bits determine arch and library type.
+  int32_t flags;// Flags bits determine arch and library type.
   uint32_t key; // String table index.
   uint32_t value;   // String table index.
   uint32_t osVersion;   // Required OS version.
   uint64_t hwcap;   // Hwcap entry.
 };
 
-
 // Returns a 'boundary' aligned pointer by rounding up to
 // the nearest multiple of 'boundary'.
 static inline const char* align(const char* address, size_t boundary)
diff --git a/src/slave/flags.cpp b/src/slave/flags.cpp
index 4637ca62b2..26646ea93c 100644
--- a/src/slave/flags.cpp
+++ b/src/slave/flags.cpp
@@ -148,6 +148,15 @@ mesos::internal::slave::Flags::Flags()
   "Directory the appc provisioner will store images in.\n",
   path::join(os::temp(), "mesos", "store", "appc"));
 
+  #if defined(__s390x__)
+  add(&Flags::docker_registry,
+  "docker_registry",
+  "The default url for pulling Docker images. It could either be a 
Docker\n"
+  "registry server url (i.e: `https://registry.docker.io`), or a local\n"
+  "path (i.e: `/tmp/docker/images`) in which Docker image archives\n"
+  "(result of `docker save`) are stored.",
+  "/opt/docker/images");
+  #else
   add(&Flags::docker_registry,
   "docker_registry",
   "The default url for pulling Docker images. It could either be a 
Docker\n"
@@ -155,6 +164,7 @@ mesos::internal::slave::Flags::Flags()
   "path (i.e: `/tmp/docker/images`) in which Docker image archives\n"
   "(result of `docker save`) are stored.",
   "https://registry-1.docker.io";);
+  #endif
 
   add(&Flags::docker_store_dir,
   "docker_store_dir",


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #191: Adding support for s390x architecture

[GitBox]

greggomann commented on issue #191: Adding support for s390x architecture
URL: https://github.com/apache/mesos/pull/191#issuecomment-416310141
 
 
   Closing this due to a lack of activity - feel free to reopen if this work is 
ongoing!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #178: WIP: Mesos Documentation Project Reorg Proposal

[GitBox]

greggomann commented on issue #178: WIP: Mesos Documentation Project Reorg 
Proposal
URL: https://github.com/apache/mesos/pull/178#issuecomment-416309831
 
 
   Closing since we have reorganized the docs in the meantime.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #178: WIP: Mesos Documentation Project Reorg Proposal

[GitBox]

greggomann closed pull request #178: WIP: Mesos Documentation Project Reorg 
Proposal
URL: https://github.com/apache/mesos/pull/178
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/concepts/agent-isolators.md b/docs/concepts/agent-isolators.md
new file mode 100644
index 00..e0eb1a5ad1
--- /dev/null
+++ b/docs/concepts/agent-isolators.md
@@ -0,0 +1 @@
+agent-isolators.md
diff --git a/docs/concepts/agents.md b/docs/concepts/agents.md
new file mode 100644
index 00..ef87c33320
--- /dev/null
+++ b/docs/concepts/agents.md
@@ -0,0 +1 @@
+agents.md
diff --git a/docs/concepts/api-concepts.md b/docs/concepts/api-concepts.md
new file mode 100644
index 00..aceda302e6
--- /dev/null
+++ b/docs/concepts/api-concepts.md
@@ -0,0 +1 @@
+api-concepts
diff --git a/docs/concepts/authentication-and-authorization.md 
b/docs/concepts/authentication-and-authorization.md
new file mode 100644
index 00..2f6e0c8edf
--- /dev/null
+++ b/docs/concepts/authentication-and-authorization.md
@@ -0,0 +1 @@
+authentication-and-authorization
diff --git a/docs/concepts/choosing-a-type-of-deployment.md 
b/docs/concepts/choosing-a-type-of-deployment.md
new file mode 100644
index 00..89f8f2ef54
--- /dev/null
+++ b/docs/concepts/choosing-a-type-of-deployment.md
@@ -0,0 +1 @@
+choosing-a-type-of-deployment.md
diff --git a/docs/concepts/code-reviewing-guidelines.md 
b/docs/concepts/code-reviewing-guidelines.md
new file mode 100644
index 00..83e93ed206
--- /dev/null
+++ b/docs/concepts/code-reviewing-guidelines.md
@@ -0,0 +1 @@
+code-reviewing-guidelines
diff --git a/docs/concepts/committing-guidelines.md 
b/docs/concepts/committing-guidelines.md
new file mode 100644
index 00..0e0efd04ea
--- /dev/null
+++ b/docs/concepts/committing-guidelines.md
@@ -0,0 +1 @@
+committing-guidelines
diff --git a/docs/concepts/configure-mesos.md b/docs/concepts/configure-mesos.md
new file mode 100644
index 00..a057700d8c
--- /dev/null
+++ b/docs/concepts/configure-mesos.md
@@ -0,0 +1 @@
+configure-mesos.md
diff --git a/docs/concepts/contributing-to-mesos-overview.md 
b/docs/concepts/contributing-to-mesos-overview.md
new file mode 100644
index 00..0d2a15887f
--- /dev/null
+++ b/docs/concepts/contributing-to-mesos-overview.md
@@ -0,0 +1 @@
+contributing-to-mesos-overview.md
diff --git a/docs/concepts/cpp-style-guide.md b/docs/concepts/cpp-style-guide.md
new file mode 100644
index 00..f33ab097d6
--- /dev/null
+++ b/docs/concepts/cpp-style-guide.md
@@ -0,0 +1 @@
+cpp-style-guide
diff --git a/docs/concepts/design-documents.md 
b/docs/concepts/design-documents.md
new file mode 100644
index 00..2314fe749e
--- /dev/null
+++ b/docs/concepts/design-documents.md
@@ -0,0 +1 @@
+design-documents
diff --git a/docs/concepts/developer-community.md 
b/docs/concepts/developer-community.md
new file mode 100644
index 00..156ddca1ed
--- /dev/null
+++ b/docs/concepts/developer-community.md
@@ -0,0 +1 @@
+developer-community
diff --git a/docs/concepts/developing-advanced-resource-types.md 
b/docs/concepts/developing-advanced-resource-types.md
new file mode 100644
index 00..5eea7ddb87
--- /dev/null
+++ b/docs/concepts/developing-advanced-resource-types.md
@@ -0,0 +1 @@
+developing-advanced-resource-types.md
diff --git a/docs/concepts/developing-containers.md.md 
b/docs/concepts/developing-containers.md.md
new file mode 100644
index 00..9f6ef17041
--- /dev/null
+++ b/docs/concepts/developing-containers.md.md
@@ -0,0 +1 @@
+developing-containers.md
diff --git a/docs/concepts/developing-executors.md 
b/docs/concepts/developing-executors.md
new file mode 100644
index 00..3ee1bd0126
--- /dev/null
+++ b/docs/concepts/developing-executors.md
@@ -0,0 +1 @@
+developing-executors.md
diff --git a/docs/concepts/developing-mesos-containerizer.md 
b/docs/concepts/developing-mesos-containerizer.md
new file mode 100644
index 00..ceb2ad7a95
--- /dev/null
+++ b/docs/concepts/developing-mesos-containerizer.md
@@ -0,0 +1 @@
+developing-mesos-containerizer.md
diff --git a/docs/concepts/developing-mesos-frameworks-overview.md 
b/docs/concepts/developing-mesos-frameworks-overview.md
new file mode 100644
index 00..32704fe636
--- /dev/null
+++ b/docs/concepts/developing-mesos-frameworks-overview.md
@@ -0,0 +1 @@
+developing-mesos-frameworks-overview.md
diff --git a/docs/concepts/developing-resource-offers.md 
b/docs/concepts/developing-resource-offers.md
new file mode 100644
index 00..27b8769b7c
--- /dev/null
+++ b/docs/concepts/developing-resource-offers.md
@@ -0,0 +1 @@
+developing-resource-offers.md
diff --git a/docs/concepts/developing-schedulers.md 
b/docs/concepts/developing-schedulers.md
new file mode 100644
index 00..8ae3

[GitHub] andschwa closed pull request #104: MESOS-3932 Suppressed boost auto_ptr compile warnings.

[GitBox]

andschwa closed pull request #104: MESOS-3932 Suppressed boost auto_ptr compile 
warnings.
URL: https://github.com/apache/mesos/pull/104
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index e0c538d9e6..cfb05475e6 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -388,7 +388,7 @@ add_definitions(-DUSE_STATIC_LIB -DBUILD_DATE=0 
-DBUILD_TIME=0 -DBUILD_USER="fra
 # INCLUDE DIRECTIVES FOR MESOS LIBRARY (generates, e.g., -I/path/to/thing
 # on Linux).
 #
-include_directories(${AGENT_INCLUDE_DIRS})
+include_directories(SYSTEM ${AGENT_INCLUDE_DIRS})
 
 # LINKING LIBRARIES BY DIRECTORY (might generate, e.g., -L/path/to/thing on
 # Linux).


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andschwa commented on issue #104: MESOS-3932 Suppressed boost auto_ptr compile warnings.

[GitBox]

andschwa commented on issue #104: MESOS-3932 Suppressed boost auto_ptr compile 
warnings.
URL: https://github.com/apache/mesos/pull/104#issuecomment-416309788
 
 
   Thanks @frankscholten! I am closing this as the whole CMake build has been 
pretty much rewritten since this was opened. Sorry we didn't get to it in time!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann commented on issue #105: MESOS-3139 Added first draft CMake build docs.

[GitBox]

greggomann commented on issue #105: MESOS-3139 Added first draft CMake build 
docs.
URL: https://github.com/apache/mesos/pull/105#issuecomment-416308848
 
 
   Closing this PR since we have added CMake documentation in the meantime.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] greggomann closed pull request #105: MESOS-3139 Added first draft CMake build docs.

[GitBox]

greggomann closed pull request #105: MESOS-3139 Added first draft CMake build 
docs.
URL: https://github.com/apache/mesos/pull/105
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/cmake.md b/docs/cmake.md
new file mode 100644
index 00..eac94da76a
--- /dev/null
+++ b/docs/cmake.md
@@ -0,0 +1,59 @@
+---
+title: Apache Mesos - CMake
+layout: documentation
+---
+
+# CMake
+
+## Downloading Mesos
+
+There are different ways you can get Mesos:
+
+1\. Download the latest stable release from 
[Apache](http://mesos.apache.org/downloads/) (***Recommended***)
+
+$ wget http://www.apache.org/dist/mesos/0.28.1/mesos-0.28.1.tar.gz
+$ tar -zxf mesos-0.28.1.tar.gz
+
+2\. Clone the Mesos git 
[repository](https://git-wip-us.apache.org/repos/asf/mesos.git) (***Advanced 
Users Only***)
+
+$ git clone https://git-wip-us.apache.org/repos/asf/mesos.git
+
+*NOTE: If you have problems running the above commands, you may need to first 
run through the ***System Requirements*** section below to install the `wget`, 
`tar`, and `git` utilities for your system.*
+
+## System Requirements
+
+Mesos runs on Linux (64 Bit) and Mac OS X (64 Bit). To build Mesos from 
source, GCC 4.8.1+ or Clang 3.5+ and CMake 3.5.1 is required.
+
+For full support of process isolation under Linux a recent kernel >=3.10 is 
required.
+
+Make sure your hostname is resolvable via DNS or via `/etc/hosts` to allow 
full support of Docker's host-networking capabilities, needed for some of the 
Mesos tests. When in doubt, please validate that `/etc/hosts` contains your 
hostname.
+
+### Ubuntu 16.04
+
+Following are the instructions for stock Ubuntu 16.04. If you are using a 
different OS, please install the packages accordingly.
+
+# Update the packages.
+$ sudo apt-get update
+
+# Install a few utility tools.
+$ sudo apt-get install -y tar wget git
+
+# Install the latest OpenJDK.
+$ sudo apt-get install -y openjdk-7-jdk
+
+# Install autotools (Only necessary if building from git repository).
+$ sudo apt-get install -y autoconf libtool
+
+# Install other Mesos dependencies.
+$ sudo apt-get -y install build-essential python-dev libcurl4-nss-dev 
libsasl2-dev libsasl2-modules maven libapr1-dev libsvn-dev
+
+## Building Mesos with CMake
+
+# Change working directory.
+$ cd mesos
+
+# Configure and build.
+$ mkdir build
+$ cd build
+$ cmake ..
+$ make
diff --git a/docs/home.md b/docs/home.md
index 16a77da437..75d659a1e8 100644
--- a/docs/home.md
+++ b/docs/home.md
@@ -13,6 +13,7 @@ layout: documentation
 ## Running Mesos
 
 * [Getting Started](getting-started.md) for basic instructions on compiling 
and installing Mesos.
+* [CMake](cmake.md) for building Mesos with CMake.
 * [Upgrades](upgrades.md) for upgrading a Mesos cluster.
 * [Configuration](configuration.md) for command-line arguments.
 * [HTTP Endpoints](endpoints/) for available HTTP endpoints.


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/
---

(Updated Aug. 27, 2018, 5:44 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Updated "Testing Done" section.


Repository: mesos


Description
---

Moved the member functions of class ReadOnlyHandler into
the new file `readonly_handler.cpp`. This follows the pattern
established by `weights_handler.cpp` and `quota_handler.cpp`.

As part of this move, it was also necessary to move some JSON
serialization that are used from both `master.cpp` and
`readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
that can be used from both places.


Diffs
-

  src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
  src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
  src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
  src/master/readonly_handler.cpp PRE-CREATION 
  src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 


Diff: https://reviews.apache.org/r/68473/diff/3/


Testing (updated)
---

`make check`
Internal CI run (Build #4249)


Thanks,

Benno Evers

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/#review207985
---



PASS: Mesos patch 68473 was successfully built and tested.

Reviews applied: `['68321', '68440', '68441', '68442', '68473']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2243/mesos-review-68473

- Mesos Reviewbot Windows


On Aug. 27, 2018, 2:57 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68473/
> ---
> 
> (Updated Aug. 27, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the member functions of class ReadOnlyHandler into
> the new file `readonly_handler.cpp`. This follows the pattern
> established by `weights_handler.cpp` and `quota_handler.cpp`.
> 
> As part of this move, it was also necessary to move some JSON
> serialization that are used from both `master.cpp` and
> `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
> that can be used from both places.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
>   src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/readonly_handler.cpp PRE-CREATION 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68473/diff/3/
> 
> 
> Testing
> ---
> 
> [Revision 0]
> `make`
> 
> [Revision 1]
> Triggered Internal CI run. (Jenkins id #4162)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68495: Made command check always waits before removing the nested container.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68495/#review207984
---




src/checks/checker_process.cpp
Lines 878-889 (original), 890-901 (patched)


It looks like we should always call `waitNestedContainer()` after we said 
`previousCheckContainerId = checkContainerId;`. For example here.

Maybe it makes sense to call `waitNestedContainer()` right in the 
beginning? We can end up calling it twice, but I think it's fine?


- Alexander Rukletsov


On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68495/
> ---
> 
> (Updated Aug. 24, 2018, 9:54 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Alexander Rukletsov, Gastón Kleiman, 
> and Gilbert Song.
> 
> 
> Bugs: MESOS-8568
> https://issues.apache.org/jira/browse/MESOS-8568
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made command check always waits before removing the nested container.
> 
> 
> Diffs
> -
> 
>   src/checks/checker_process.cpp 77a76f465fe57eab89f027b5acb74c2339551678 
> 
> 
> Diff: https://reviews.apache.org/r/68495/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68147: Added agent support to remove local resource providers.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68147/#review207982
---



Patch looks great!

Reviews applied: [68407, 68143, 68144, 68146, 68362, 68145, 68147]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 20, 2018, 6:47 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68147/
> ---
> 
> (Updated Aug. 20, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds support for triggering permanent removal of local
> resource providers. We also add authorization and tests as part of this
> patch.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 
>   include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f2159367c66ed35ee90aea07f 
>   src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
>   src/slave/slave.hpp b1d695b59a63a5af34b19faff16bf6c82b7e7d88 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
>   src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e 
>   src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 
> 
> 
> Diff: https://reviews.apache.org/r/68147/diff/8/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 68147: Added agent support to remove local resource providers.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68147/#review207979
---



PASS: Mesos patch 68147 was successfully built and tested.

Reviews applied: `['68407', '68143', '68144', '68146', '68362', '68145', 
'68147']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2242/mesos-review-68147

- Mesos Reviewbot Windows


On Aug. 20, 2018, 6:47 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68147/
> ---
> 
> (Updated Aug. 20, 2018, 6:47 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gastón Kleiman, Greg Mann, and Jan 
> Schlicht.
> 
> 
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds support for triggering permanent removal of local
> resource providers. We also add authorization and tests as part of this
> patch.
> 
> 
> Diffs
> -
> 
>   include/mesos/agent/agent.proto 74488e873cbf99ca487403b70691912cf3788288 
>   include/mesos/v1/agent/agent.proto 5d1ab6fd7f6f2159367c66ed35ee90aea07f 
>   src/slave/http.hpp 78200874cb03a3d5af4ee0443c03a1d94cd494cc 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
>   src/slave/slave.hpp b1d695b59a63a5af34b19faff16bf6c82b7e7d88 
>   src/slave/slave.cpp e6c7e686f287fb4448a0074d4e99298665fc866d 
>   src/slave/validation.cpp df5e1373dbe497bc859455dcaf4e064e923bd72e 
>   src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 
> 
> 
> Diff: https://reviews.apache.org/r/68147/diff/8/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 68234: Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68234/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.


Summary (updated)
-

Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.


Repository: mesos


Description (updated)
---

This test verifies that launch nested container fails when the parent
container is unknown to the containerizer.


Diffs (updated)
-

  src/tests/api_tests.cpp ee82350f7a6c6d44ba0590608e7d9a223c0be169 


Diff: https://reviews.apache.org/r/68234/diff/1/


Testing
---


Thanks,

Andrei Budnik

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Benno Evers]

> On Aug. 27, 2018, 11:18 a.m., Alexander Rukletsov wrote:
> > src/common/http.hpp
> > Line 165 (original), 165-174 (patched)
> > 
> >
> > I believe it was meant to be sorted alphabetically. Can you please 
> > restore that order *and* add new lines respectfully?

For a very loose definition of "alphabetically" ;) But I've rearranged things 
now.


- Benno


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/#review207963
---


On Aug. 27, 2018, 2:57 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68473/
> ---
> 
> (Updated Aug. 27, 2018, 2:57 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the member functions of class ReadOnlyHandler into
> the new file `readonly_handler.cpp`. This follows the pattern
> established by `weights_handler.cpp` and `quota_handler.cpp`.
> 
> As part of this move, it was also necessary to move some JSON
> serialization that are used from both `master.cpp` and
> `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
> that can be used from both places.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
>   src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/readonly_handler.cpp PRE-CREATION 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68473/diff/3/
> 
> 
> Testing
> ---
> 
> [Revision 0]
> `make`
> 
> [Revision 1]
> Triggered Internal CI run. (Jenkins id #4162)
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 68235: Cleaned up container on launch failures in composing containerizer.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68235/
---

Review request for mesos, Alexander Rukletsov, Gilbert Song, and Qian Zhang.


Summary (updated)
-

Cleaned up container on launch failures in composing containerizer.


Repository: mesos


Description (updated)
---

Previously, if a parent container was unknown to the composing
containerizer during an attempt to launch a nested container
via `ComposingContainerizerProcess::launch()`, the composing
containerizer returned an error without cleaning up the container.
The `containerizer` field was uninitialized, so a further attempt
to remove or destroy the nested container led to segfault.

This patch removes the container when the parent container is unknown.


Diffs (updated)
-

  src/slave/containerizer/composing.cpp 
521645839b422d455da08ce7ab306f83da0b88ad 


Diff: https://reviews.apache.org/r/68235/diff/1/


Testing (updated)
---

sudo make check (Fedora 25)

This test fixes agent's segfault when running 
`AgentAPITest.LaunchNestedContainerWithUnknownParent` test, which can be found 
in the previous patch.


Thanks,

Andrei Budnik

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/
---

(Updated Aug. 27, 2018, 2:57 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Remove `json.hpp` as separate file.


Repository: mesos


Description
---

Moved the member functions of class ReadOnlyHandler into
the new file `readonly_handler.cpp`. This follows the pattern
established by `weights_handler.cpp` and `quota_handler.cpp`.

As part of this move, it was also necessary to move some JSON
serialization that are used from both `master.cpp` and
`readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
that can be used from both places.


Diffs (updated)
-

  src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
  src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
  src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
  src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
  src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
  src/master/readonly_handler.cpp PRE-CREATION 
  src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 


Diff: https://reviews.apache.org/r/68473/diff/3/

Changes: https://reviews.apache.org/r/68473/diff/2-3/


Testing (updated)
---

[Revision 0]
`make`

[Revision 1]
Triggered Internal CI run. (Jenkins id #4162)


Thanks,

Benno Evers

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68441/#review207960
---


Fix it, then Ship it!





src/master/http.cpp
Lines 2524 (patched)


No need for this extra variable either: `IDAcceptor` takes `Option<>` as an 
argument.



src/master/http.cpp
Lines 2525 (patched)


Let's fix this inconsistency and pass `request.url.query.get("jsonp")` 
directly like you do with all other handlers.



src/master/http.cpp
Lines 2528 (patched)


`return std::move(OK(...));`



src/master/master.hpp
Lines 1491-1492 (original), 1496-1497 (patched)


// NOTE: Requests to this endpoint are batched.

Or maybe even better: group batched endpoints together.


- Alexander Rukletsov


On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68441/
> ---
> 
> (Updated Aug. 22, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '/slaves' to the set of batched master endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68441/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68440/#review207954
---


Fix it, then Ship it!




Looks good to me (modulo testing).


src/master/http.cpp
Line 4171 (original), 4149 (patched)


`return std::move(OK(...));`



src/master/master.hpp
Lines 1508-1509 (original), 1513-1514 (patched)


// NOTE: Requests to this endpoint are batched.


- Alexander Rukletsov


On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68440/
> ---
> 
> (Updated Aug. 22, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '/tasks' to the set of batched master endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68440/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68321/#review207956
---


Fix it, then Ship it!




Looks good to me (modulo testing).


src/master/http.cpp
Line 3476 (original), 3487 (patched)


`return std::move(OK(...));`


- Alexander Rukletsov


On Aug. 21, 2018, 2:09 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68321/
> ---
> 
> (Updated Aug. 21, 2018, 2:09 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9158
> https://issues.apache.org/jira/browse/MESOS-9158
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '/state-summary' to the set of batched master endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68321/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68442/#review207961
---


Fix it, then Ship it!





src/master/http.cpp
Line 1690 (original), 1700 (patched)


This seems inconsistent to other handlers you've introduced: you've been 
capturing `master` there.



src/master/http.cpp
Line 1734 (original), 1744 (patched)


`std::move`



src/master/master.hpp
Lines 1420-1424 (patched)


let's keep 'em sorted



src/master/master.hpp
Line 1464 (original), 1469 (patched)


// NOTE: Requests to this endpoint are batched.

or grouping, see https://reviews.apache.org/r/68441/


- Alexander Rukletsov


On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68442/
> ---
> 
> (Updated Aug. 22, 2018, 1:16 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added '/frameworks' to the set of batched master endpoints.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/master.hpp dc0080b24f19b77a4de34ab24aece657726343b8 
> 
> 
> Diff: https://reviews.apache.org/r/68442/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68473/#review207963
---



Nice cleanup, thank! I assume there were no functional changes, just moving 
around the code.


src/common/http.hpp
Line 165 (original), 165-174 (patched)


I believe it was meant to be sorted alphabetically. Can you please restore 
that order *and* add new lines respectfully?



src/common/http.cpp
Lines 758-766 (patched)


Can you please sort the definitions to match the _updated_ order of 
declarations?



src/master/http.cpp
Line 71 (original), 71 (patched)


Can this be removed now?



src/master/http.cpp
Lines 80 (patched)


Is it necessary here?



src/master/json.hpp
Lines 17 (patched)


Why not `__MASTER_JSON_HPP__`?



src/master/json.hpp
Lines 53 (patched)


=> #include \



src/master/json.hpp
Lines 93 (patched)


=> #include \ or fwd decl



src/master/json.cpp
Lines 25 (patched)


=> #include \



src/master/json.cpp
Lines 42 (patched)


=> #include \



src/master/json.cpp
Lines 162 (patched)


=> #include \



src/master/json.cpp
Lines 240 (patched)


Remove this line



src/master/json.cpp
Lines 282 (patched)


=> #include \



src/master/readonly_handler.cpp
Lines 17-23 (patched)


#include "master/master.hpp"

#include \

#include "common/build.hpp"

#include "master/json.hpp"



src/master/readonly_handler.cpp
Lines 35 (patched)


remove this line



src/master/readonly_handler.cpp
Lines 40 (patched)


remove this line



src/master/readonly_handler.cpp
Lines 91-92 (patched)


Please have a look at what includes you need to mention in this file.


- Alexander Rukletsov


On Aug. 22, 2018, 1:32 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68473/
> ---
> 
> (Updated Aug. 22, 2018, 1:32 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the member functions of class ReadOnlyHandler into
> the new file `readonly_handler.cpp`. This follows the pattern
> established by `weights_handler.cpp` and `quota_handler.cpp`.
> 
> As part of this move, it was also necessary to move some JSON
> serialization that are used from both `master.cpp` and
> `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}`
> that can be used from both places.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
>   src/common/http.hpp 19f0da2004391af7a526026c5e293fb01c01e97c 
>   src/common/http.cpp 932111dde6e49c697bb23e322cae934effacd1b1 
>   src/master/http.cpp ae28d525e5c0fe067ae77a4c71e8f18f772ff1dc 
>   src/master/json.hpp PRE-CREATION 
>   src/master/json.cpp PRE-CREATION 
>   src/master/readonly_handler.cpp PRE-CREATION 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68473/diff/2/
> 
> 
> Testing
> ---
> 
> `make`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 68472: Removed `ROOT` requirement some `StorageLocalResourceProvider` tests.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68472/#review207958
---



Patch looks great!

Reviews applied: [68472]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 27, 2018, 7:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68472/
> ---
> 
> (Updated Aug. 27, 2018, 7:48 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests required `ROOT` in order to use `filesystem/linux`
> isolation this is not a requirement anymore so we can run the tests in
> general. These tests appear to be able to run in parallel as well.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 65b1464733926cc0ddaa1f0d518411b70daa6a03 
> 
> 
> Diff: https://reviews.apache.org/r/68472/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `GTEST_FILTER='*StorageLocalResourceProviderTest*' 
> ../support/mesos-gtest-runner.py ./src/mesos-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 68472: Removed `ROOT` requirement some `StorageLocalResourceProvider` tests.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68472/#review207953
---



PASS: Mesos patch 68472 was successfully built and tested.

Reviews applied: `['68472']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2241/mesos-review-68472

- Mesos Reviewbot Windows


On Aug. 27, 2018, 7:48 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68472/
> ---
> 
> (Updated Aug. 27, 2018, 7:48 a.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These tests required `ROOT` in order to use `filesystem/linux`
> isolation this is not a requirement anymore so we can run the tests in
> general. These tests appear to be able to run in parallel as well.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 65b1464733926cc0ddaa1f0d518411b70daa6a03 
> 
> 
> Diff: https://reviews.apache.org/r/68472/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> `GTEST_FILTER='*StorageLocalResourceProviderTest*' 
> ../support/mesos-gtest-runner.py ./src/mesos-tests`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 68485: Fixed pylint violations in Python 2 codebase.

[Armand Grillet]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68485/
---

(Updated Aug. 27, 2018, 10:12 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
---

Fixed issue.


Bugs: MESOS-9112
https://issues.apache.org/jira/browse/MESOS-9112


Repository: mesos


Description
---

This decreases the number of errors reported by `support/mesos-style.py`
on a clean checkout. There will be 0 errors displayed once the new
CLI and the Mesos python package will be excluded from linting due
to the use of Python 3 instead of 2 in those components.


Diffs (updated)
-

  support/apply-reviews.py 4e292a91f9eb3c6d4598ba258d6aae9dcfa86fc7 
  support/generate-endpoint-help.py 37c4b58462ca42a42276ed1129190fc3359c01cf 
  support/verify-reviews.py c86db35c3231af8f1493519759a02cbaf7ef0209 


Diff: https://reviews.apache.org/r/68485/diff/2/

Changes: https://reviews.apache.org/r/68485/diff/1-2/


Testing
---

Before:
```
Checking 46 Python files
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
* Module cli.plugins.base
E:119, 0: Bad option value 'R0204' (bad-option-value)
* Module settings
E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
* Module mesos.http
E: 25, 0: Unable to import 'urlparse' (import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
* Module apply-reviews
R: 99, 0: Either all return statements in a function should return an 
expression, or none of them should. (inconsistent-return-statements)
C:124, 9: Do not use `len(SEQUENCE)` to determine if a sequence is empty 
(len-as-condition)
R:302, 4: Unnecessary "else" after "return" (no-else-return)
* Module generate-endpoint-help
R:215, 4: Unnecessary "else" after "return" (no-else-return)
* Module verify-reviews
C:261, 7: Do not use `len(SEQUENCE)` to determine if a sequence is empty 
(len-as-condition)
Total errors found: 9
```
After:
```
Checking 46 Python files
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
* Module cli.plugins.base
E:119, 0: Bad option value 'R0204' (bad-option-value)
* Module settings
E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
* Module mesos.http
E: 25, 0: Unable to import 'urlparse' (import-error)
E: 87,30: Undefined variable 'xrange' (undefined-variable)
Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
Total errors found: 4
```


Thanks,

Armand Grillet

Re: Review Request 68486: Added `cli_new` to the excluded directories for Python 2 mesos-style.py.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68486/#review207949
---


Ship it!




Ship It!

- Benjamin Bannier


On Aug. 24, 2018, 9:17 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68486/
> ---
> 
> (Updated Aug. 24, 2018, 9:17 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9112
> https://issues.apache.org/jira/browse/MESOS-9112
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This way, pylint does not report outdated errors when the old mesos-style.py 
> is run.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py a0ef221e7d884a73c551e657d538438ec98eed65 
> 
> 
> Diff: https://reviews.apache.org/r/68486/diff/1/
> 
> 
> Testing
> ---
> 
> Using mesos-style, before:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> * Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 4
> ```
> After:
> ```
> Checking 21 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 2
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 68485: Fixed pylint violations in Python 2 codebase.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68485/#review207948
---


Fix it, then Ship it!





support/apply-reviews.py
Lines 104 (patched)


I'd prefer if we'd return `None` here instead.


- Benjamin Bannier


On Aug. 24, 2018, 9:08 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68485/
> ---
> 
> (Updated Aug. 24, 2018, 9:08 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9112
> https://issues.apache.org/jira/browse/MESOS-9112
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This decreases the number of errors reported by `support/mesos-style.py`
> on a clean checkout. There will be 0 errors displayed once the new
> CLI and the Mesos python package will be excluded from linting due
> to the use of Python 3 instead of 2 in those components.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py 4e292a91f9eb3c6d4598ba258d6aae9dcfa86fc7 
>   support/generate-endpoint-help.py 37c4b58462ca42a42276ed1129190fc3359c01cf 
>   support/verify-reviews.py c86db35c3231af8f1493519759a02cbaf7ef0209 
> 
> 
> Diff: https://reviews.apache.org/r/68485/diff/1/
> 
> 
> Testing
> ---
> 
> Before:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> * Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module apply-reviews
> R: 99, 0: Either all return statements in a function should return an 
> expression, or none of them should. (inconsistent-return-statements)
> C:124, 9: Do not use `len(SEQUENCE)` to determine if a sequence is empty 
> (len-as-condition)
> R:302, 4: Unnecessary "else" after "return" (no-else-return)
> * Module generate-endpoint-help
> R:215, 4: Unnecessary "else" after "return" (no-else-return)
> * Module verify-reviews
> C:261, 7: Do not use `len(SEQUENCE)` to determine if a sequence is empty 
> (len-as-condition)
> Total errors found: 9
> ```
> After:
> ```
> Checking 46 Python files
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module cli.plugins.base
> E:119, 0: Bad option value 'R0204' (bad-option-value)
> * Module settings
> E: 32, 4: No name 'VERSION' in module 'version' (no-name-in-module)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> * Module mesos.http
> E: 25, 0: Unable to import 'urlparse' (import-error)
> E: 87,30: Undefined variable 'xrange' (undefined-variable)
> Using config file /Users/Armand/Code/apache-mesos/support/pylint.config
> Total errors found: 4
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 68472: Removed `ROOT` requirement some `StorageLocalResourceProvider` tests.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68472/
---

(Updated Aug. 27, 2018, 9:48 a.m.)


Review request for mesos and Chun-Hung Hsiao.


Changes
---

Rebased.


Repository: mesos


Description
---

These tests required `ROOT` in order to use `filesystem/linux`
isolation this is not a requirement anymore so we can run the tests in
general. These tests appear to be able to run in parallel as well.


Diffs (updated)
-

  src/tests/storage_local_resource_provider_tests.cpp 
65b1464733926cc0ddaa1f0d518411b70daa6a03 


Diff: https://reviews.apache.org/r/68472/diff/2/

Changes: https://reviews.apache.org/r/68472/diff/1-2/


Testing
---

`make check`
`GTEST_FILTER='*StorageLocalResourceProviderTest*' 
../support/mesos-gtest-runner.py ./src/mesos-tests`


Thanks,

Benjamin Bannier