Re: Review Request 47484: Added -lelf to default dynamic libraries on Linux.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47484/#review133926 --- Can someone revert this commit? This commit caused I can't find libz on both Ubuntu and CentOS. - Zhiwei Chen On May 18, 2016, 3:17 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47484/ > --- > > (Updated May 18, 2016, 3:17 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5400 > https://issues.apache.org/jira/browse/MESOS-5400 > > > Repository: mesos > > > Description > --- > > Added -lelf to default dynamic libraries on Linux. > > > Diffs > - > > configure.ac 63ea028fa89ba8e164e98226fc7ddcffd8b045c8 > > Diff: https://reviews.apache.org/r/47484/diff/ > > > Testing > --- > > > Thanks, > > Kevin Klues > >
Re: Review Request 47324: Update leveldb to 1.18.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133327 --- Ship it! I tested on ppc64le with ssl and libevent enabled, it passed. - Zhiwei Chen On May 14, 2016, 11:01 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 14, 2016, 11:01 p.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Leveldb in modern version is required to support s390x. > It's also required to replace default byte-wise comparator > with varint comparator in `src/log/leveldb.cpp`. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.patch PRE-CREATION > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 47324: Update leveldb.
> On May 13, 2016, 12:38 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47324] > > > > Failed command: ./support/apply-review.sh -n -r 47324 > > > > Error: > > 2016-05-13 04:38:10 URL:https://reviews.apache.org/r/47324/diff/raw/ > > [4739/4739] -> "47324.patch" [1] > > error: missing binary patch data for '3rdparty/leveldb-1.18.tar.gz' > > error: binary patch does not apply to '3rdparty/leveldb-1.18.tar.gz' > > error: 3rdparty/leveldb-1.18.tar.gz: patch does not apply > > > > Full log: https://builds.apache.org/job/mesos-reviewbot/13038/console The rbtools does not support binary patch, please apply this patch to your rbtools. https://reviews.reviewboard.org/r/7571/diff/1#index_header Or use git diff --binary to generate a patch file and upload it through reviewboard Web UI. I will help you test on ppc64le when you fix this. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47324/#review133030 --- On May 13, 2016, 4:46 a.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47324/ > --- > > (Updated May 13, 2016, 4:46 a.m.) > > > Review request for mesos, Bing Li, Benjamin Mahler, Zhiwei Chen, and haosdent > huang. > > > Bugs: MESOS-970 > https://issues.apache.org/jira/browse/MESOS-970 > > > Repository: mesos > > > Description > --- > > Update leveldb to 1.18. > Remove patch that is already included in latest leveldb release. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 86c51edb3aa2daf6451459aaf18278f09b91b000 > 3rdparty/leveldb-1.18.tar.gz PRE-CREATION > 3rdparty/leveldb-1.4.patch b899f0141d633b1ffb2321e573395256fc893b16 > 3rdparty/leveldb-1.4.tar.gz 2ddbc0c2e02054406ff0ea43ddc10d14979de8d8 > 3rdparty/versions.am 7dcd6bf914de3213755ec9d4e701a190750424e9 > LICENSE eb39f6d69a165f59c00e8bb0ba9e15be8c958a5b > src/python/native_common/ext_modules.py.in > 2d4a45efa224b32f80ace4542a00062c5ccb06d5 > > Diff: https://reviews.apache.org/r/47324/diff/ > > > Testing > --- > > Tested on Ubuntu amd_64 need to test on PPC > > > Thanks, > > Tomasz Janiszewski > >
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 12, 2016, 1:05 p.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5321 https://issues.apache.org/jira/browse/MESOS-5321 Repository: mesos Description --- Added Ubuntu 16.04 LTS to getting started document. Diffs (updated) - docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba Diff: https://reviews.apache.org/r/46958/diff/ Testing --- ./configure --enable-ssl --enable-libevent && make Thanks, Zhiwei Chen
Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
> On May 11, 2016, 7:12 a.m., Vinod Kone wrote: > > Can you copy the description from the ticket to the description section in > > this review? Done, thanks. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/#review132565 --- On May 5, 2016, 2:23 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46816/ > --- > > (Updated May 5, 2016, 2:23 p.m.) > > > Review request for mesos, zhou xing, Jie Yu, James Peach, Kapil Arya, and > Vinod Kone. > > > Bugs: MESOS-5326 > https://issues.apache.org/jira/browse/MESOS-5326 > > > Repository: mesos > > > Description > --- > > Fix the absolute symlink path issue of include/slave. > > > Diffs > - > > src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd > > Diff: https://reviews.apache.org/r/46816/diff/ > > > Testing > --- > > Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, > should use relative path. > > I am not sure if this copy-template-and-create-symlink should be removed of > not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily > build. > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- (Updated May 11, 2016, 9:17 a.m.) Review request for mesos, zhou xing, Jie Yu, James Peach, Kapil Arya, and Vinod Kone. Bugs: MESOS-5326 https://issues.apache.org/jira/browse/MESOS-5326 Repository: mesos Description (updated) --- The symbolic link of include/slave to include/agent uses an absolute path to $(DESTDIR)/include. But $(DESTDIR) is the tmp dir in build time, it will not exist in target machine. Diffs - src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd Diff: https://reviews.apache.org/r/46816/diff/ Testing --- Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path. I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build. Thanks, Zhiwei Chen
Review Request 47056: Remove python-boto since 'mesos-ec2' has been removed.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47056/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-5287 https://issues.apache.org/jira/browse/MESOS-5287 Repository: mesos Description --- Remove python-boto since 'mesos-ec2' has been removed. Diffs - configure.ac 0b9683be6f8d0805f2c04797e839f3578a57efbe support/docker_build.sh c5917bcce4cf1f98a1808ceabe340648edd7d2a9 Diff: https://reviews.apache.org/r/47056/diff/ Testing --- make check Thanks, Zhiwei Chen
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 6, 2016, 11:18 a.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Changes --- Remove python-boto since it is not required anymore, see: https://issues.apache.org/jira/browse/MESOS-5287 Bugs: MESOS-5321 https://issues.apache.org/jira/browse/MESOS-5321 Repository: mesos Description --- Added Ubuntu 16.04 LTS to getting started document. Diffs (updated) - docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e Diff: https://reviews.apache.org/r/46958/diff/ Testing --- ./configure --enable-ssl --enable-libevent && make Thanks, Zhiwei Chen
Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- (Updated May 5, 2016, 2:23 p.m.) Review request for mesos, zhou xing, Jie Yu, James Peach, Kapil Arya, and Vinod Kone. Bugs: MESOS-5326 https://issues.apache.org/jira/browse/MESOS-5326 Repository: mesos Description --- Fix the absolute symlink path issue of include/slave. Diffs (updated) - src/Makefile.am 710e1644e2f0a8e9b87cc997b2211291f4e055fd Diff: https://reviews.apache.org/r/46816/diff/ Testing --- Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path. I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build. Thanks, Zhiwei Chen
Re: Review Request 46872: Updated quota.md and weights.md for set quota and update weight.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46872/#review131789
---
Ship it!
Here I think it's ok in document, since -d supports raw data and a file path.
But this patch makes the doc more friendly to beginners.
- Zhiwei Chen
On May 3, 2016, 6:35 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46872/
> ---
>
> (Updated May 3, 2016, 6:35 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and haosdent huang.
>
>
> Bugs: MESOS-5313
> https://issues.apache.org/jira/browse/MESOS-5313
>
>
> Repository: mesos
>
>
> Description
> ---
>
> There should be a @ before the json file when using "curl -d".
>
>
> Diffs
> -
>
> docs/quota.md 797e134605381ae576d9aa93875e0314889ab047
> docs/weights.md 59d1579ed691524185c52ccd0bc26eadfbe167c2
>
> Diff: https://reviews.apache.org/r/46872/diff/
>
>
> Testing
> ---
>
> root@mesos002:~/test# cat quota.json
> {
> "role": "role1",
> "guarantee": [{
> "name": "cpus",
> "type": "SCALAR",
> "scalar": {
> "value": 1
> }
> }, {
> "name": "mem",
> "type": "SCALAR",
> "scalar": {
> "value": 128
> }
> }]
> }
>
> root@mesos002:~/test# curl -d @quota.json -X POST
> http://192.168.56.12:5050/quota
>
> root@mesos002:~/test# curl -X GET http://192.168.56.12:5050/quota
> 2>/dev/null|python -m json.tool
> {
> "infos": [
> {
> "guarantee": [
> {
> "name": "cpus",
> "role": "*",
> "scalar": {
> "value": 1.0
> },
> "type": "SCALAR"
> },
> {
> "name": "mem",
> "role": "*",
> "scalar": {
> "value": 128.0
> },
> "type": "SCALAR"
> }
> ],
> "role": "role1"
> }
> ]
> }
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 45995: Fixed memory leak of `Route` in `finalize()` in libprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45995/#review131788 --- Ship it! Ship It! - Zhiwei Chen On May 3, 2016, 5:40 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45995/ > --- > > (Updated May 3, 2016, 5:40 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-5144 > https://issues.apache.org/jira/browse/MESOS-5144 > > > Repository: mesos > > > Description > --- > > Fixed memory leak of `Route` in `finalize()` in libprocess. > > > Diffs > - > > 3rdparty/libprocess/src/process.cpp > dcaa64633d1eea330649c563635642928164d73c > > Diff: https://reviews.apache.org/r/45995/diff/ > > > Testing > --- > > make check > > > Thanks, > > Neil Conway > >
Review Request 47003: Fixed table accessibility.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47003/ --- Review request for mesos. Bugs: MESOS-5201 https://issues.apache.org/jira/browse/MESOS-5201 Repository: mesos Description --- Fixed table accessibility. Diffs - src/webui/master/static/home.html 4b201d72f9dfd787133008b8105a225ffb2747aa Diff: https://reviews.apache.org/r/47003/diff/ Testing --- Thanks, Zhiwei Chen
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
> On May 4, 2016, 4:57 p.m., Neil Conway wrote: > > docs/getting-started.md, line 47 > > <https://reviews.apache.org/r/46958/diff/2/?file=1370620#file1370620line47> > > > > This should end in a period. Also, I'd say "(Only necessary if SSL and > > libevent are enabled)." Thank you very much, I missed this. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131642 --- On May 4, 2016, 5:03 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46958/ > --- > > (Updated May 4, 2016, 5:03 p.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5321 > https://issues.apache.org/jira/browse/MESOS-5321 > > > Repository: mesos > > > Description > --- > > Added Ubuntu 16.04 LTS to getting started document. > > > Diffs > - > > docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e > > Diff: https://reviews.apache.org/r/46958/diff/ > > > Testing > --- > > ./configure --enable-ssl --enable-libevent && make > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 4, 2016, 5:03 p.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5321 https://issues.apache.org/jira/browse/MESOS-5321 Repository: mesos Description --- Added Ubuntu 16.04 LTS to getting started document. Diffs (updated) - docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e Diff: https://reviews.apache.org/r/46958/diff/ Testing --- ./configure --enable-ssl --enable-libevent && make Thanks, Zhiwei Chen
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- (Updated May 4, 2016, 4:31 p.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5321 https://issues.apache.org/jira/browse/MESOS-5321 Repository: mesos Description --- Added Ubuntu 16.04 LTS to getting started document. Diffs (updated) - docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e Diff: https://reviews.apache.org/r/46958/diff/ Testing --- ./configure --enable-ssl --enable-libevent && make Thanks, Zhiwei Chen
Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
> On May 4, 2016, 3:48 p.m., Neil Conway wrote: > > docs/getting-started.md, line 64 > > <https://reviews.apache.org/r/46958/diff/1/?file=1370478#file1370478line64> > > > > Is automake also required for 14.04? my falt, it will be automatically installed. Will remove it in next patch. > On May 4, 2016, 3:48 p.m., Neil Conway wrote: > > docs/getting-started.md, line 66 > > <https://reviews.apache.org/r/46958/diff/1/?file=1370478#file1370478line66> > > > > Can we synchronize this with the instructions for Ubuntu 14.04? i.e., > > either mention installing the SSL dependencies for both versions or neither. OK, I will also update the Ubuntu 14.04 section. > On May 4, 2016, 3:48 p.m., Neil Conway wrote: > > docs/getting-started.md, line 70 > > <https://reviews.apache.org/r/46958/diff/1/?file=1370478#file1370478line70> > > > > Is zlib1g-dev also required for 14.04? Yes, it is required for 14.04, but it will be automatically installed when install libcurl4-nss-dev. In Ubuntu 16.04, it will no be installed when install libcurl4-nss-dev. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/#review131637 --- On May 4, 2016, 10:50 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46958/ > --- > > (Updated May 4, 2016, 10:50 a.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5321 > https://issues.apache.org/jira/browse/MESOS-5321 > > > Repository: mesos > > > Description > --- > > Added Ubuntu 16.04 LTS to getting started document. > > > Diffs > - > > docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e > > Diff: https://reviews.apache.org/r/46958/diff/ > > > Testing > --- > > ./configure --enable-ssl --enable-libevent && make > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46730: Cleanup syscalls logic.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46730/#review131612 --- Ship it! Ship It! - Zhiwei Chen On April 29, 2016, 9:03 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46730/ > --- > > (Updated April 29, 2016, 9:03 p.m.) > > > Review request for mesos, Ben Mahler, Zhiwei Chen, and haosdent huang. > > > Bugs: MESOS-5263 > https://issues.apache.org/jira/browse/MESOS-5263 > > > Repository: mesos > > > Description > --- > > Used `` and removed uncessary condition complie. > > > Diffs > - > > src/linux/fs.cpp 81f040e5c7ed7cbca569f5d43cb5afc5da1b5e64 > > Diff: https://reviews.apache.org/r/46730/diff/ > > > Testing > --- > > > Thanks, > > Tomasz Janiszewski > >
Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46958/ --- Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5321 https://issues.apache.org/jira/browse/MESOS-5321 Repository: mesos Description --- Added Ubuntu 16.04 LTS to getting started document. Diffs - docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e Diff: https://reviews.apache.org/r/46958/diff/ Testing --- ./configure --enable-ssl --enable-libevent && make Thanks, Zhiwei Chen
Re: Review Request 46816: Fix the absolute symlink path issue of include/slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- (Updated May 4, 2016, 10:42 a.m.) Review request for mesos, zhou xing, James Peach, Kapil Arya, and Vinod Kone. Bugs: MESOS-5326 https://issues.apache.org/jira/browse/MESOS-5326 Repository: mesos Description --- Fix the absolute symlink path issue of include/slave. Diffs - src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 Diff: https://reviews.apache.org/r/46816/diff/ Testing --- Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path. I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build. Thanks, Zhiwei Chen
Re: Review Request 46813: Update distribute to setuptools.
> On April 30, 2016, 12:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > <https://reviews.apache.org/r/46813/diff/2/?file=1365654#file1365654line25> > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any reasons to use > > 20.9.0? > > Zhiwei Chen wrote: > oh, it's latest version is 20.9.0 when I first testing this patch. I will > try to upgrade to the latest one. I found setuptools now upgrade to 21.0.0, it's version grows too fast[1] and there seems no significant changes[2], so I decided not to catch up the latest version. [1]: https://github.com/pypa/setuptools/releases [2]: https://pythonhosted.org/setuptools/history.html - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131118 ------- On April 29, 2016, 5:13 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46813/ > --- > > (Updated April 29, 2016, 5:13 p.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5244 > https://issues.apache.org/jira/browse/MESOS-5244 > > > Repository: mesos > > > Description > --- > > Update distribute to setuptools. > > > Diffs > - > > 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 > 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 > 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION > 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 > LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d > configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 > mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee > src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 > src/examples/python/test-containerizer.in > b8258e75a3cd5f8d18ab8eff8196c5374db4f629 > src/examples/python/test-executor.in > 6be0ad2d339ff43d074e9688978af1ddf956803c > src/examples/python/test-framework.in > 59bab82962c5846c6be288f3d392986e146e9da6 > support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 > > Diff: https://reviews.apache.org/r/46813/diff/ > > > Testing > --- > > make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5. > > NOTE: I tested on my RHEL 6.6 and failed, because the package > pytz-2010h-2.el6.noarch was installed, when I removed this package verything > ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think > it's ok for this patch. > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46813: Update distribute to setuptools.
> On April 30, 2016, 12:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > <https://reviews.apache.org/r/46813/diff/2/?file=1365654#file1365654line25> > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any reasons to use > > 20.9.0? oh, it's latest version is 20.9.0 when I first testing this patch. I will try to upgrade to the latest one. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131118 ------- On April 29, 2016, 5:13 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46813/ > --- > > (Updated April 29, 2016, 5:13 p.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5244 > https://issues.apache.org/jira/browse/MESOS-5244 > > > Repository: mesos > > > Description > --- > > Update distribute to setuptools. > > > Diffs > - > > 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 > 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 > 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION > 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 > LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d > configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 > mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee > src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 > src/examples/python/test-containerizer.in > b8258e75a3cd5f8d18ab8eff8196c5374db4f629 > src/examples/python/test-executor.in > 6be0ad2d339ff43d074e9688978af1ddf956803c > src/examples/python/test-framework.in > 59bab82962c5846c6be288f3d392986e146e9da6 > support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 > > Diff: https://reviews.apache.org/r/46813/diff/ > > > Testing > --- > > make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5. > > NOTE: I tested on my RHEL 6.6 and failed, because the package > pytz-2010h-2.el6.noarch was installed, when I removed this package verything > ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think > it's ok for this patch. > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46813: Update distribute to setuptools.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- (Updated April 29, 2016, 5:13 p.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5244 https://issues.apache.org/jira/browse/MESOS-5244 Repository: mesos Description --- Update distribute to setuptools. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 src/examples/python/test-containerizer.in b8258e75a3cd5f8d18ab8eff8196c5374db4f629 src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c src/examples/python/test-framework.in 59bab82962c5846c6be288f3d392986e146e9da6 support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 Diff: https://reviews.apache.org/r/46813/diff/ Testing (updated) --- make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 and OS X 10.10.5. NOTE: I tested on my RHEL 6.6 and failed, because the package pytz-2010h-2.el6.noarch was installed, when I removed this package verything ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think it's ok for this patch. Thanks, Zhiwei Chen
Re: Review Request 46813: Update distribute to setuptools.
> On April 29, 2016, 2:08 p.m., haosdent huang wrote: > > I saw we order the dependencies by alphabetically, may you update it to > > make sure this? Thanks, fixed. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/#review131053 --- On April 29, 2016, 4:36 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46813/ > --- > > (Updated April 29, 2016, 4:36 p.m.) > > > Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5244 > https://issues.apache.org/jira/browse/MESOS-5244 > > > Repository: mesos > > > Description > --- > > Update distribute to setuptools. > > > Diffs > - > > 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 > 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 > 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION > 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 > LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d > configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 > mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee > src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 > src/examples/python/test-containerizer.in > b8258e75a3cd5f8d18ab8eff8196c5374db4f629 > src/examples/python/test-executor.in > 6be0ad2d339ff43d074e9688978af1ddf956803c > src/examples/python/test-framework.in > 59bab82962c5846c6be288f3d392986e146e9da6 > support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 > > Diff: https://reviews.apache.org/r/46813/diff/ > > > Testing > --- > > make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 > > NOTE: I tested on my RHEL 6.6 and failed, because the package > pytz-2010h-2.el6.noarch was installed, when I removed this package verything > ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think > it's ok for this patch. > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 46813: Update distribute to setuptools.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- (Updated April 29, 2016, 5:05 p.m.) Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu. Bugs: MESOS-5244 https://issues.apache.org/jira/browse/MESOS-5244 Repository: mesos Description --- Update distribute to setuptools. Diffs (updated) - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 src/examples/python/test-containerizer.in b8258e75a3cd5f8d18ab8eff8196c5374db4f629 src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c src/examples/python/test-framework.in 59bab82962c5846c6be288f3d392986e146e9da6 support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 Diff: https://reviews.apache.org/r/46813/diff/ Testing --- make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 NOTE: I tested on my RHEL 6.6 and failed, because the package pytz-2010h-2.el6.noarch was installed, when I removed this package verything ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think it's ok for this patch. Thanks, Zhiwei Chen
Review Request 46816: Fix the absolute symlink path issue of include/slave.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46816/ --- Review request for mesos, zhou xing and Vinod Kone. Repository: mesos Description --- Fix the absolute symlink path issue of include/slave. Diffs - src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 Diff: https://reviews.apache.org/r/46816/diff/ Testing --- Fixes the slave linked to $RPM_BUILD_ROOT/$PREFIX/include/mesos/agent issue, should use relative path. I am not sure if this copy-template-and-create-symlink should be removed of not, since MESOS-3782 & MESOS-5230 already completed. This blocked our daily build. Thanks, Zhiwei Chen
Review Request 46813: Update distribute to setuptools.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46813/ --- Review request for mesos, haosdent huang and Joseph Wu. Bugs: MESOS-5244 https://issues.apache.org/jira/browse/MESOS-5244 Repository: mesos Description --- Update distribute to setuptools. Diffs - 3rdparty/Makefile.am 0523151d924a1398334767bd401ae84e41bdceb7 3rdparty/distribute-0.6.26.tar.gz 3a598ccd4bfdfdf250a6d7a28552677394f14a76 3rdparty/setuptools-20.9.0.tar.gz PRE-CREATION 3rdparty/versions.am a94723e213dbbbd1df7e1b784386023412f7b961 LICENSE 19130d977986dc9e23872817251ffcaa5a3c2c7d configure.ac ae91a07e2bafd97566ac6e6873990302acad14c9 mpi/mpiexec-mesos.in 021dd5b6b9c1c601b81d5bf49fda1bd23c2040ee src/Makefile.am 53de98f43629dc94f7619324369caf88407b2f41 src/examples/python/test-containerizer.in b8258e75a3cd5f8d18ab8eff8196c5374db4f629 src/examples/python/test-executor.in 6be0ad2d339ff43d074e9688978af1ddf956803c src/examples/python/test-framework.in 59bab82962c5846c6be288f3d392986e146e9da6 support/coverage.sh 7edfec27d29fa900d35894c7778fcb7cfde513b8 Diff: https://reviews.apache.org/r/46813/diff/ Testing --- make && make install on Ubuntu 14.04/16.04, RHEL 6.6/7.1 NOTE: I tested on my RHEL 6.6 and failed, because the package pytz-2010h-2.el6.noarch was installed, when I removed this package verything ok. The default RHEL/CentOS 6.6 has no pytz-2010h-2.el6.noarch, so I think it's ok for this patch. Thanks, Zhiwei Chen
Re: Review Request 46102: Fixed logic error in execute.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46102/#review128599 --- Ship it! Ship It! - Zhiwei Chen On April 13, 2016, 7:34 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46102/ > --- > > (Updated April 13, 2016, 7:34 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-5199 > https://issues.apache.org/jira/browse/MESOS-5199 > > > Repository: mesos > > > Description > --- > > Fixed logic error in execute.cpp. > > > Diffs > - > > src/cli/execute.cpp 306779f5227248a9f1d67b6c50854ec47dd59cd5 > > Diff: https://reviews.apache.org/r/46102/diff/ > > > Testing > --- > > root@mesos002:~/src/mesos/m2/mesos/build# src/mesos-execute > --master=192.168.56.12:5050 --name=test --docker_image=ubuntu:14.04 > --command="ls /root" > I0413 07:28:03.833521 2295 scheduler.cpp:175] Version: 0.29.0 > Subscribed with ID '3a1af11e-cf66-4ce2-826d-48b332977999-0001' > Submitted task 'test' to agent '3a1af11e-cf66-4ce2-826d-48b332977999-S0' > Received status update TASK_RUNNING for task 'test' > source: SOURCE_EXECUTOR > Received status update TASK_FINISHED for task 'test' > message: 'Command exited with status 0' > source: SOURCE_EXECUTOR > > > Thanks, > > Guangya Liu > >
Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.
> On April 9, 2016, 1:59 a.m., Vinod Kone wrote:
> > I think to test this you need to revert the changes made to SSL tests?
> >
> > Also for CMake, you can add the -D flag by adding a "add_definitions(-D
> > HTTP_PARSER_STRICT=0)" to
> > 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template.
> > @AlexClemner is this the right way to add -D flag to http parser
> > compilation?
> >
> > Additionaly, while looking through the CMAKE files I realized that there
> > are still references to the old http parser library:
> >
> > ```
> > ? mesos git:(vinod/release_support_doc) ack RY_UPDATE 3rdparty
> > 3rdparty/libprocess/3rdparty/CMakeLists.txt
> > 117:set(RY_UPDATE_CMD ${CMAKE_COMMAND} -E copy
> > ${PROCESS_3RD_SRC}/http-parser/CMakeLists.txt.template
> > ${HTTP_PARSER_ROOT}/CMakeLists.txt)
> > 174: UPDATE_COMMAND${RY_UPDATE_CMD}
> >
> >
> > ? mesos git:(vinod/release_support_doc) ack Ryan 3rdparty
> > 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template
> > 17:# Builds Ryan Dahl's http-parser project.
> >
> > 3rdparty/libprocess/3rdparty/Makefile.am
> > 86: # Convenience library for Ryan Dahl's HTTP parser.
> >
> > ```
> >
> > Can you make sure to clean these up as well?
Thanks, I updated these stuff, but do not sure it's ok for cmake, since I can't
build Mesos with cmake even on master branch.
- Zhiwei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45917/#review127819
---
On April 11, 2016, 10:49 a.m., Zhiwei Chen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45917/
> ---
>
> (Updated April 11, 2016, 10:49 a.m.)
>
>
> Review request for mesos, Greg Mann and Vinod Kone.
>
>
> Bugs: MESOS-5063
> https://issues.apache.org/jira/browse/MESOS-5063
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Disable http-parser strict mode to allow flexible http header fields.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/3rdparty/CMakeLists.txt
> 21fc067c0da03c60471953342d863c9ecd6e72c7
> 3rdparty/libprocess/3rdparty/Makefile.am
> 217283cd3ce6df699b63dc5b8fb3aab0c6debd04
> 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template
> 056a1c1e9b3e31f2958be7779e87294cc5b43710
> 3rdparty/libprocess/src/decoder.hpp
> 51ef6bcf264de3af8b80003d249d55bdc6953b98
> 3rdparty/libprocess/src/tests/ssl_tests.cpp
> aa6021cadd4a1934afaf7f258ab8bcb83cafd6cb
>
> Diff: https://reviews.apache.org/r/45917/diff/
>
>
> Testing
> ---
>
> ./configure --enable-ssl --enable-libevent
> make distcheck
>
>
> Thanks,
>
> Zhiwei Chen
>
>
Re: Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45917/ --- (Updated April 11, 2016, 10:49 a.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5063 https://issues.apache.org/jira/browse/MESOS-5063 Repository: mesos Description --- Disable http-parser strict mode to allow flexible http header fields. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 21fc067c0da03c60471953342d863c9ecd6e72c7 3rdparty/libprocess/3rdparty/Makefile.am 217283cd3ce6df699b63dc5b8fb3aab0c6debd04 3rdparty/libprocess/3rdparty/http-parser/CMakeLists.txt.template 056a1c1e9b3e31f2958be7779e87294cc5b43710 3rdparty/libprocess/src/decoder.hpp 51ef6bcf264de3af8b80003d249d55bdc6953b98 3rdparty/libprocess/src/tests/ssl_tests.cpp aa6021cadd4a1934afaf7f258ab8bcb83cafd6cb Diff: https://reviews.apache.org/r/45917/diff/ Testing --- ./configure --enable-ssl --enable-libevent make distcheck Thanks, Zhiwei Chen
Review Request 45917: Disable http-parser strict mode to allow flexible http header fields.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45917/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5063 https://issues.apache.org/jira/browse/MESOS-5063 Repository: mesos Description --- Disable http-parser strict mode to allow flexible http header fields. Diffs - 3rdparty/libprocess/3rdparty/Makefile.am 217283cd3ce6df699b63dc5b8fb3aab0c6debd04 Diff: https://reviews.apache.org/r/45917/diff/ Testing --- ./configure --enable-ssl --enable-libevent make distcheck Thanks, Zhiwei Chen
Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.
> On April 8, 2016, 6 a.m., Vinod Kone wrote: > > support/docker_build.sh, line 84 > > <https://reviews.apache.org/r/45803/diff/1/?file=1327362#file1327362line84> > > > > gcc is installed by `build-essential`. don't you want to install clang > > like we did above? clang does not exist on ubuntu ppc64le, but the clang-3.5 and clang 3.6 exists. I tested with v3.5 and v3.6, both of them can't work on Power, so I disabled clang on Power. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/#review127676 --- On April 6, 2016, 5:25 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45803/ > --- > > (Updated April 6, 2016, 5:25 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-4897 > https://issues.apache.org/jira/browse/MESOS-4897 > > > Repository: mesos > > > Description > --- > > Add PowerPC LE CI for support/docker_build.sh. > > > Diffs > - > > support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d > > Diff: https://reviews.apache.org/r/45803/diff/ > > > Testing > --- > > On a PowerPC machine, run following command: > > ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' > OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/ --- (Updated April 8, 2016, 5:21 p.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-4897 https://issues.apache.org/jira/browse/MESOS-4897 Repository: mesos Description --- Add PowerPC LE CI for support/docker_build.sh. Diffs (updated) - support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d Diff: https://reviews.apache.org/r/45803/diff/ Testing --- On a PowerPC machine, run following command: ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh Thanks, Zhiwei Chen
Review Request 45803: Add PowerPC LE CI for support/docker_build.sh.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45803/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4897 https://issues.apache.org/jira/browse/MESOS-4897 Repository: mesos Description --- Add PowerPC LE CI for support/docker_build.sh. Diffs - support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d Diff: https://reviews.apache.org/r/45803/diff/ Testing --- On a PowerPC machine, run following command: ENVIRONMENT='GLOG_v=0' CONFIGURATION='--enable-libevent --enable-ssl' OS='ppc64le/ubuntu:14.04' COMPILER=gcc ./support/docker_build.sh Thanks, Zhiwei Chen
Re: Review Request 42551: Porting mesos on ppc64le.
> On March 24, 2016, 10:14 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [42551] > > > > Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' > > COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; > > ./support/docker_build.sh This seems not the right way to solve the powerpc make issue, please check https://issues.apache.org/jira/browse/MESOS-5121 - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42551/#review125251 --- On March 24, 2016, 1:10 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42551/ > --- > > (Updated March 24, 2016, 1:10 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-4312 > https://issues.apache.org/jira/browse/MESOS-4312 > > > Repository: mesos > > > Description > --- > > Porting mesos on ppc64le. > > > Diffs > - > > src/linux/fs.cpp 0df194207a66bf4c417349bebcc8912acbf5976e > > Diff: https://reviews.apache.org/r/42551/diff/ > > > Testing > --- > > make check (OSX 10.10.5, Ubuntu 14.04.3 LTS ppc64le) > > > Thanks, > > Qian Zhang > >
Review Request 45734: Fix 'pivot_root is not available' error on powerpc platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45734/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5121 https://issues.apache.org/jira/browse/MESOS-5121 Repository: mesos Description --- Fix 'pivot_root is not available' error on powerpc platform. Diffs - src/linux/fs.cpp 306beab4c294e6a83e469279f38a8423dabd3f19 Diff: https://reviews.apache.org/r/45734/diff/ Testing --- ../configure --enable-libevent --enable-ssl make -j60 make dist check -j60 Thanks, Zhiwei Chen
Re: Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated April 4, 2016, 7:40 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Summary (updated) - Upgrade http-parser to v2.6.2 [mesos]. Bugs: MESOS-5069 https://issues.apache.org/jira/browse/MESOS-5069 Repository: mesos Description --- Upgrade http-parser to v2.6.2 [mesos]. Diffs (updated) - 3rdparty/cmake/Versions.cmake 35d7e98e9de7dcebbba3b7cdf4d139c918b6f6de LICENSE 1c0355c1462654e1c30546b448f503cd6365dc46 Diff: https://reviews.apache.org/r/45528/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:33 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5069 https://issues.apache.org/jira/browse/MESOS-5069 Repository: mesos Description --- Upgrade http-parser to v2.6.2 [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch 2877597 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 06528d5a456d6aa8dcee18159392d2ed4e5f3866 3rdparty/libprocess/3rdparty/http-parser-2.6.2.patch PRE-CREATION 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 2616b2d Diff: https://reviews.apache.org/r/45527/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated April 4, 2016, 7:26 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5069 https://issues.apache.org/jira/browse/MESOS-5069 Repository: mesos Description --- Upgrade http-parser to v2.6.2 [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 06528d5a456d6aa8dcee18159392d2ed4e5f3866 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 2616b2d3fbecc0f9f5ef8eea20a61c927da70814 Diff: https://reviews.apache.org/r/45527/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.
> On April 1, 2016, 1:38 a.m., Vinod Kone wrote: > > 3rdparty/zookeeper-3.4.8.patch, line 13 > > <https://reviews.apache.org/r/45376/diff/1/?file=1315991#file1315991line13> > > > > Can you explain in the description what this patch is doing? It's not > > obvious. > > > > How does this affect non-PPC platforms? This patch was carried from upstream zookeeper repo and it will be in zookeeper 3.5.0, so I think it will affect non-PPC platforms. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/#review126364 --- On April 1, 2016, 5:49 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45376/ > --- > > (Updated April 1, 2016, 5:49 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4312 > https://issues.apache.org/jira/browse/MESOS-4312 > > > Repository: mesos > > > Description > --- > > I carried this patch from upstream zookeeper, since the > fetch_and_add function in zookeeper is not 64bit-compatible. > Details see: https://issues.apache.org/jira/browse/ZOOKEEPER-1643 > > > Diffs > - > > 3rdparty/zookeeper-3.4.8.patch PRE-CREATION > > Diff: https://reviews.apache.org/r/45376/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated April 1, 2016, 5:32 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt c3dcbb59816c0ff6d929ef0aad9a136d38cf84cb 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 7f5a61867e341e4ed67ff9f9127e5739b5a48b1d Diff: https://reviews.apache.org/r/44378/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated April 1, 2016, 5:32 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [mesos]. Diffs (updated) - 3rdparty/cmake/Versions.cmake b89efd519eddfc96ce8fffb414d267a9770dda09 LICENSE bbea085cfce1b9b3cbe002630955207f1c9ec60f src/python/native_common/ext_modules.py.in 1c2fc49d0608570fa105628f28b9cc0b435e7e57 Diff: https://reviews.apache.org/r/45371/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 31, 2016, 5:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- set "depends on" field -- @vinodkone Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/45371/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 31, 2016, 5:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- removed the incorrect "depends on" field. this should block the mesos review r/45371 instead. -- @vinodkone Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 04a4cf4241b8188c093f4942d27b050fa7b20397 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/44378/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].
> On March 31, 2016, 6:02 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [45528, 45527] > > > > Failed command: ./support/apply-review.sh -n -r 45527 > > > > Error: > > 2016-03-31 10:02:51 URL:https://reviews.apache.org/r/45527/diff/raw/ > > [125760/125760] -> "45527.patch" [1] > > error: unrecognized binary patch at line 942 > > error: removal patch leaves file contents > > error: 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz: patch does > > not apply > > > > Full log: https://builds.apache.org/job/mesos-reviewbot/12237/console Does anyone know this issue? I submitted twice, both of them failed with this error when I apply the patch. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/#review126288 --- On March 31, 2016, 5:48 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45528/ > --- > > (Updated March 31, 2016, 5:48 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5069 > https://issues.apache.org/jira/browse/MESOS-5069 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to v2.6.2 [mesos]. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 > LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa > > Diff: https://reviews.apache.org/r/45528/diff/ > > > Testing > --- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated March 31, 2016, 5:48 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5069 https://issues.apache.org/jira/browse/MESOS-5069 Repository: mesos Description --- Upgrade http-parser to v2.6.2 [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa Diff: https://reviews.apache.org/r/45528/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated March 31, 2016, 5:48 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5069 https://issues.apache.org/jira/browse/MESOS-5069 Repository: mesos Description --- Upgrade http-parser to v2.6.2 [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 06528d5a456d6aa8dcee18159392d2ed4e5f3866 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/45527/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45528: [WIP] Upgrade http-parser to v2.6.2 [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- (Updated March 31, 2016, 5:47 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Summary (updated) - [WIP] Upgrade http-parser to v2.6.2 [mesos]. Repository: mesos Description --- Upgrade http-parser to v2.6.2 [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa Diff: https://reviews.apache.org/r/45528/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- (Updated March 31, 2016, 5:43 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Description --- Upgrade http-parser to v2.6.2 [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 06528d5a456d6aa8dcee18159392d2ed4e5f3866 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/45527/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Review Request 45527: Upgrade http-parser to v2.6.2 [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45527/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Description --- Upgrade http-parser to v2.6.2 [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/http-parser-2.6.1.patch 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz 06528d5a456d6aa8dcee18159392d2ed4e5f3866 3rdparty/libprocess/3rdparty/http-parser-2.6.2.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/45527/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Review Request 45528: Upgrade http-parser to v2.6.2 [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45528/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos Description --- Upgrade http-parser to v2.6.2 [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa Diff: https://reviews.apache.org/r/45528/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
> On March 31, 2016, 2:10 a.m., Greg Mann wrote: > > This could break existing clients which include extra whitespace, though it > > does seem that RFC-7230 specifically prohibits whitespace in that location. > > I wonder if a deprecation cycle is advisable for this change? > > > > Also, it's not immediately clear to me: are we using http-parser in > > "strict" mode? > > Vinod Kone wrote: > Good point. Though I would be surprised if typical clients use colons > after header names. IIIUC (zhiwei can correct me if i'm wrong) 2.6.1 > disallowed spaces before colon irrespective of strict mode (which was a bug). > I think they fixed the behavior in 2.6.2 so that it rejects spaces iff the > mode is strict. If that's the case, we should probably just upgrade to 2.6.2 > instead of 2.6.1? Yes, I think I need to create another ticket to upgrade to 2.6.2. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/#review126160 ------- On March 30, 2016, 1:35 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45471/ > --- > > (Updated March 30, 2016, 1:35 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5063 > https://issues.apache.org/jira/browse/MESOS-5063 > > > Repository: mesos > > > Description > --- > > Fix a test case bug due to upgrade http-parser to 2.6.1. > > > Diffs > - > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f > > Diff: https://reviews.apache.org/r/45471/diff/ > > > Testing > --- > > ../configure --enable-libevent --enable-ssl > > sudo make dist check > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:35 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5063 https://issues.apache.org/jira/browse/MESOS-5063 Repository: mesos Description --- Fix a test case bug due to upgrade http-parser to 2.6.1. Diffs - 3rdparty/libprocess/src/tests/ssl_tests.cpp 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f Diff: https://reviews.apache.org/r/45471/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- (Updated March 30, 2016, 1:33 p.m.) Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description --- Fix a test case bug due to upgrade http-parser to 2.6.1. Diffs (updated) - 3rdparty/libprocess/src/tests/ssl_tests.cpp 53a0ed03226030104af43a45c6ccfbfc0f4b7e9f Diff: https://reviews.apache.org/r/45471/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Review Request 45471: Fix a test case bug due to upgrade http-parser to 2.6.1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45471/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description --- Fix a test case bug due to upgrade http-parser to 2.6.1. Diffs - 3rdparty/libprocess/src/tests/ssl_tests.cpp 4d237815a03828b915e821c3af78132e2915c610 Diff: https://reviews.apache.org/r/45471/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check Thanks, Zhiwei Chen
Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 29, 2016, 6:47 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/45368/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 29, 2016, 6:34 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 04a4cf4241b8188c093f4942d27b050fa7b20397 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 462a867f4c4e8fce0b62f95bac05ae069281393f Diff: https://reviews.apache.org/r/44378/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 29, 2016, 6:28 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [mesos]. Diffs (updated) - 3rdparty/cmake/Versions.cmake 6530fccc43a11bfb423a2e2e39c954d114c5d902 LICENSE 4cc7f5b321a468bdbdac189b4cf8dc065735ebaa src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/45371/diff/ Testing --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/45368/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, James Peach, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/45367/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 29, 2016, 3:14 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout]. Diffs - 3rdparty/libprocess/3rdparty/stout/README.md c534835db7baca1138791f2c700e95ff73052d85 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc fb11b1147b3a1872f60e90d0691723f9b2985427 Diff: https://reviews.apache.org/r/44257/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- (Updated March 29, 2016, 10 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/45371/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 29, 2016, 10 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/44378/diff/ Testing (updated) --- ../configure --enable-libevent --enable-ssl sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- (Updated March 28, 2016, 6:55 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- Fixed "bugs" and "depends on" fields -- @vinodkone Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/45367/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- (Updated March 28, 2016, 6:54 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- Fixed "bugs" and "depends on" fields -- @vinodkone Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/45368/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45369/ --- (Updated March 28, 2016, 6:36 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Changes --- Fixing the "bugs" and "depends on" fields -- @vinodkone @Zhiwei please make sure you link related reviews by setting "depends on" field. That way ReviewBot can test the whole chain. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description --- Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 Diff: https://reviews.apache.org/r/45369/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Review Request 45376: Add zookeeper patch for 3.4.8 to support PPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45376/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Add zookeeper patch for 3.4.8 to support PPC LE platform. Diffs - 3rdparty/zookeeper-3.4.8.patch PRE-CREATION Diff: https://reviews.apache.org/r/45376/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 28, 2016, 10:21 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Summary (updated) - Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description (updated) --- Upgrade libev to 4.22 to support PowerPC LE platform [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/44378/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Review Request 45371: Upgrade libev to 4.22 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45371/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/45371/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 28, 2016, 10:09 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Summary (updated) - Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess]. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description (updated) --- Upgrade http-parser to 2.6.1 to support PPC LE platform [libprocess]. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/Makefile.am ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch f9fac12437a6bedc66353fda1ce9c0d7a383225a 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz b811b63ce0ad6d71d9d296fed76656c023c76fc5 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd Diff: https://reviews.apache.org/r/44372/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Review Request 45369: Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45369/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade http-parser to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 Diff: https://reviews.apache.org/r/45369/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Review Request 45367: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45367/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [mesos]. Diffs - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/45367/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Review Request 45368: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45368/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [libprocess]. Diffs - 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/45368/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout].
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 28, 2016, 9:53 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Summary (updated) - Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout]. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description (updated) --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform [stout]. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/README.md c534835db7baca1138791f2c700e95ff73052d85 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc fb11b1147b3a1872f60e90d0691723f9b2985427 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf Diff: https://reviews.apache.org/r/44257/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
> On March 26, 2016, 5:04 a.m., Vinod Kone wrote: > > Can you split this review into 2 reviews > > > > 1) Changes needed just for protobuf upgrade to 2.6.1 > > 2) Changes needed to make it compile for PPC Thanks, actually there is no specific changes for PPC, I just separated this patch for three: mesos, libprocess and stout. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review125471 --- On March 24, 2016, 9:28 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44257/ > --- > > (Updated March 24, 2016, 9:28 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4678 > https://issues.apache.org/jira/browse/MESOS-4678 > > > Repository: mesos > > > Description > --- > > Upgrade protobuf to 2.6.1 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz > e600ac57be4c88efb5f146e4b3ec226d8f685033 > 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/README.md > c534835db7baca1138791f2c700e95ff73052d85 > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h > 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc > fb11b1147b3a1872f60e90d0691723f9b2985427 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 > src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af > src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b > > Diff: https://reviews.apache.org/r/44257/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 24, 2016, 4:58 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Summary (updated) - Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. Bugs: MESOS-4612 https://issues.apache.org/jira/browse/MESOS-4612 Repository: mesos Description (updated) --- Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. Diffs (updated) - 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 3rdparty/zookeeper-3.4.8.patch PRE-CREATION src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 Diff: https://reviews.apache.org/r/44376/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 24, 2016, 10:02 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/44378/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 24, 2016, 9:28 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/stout/README.md c534835db7baca1138791f2c700e95ff73052d85 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc fb11b1147b3a1872f60e90d0691723f9b2985427 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/44257/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > new file mode 100644 > > index > > ..06528d5a456d6aa8dcee18159392d2ed4e5f3866 > > Binary files /dev/null and > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ > > ``` > > Zhiwei Chen wrote: > Yes, I told Vinod in another patch, I think he can solve this issue. > Thanks. > > Vinod Kone wrote: > Looks like you haven't uploaded the tar.gz files? Can you upload them > manually to reviewboard if support/post-reviews.py or rbt doesn't support > binary file uploads? > > haosdent huang wrote: > Hi, @vinodkone As I metioned to zhiwei before, he need apply this patch > to his rbtools if he want upload the binary files. > https://reviews.apache.org/r/40053/diff/3/ is a example that could upload > binary file sucessfully. :-) > > Zhiwei Chen wrote: > Thanks, I thought the Mesos committer may have a better solution for this. > > Joseph Wu wrote: > You can also just generate the diff via: > ``` > git diff --binary > ``` > and upload that diff via the web UI. Thanks Joseph, this is very helpful. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 --- On March 24, 2016, 9:13 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 24, 2016, 9:13 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 6b07aefc58a1daa235b35e83832e47d1878e2e94 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > new file mode 100644 > > index > > ..06528d5a456d6aa8dcee18159392d2ed4e5f3866 > > Binary files /dev/null and > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ > > ``` > > Zhiwei Chen wrote: > Yes, I told Vinod in another patch, I think he can solve this issue. > Thanks. > > Vinod Kone wrote: > Looks like you haven't uploaded the tar.gz files? Can you upload them > manually to reviewboard if support/post-reviews.py or rbt doesn't support > binary file uploads? > > haosdent huang wrote: > Hi, @vinodkone As I metioned to zhiwei before, he need apply this patch > to his rbtools if he want upload the binary files. > https://reviews.apache.org/r/40053/diff/3/ is a example that could upload > binary file sucessfully. :-) Thanks, I thought the Mesos committer may have a better solution for this. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 --- On March 24, 2016, 9:13 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 24, 2016, 9:13 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 6b07aefc58a1daa235b35e83832e47d1878e2e94 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 24, 2016, 9:13 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description --- Upgrade http-parser to 2.6.1 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/Makefile.am ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch f9fac12437a6bedc66353fda1ce9c0d7a383225a 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz b811b63ce0ad6d71d9d296fed76656c023c76fc5 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 Diff: https://reviews.apache.org/r/44372/diff/ Testing --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/ --- (Updated March 22, 2016, 4:44 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4802 https://issues.apache.org/jira/browse/MESOS-4802 Repository: mesos Description --- Update leveldb-1.4.patch to support PowerPC LE platform. Diffs (updated) - 3rdparty/leveldb-1.4.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 Diff: https://reviews.apache.org/r/44382/diff/ Testing (updated) --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- (Updated March 22, 2016, 12:13 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4678 https://issues.apache.org/jira/browse/MESOS-4678 Repository: mesos Description --- Upgrade protobuf to 2.6.1 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/protobuf-2.5.0.tar.gz e600ac57be4c88efb5f146e4b3ec226d8f685033 3rdparty/libprocess/3rdparty/protobuf-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/stout/README.md c534835db7baca1138791f2c700e95ff73052d85 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h 3d1f13082a65f9b1694ee7c65ba0cec131c18c5a 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc fb11b1147b3a1872f60e90d0691723f9b2985427 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 configure.ac 9ec4bc1cff3b0b46dd2e7ece2c1f2d19ffb8 src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af src/python/interface/setup.py.in d73996734c3a3c70c3a6c0c697bb6733c241c091 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 src/python/protocol/setup.py.in 4c50fbbf1ce11c4c42c848364523225ee7ea5a3b Diff: https://reviews.apache.org/r/44257/diff/ Testing (updated) --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
> On March 22, 2016, 10:35 a.m., haosdent huang wrote: > > Hi, zhiwei. Thank you for your patch. But seems it still doesn't contain > > the binary file correctly after I apply this patch. > > > > ``` > > diff --git a/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz > > new file mode 100644 > > index > > ..06528d5a456d6aa8dcee18159392d2ed4e5f3866 > > Binary files /dev/null and > > b/3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz differ > > ``` Yes, I told Vinod in another patch, I think he can solve this issue. Thanks. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124717 ------- On March 22, 2016, 10:22 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 22, 2016, 10:22 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 6b07aefc58a1daa235b35e83832e47d1878e2e94 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 22, 2016, 10:22 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Summary (updated) - Upgrade http-parser to 2.6.1 to support PowerPC LE platform. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description (updated) --- Upgrade http-parser to 2.6.1 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/Makefile.am ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch f9fac12437a6bedc66353fda1ce9c0d7a383225a 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz b811b63ce0ad6d71d9d296fed76656c023c76fc5 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 Diff: https://reviews.apache.org/r/44372/diff/ Testing (updated) --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.
> On March 22, 2016, 7:21 a.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/decoder.hpp, lines 175-177 > > <https://reviews.apache.org/r/44372/diff/2/?file=1280497#file1280497line175> > > > > Why do we need this now? In http-parse >= 2.x, the url.fragement is None, the previous code did not catch this, so I added it. Actually, the previous code logic will not run this function because of the `#if (HTTP_PARSER_VERSION_MAJOR >= 2)`. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review124679 --- On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 14, 2016, 10:01 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support Power LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b8351ad0181d885a984580ae8de208ea0524b0e7 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platforms. > > -- Do the validation on all platforms by "sudo make dist check" and "sudo > > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf > > numbers are OK. > > -- Run compatibility tests between scheduler <=> master <=> slave <=> > > executor where each of the components is running either the > > patched/upgraded version or not. > > Zhiwei Chen wrote: > Thanks Vinod, I need to combine all patches and then test on Power > platform, so I planed only to test single patches on ubuntu/rhel/apple one by > one, after all patches go into upstream, I will create a patch to fix ppc64le > test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch > and then test again. Will update the Testing section when I am done. > > Zhiwei Chen wrote: > Hi Vinod, when I do make check, I encouter this message many times, could > you tell me how to solve this? > > **1. This will cause the CgroupsNoHierarchyTest failed** > We cannot run any cgroups tests that require mounting > hierarchies because you have the following hierarchies mounted: > /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, > /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, > /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, > /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd > We'll disable the CgroupsNoHierarchyTest test fixture for now. > > **2. I have no physical machine, so I can't do perf test** > The 'cpu-cycles' hardware event of 'perf' is not available on > this platform so tests using it will not be run. > One likely reason is that the tests are run in a virtual > machine that does not provide CPU performance counters > > **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test** > > We cannot run any overlayfs tests because: > Overlayfs is not supported on your systems > > Vinod Kone wrote: > Skipping the above tests is fine. > > Can you make sure to run the benchmarks before and after? Also the > upgrade path (support/test_upgrade.py). > > Once you confirm, I will commit this. Then you can tackle the next > dependendcy upgrade. I would like us to do the ugprades in the order of least > disruption, so we can do glog and http parser next. Thanks, I have done all the tests. But there is an issue, the ./support/post-reviews.py can't submit binary file, so there will be no 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz file in the repo, I think you can fix this. - Zhiwei ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review123812 --- On March 22, 2016, 9:38 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44378/ > --- > > (Updated March 22, 2016, 9:38 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4803 > https://issues.apache.org/jira/browse/MESOS-4803 > > > Repository: mesos > > > Description > --- > > Upgrade libev to 4.22 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > 6b07aefc58a1daa235b35e83832e47d1878e2e94 > 3rdparty/libprocess/3rdparty/libev-4.15.patch > bbd83e6928e6caba3bc5a9739823d60923cfaa2a > 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz > 4c282b573aa9331fd16197ef286faf323b6515eb > 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION > 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > src/python/native_common/ext_modules.py.in > c335bd83024bc07b6243dd59d775e7f29adc7520 > > Diff: https://reviews.apache.org/r/44378/diff/ > > > Testing > --- > > sudo make dist check > > sudo ./src/mesos-tests --benchmark > > sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- (Updated March 22, 2016, 9:38 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, and Vinod Kone. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 24490d399f20b31b6336e92d1bd5d9a7230f31f7 3rdparty/libprocess/3rdparty/CMakeLists.txt 6b07aefc58a1daa235b35e83832e47d1878e2e94 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 src/python/native_common/ext_modules.py.in c335bd83024bc07b6243dd59d775e7f29adc7520 Diff: https://reviews.apache.org/r/44378/diff/ Testing (updated) --- sudo make dist check sudo ./src/mesos-tests --benchmark sudo ./support/run-upgrade.py --prev=../mesos-0.27.0/build --next=./build Thanks, Zhiwei Chen
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platforms. > > -- Do the validation on all platforms by "sudo make dist check" and "sudo > > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf > > numbers are OK. > > -- Run compatibility tests between scheduler <=> master <=> slave <=> > > executor where each of the components is running either the > > patched/upgraded version or not. > > Zhiwei Chen wrote: > Thanks Vinod, I need to combine all patches and then test on Power > platform, so I planed only to test single patches on ubuntu/rhel/apple one by > one, after all patches go into upstream, I will create a patch to fix ppc64le > test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch > and then test again. Will update the Testing section when I am done. Hi Vinod, when I do make check, I encouter this message many times, could you tell me how to solve this? **1. This will cause the CgroupsNoHierarchyTest failed** We cannot run any cgroups tests that require mounting hierarchies because you have the following hierarchies mounted: /sys/fs/cgroup/blkio, /sys/fs/cgroup/cpu, /sys/fs/cgroup/cpuacct, /sys/fs/cgroup/cpuset, /sys/fs/cgroup/devices, /sys/fs/cgroup/freezer, /sys/fs/cgroup/hugetlb, /sys/fs/cgroup/memory, /sys/fs/cgroup/net_cls, /sys/fs/cgroup/net_prio, /sys/fs/cgroup/perf_event, /sys/fs/cgroup/systemd We'll disable the CgroupsNoHierarchyTest test fixture for now. **2. I have no physical machine, so I can't do perf test** The 'cpu-cycles' hardware event of 'perf' is not available on this platform so tests using it will not be run. One likely reason is that the tests are run in a virtual machine that does not provide CPU performance counters **3. I use Ubuntu 14.04 as dev environment, so no overlayfs test** We cannot run any overlayfs tests because: Overlayfs is not supported on your systems - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review123812 --- On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44378/ > --- > > (Updated March 14, 2016, 10:01 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4803 > https://issues.apache.org/jira/browse/MESOS-4803 > > > Repository: mesos > > > Description > --- > > Upgrade libev to 4.22 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b8351ad0181d885a984580ae8de208ea0524b0e7 > 3rdparty/libprocess/3rdparty/libev-4.15.patch > bbd83e6928e6caba3bc5a9739823d60923cfaa2a > 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz > 4c282b573aa9331fd16197ef286faf323b6515eb > 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION > 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > src/python/native/ext_modules.py.in > eb93864733713dddad66141c6b8b6cd895f41484 > > Diff: https://reviews.apache.org/r/44378/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
> On March 16, 2016, 8:46 a.m., Vinod Kone wrote: > > Can you explain what testing you have done in the "Testing done" section? > > > > According to MESOS-4312, we agreed to do the following tests: > > > > -- Verify SSL, perf and docker related test cases work as expected on all > > platforms. > > -- Do the validation on all platforms by "sudo make dist check" and "sudo > > make check --benchmark --gtest_filter="*Benchmark*"" and make sure the perf > > numbers are OK. > > -- Run compatibility tests between scheduler <=> master <=> slave <=> > > executor where each of the components is running either the > > patched/upgraded version or not. Thanks Vinod, I need to combine all patches and then test on Power platform, so I planed only to test single patches on ubuntu/rhel/apple one by one, after all patches go into upstream, I will create a patch to fix ppc64le test cases[MESOS-4897]. Mesos code base changed, I need to rebase the patch and then test again. Will update the Testing section when I am done. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/#review123812 --- On March 14, 2016, 10:01 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44378/ > --- > > (Updated March 14, 2016, 10:01 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, Neil Conway, > and Vinod Kone. > > > Bugs: MESOS-4803 > https://issues.apache.org/jira/browse/MESOS-4803 > > > Repository: mesos > > > Description > --- > > Upgrade libev to 4.22 to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b8351ad0181d885a984580ae8de208ea0524b0e7 > 3rdparty/libprocess/3rdparty/libev-4.15.patch > bbd83e6928e6caba3bc5a9739823d60923cfaa2a > 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz > 4c282b573aa9331fd16197ef286faf323b6515eb > 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION > 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > src/python/native/ext_modules.py.in > eb93864733713dddad66141c6b8b6cd895f41484 > > Diff: https://reviews.apache.org/r/44378/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/ --- (Updated March 7, 2016, 10:05 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4879 https://issues.apache.org/jira/browse/MESOS-4879 Repository: mesos Description --- Update glog-0.3.3.patch to support PowerPC LE platform. Diffs - 3rdparty/libprocess/3rdparty/glog-0.3.3.patch 76b8c0fe3b4615371e265bab713d62c896b7c3d6 Diff: https://reviews.apache.org/r/44252/diff/ Testing --- Thanks, Zhiwei Chen
Re: Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/ --- (Updated March 7, 2016, 9:31 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4802 https://issues.apache.org/jira/browse/MESOS-4802 Repository: mesos Description --- Update leveldb-1.4.patch to support PowerPC LE platform. Diffs - 3rdparty/leveldb-1.4.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 Diff: https://reviews.apache.org/r/44382/diff/ Testing --- Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.
> On March 4, 2016, 3:37 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 44 > > <https://reviews.apache.org/r/44372/diff/2/?file=1280491#file1280491line44> > > > > How about align the `` here. > > Zhiwei Chen wrote: > There are too many backslashes that did not column aligned, how about > create another patch to fix this? > > I don't want to do things that not related to this patch. > > Thanks. > > haosdent huang wrote: > Seems only few `` not align. > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/Makefile.am I mean in many files many backslashes, not only this file. I think you can create a code clean task do things like this. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122029 ------- On March 4, 2016, 3:24 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 4, 2016, 3:24 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil > Conway. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support Power LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b8351ad0181d885a984580ae8de208ea0524b0e7 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Review Request 44382: Update leveldb-1.4.patch to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44382/ --- Review request for mesos. Repository: mesos Description --- Update leveldb-1.4.patch to support PowerPC LE platform. Diffs - 3rdparty/leveldb-1.4.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 Diff: https://reviews.apache.org/r/44382/diff/ Testing --- Thanks, Zhiwei Chen
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 4, 2016, 5:22 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4612 https://issues.apache.org/jira/browse/MESOS-4612 Repository: mesos Description --- Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. Diffs (updated) - 3rdparty/Makefile.am 49aa55741d76aa88c8fbb526f18908312bb0c717 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 3rdparty/versions.am c2dae2fb521b12344b93bf771dd5497ba8d446c3 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 3rdparty/zookeeper-3.4.8.patch PRE-CREATION src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 src/python/native/ext_modules.py.in eb93864733713dddad66141c6b8b6cd895f41484 src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 Diff: https://reviews.apache.org/r/44376/diff/ Testing --- Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643) The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c> Thanks, Zhiwei Chen
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.
> On March 4, 2016, 3:37 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 68 > > <https://reviews.apache.org/r/44372/diff/2/?file=1280491#file1280491line68> > > > > ditto. In the real file, there is a table bracket and backslash. > On March 4, 2016, 3:37 p.m., haosdent huang wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 44 > > <https://reviews.apache.org/r/44372/diff/2/?file=1280491#file1280491line44> > > > > How about align the `` here. There are too many backslashes that did not column aligned, how about create another patch to fix this? I don't want to do things that not related to this patch. Thanks. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/#review122029 ------- On March 4, 2016, 3:24 p.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44372/ > --- > > (Updated March 4, 2016, 3:24 p.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil > Conway. > > > Bugs: MESOS-4805 > https://issues.apache.org/jira/browse/MESOS-4805 > > > Repository: mesos > > > Description > --- > > Upgrade http-parser to 2.6.1 to support Power LE platform. > > > Diffs > - > > 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b8351ad0181d885a984580ae8de208ea0524b0e7 > 3rdparty/libprocess/3rdparty/Makefile.am > ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 > 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch > f9fac12437a6bedc66353fda1ce9c0d7a383225a > 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz > b811b63ce0ad6d71d9d296fed76656c023c76fc5 > 3rdparty/libprocess/3rdparty/versions.am > 98195b8eb60b2673d610d8ab7ea31103f137debf > 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d > 3rdparty/libprocess/src/decoder.hpp > a20b5ba8fc50d834573d253948645cc863f030dd > LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 > > Diff: https://reviews.apache.org/r/44372/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44372: Upgrade http-parser to 2.6.1 to support Power LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44372/ --- (Updated March 4, 2016, 3:24 p.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Summary (updated) - Upgrade http-parser to 2.6.1 to support Power LE platform. Bugs: MESOS-4805 https://issues.apache.org/jira/browse/MESOS-4805 Repository: mesos Description (updated) --- Upgrade http-parser to 2.6.1 to support Power LE platform. Diffs (updated) - 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 3rdparty/libprocess/3rdparty/CMakeLists.txt b8351ad0181d885a984580ae8de208ea0524b0e7 3rdparty/libprocess/3rdparty/Makefile.am ddf7e3d9bf76d4a03c33f02d52ec29812aef8509 3rdparty/libprocess/3rdparty/http-parser-2.6.1.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.patch f9fac12437a6bedc66353fda1ce9c0d7a383225a 3rdparty/libprocess/3rdparty/ry-http-parser-1c3624a.tar.gz b811b63ce0ad6d71d9d296fed76656c023c76fc5 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf 3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 3rdparty/libprocess/src/decoder.hpp a20b5ba8fc50d834573d253948645cc863f030dd LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 Diff: https://reviews.apache.org/r/44372/diff/ Testing --- Thanks, Zhiwei Chen
Review Request 44378: Upgrade libev to 4.22 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44378/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4803 https://issues.apache.org/jira/browse/MESOS-4803 Repository: mesos Description --- Upgrade libev to 4.22 to support PowerPC LE platform. Diffs - 3rdparty/cmake/Versions.cmake 6eac4dc0f7189e209e7d7232419e4de4bc0875c0 3rdparty/libprocess/3rdparty/CMakeLists.txt b8351ad0181d885a984580ae8de208ea0524b0e7 3rdparty/libprocess/3rdparty/libev-4.15.patch bbd83e6928e6caba3bc5a9739823d60923cfaa2a 3rdparty/libprocess/3rdparty/libev-4.15.tar.gz 4c282b573aa9331fd16197ef286faf323b6515eb 3rdparty/libprocess/3rdparty/libev-4.22.patch PRE-CREATION 3rdparty/libprocess/3rdparty/libev-4.22.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 98195b8eb60b2673d610d8ab7ea31103f137debf LICENSE 66a99b8a84e614cc89a22df02e3c47d01e26cd39 src/python/native/ext_modules.py.in eb93864733713dddad66141c6b8b6cd895f41484 Diff: https://reviews.apache.org/r/44378/diff/ Testing --- Thanks, Zhiwei Chen
Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.
> On March 4, 2016, 9:40 a.m., Neil Conway wrote: > > Is this patch in upstream glog? > > Zhiwei Chen wrote: > No, this is PowerPC LE porting patch, and this patch can also work on > other platforms. > > As you can see the diff of this patch, it will not break other platforms. > > Neil Conway wrote: > I mean, have you sent this patch to upstream glog? I would like to get us > out of the business of patching glog at some point in the future. I will send it to upsteam glog, but this may take a long time to be contained in new glog release. - Zhiwei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/#review121983 --- On March 4, 2016, 9:39 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44252/ > --- > > (Updated March 4, 2016, 9:39 a.m.) > > > Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil > Conway. > > > Bugs: MESOS-4312 > https://issues.apache.org/jira/browse/MESOS-4312 > > > Repository: mesos > > > Description > --- > > Update glog-0.3.3.patch to support PowerPC LE platform. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/glog-0.3.3.patch > 76b8c0fe3b4615371e265bab713d62c896b7c3d6 > > Diff: https://reviews.apache.org/r/44252/diff/ > > > Testing > --- > > > Thanks, > > Zhiwei Chen > >
Re: Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- (Updated March 4, 2016, 10:33 a.m.) Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4612 https://issues.apache.org/jira/browse/MESOS-4612 Repository: mesos Description --- Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. Diffs - 3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 3rdparty/zookeeper-3.4.8.patch PRE-CREATION src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 Diff: https://reviews.apache.org/r/44376/diff/ Testing (updated) --- Added a new patch that solved [ZOOKEEPER-1643](https://issues.apache.org/jira/browse/ZOOKEEPER-1643) The original patch: <https://github.com/apache/zookeeper/commit/46b565e6abd8423c43f1bb8da782d76bac7c392c> Thanks, Zhiwei Chen
Review Request 44376: Upgrade zookeeper to 3.4.8 to support PowerPC LE platform.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44376/ --- Review request for mesos, Ben Mahler, Alex Clemmer, Kapil Arya, and Neil Conway. Bugs: MESOS-4612 https://issues.apache.org/jira/browse/MESOS-4612 Repository: mesos Description --- Upgrade zookeeper to 3.4.8 to support PowerPC LE platform. Diffs - 3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 3rdparty/zookeeper-3.4.5.tar.gz 1a547fe17a6fad86012f855d3c4cc38fed4899fc 3rdparty/zookeeper-3.4.8.patch PRE-CREATION src/examples/java/test-log.in 4c8547aaa115779ae7cec58edde01ab85feeb1b1 src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 src/tests/zookeeper_test_server.cpp 0dc041fef8973d35114b9f76a6a4002853884670 Diff: https://reviews.apache.org/r/44376/diff/ Testing --- Thanks, Zhiwei Chen
