Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137640
---



I did a bunch of grammar fixes for you. Please take a look at the final 
committed doc.

- Jie Yu


On June 14, 2016, 9:19 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated June 14, 2016, 9:19 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137473
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-06-14 09:37:21 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11711/11711] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13761/console

- Mesos ReviewBot


On June 14, 2016, 9:19 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated June 14, 2016, 9:19 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated 六月 14, 2016, 9:19 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137464
---


Fix it, then Ship it!




This is great! Thanks, Guangya!


docs/docker-volume.md (lines 28 - 31)


The integration of external storage in Mesos is an attractive feature, 
since it supports stateful services in mesos containers by using external 
volumes.



docs/docker-volume.md (line 35)


"size-limited"?



docs/docker-volume.md (line 37)


s/is/becomes/g



docs/docker-volume.md (line 88)


remove "to be"



docs/docker-volume.md (line 89)


generates



docs/docker-volume.md (line 95)


Replace "The cleanup module" by "The isolator cleanup"?



docs/docker-volume.md (line 159)


should we kill this line? (I would suggest for here in doc).



docs/docker-volume.md (line 165)


ditto.



docs/docker-volume.md (line 167)


ditto.



docs/docker-volume.md (line 172)


ditto.



docs/docker-volume.md (lines 306 - 311)


It is highly not recommended to use the same Docker volume by 
DockerContainerizer and MesosContainerizer simultaneously, because
MesosContainerizer has its own reference counter to decide when to unmount 
the
Docker volume mount point. Otherwise, it would be problematic if a Docker 
volume is
unmounted by MesosContainerizer but the DockerContainerizer is still using 
it.


- Gilbert Song


On June 12, 2016, 8:18 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated June 12, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137222
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-06-13 03:34:00 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11891/11891] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13729/console

- Mesos ReviewBot


On June 13, 2016, 3:18 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated June 13, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated 六月 13, 2016, 3:18 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs
-

  docs/docker-volume.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing (updated)
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated 六月 13, 2016, 3:16 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

> On 六月 12, 2016, 6:57 p.m., Jie Yu wrote:
> > docs/docker-volume-isolator.md, line 181
> > 
> >
> > WHy operator?

Updating to `framework developer`


> On 六月 12, 2016, 6:57 p.m., Jie Yu wrote:
> > docs/docker-volume-isolator.md, line 184
> > 
> >
> > WHy operator?

Updating to `framework developer`


> On 六月 12, 2016, 6:57 p.m., Jie Yu wrote:
> > docs/docker-volume-isolator.md, line 67
> > 
> >
> > Have a link to below (i.e., framework API)

For this part, I think that we should refer to `TaskInfo` and it was already 
covered by `Enabling frameworks for Docker volume support`, comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137185
---


On 六月 13, 2016, 3:16 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated 六月 13, 2016, 3:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review137185
---




docs/docker-volume-isolator.md (line 2)


I would rename the filename to be `docker-volume.md`.

I would rename the title to be `Docker Volume Support in Mesos 
Containerizer`



docs/docker-volume-isolator.md (line 6)


Please adjust the title here as well.



docs/docker-volume-isolator.md (lines 8 - 10)


```
Mesos 1.0 adds the docker volume support for MesosContainerizer (a.k.a., 
the unified containerizer) by introducing a new isolator, called 
`docker/volume` isolator.
```



docs/docker-volume-isolator.md (line 12)


s/of docker volume support//



docs/docker-volume-isolator.md (line 13)


s/of all the involved components//



docs/docker-volume-isolator.md (line 34)


have a link to the persistent volume doc.

ALso, i would consistently use `Mesos` (not mesos) in this doc. Can you do 
a sweep to fix all of them?



docs/docker-volume-isolator.md (line 36)


I would say:
```
The external storage is needed for applications that need much larger 
storage (e.g., databases).
```



docs/docker-volume-isolator.md (line 39)


can be integrated with



docs/docker-volume-isolator.md (lines 39 - 40)


This is the 'motivation' section. I would focus on why we need docker 
volume support. You mentioned local disk size limit, which is very good.

I think you should also mention that the other motivation is that we want 
Mesos to be able to integrate with external storage providers like EBS, GCE 
volume, etc. so that the data persisted is beyond the lifetime of a single host.

And then, you should have a paragraph exlaining why we choose Docker volume 
plugin API.



docs/docker-volume-isolator.md (lines 42 - 45)


I would move this to the following section (i.e., how does it work).



docs/docker-volume-isolator.md (line 49)


s/Engine//



docs/docker-volume-isolator.md (line 67)


Have a link to below (i.e., framework API)



docs/docker-volume-isolator.md (line 95)


Please use `Docker` (not docker) consistently in this doc.



docs/docker-volume-isolator.md (line 105)


by frameworks to specify the docker volumes



docs/docker-volume-isolator.md (lines 125 - 127)


two space indentation. I would put each flag in its own line.



docs/docker-volume-isolator.md (line 151)


can you kill extra lines here to make it compact



docs/docker-volume-isolator.md (line 181)


WHy operator?



docs/docker-volume-isolator.md (line 184)


WHy operator?



docs/docker-volume-isolator.md (line 225)


that want to

need to set



docs/docker-volume-isolator.md (lines 233 - 251)


Please make it a JSON (adding quotes for keys) format.



docs/docker-volume-isolator.md (lines 305 - 306)


It is not recommended to use the same Docker volume from both 
DockerContainerizer and MesosContainerizer...


- Jie Yu


On May 31, 2016, 12:46 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 31, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document 

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review135583
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-31 03:48:53 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11847/11847] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13455/console

- Mesos ReviewBot


On May 31, 2016, 12:46 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 31, 2016, 12:46 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 31, 2016, 12:46 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review135564
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-31 00:12:54 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11827/11827] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13451/console

- Mesos ReviewBot


On May 30, 2016, 11:44 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 30, 2016, 11:44 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 30, 2016, 11:44 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

> On May 30, 2016, 5:42 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 45-55
> > 
> >
> > Or it seems to me that you should merge this to the 'without' paragraph.

I have removed the `without` section


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review135526
---


On May 29, 2016, 11:22 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 29, 2016, 11:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review135526
---




docs/docker-volume-isolator.md (lines 8 - 11)


I would rephase it a little bit.

The docker volume isolator is introduced in Mesos 0.29.0. This isolator 
adds external volume support for mesos containers via docker volume driver API.



docs/docker-volume-isolator.md (line 13)


the movivation of docker volume support,



docs/docker-volume-isolator.md (lines 30 - 33)


I would prefer expend what is attractive for this feature:

Currently, the persistent volume in mesos provides stateful services to 
store their data locally in mesos. However, the local disk is size limited. The 
external storage is needed for applications (e.g., database) to achive a more 
reliable/ambitious goal. In addition, data migration between agents/containers 
is possible by plugable external volume support.



docs/docker-volume-isolator.md (lines 35 - 38)


could we simplify this to a shorter sentence and merge to above paragraph?



docs/docker-volume-isolator.md (lines 40 - 43)


The docker/volume isolator manipulate docker volume driver API by dvdcli, 
to intergrate with external volumes.



docs/docker-volume-isolator.md (lines 45 - 55)


Or it seems to me that you should merge this to the 'without' paragraph.



docs/docker-volume-isolator.md (lines 57 - 59)


Simplify a little bit:

Thus, the docker volume support provides Mesos...



docs/docker-volume-isolator.md (lines 77 - 79)


This is not 100% true, right?



docs/docker-volume-isolator.md (lines 77 - 86)


These three may not necessary to be TaskInfo. They can also be the case for 
custom executor.



docs/docker-volume-isolator.md (lines 114 - 116)


Could you rephase this sentence? Thanks.



docs/docker-volume-isolator.md (lines 130 - 132)


The `docker/volume` isolator must be specified in the `--isolation` at agent
startup, and the `docker/volume` isolator has a dependency on 
`filesystem/linux` isolator.



docs/docker-volume-isolator.md (line 181)


s/one/operators/g



docs/docker-volume-isolator.md (line 184)


where the volume comes from. Operator need to ...



docs/docker-volume-isolator.md (line 189)


How to specify `container_path`:


- Gilbert Song


On May 29, 2016, 4:22 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 29, 2016, 4:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review135456
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-29 23:26:50 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11768/11768] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13427/console

- Mesos ReviewBot


On May 29, 2016, 11:22 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 29, 2016, 11:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 29, 2016, 11:22 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Updated `DockerVolume.driver` to `optional` in protobuf.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134931
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-26 05:45:06 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11768/11768] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13335/console

- Mesos ReviewBot


On May 26, 2016, 3:19 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 26, 2016, 3:19 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 26, 2016, 3:19 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 26, 2016, 3:16 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134543
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-24 08:24:17 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[12837/12837] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13279/console

- Mesos ReviewBot


On May 24, 2016, 7:20 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 24, 2016, 7:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated 五月 24, 2016, 7:20 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 17-20
> > 
> >
> > newline for each.

Can you please take a look at 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md to 
see the output of this? What I want is that I hope that I can list all of the 
driver backends as `including Convoy plugin, Flocker plugin, GlusterFS plugin, 
REX-Ray plugin etc.`


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, line 30
> > 
> >
> > s/docker volume driver isolator/ docker volume isolator/g

I do not found I have this in the document ;-)


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 33-40
> > 
> >
> > Merge together and rephase.

I think that diving those to two parts may be better and seems difficult to 
merge those two part.


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, line 42
> > 
> >
> > Move this below when introducing `container_path`:
> > 
> > The docker volume isolator supports tasks with/without rootfs:
> > with rootfs v.s. without rootfs
> > absolute path v.s. relative path

I was clarifying this part in line 198, hope it is OK.


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 45-52
> > 
> >
> > kill this.

Here I want to list an e2e use case just like what we did for 
https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#framework-requests-ip-address-for-containers
 here.


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 54-75
> > 
> >
> > kill this.
> > 
> > Generally, we may not need to explain the implementation in detail. 
> > Let's just explain the diagram and mention the recoverablity in one 
> > sentence.

Can we take this as the explanation for the diagram? I was following this 
document as a reference 
https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#network-virtualizer-assigns-ip-address-to-the-container-and-isolates-it
 , comments?


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 120-187
> > 
> >
> > let's just pick out related message fields and filter out all comments.

Except `host_path`, all of other fields are needed, so I suggest that we keep 
current protobuf.


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 216-288
> > 
> >
> > we dont need this if we explain ContainerInfo.Volumes above.

I think that it is better put an example here to show how to use the protobuf, 
this can make the framework developer more clear for how to use it, and I was 
following the same way as 
https://github.com/apache/mesos/blob/master/docs/networking-for-mesos-managed-containers.md#enabling-frameworks-for-ip-per-container-capability
 here


> On 五月 23, 2016, 10:53 p.m., Gilbert Song wrote:
> > docs/docker-volume-isolator.md, lines 79-80
> > 
> >
> > could we rephase?

Updated a bit.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134461
---


On 五月 24, 2016, 4:11 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated 五月 24, 2016, 4:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 24, 2016, 4:11 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134461
---




docs/docker-volume-isolator.md (line 7)


Could we add a section #Motivation?



docs/docker-volume-isolator.md (line 8)


The docker volume isolator is introduced...



docs/docker-volume-isolator.md (lines 17 - 20)


newline for each.



docs/docker-volume-isolator.md (line 24)


Remove "The rest of this document"



docs/docker-volume-isolator.md (line 30)


s/docker volume driver isolator/ docker volume isolator/g



docs/docker-volume-isolator.md (line 33)


When a new task with docker volumes specified is launched



docs/docker-volume-isolator.md (lines 33 - 40)


Merge together and rephase.



docs/docker-volume-isolator.md (line 42)


Move this below when introducing `container_path`:

The docker volume isolator supports tasks with/without rootfs:
with rootfs v.s. without rootfs
absolute path v.s. relative path



docs/docker-volume-isolator.md (lines 45 - 52)


kill this.



docs/docker-volume-isolator.md (lines 54 - 75)


kill this.

Generally, we may not need to explain the implementation in detail. Let's 
just explain the diagram and mention the recoverablity in one sentence.



docs/docker-volume-isolator.md (lines 79 - 80)


could we rephase?



docs/docker-volume-isolator.md (line 84)


let's numify each step:

1. pre-condition
2. configuration
...



docs/docker-volume-isolator.md (lines 91 - 92)


strongly recommend to create volumes explicitly, otherwise, volumes will be 
created by dvdcli.



docs/docker-volume-isolator.md (lines 106 - 107)


dependency on linux filesystem isolator.



docs/docker-volume-isolator.md (lines 120 - 187)


let's just pick out related message fields and filter out all comments.



docs/docker-volume-isolator.md (lines 198 - 209)


could we draw a table?



docs/docker-volume-isolator.md (line 200)


if it is a command task V.S. a mesos container with a specified image...



docs/docker-volume-isolator.md (line 213)


please fix the grammar.



docs/docker-volume-isolator.md (lines 216 - 288)


we dont need this if we explain ContainerInfo.Volumes above.



docs/docker-volume-isolator.md (line 290)


could rephase and fix the grammar.



docs/docker-volume-isolator.md (line 302)


do we need this section for now? since users may not be able to test it out 
depending on the code base.



docs/docker-volume-isolator.md (lines 329 - 339)


kill this.



docs/docker-volume-isolator.md (line 341)


let's add it later.


- Gilbert Song


On May 20, 2016, 6:51 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 20, 2016, 6:51 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review134145
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-20 14:22:44 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[12354/12354] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13201/console

- Mesos ReviewBot


On May 20, 2016, 1:51 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 20, 2016, 1:51 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 20, 2016, 1:51 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Added "Limitation" section


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review133859
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-19 02:13:04 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[11902/11902] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13158/console

- Mesos ReviewBot


On May 19, 2016, 1:38 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 19, 2016, 1:38 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 19, 2016, 1:38 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/
---

(Updated May 19, 2016, 1:37 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5216
https://issues.apache.org/jira/browse/MESOS-5216


Repository: mesos


Description
---

Added documentation for `docker/volume` isolator.


Diffs (updated)
-

  docs/.mesos-containerizer.md.swp PRE-CREATION 
  docs/docker-volume-isolator.md PRE-CREATION 
  docs/images/docker-volume-isolator.png PRE-CREATION 

Diff: https://reviews.apache.org/r/47511/diff/


Testing
---

You can review the document here: 
https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md


Thanks,

Guangya Liu

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47511/#review133771
---



Bad patch!

Reviews applied: [47511]

Failed command: ./support/apply-review.sh -n -r 47511

Error:
2016-05-18 17:34:03 URL:https://reviews.apache.org/r/47511/diff/raw/ 
[7/7] -> "47511.patch" [1]
error: missing binary patch data for 'docs/images/docker-volume-isolator.png'
error: binary patch does not apply to 'docs/images/docker-volume-isolator.png'
error: docs/images/docker-volume-isolator.png: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/13150/console

- Mesos ReviewBot


On May 18, 2016, 9:43 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47511/
> ---
> 
> (Updated May 18, 2016, 9:43 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5216
> https://issues.apache.org/jira/browse/MESOS-5216
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for `docker/volume` isolator.
> 
> 
> Diffs
> -
> 
>   docs/docker-volume-isolator.md PRE-CREATION 
>   docs/images/docker-volume-isolator.png PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47511/diff/
> 
> 
> Testing
> ---
> 
> You can review the document here: 
> https://github.com/jay-lau/mesos/blob/master/docs/docker-volume-isolator.md
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>