Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review95637 --- Ship it! Ship It! src/linux/cgroups.cpp (line 1686) https://reviews.apache.org/r/36620/#comment150750 More like a code suggestion, looks like reap is always called after kill, and just waiting on all the statuses you gathered. I wonder why not just move collect inside of kill(processes) in the end and return that instead of another callback? - Timothy Chen On Aug. 13, 2015, 1:52 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 13, 2015, 1:52 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 13, 2015, 1:52 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Changes --- Addressed comment and rebased. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing (updated) --- sudo make check + manual tests Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
On July 28, 2015, 7:20 p.m., Timothy Chen wrote: I notice there are no new tests added for this, can you add a test to verify the new change works? Timothy Chen wrote: Are you able to add this? Otherwise let's add a TODO and get this in. Created MESOS-3255 to follow up with tests. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 --- On July 24, 2015, 1:07 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 24, 2015, 1:07 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review95259 --- Patch looks great! Reviews applied: [36612, 36620] All tests passed. - Mesos ReviewBot On Aug. 13, 2015, 1:52 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 13, 2015, 1:52 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check + manual tests Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
On July 28, 2015, 7:20 p.m., Timothy Chen wrote: I notice there are no new tests added for this, can you add a test to verify the new change works? Are you able to add this? Otherwise let's add a TODO and get this in. - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 --- On July 24, 2015, 1:07 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 24, 2015, 1:07 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review93329 --- I notice there are no new tests added for this, can you add a test to verify the new change works? src/linux/cgroups.cpp (line 1689) https://reviews.apache.org/r/36620/#comment147707 I'll move the onFailed to next line so we line up the indentation. - Timothy Chen On July 24, 2015, 1:07 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 24, 2015, 1:07 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
On July 23, 2015, 5:42 p.m., Timothy Chen wrote: src/linux/cgroups.cpp, line 1696 https://reviews.apache.org/r/36620/diff/10/?file=1019693#file1019693line1696 Seems like we can just a lambda instead of a new fail method, then we don't even need to store chain variable right? We need to store the chain variable for the finalize call, e.g. when the timeout kills the process. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92774 --- On July 24, 2015, 1:07 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 24, 2015, 1:07 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92901 --- Bad patch! Reviews applied: [36612, 36620] Failed command: ./support/apply-review.sh -n -r 36620 Error: 2015-07-24 12:57:59 URL:https://reviews.apache.org/r/36620/diff/raw/ [234469/234469] - 36620.patch [1] Successfully applied: WIP Added Non-Freezeer Task Killer. WIP Added Non-Freezeer Task Killer. Review: https://reviews.apache.org/r/36620 Checking 54 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: cmake/MesosConfigure.cmake docs/app-framework-development-guide.md docs/fetcher-cache-internals.md docs/release-guide.md include/mesos/mesos.proto include/mesos/scheduler/scheduler.proto include/mesos/slave/isolator.hpp include/mesos/slave/isolator.proto src/Makefile.am src/common/protobuf_utils.cpp src/common/protobuf_utils.hpp src/exec/exec.cpp src/linux/cgroups.cpp src/master/master.cpp src/master/master.hpp src/sched/sched.cpp src/scheduler/scheduler.cpp src/slave/containerizer/isolator.cpp src/slave/containerizer/isolators/cgroups/cpushare.cpp src/slave/containerizer/isolators/cgroups/cpushare.hpp src/slave/containerizer/isolators/cgroups/mem.cpp src/slave/containerizer/isolators/cgroups/mem.hpp src/slave/containerizer/isolators/cgroups/perf_event.cpp src/slave/containerizer/isolators/cgroups/perf_event.hpp src/slave/containerizer/isolators/filesystem/posix.cpp src/slave/containerizer/isolators/filesystem/posix.hpp src/slave/containerizer/isolators/filesystem/shared.cpp src/slave/containerizer/isolators/filesystem/shared.hpp src/slave/containerizer/isolators/namespaces/pid.cpp src/slave/containerizer/isolators/namespaces/pid.hpp src/slave/containerizer/isolators/network/port_mapping.cpp src/slave/containerizer/isolators/network/port_mapping.hpp src/slave/containerizer/isolators/posix.hpp src/slave/containerizer/isolators/posix/disk.cpp src/slave/containerizer/isolators/posix/disk.hpp src/slave/containerizer/launcher.cpp src/slave/containerizer/linux_launcher.cpp src/slave/containerizer/mesos/containerizer.cpp src/slave/containerizer/mesos/containerizer.hpp src/tests/containerizer_tests.cpp src/tests/disk_quota_tests.cpp src/tests/docker_containerizer_tests.cpp src/tests/external_containerizer_test.cpp src/tests/fault_tolerance_tests.cpp src/tests/hook_tests.cpp src/tests/isolator.hpp src/tests/master_authorization_tests.cpp src/tests/master_slave_reconciliation_tests.cpp src/tests/master_tests.cpp src/tests/master_validation_tests.cpp src/tests/memory_pressure_tests.cpp src/tests/partition_tests.cpp src/tests/persistent_volume_tests.cpp src/tests/port_mapping_tests.cpp src/tests/rate_limiting_tests.cpp src/tests/reconciliation_tests.cpp src/tests/registrar_zookeeper_tests.cpp src/tests/scheduler_tests.cpp src/tests/slave_recovery_tests.cpp src/tests/slave_tests.cpp support/tag.sh stout: 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt libprocess: 3rdparty/libprocess/3rdparty/CMakeLists.txt 3rdparty/libprocess/cmake/ProcessConfigure.cmake 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3rdparty/libprocess/include/process/http.hpp 3rdparty/libprocess/src/tests/CMakeLists.txt Failed to commit patch - Mesos ReviewBot On July 24, 2015, 12:15 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 24, 2015, 12:15 p.m.) Review request for mesos, Benjamin Hindman and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt d7c6dfb04120a7fd28e1a4682f39015bd149eb40 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd 3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 23, 2015, 12:21 p.m.) Review request for mesos and Timothy Chen. Changes --- Improved comments. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92747 --- Patch looks great! Reviews applied: [36612, 36620] All tests passed. - Mesos ReviewBot On July 23, 2015, 12:21 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 23, 2015, 12:21 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 23, 2015, 12:19 p.m.) Review request for mesos and Timothy Chen. Changes --- Improved comments. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 10:04 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92585 --- Patch looks great! Reviews applied: [36612, 36620] All tests passed. - Mesos ReviewBot On July 22, 2015, 10:04 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 10:04 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 3:59 p.m.) Review request for mesos and Timothy Chen. Changes --- Style fixes Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 4:42 p.m.) Review request for mesos and Timothy Chen. Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 4:37 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs (updated) - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing (updated) --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92432 --- Could you please attach a ticket or explain in the description about the motivation? - Jie Yu On July 21, 2015, 4:42 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 4:42 p.m.) Review request for mesos and Timothy Chen. Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92549 --- Bad patch! Reviews applied: [36612] Failed command: ./support/apply-review.sh -n -r 36612 Error: 2015-07-22 05:28:09 URL:https://reviews.apache.org/r/36612/diff/raw/ [12620/12620] - 36612.patch [1] error: patch failed: src/linux/cgroups.hpp:92 error: src/linux/cgroups.hpp: patch does not apply error: patch failed: src/linux/cgroups.cpp:110 error: src/linux/cgroups.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On July 22, 2015, 4:37 a.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 4:37 a.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92457 --- src/linux/cgroups.cpp (line 1504) https://reviews.apache.org/r/36620/#comment146628 This is actually the Freezer right? And we should make this VLOG(1) src/linux/cgroups.cpp (line 1627) https://reviews.apache.org/r/36620/#comment146629 To me this doesn't killer doesn't atomically kill all of them, as that implies either all or none. I think the TaskKiller actually best effort try to kill by signal and reintrospect all tasks in a cgroup within the timeout src/linux/cgroups.cpp (line 1650) https://reviews.apache.org/r/36620/#comment146630 100 ms seems way too fast? And why not use the default timeout that's already there? src/linux/cgroups.cpp (line 1668) https://reviews.apache.org/r/36620/#comment146632 This should go to line 1674? src/linux/cgroups.cpp (line 1676) https://reviews.apache.org/r/36620/#comment146631 Move to previous line. src/linux/cgroups.cpp (line 1684) https://reviews.apache.org/r/36620/#comment146633 This fits on to previous line? - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92459 --- src/linux/cgroups.cpp (line 1671) https://reviews.apache.org/r/36620/#comment146638 It's very odd to see the failure message set here but then a lot more attempts to try to set it in the finished callback. How about having a failed method that sets the failure and another finished callback that is what you have? src/linux/cgroups.cpp (line 1683) https://reviews.apache.org/r/36620/#comment146637 Very wierd identation? src/linux/cgroups.cpp (line 1686) https://reviews.apache.org/r/36620/#comment146634 //check - // Check src/linux/cgroups.cpp (line 1688) https://reviews.apache.org/r/36620/#comment146636 one more space to the right src/linux/cgroups.cpp (line 1708) https://reviews.apache.org/r/36620/#comment146635 extra space between the and pids - Timothy Chen On July 21, 2015, 5:18 p.m., Joerg Schad wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 21, 2015, 5:18 p.m.) Review request for mesos and Timothy Chen. Bugs: MESOS-3086 https://issues.apache.org/jira/browse/MESOS-3086 Repository: mesos Description --- WIP Added Non-Freezeer Task Killer. Diffs - src/linux/cgroups.cpp b7d11ac4eb8b78664c8c7bd7a5b0d566b5bf2f0e Diff: https://reviews.apache.org/r/36620/diff/ Testing --- sudo make check Thanks, Joerg Schad
