----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92901 -----------------------------------------------------------
Bad patch! Reviews applied: [36612, 36620] Failed command: ./support/apply-review.sh -n -r 36620 Error: 2015-07-24 12:57:59 URL:https://reviews.apache.org/r/36620/diff/raw/ [234469/234469] -> "36620.patch" [1] Successfully applied: WIP Added Non-Freezeer Task Killer. WIP Added Non-Freezeer Task Killer. Review: https://reviews.apache.org/r/36620 Checking 54 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo Total errors found: 0 ERROR: Commit spanning multiple projects. Please use separate commits for mesos, libprocess and stout. Paths grouped by project: mesos: cmake/MesosConfigure.cmake docs/app-framework-development-guide.md docs/fetcher-cache-internals.md docs/release-guide.md include/mesos/mesos.proto include/mesos/scheduler/scheduler.proto include/mesos/slave/isolator.hpp include/mesos/slave/isolator.proto src/Makefile.am src/common/protobuf_utils.cpp src/common/protobuf_utils.hpp src/exec/exec.cpp src/linux/cgroups.cpp src/master/master.cpp src/master/master.hpp src/sched/sched.cpp src/scheduler/scheduler.cpp src/slave/containerizer/isolator.cpp src/slave/containerizer/isolators/cgroups/cpushare.cpp src/slave/containerizer/isolators/cgroups/cpushare.hpp src/slave/containerizer/isolators/cgroups/mem.cpp src/slave/containerizer/isolators/cgroups/mem.hpp src/slave/containerizer/isolators/cgroups/perf_event.cpp src/slave/containerizer/isolators/cgroups/perf_event.hpp src/slave/containerizer/isolators/filesystem/posix.cpp src/slave/containerizer/isolators/filesystem/posix.hpp src/slave/containerizer/isolators/filesystem/shared.cpp src/slave/containerizer/isolators/filesystem/shared.hpp src/slave/containerizer/isolators/namespaces/pid.cpp src/slave/containerizer/isolators/namespaces/pid.hpp src/slave/containerizer/isolators/network/port_mapping.cpp src/slave/containerizer/isolators/network/port_mapping.hpp src/slave/containerizer/isolators/posix.hpp src/slave/containerizer/isolators/posix/disk.cpp src/slave/containerizer/isolators/posix/disk.hpp src/slave/containerizer/launcher.cpp src/slave/containerizer/linux_launcher.cpp src/slave/containerizer/mesos/containerizer.cpp src/slave/containerizer/mesos/containerizer.hpp src/tests/containerizer_tests.cpp src/tests/disk_quota_tests.cpp src/tests/docker_containerizer_tests.cpp src/tests/external_containerizer_test.cpp src/tests/fault_tolerance_tests.cpp src/tests/hook_tests.cpp src/tests/isolator.hpp src/tests/master_authorization_tests.cpp src/tests/master_slave_reconciliation_tests.cpp src/tests/master_tests.cpp src/tests/master_validation_tests.cpp src/tests/memory_pressure_tests.cpp src/tests/partition_tests.cpp src/tests/persistent_volume_tests.cpp src/tests/port_mapping_tests.cpp src/tests/rate_limiting_tests.cpp src/tests/reconciliation_tests.cpp src/tests/registrar_zookeeper_tests.cpp src/tests/scheduler_tests.cpp src/tests/slave_recovery_tests.cpp src/tests/slave_tests.cpp support/tag.sh stout: 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake 3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt libprocess: 3rdparty/libprocess/3rdparty/CMakeLists.txt 3rdparty/libprocess/cmake/ProcessConfigure.cmake 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3rdparty/libprocess/include/process/http.hpp 3rdparty/libprocess/src/tests/CMakeLists.txt Failed to commit patch - Mesos ReviewBot On July 24, 2015, 12:15 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36620/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:15 p.m.) > > > Review request for mesos, Benjamin Hindman and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > WIP Added Non-Freezeer Task Killer. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > d7c6dfb04120a7fd28e1a4682f39015bd149eb40 > 3rdparty/libprocess/3rdparty/stout/cmake/FindApr.cmake > 4b28aa170f48d37ae9096bc28a64d8a32e8d35dd > 3rdparty/libprocess/3rdparty/stout/cmake/FindSvn.cmake > 87737395d011393e7ef0c86fa18a3d31f3045fb0 > 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake > 6e7eb00b79e81cb6426cf08d50e22075898f2616 > 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp > d58f8a4ab8f6f761adb6a9db2dac438ffe0e211b > 3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt > b1a519007e5bed196541f294c4676277f9708714 > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 4681eef1347fd46e85e1768795cc2f34aaba02b2 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c > 3rdparty/libprocess/include/process/http.hpp > 9faed55247a3ccd629db7b85dbf31d3117e120e9 > 3rdparty/libprocess/src/tests/CMakeLists.txt > b61ca1e5be2054c1156205c62a1e8311a575bfa5 > cmake/MesosConfigure.cmake ee47842a5a2681221838e736738943572e96e702 > docs/app-framework-development-guide.md > db0181c0b82fded1860ef636747e70d80e3884f2 > docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b > docs/release-guide.md a946c7e2c57632d3ff1b4cd6ac6c47df69dcf80c > include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a > include/mesos/scheduler/scheduler.proto > 89daf8a6b74057ee156b3ad691397e76fcb835b8 > include/mesos/slave/isolator.hpp 8387efd39a0e868038350ab620b38e4ab89327db > include/mesos/slave/isolator.proto 07c1c1a09d1578dd4c3abd8bb1773782b4aa9549 > src/Makefile.am 9f2d7e38b28c1208cd819d2470c7f6ec6d5a71f9 > src/common/protobuf_utils.hpp 22046bad118818dc815f1752fa805adaba136bab > src/common/protobuf_utils.cpp 4cfbda4696d4abc169b3d1a05dc522889232ebcd > src/exec/exec.cpp 54ef622ca3e9a004b065e2f3a496a1b87902f722 > src/linux/cgroups.cpp e062fcbd56315f11882fe0ccb615c490dd719934 > src/master/master.hpp bf61bb2deb61a73303f4122383dcb7e8f5d726de > src/master/master.cpp bab04feaf238e51c4d50feb1d3a9c0735ec68fec > src/sched/sched.cpp e411f376938a2c6793621de42e60425e5faed453 > src/scheduler/scheduler.cpp badc107dbf4e2bd9146f9244724e0db5c2ae05d3 > src/slave/containerizer/isolator.cpp > ec14b207be36af7ca601e0f327e7025a155f41e4 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4fa9015e445872ec4a060e62dc2b5f2b30fc0f47 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > b1ebdaddc211bab023be85084bc82b6b82093f0b > src/slave/containerizer/isolators/cgroups/mem.hpp > c198c832f8fb3765e932f1f20d3e16524340a7f2 > src/slave/containerizer/isolators/cgroups/mem.cpp > 919e0f7eccff1d4c10852260965bda2bdb1c4267 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 243cf5a6ff699aa37f885cc164977126413d155b > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 367cb4364212ce057a474b574b8dbf8ccc1ae235 > src/slave/containerizer/isolators/filesystem/posix.hpp > d44023eb95c48d6ffbd69334f91a2b4c4b760db0 > src/slave/containerizer/isolators/filesystem/posix.cpp > 2aa8406b8386c7e407c9330400629a651f346ddf > src/slave/containerizer/isolators/filesystem/shared.hpp > 4a5dcc35b6aea665893a1406fe4e2a97cf4e5d1a > src/slave/containerizer/isolators/filesystem/shared.cpp > f90045e7696b54b7b5082b9aa16c78d0347afde6 > src/slave/containerizer/isolators/namespaces/pid.hpp > 702f331d39acc75e9c98183c30227ec47f10e904 > src/slave/containerizer/isolators/namespaces/pid.cpp > 4241fa7a917ab31f52ece4caf16e94b3ef9ac353 > src/slave/containerizer/isolators/network/port_mapping.hpp > 6ffd7290eef2f0c3d3dc1c6236248e498c5be6ca > src/slave/containerizer/isolators/network/port_mapping.cpp > 39d1813ee534df184cd5cf2b11af22e0195b0802 > src/slave/containerizer/isolators/posix.hpp > 6ddab7df489feb2a7762178183191d5d1dc99e15 > src/slave/containerizer/isolators/posix/disk.hpp > fdf24a18bfca97863b7c15c39378b879d7b43517 > src/slave/containerizer/isolators/posix/disk.cpp > 238f17941712e0709eba1cf78c6bc825b3b4459e > src/slave/containerizer/launcher.cpp > ecb33309ff0941985eebf7a94d831330076978de > src/slave/containerizer/linux_launcher.cpp > ed2e881f555d651ad1e5f1b62f32848ade09b424 > src/slave/containerizer/mesos/containerizer.hpp > 5155362bef9163af3fa5334be3a39b91549e1ec1 > src/slave/containerizer/mesos/containerizer.cpp > c21e925e9584bc914f492d7f459498f732779fc8 > src/tests/containerizer_tests.cpp 0b1338107ebe7b78821fddbefec90524f35e3858 > src/tests/disk_quota_tests.cpp 1ed1342a10a4d59b84ef13a3d66eef95150c4e53 > src/tests/docker_containerizer_tests.cpp > 80ed60e2b0fa39e8302867a7cb6a7388c25f9a40 > src/tests/external_containerizer_test.cpp > 17bfb72cbefc637d45fa26cf5b412b58059282a9 > src/tests/fault_tolerance_tests.cpp > 928871863c2515a5269a439cb13dad79062f3663 > src/tests/hook_tests.cpp e9f1c777153b94eebea0f2c4fc2f4afb0e382afb > src/tests/isolator.hpp 671b02141c0afde8718b81dddc7629bb1b9d00fb > src/tests/master_authorization_tests.cpp > d9b5d01c583b8b355426b0992eebd7b16f9c4505 > src/tests/master_slave_reconciliation_tests.cpp > 7b0b983cae090ca5166d9fb1905fff88d3f21600 > src/tests/master_tests.cpp 05c148ee1660b86428afe4eda718b17052743a8c > src/tests/master_validation_tests.cpp > 3513bca6fd6773f712d1a647b1757766dc34f948 > src/tests/memory_pressure_tests.cpp > 8089879b5542ada0a6613d444ab19065ef150d9b > src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c > src/tests/persistent_volume_tests.cpp > 8b791ac0861171b0c655307e965165d9ad7ba966 > src/tests/port_mapping_tests.cpp 45ef97a4822edacd2c2964e63ec624fe4190b3b9 > src/tests/rate_limiting_tests.cpp d02cb5f5b9bd262c377356bab1699834d9a046dd > src/tests/reconciliation_tests.cpp d9dde93e14b143a01cf9af055df081f4d034e080 > src/tests/registrar_zookeeper_tests.cpp > 29832b43cb8c6d201ebdba6f268d7dfaddd9caa2 > src/tests/scheduler_tests.cpp 98fc70bf43ba99b54064a236795c7e1269004b71 > src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc > src/tests/slave_tests.cpp b145d76cf9e96fe89a5e3df1c4611a6b146585e9 > support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 > > Diff: https://reviews.apache.org/r/36620/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >