Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-07 Thread Till Toenshoff 


> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [39452]
> > 
> > Failed command: ./support/apply-review.sh -n -r 39452
> > 
> > Error:
> >  2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ 
> > [2542/2542] -> "39452.patch" [1]
> > error: docs/scheduler-http-api.md: does not exist in index
> > Failed to apply patch
> 
> Marco Massenzio wrote:
> uhm... what does this even mean?

Seems to be a glitch in the matrix - I can apply your patch locally just fine.


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review10
---


On Nov. 7, 2015, 1:19 a.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 7, 2015, 1:19 a.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> Built the site & tested using:
> https://github.com/apache/mesos/tree/master/support/site-docker
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio 


> On Nov. 7, 2015, 1:15 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [39452]
> > 
> > Failed command: ./support/apply-review.sh -n -r 39452
> > 
> > Error:
> >  2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ 
> > [2542/2542] -> "39452.patch" [1]
> > error: docs/scheduler-http-api.md: does not exist in index
> > Failed to apply patch

uhm... what does this even mean?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review10
---


On Nov. 6, 2015, 8:35 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 6, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> Built the site & tested using:
> https://github.com/apache/mesos/tree/master/support/site-docker
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review10
---


Bad patch!

Reviews applied: [39452]

Failed command: ./support/apply-review.sh -n -r 39452

Error:
 2015-11-07 01:15:41 URL:https://reviews.apache.org/r/39452/diff/raw/ 
[2542/2542] -> "39452.patch" [1]
error: docs/scheduler-http-api.md: does not exist in index
Failed to apply patch

- Mesos ReviewBot


On Nov. 6, 2015, 8:35 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 6, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> Built the site & tested using:
> https://github.com/apache/mesos/tree/master/support/site-docker
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105385
---

Ship it!


Please verify your test results from rendering the website and then I'll commit 
this.


docs/scheduler-http-api.md (line 27)


"[below][subscribe]" Have you rendered this on the website to see if this 
kind of link still works? This has gotten even easier now that the website 
itself is included in the git source.
Please mention your test results from rendering the doc on the website in 
the "Testing Done" section.



docs/scheduler-http-api.md (line 31)


s/to be/would be/? or "is"?



docs/scheduler-http-api.md (lines 37 - 38)


I don't think you necessarily need the actual line break in your 
definition, since you're encoding it as "LF", so I would suggest:
`record  = record-size LF record-data`


- Adam B


On Nov. 5, 2015, 3:50 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 5, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio 


> On Nov. 6, 2015, 8:53 a.m., Adam B wrote:
> > Please verify your test results from rendering the website and then I'll 
> > commit this.

thanks for pointers, done!


> On Nov. 6, 2015, 8:53 a.m., Adam B wrote:
> > docs/scheduler-http-api.md, line 31
> > 
> >
> > s/to be/would be/? or "is"?

"is"


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105385
---


On Nov. 6, 2015, 7:45 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 6, 2015, 7:45 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> Built the site & tested using:
> https://github.com/apache/mesos/tree/master/support/site-docker
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Nov. 6, 2015, 7:45 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing (updated)
---

Built the site & tested using:
https://github.com/apache/mesos/tree/master/support/site-docker


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Nov. 6, 2015, 8:35 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Addressed comments / tested on the site-builder


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---

Built the site & tested using:
https://github.com/apache/mesos/tree/master/support/site-docker


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-05 Thread Ben Whitehead 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105333
---

Ship it!


Ship It!

- Ben Whitehead


On Nov. 5, 2015, 3:50 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 5, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-05 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Nov. 5, 2015, 11:50 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Addressed all comments.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105356
---


Patch looks great!

Reviews applied: [39452]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 11:50 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Nov. 5, 2015, 11:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103229
---


Patch looks great!

Reviews applied: [39452]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio 


> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 44
> > 
> >
> > Nit: Can we just check for `200` here (since the response from 
> > `Subscribe` should be `200` for a good response ?

we removed this code


> On Oct. 19, 2015, 10:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 51
> > 
> >
> > Is `int(...)` in python unsigned and 64 bytes ? That is the 
> > requirements we mention in our docs.

no (signed) and yes (64 bits - not bytes :) - but that's now largely 
irrelevant, as we removed the code.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103172
---


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103267
---

Ship it!



docs/scheduler-http-api.md (line 36)


s/In more formal terms/As per ABNF-based grammar



docs/scheduler-http-api.md (line 66)


Do we need this line anymore now ? This can be killed in favor of the 
following lines that we added around why RecordIO was needed.


- Anand Mazumdar


On Oct. 20, 2015, 4:34 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 4:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 20, 2015, 4:34 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 20, 2015, 9:30 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead 


> On Oct. 20, 2015, 9:38 a.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 66
> > 
> >
> > Do we need this line anymore now ? This can be killed in favor of the 
> > following lines that we added around why RecordIO was needed.
> 
> Marco Massenzio wrote:
> I got a +1 from Ben on this one :)
> Let's see what @vinodkone says...

Sorry, new to review board.  I actually meant +1 to Anands comment. I'll remove 
me previous point and add a +1 to Anands comment.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103267
---


On Oct. 20, 2015, 2:30 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead 


> On Oct. 19, 2015, 3:34 p.m., Anand Mazumdar wrote:
> > docs/scheduler-http-api.md, line 59
> > 
> >
> > Should we also mention why just encoding one event per chunk won't 
> > suffice and why we needed this ?
> > 
> > How about:
> > 
> > ```Network intermediataries e.g. proxies are free to change the chunk 
> > boundaries and this should not have any effect on the recipient 
> > application(scheduler layer). We wanted a way to delimit/encode two events 
> > for JSON/Protobuf responses consistently and RecordIO format allowed us to 
> > do that.```

+1


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103172
---


On Oct. 20, 2015, 2:30 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:30 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Ben Whitehead 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103314
---



docs/scheduler-http-api.md (lines 29 - 34)


Now that there is a formal grammar this example should be removed.



docs/scheduler-http-api.md (lines 36 - 48)


The proposed grammar I made was based of the ABNF of the HTTP 1.1 spec 
here: http://www.w3.org/Protocols/rfc2616/rfc2616-sec2.html#sec2.1 This spec 
should probably be linked to so the user can follow it.

`LF` is the method used to refer to `\n` character and I think we should be 
consistent with that.

`1*(DIGIT)` was there to denote the repetition of digit. Meaning at least 1 
digit.

`DIGIT` is already defined in the rfc I linked to.

`NL` is non-standard and should be removed in favor of `LF`



docs/scheduler-http-api.md (line 51)


This section of the document is expalaining RecordIO not http clients. 
Please remove this sentence.



docs/scheduler-http-api.md (lines 66 - 68)


These two lines don't flow together very well, a single paragraph should 
contain the motivation and justification.


- Ben Whitehead


On Oct. 20, 2015, 2:58 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103344
---


Patch looks great!

Reviews applied: [39452]

All tests passed.

- Mesos ReviewBot


On Oct. 20, 2015, 9:58 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 20, 2015, 9:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103152
---

Ship it!



docs/scheduler-http-api.md (line 59)


independent


- Joerg Schad


On Oct. 19, 2015, 7:59 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 7:59 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/
---

(Updated Oct. 19, 2015, 9:07 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3566
https://issues.apache.org/jira/browse/MESOS-3566


Repository: mesos


Description
---

Added the description of the RecordIO format to the HTTP API
document with example code (Python) to decode.


Diffs (updated)
-

  docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 

Diff: https://reviews.apache.org/r/39452/diff/


Testing
---


Thanks,

Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Ben Whitehead 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
---



docs/scheduler-http-api.md (lines 28 - 36)


This text isn't helpful.

I wanted a grammar that defined what the RecordIO format was, having the 
formal grammar removes any subtelties of examples.

Here is a grammar that reflects RecordIO:

```
records = *record

record  = record-size LF
  record-data

record-size = 1*DIGIT
record-data = record-size(OCTET)
```

`record-size` should be interpreted as an unsigned 64-bit integer (uint64)



docs/scheduler-http-api.md (lines 38 - 57)


The rest of the HTTP API Documentation is language agnostic and I feel 
strongly that it should be kept that way.

Please remove this example. In the future when there are implementations 
available they can be linked to in an appendix.



docs/scheduler-http-api.md (line 59)


+1


- Ben Whitehead


On Oct. 19, 2015, 2:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 2:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Anand Mazumdar 


> On Oct. 20, 2015, 1:03 a.m., Ben Whitehead wrote:
> > docs/scheduler-http-api.md, lines 38-57
> > 
> >
> > The rest of the HTTP API Documentation is language agnostic and I feel 
> > strongly that it should be kept that way.
> > 
> > Please remove this example. In the future when there are 
> > implementations available they can be linked to in an appendix.

I tend to agree with BenW here. Let's add pseudo code instead of python code 
here in addition to the suggested ABNF grammar. Borrowed from: 
https://dev.twitter.com/streaming/overview/processing ( Delimited section )

```
while (true) {
  do {
lengthBytes = readline()
  } while (lengthBytes.length < 1)
  messageLength = parseInt(lengthBytes);
  messageBytes = read(messageLength);
  process(messageBytes);
}
```

What do you think ?


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review103194
---


On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> ---
> 
> (Updated Oct. 19, 2015, 9:07 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
> https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>