Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Dec. 18, 2015, 9:38 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
01b3c13751a5558d5f06edb8f650c8644dc54486 

Diff: https://reviews.apache.org/r/40256/diff/


Testing
---

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-18 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/#review111249
---

Ship it!



src/tests/persistent_volume_tests.cpp (line 99)


Looks like `MasterFlags` is not needed anymore with implicit roles. Can you 
do a sweep to remove it in a subsequent patch?


- Jie Yu


On Dec. 18, 2015, 9:38 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40256/
> ---
> 
> (Updated Dec. 18, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of multiple offer operations in 
> PersistentVolumeTest.SendingCheckpointResourcesMessage.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 01b3c13751a5558d5f06edb8f650c8644dc54486 
> 
> Diff: https://reviews.apache.org/r/40256/diff/
> 
> 
> Testing
> ---
> 
> This is the sixth in a chain of 7 patches. This patch was required in order 
> to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, 
> which was broken by the addition of authorization to the `CREATE` and 
> `DESTROY` offer operations. The test was previously both creating and 
> destroying a persistent volume in a single `acceptOffer` message. However, 
> our `validate` method for `DESTROY` offer operations correctly enforces that 
> in order to delete a volume, the volume should be present in the checkpointed 
> resources of the relevant Agent. This is likely not the case if the `CREATE` 
> and `DESTROY` operations are both in the same message.
> 
> `make check` was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-18 Thread Greg Mann 


> On Dec. 18, 2015, 8:05 p.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 99
> > 
> >
> > Looks like `MasterFlags` is not needed anymore with implicit roles. Can 
> > you do a sweep to remove it in a subsequent patch?

Simply removing `MasterFlags` results in an uninteresting mock function call 
error, probably because of a method triggered by adding an unknown role. I'm 
happy to take care of this, but I'd prefer to wait until I have some more time. 
I've created a JIRA to track this here: 
https://issues.apache.org/jira/browse/MESOS-4205 Sound OK to you?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/#review111249
---


On Dec. 18, 2015, 9:38 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40256/
> ---
> 
> (Updated Dec. 18, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of multiple offer operations in 
> PersistentVolumeTest.SendingCheckpointResourcesMessage.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 01b3c13751a5558d5f06edb8f650c8644dc54486 
> 
> Diff: https://reviews.apache.org/r/40256/diff/
> 
> 
> Testing
> ---
> 
> This is the sixth in a chain of 7 patches. This patch was required in order 
> to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, 
> which was broken by the addition of authorization to the `CREATE` and 
> `DESTROY` offer operations. The test was previously both creating and 
> destroying a persistent volume in a single `acceptOffer` message. However, 
> our `validate` method for `DESTROY` offer operations correctly enforces that 
> in order to delete a volume, the volume should be present in the checkpointed 
> resources of the relevant Agent. This is likely not the case if the `CREATE` 
> and `DESTROY` operations are both in the same message.
> 
> `make check` was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-12-08 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Dec. 8, 2015, 7:24 p.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
01b3c13751a5558d5f06edb8f650c8644dc54486 

Diff: https://reviews.apache.org/r/40256/diff/


Testing (updated)
---

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is likely not the case if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.


Thanks,

Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-13 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Nov. 14, 2015, 12:26 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
---

Rebase.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing
---

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is clearly impossible if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Nov. 13, 2015, 1:21 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Summary (updated)
-

[6/7] Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing
---

This is the last in a chain of 6 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is clearly impossible if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Nov. 13, 2015, 1:21 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing (updated)
---

This is the last in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is clearly impossible if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann

Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.

2015-11-12 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
---

(Updated Nov. 13, 2015, 1:22 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
---

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing (updated)
---

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is clearly impossible if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann