-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
-----------------------------------------------------------

(Updated Nov. 14, 2015, 12:26 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Changes
-------

Rebase.


Bugs: MESOS-3065
    https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
-------

Fixed handling of multiple offer operations in 
PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs (updated)
-----

  src/tests/persistent_volume_tests.cpp 
8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing
-------

This is the sixth in a chain of 7 patches. This patch was required in order to 
fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage` test, which 
was broken by the addition of authorization to the `CREATE` and `DESTROY` offer 
operations. The test was previously both creating and destroying a persistent 
volume in a single `acceptOffer` message. However, our `validate` method for 
`DESTROY` offer operations correctly enforces that in order to delete a volume, 
the volume should be present in the checkpointed resources of the relevant 
Agent. This is clearly impossible if the `CREATE` and `DESTROY` operations are 
both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann

Reply via email to