Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Dec. 3, 2015, 9:29 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Removed use of function-style `print` calls as per review comments.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Review: https://reviews.apache.org/r/40445


Diffs (updated)
-

  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


NOTE TO THE COMMITTER
-

Before committing this, it is probably a good idea to check the whole code base 
again and fix any new files which do not follow the current license style. The 
commits which originally fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, line 6
> > 
> >
> > Why the introduction of the `print` function? Can't we just use `print` 
> > and `.format`?
> 
> Benjamin Bannier wrote:
> This was some drive-by future proofing. 
> 
> In python-3.0 `print` can only be called as a function (`print("foo")`) 
> and the python-2.X syntax used around here (`print "foo"`) isn't available 
> anymore. The `print` function becomes available in python-2.6.0, but in the 
> shebang we pick whatever python interpreter is in `$PATH`. If we can drop 
> support for python-2.5 or earlier (not sure if it is still supported with 
> what is in here) we don't need to import it from `__future__`.
> 
> Michael Park wrote:
> Can we take this on as a separate ticket/task? We have a bunch of python 
> scripts, all of them seem to assume Python 2.

I filed MESOS-4054, and reverted to a `print "foo"` style.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108745
---


On Dec. 3, 2015, 9:29 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 9:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

> On Dec. 3, 2015, 3:51 a.m., Michael Park wrote:
> > support/mesos-style.py, lines 152-153
> > 
> >
> > Why not `print`?

Using `print "foo"`-style now (for local consistency).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108772
---


On Dec. 3, 2015, 9:29 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 9:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108805
---


Patch looks great!

Reviews applied: [39590, 39591, 39592, 40445]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 3, 2015, 9:29 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 9:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Dec. 3, 2015, 1:06 p.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Used `str.format` as suggested out-of-band by mcypark.

Also fixed a faulty regex to now actually display `cpplint` issues.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This adds a style check for license headers in C, C++, and Proto files.


Diffs (updated)
-

  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing (updated)
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).

`make check` under OS X 10.10.5 succeeded modulo MESOS-4045.


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108854
---

Ship it!


Ship It!

- Michael Park


On Dec. 3, 2015, 1:06 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 1:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds a style check for license headers in C, C++, and Proto files.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> `make check` under OS X 10.10.5 succeeded modulo MESOS-4045.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Michael Park]

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, line 6
> > 
> >
> > Why the introduction of the `print` function? Can't we just use `print` 
> > and `.format`?
> 
> Benjamin Bannier wrote:
> This was some drive-by future proofing. 
> 
> In python-3.0 `print` can only be called as a function (`print("foo")`) 
> and the python-2.X syntax used around here (`print "foo"`) isn't available 
> anymore. The `print` function becomes available in python-2.6.0, but in the 
> shebang we pick whatever python interpreter is in `$PATH`. If we can drop 
> support for python-2.5 or earlier (not sure if it is still supported with 
> what is in here) we don't need to import it from `__future__`.

Can we take this on as a separate ticket/task? We have a bunch of python 
scripts, all of them seem to assume Python 2.


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108745
---


On Dec. 3, 2015, 12:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108772
---



support/mesos-style.py (lines 126 - 127)


Why not `print`?


- Michael Park


On Dec. 3, 2015, 12:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Dec. 3, 2015, 12:02 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Addressed review comments.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/40445


Diffs (updated)
-

  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


NOTE TO THE COMMITTER
-

Before committing this, it is probably a good idea to check the whole code base 
again and fix any new files which do not follow the current license style. The 
commits which originally fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108745
---



support/mesos-style.py (line 5)


Why the introduction of the `print` function? Can't we just use `print` and 
`.format`?



support/mesos-style.py (lines 63 - 64)


Is this meant to be commented out?



support/mesos-style.py (lines 74 - 75)


Why the change here?



support/mesos-style.py (line 91)


Do we allow arbitrary whitespace `\s`? or do we want to lock it down to 
exactly one space character?


- Michael Park


On Dec. 2, 2015, 11:18 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 2, 2015, 11:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, line 6
> > 
> >
> > Why the introduction of the `print` function? Can't we just use `print` 
> > and `.format`?

This was some drive-by future proofing. 

In python-3.0 `print` can only be called as a function (`print("foo")`) and the 
python-2.X syntax used around here (`print "foo"`) isn't available anymore. The 
`print` function becomes available in python-2.6.0, but in the shebang we pick 
whatever python interpreter is in `$PATH`. If we can drop support for 
python-2.5 or earlier (not sure if it is still supported with what is in here) 
we don't need to import it from `__future__`.


> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, lines 83-84
> > 
> >
> > Is this meant to be commented out?

I removed this intentionally as it was purely `cpplint` specific (but missed 
nuking the commented code). The idea here was that as `mesos-style` wraps other 
checks we should not need to act like a thin wrapper around `cpplint` anymore. 
I added a more generic header below.


> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, lines 95-96
> > 
> >
> > Why the change here?

The old regex matched interesting lines by just looking for a `:` somewhere 
which let the total `cpplint` error count slip through (it was useful for a 
thin wrapper around `cpplint`). We now calculate and output our own, combined 
error count so we should remove the one from `cpplint`.

I replaced this construct with a simple regex.


> On Dec. 2, 2015, 11:31 p.m., Michael Park wrote:
> > support/mesos-style.py, line 112
> > 
> >
> > Do we allow arbitrary whitespace `\s`? or do we want to lock it down to 
> > exactly one space character?

Good point, this can be tightened.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108745
---


On Dec. 3, 2015, 12:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108634
---


Patch looks great!

Reviews applied: [39590, 39591, 39592, 40445]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 2, 2015, 11:18 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 2, 2015, 11:18 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Dec. 2, 2015, 11:18 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Moved license check into `mesos-style.py`.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs (updated)
-

  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


NOTE TO THE COMMITTER
-

Before committing this, it is probably a good idea to check the whole code base 
again and fix any new files which do not follow the current license style. The 
commits which originally fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108767
---


Patch looks great!

Reviews applied: [39590, 39591, 39592, 40445]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 3, 2015, 12:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Dec. 3, 2015, 12:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Review: https://reviews.apache.org/r/40445
> 
> 
> Diffs
> -
> 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108523
---


Why do we want to introduce a `mesos-license.py` rather than simply augmenting 
`mesos-style.py`?


support/mesos-style.py (line 106)


Isn't `run_license_check` undefined here?


- Michael Park


On Nov. 27, 2015, 10:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 27, 2015, 10:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108214
---


Patch looks great!

Reviews applied: [39590, 39591, 39592, 40445]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 27, 2015, 10:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 27, 2015, 10:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Marco Massenzio]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108054
---



support/mesos-license.py (line 29)


best not to have spaces in the logger's name



support/mesos-license.py (line 30)


is this dead code? please remove
However, I'd like to see the log-level to be set to INFO by defaul and 
driven by customer option (eg, a --debug or -v,--verbose flag) to be DEBUG 
on-demand.



support/mesos-license.py (line 36)


blank line between method definition

IMO both methods are redundant, but please derive it from `Exception` 
(instead of `BaseEx`) unless you have a good reason for it.



support/mesos-license.py (line 39)


please add epydoc to the method and explain what the @param is supposed to 
be (also @type)



support/mesos-license.py (lines 43 - 47)


this is a bit on the ugly side of things :)
and not very readable either (not to mention, not very extensible).

Ideally, on would use a combination of RegEx and a comprehension list.


- Marco Massenzio


On Nov. 25, 2015, 9:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 25, 2015, 9:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

> On Nov. 27, 2015, 8:48 a.m., Marco Massenzio wrote:
> > support/mesos-license.py, line 30
> > 
> >
> > is this dead code? please remove
> > However, I'd like to see the log-level to be set to INFO by defaul and 
> > driven by customer option (eg, a --debug or -v,--verbose flag) to be DEBUG 
> > on-demand.

I have added an command line option making this settable from the outside 
(which was also a good reason to provide meaningful help output).


> On Nov. 27, 2015, 8:48 a.m., Marco Massenzio wrote:
> > support/mesos-license.py, lines 43-47
> > 
> >
> > this is a bit on the ugly side of things :)
> > and not very readable either (not to mention, not very extensible).
> > 
> > Ideally, on would use a combination of RegEx and a comprehension list.

I am unsure if for something like this with a regexp we do not suddenly have 
two problems.

I changed the implementation to use a regexp nevertheless; I'll leave verdict 
on the final readability to the reviewer.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108054
---


On Nov. 27, 2015, 10:52 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 27, 2015, 10:52 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Nov. 27, 2015, 10:52 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Addressed review comments.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs (updated)
-

  support/mesos-license.py PRE-CREATION 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


NOTE TO THE COMMITTER
-

Before committing this, it is probably a good idea to check the whole code base 
again and fix any new files which do not follow the current license style. The 
commits which originally fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review108032
---


Patch looks great!

Reviews applied: [39590, 39591, 39592, 40445]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 25, 2015, 9:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 25, 2015, 9:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Nov. 25, 2015, 8:55 a.m.)


Review request for mesos, Benjamin Hindman and Marco Massenzio.


Changes
---

Now call mesos-license from mesos-style.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs (updated)
-

  support/mesos-license.py PRE-CREATION 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Nov. 25, 2015, 9:49 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Addressed out-of-band review comments from @tillt.

Also, added @mcypark as reviewer.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs (updated)
-

  support/mesos-license.py PRE-CREATION 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

(Updated Nov. 25, 2015, 9:59 a.m.)


Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.


Changes
---

Fixed one style of one more `TODO`.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs (updated)
-

  support/mesos-license.py PRE-CREATION 
  support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 

Diff: https://reviews.apache.org/r/40445/diff/


Testing (updated)
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


NOTE TO THE COMMITTER
-

Before committing this, it is probably a good idea to check the whole code base 
again and fix any new files which do not follow the current license style. The 
commits which originally fixed this were

* fa36917 (mesos),
* dc23756 (stout), and
* 3539b7a (libprocess).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107957
---


LGMT!

- Till Toenshoff


On Nov. 25, 2015, 9:59 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 25, 2015, 9:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/mesos-license.py PRE-CREATION 
>   support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> NOTE TO THE COMMITTER
> -
> 
> Before committing this, it is probably a good idea to check the whole code 
> base again and fix any new files which do not follow the current license 
> style. The commits which originally fixed this were
> 
> * fa36917 (mesos),
> * dc23756 (stout), and
> * 3539b7a (libprocess).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Vinod Kone]

> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote:
> > support/hooks/post-rewrite, line 33
> > 
> >
> > instead of calling this script directly, i would recommend calling it 
> > from mesos-style.py. this way users and tools (review bot) can run just one 
> > script to test compliance.
> 
> Benjamin Bannier wrote:
> We do already call two scripts from the hooks ATM (one to wrap 
> `cpplint.py`, and one to check for properly split commits across libraries). 
> Looking at `mesos-style.py`, its logic is pretty much tied to just running 
> `cpplint` and parsing its output -- do you really mean we should rewrite all 
> of that?
> 
> Note that users can always manually run the hooks.

I just meant to call mesos-license.py from mesos-style.py because it is 
essentially a style checker. This just adds ~1 line to mesos-style.py. The 
reason I suggested this because if there are multiple scripts to run to check 
conformance, it will be hard to track. For example, review bot manually runs 
`./support/mesos-style.py` before doing `make check`. I would like to avoid 
updating review bot, everytime someone adds a new script to improve style 
checking. It would be also easy for  us to tell users to run this single script 
to check sytle (they might want to check before doing commit). 

The reason split commits checker has its own line in the commit hook is because 
it only comes into play when committing. For example, you wouldn't (couldn't) 
run that script on a freshly cloned repo. This is the same reason review bot 
doesn't run that checker.

Does that make sense?


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
---


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

> On Nov. 18, 2015, 6:21 p.m., Vinod Kone wrote:
> > support/hooks/post-rewrite, line 33
> > 
> >
> > instead of calling this script directly, i would recommend calling it 
> > from mesos-style.py. this way users and tools (review bot) can run just one 
> > script to test compliance.

We do already call two scripts from the hooks ATM (one to wrap `cpplint.py`, 
and one to check for properly split commits across libraries). Looking at 
`mesos-style.py`, its logic is pretty much tied to just running `cpplint` and 
parsing its output -- do you really mean we should rewrite all of that?

Note that users can always manually run the hooks.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
---


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Review Request 40445: Added linter for license headers in some file types.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/
---

Review request for mesos, Benjamin Hindman and Marco Massenzio.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

Added linter for license headers in some file types.


Diffs
-

  support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
  support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
  support/mesos-license.py PRE-CREATION 

Diff: https://reviews.apache.org/r/40445/diff/


Testing
---

Ran the a whole clean checkout through the linter with only one expected 
failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
license).


Thanks,

Benjamin Bannier

Re: Review Request 40445: Added linter for license headers in some file types.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40445/#review107061
---



support/hooks/post-rewrite (line 33)


instead of calling this script directly, i would recommend calling it from 
mesos-style.py. this way users and tools (review bot) can run just one script 
to test compliance.


- Vinod Kone


On Nov. 18, 2015, 4:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40445/
> ---
> 
> (Updated Nov. 18, 2015, 4:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added linter for license headers in some file types.
> 
> 
> Diffs
> -
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
>   support/mesos-license.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40445/diff/
> 
> 
> Testing
> ---
> 
> Ran the a whole clean checkout through the linter with only one expected 
> failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a 
> license).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>