Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated April 1, 2016, 3:38 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Changes
---

Updated testing section.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs
-

  include/mesos/mesos.proto 59f5d3aadd1cb32c1eb869451ad55d877bdeee28 
  include/mesos/v1/mesos.proto 6556a1c243d227fdb9af0d3c1063fed08d3f6c8b 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/44660/diff/


Testing (updated)
---

On CentOS 7.2.1511:
`make check`

To test the newly introduced protobuf fields, I've modified "mesos-execute" to
support these fields. I've inserted these lines in `offers()` method:
```
task.mutable_kill_policy()->mutable_grace_period()->
set_nanoseconds(Seconds().ns());
```

I've also implemented a "--no-shell" flag to support
setting `CommandInfo.shell` to `false`. An example command used in testing:
```
./src/mesos-execute --master=192.99.40.208:5551 --name=test --no-shell 
--env='{"GLOG_v": 1}' --containerizer=docker 
--docker_image=rukletsov/unresponsive-process
```

Mesos master is launched via:
```
./bin/mesos-master.sh --work_dir=m/work --port=5551
```

Mesos agent is launched via:
```
sudo su
GLOG_v=1 ./bin/mesos-slave.sh --work_dir=/tmp --master=192.99.40.208:5551 
--port=5552 --containerizers=docker
```

In order to test the docker stop timeout, which is what the docker executor
uses currently for kill policy, I've created a tiny application that ignores
SIGTERM (https://github.com/rukletsov/unresponsive-process ), wrapped it in a
docker container and published on docker hub
(https://hub.docker.com/r/rukletsov/unresponsive-process/ ).

Test 1.1

`KillPolicy.grace_period` is **not set**, `shell=false`, framework shutdown.
Framework is asked to shutdown several seconds after the task is started. This
results in agent asking executor to shutdown. From the agent's logs, we see that
the command executor sends a TASK_KILLED update in approx. **3 seconds** (the
default value is **5 seconds**, but we deduct some buffer to make sure the task 
can
be reaped and TASK_KILLED is sent) after it has been asked to shut down:
```
I0401 10:40:08.641249 13266 slave.cpp:2215] Asked to shut down framework 
1615ae6e-e907-4296-8d46-d864fae3359b- by master@192.99.40.208:5551
I0401 10:40:08.641286 13266 slave.cpp:2240] Shutting down framework 
1615ae6e-e907-4296-8d46-d864fae3359b-
I0401 10:40:08.641402 13266 slave.cpp:4398] Shutting down executor 'test' of 
framework 1615ae6e-e907-4296-8d46-d864fae3359b- at 
executor(1)@192.99.40.208:51023
I0401 10:40:11.837626 13271 slave.cpp:3184] Handling status update TASK_KILLED 
(UUID: e3388b10-6bd0-4571-ad08-30b77550392e) for task test of framework 
1615ae6e-e907-4296-8d46-d864fae3359b- from exec
utor(1)@192.99.40.208:51023
```

In an excerpt from the executor's log we see, that docker timeout is set to 3s:
```
I0401 10:40:08.641784 13360 exec.cpp:399] Executor asked to shutdown
I0401 10:40:08.641891 13368 exec.cpp:91] Scheduling shutdown of the executor in 
5secs
I0401 10:40:08.641902 13360 exec.cpp:414] Executor::shutdown took 19573ns
I0401 10:40:08.642026 13365 docker.cpp:134] 'docker -H 
unix:///var/run/docker.sock run --cpu-shares 1024 --memory 134217728 -e 
GLOG_v=2 -e MESOS_SANDBOX=/mnt/mesos/sandbox -e 
MESOS_CONTAINER_NAME=mesos-ef6f8d28-d279-40f7-b66a-f9659ca72299-S1.379cbab7-1ba4-4901-b8fa-b717bd1493f4
 -v 
/tmp/slaves/ef6f8d28-d279-40f7-b66a-f9659ca72299-S1/frameworks/1615ae6e-e907-4296-8d46-d864fae3359b-/executors/test/runs/379cbab7-1ba4-4901-b8fa-b717bd1493f4:/mnt/mesos/sandbox
 --net host --name 
mesos-ef6f8d28-d279-40f7-b66a-f9659ca72299-S1.379cbab7-1ba4-4901-b8fa-b717bd1493f4
 rukletsov/unresponsive-process' is being discarded
I0401 10:40:08.667981 13365 docker.cpp:712] Running docker -H 
unix:///var/run/docker.sock stop -t 3 
mesos-ef6f8d28-d279-40f7-b66a-f9659ca72299-S1.379cbab7-1ba4-4901-b8fa-b717bd1493f4
I0401 10:40:11.836829 13363 exec.cpp:535] Executor sending status update 
TASK_KILLED (UUID: e3388b10-6bd0-4571-ad08-30b77550392e) for task test of 
framework 1615ae6e-e907-4296-8d46-d864fae3359b-
```

Test 1.2

`KillPolicy.grace_period` is **not set**, `shell=true`, framework shutdown.
The only difference to test 1.1 is `shell=true` and as required by Mesos in this
case, `command` is set to container's entrypoint. Similar behavior is observed:
```
I0401 11:00:41.629098 14162 exec.cpp:312] Executor 

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 24, 2016, 4:18 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs (updated)
-

  include/mesos/mesos.proto 59f5d3aadd1cb32c1eb869451ad55d877bdeee28 
  include/mesos/v1/mesos.proto 6556a1c243d227fdb9af0d3c1063fed08d3f6c8b 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review125185
---


Fix it, then Ship it!





include/mesos/mesos.proto (lines 359 - 360)


`s/-t/--time/` here and elsewhere?



src/docker/executor.cpp (lines 200 - 205)


This is for backwards compatibility, right? I wouldn't expect the shutdown 
timeout to impact the kill timeout since no shutdown is occuring, so that might 
surprise others and its worth saying why we do this.


- Ben Mahler


On March 23, 2016, 11:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 23, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
>   include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review124353
---



Sorry I forgot to publish some stale comments from before, these are partial 
and may be out-of-date but figured you may find them useful.


include/mesos/mesos.proto (line 360)


For docker executor-less tasks?



include/mesos/mesos.proto (line 361)


To be more helpful s/-t/--time/



include/mesos/mesos.proto (line 1247)


ditto here, the user doesn't know about the docker executor



include/mesos/v1/mesos.proto (lines 358 - 1244)


Ditto here.



include/mesos/v1/mesos.proto (line 361)


To be more helpful s/-t/--time/



src/docker/executor.cpp (lines 216 - 242)


It's not immediately clear to me why the approach taken here is different 
from the approach taken in the command executor:

In the command executor, the kill policy overrides the shutdown grace 
period. In the docker executor, we still take the minimum of the kill policy 
and the shutdown grace period.

After thinking about it, I assume it's because you want to respect the 
--docker_stop_timeout flag when it's set to a smaller value than the kill 
policy? If so, please document why we have the minimum logic, because in the 
command executor there is an assumption that we never need to take a minimum of 
the shutdown grace period and the kill policy.



src/docker/executor.cpp (line 222)


Let's say --time to be more clear than -t



src/docker/executor.cpp (lines 236 - 239)


I added this TODO for killTask, can you help by clarifying that the 
shutdown arrives after a kill task?



src/docker/executor.cpp (line 630)


It doesn't crash it just exits :)



src/docker/executor.cpp (line 631)


removing flags is also difficult :)


- Ben Mahler


On March 23, 2016, 11:25 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 23, 2016, 11:25 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
>   include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 23, 2016, 11:25 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Changes
---

Rebased.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs (updated)
-

  include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
  include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 22, 2016, 5:13 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs (updated)
-

  include/mesos/mesos.proto b965f5a6b1aff28feb2ab088c30ea927b9247403 
  include/mesos/v1/mesos.proto d2ab6ed187ec0d0e5dbac92607b612bb55b1a682 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review124112
---




src/docker/executor.cpp (line 226)


This should fit 80 char width?


- Timothy Chen


On March 15, 2016, 4:04 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 15, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 101-105
> > 
> >
> > Ditto feedback from previous reviews about this no longer being a 
> > default.

Per offline discussion, we decided to drop this code altogether. The env var 
has the actual value. If the env var is not set, the agent is pre 0.28 and it 
doesn't support custom shutdown grace periods anyway, so even if ExecutorInfo 
specifies the custom grace period, we can ignore it.


> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 235-239
> > 
> >
> > Ditto earlier comments. I would expect the buffer to be in addition to 
> > the reap interval. It also wasn't obvious to me that docker->run uses the 
> > reaper internally, so perhaps a note here about that.
> > 
> > At some point we'll make reaping children be non-polling :)

I'm a bit hesitant to add the comment here about how `docker->run()` works. 
Such comments tend to become outdated when the internal implementation changes.


> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 657-663
> > 
> >
> > Hm.. ideally we could ignore the docker stop flag if a kill policy was 
> > set, because the user is being explicit about how much time they need. This 
> > is the same as how we ignore the executor shutdown grace period flag if the 
> > executor explicitly sets one.

Yes, that would be ideal. However, we'll learn about kill policy only later, 
when the task is launched. The case when the user sets both the docker stop 
timeout and the killpolicy, and the kill policy is smaller than the docker flag 
seems to be rare to me. Moreover, in such case we give *not less* time than 
requested. I'd suggest to leave this as is as opposed to saving the docker flag 
value and deciding later whether we need it or not.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review123782
---


On March 15, 2016, 4:04 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 15, 2016, 4:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 18, 2016, 5:21 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs (updated)
-

  include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
  include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
  src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Ben Mahler]

> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 235-239
> > 
> >
> > Ditto earlier comments. I would expect the buffer to be in addition to 
> > the reap interval. It also wasn't obvious to me that docker->run uses the 
> > reaper internally, so perhaps a note here about that.
> > 
> > At some point we'll make reaping children be non-polling :)
> 
> Alexander Rukletsov wrote:
> I'm a bit hesitant to add the comment here about how `docker->run()` 
> works. Such comments tend to become outdated when the internal implementation 
> changes.

The point I was trying to make was that you essentially already have this 
comment in the code itself:

```
Option gracePeriod = min(
shutdownGracePeriod - process::MAX_REAP_INTERVAL(),
killPolicyGracePeriod);
```

We're using the reap interval, so that means we're assuming docker->run 
involves the reap interval already, the comment was just to reflect this 
assumption :)


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review123782
---


On March 18, 2016, 5:21 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 18, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Ben Mahler]

> On March 15, 2016, 11:21 p.m., Ben Mahler wrote:
> > src/docker/executor.cpp, lines 657-663
> > 
> >
> > Hm.. ideally we could ignore the docker stop flag if a kill policy was 
> > set, because the user is being explicit about how much time they need. This 
> > is the same as how we ignore the executor shutdown grace period flag if the 
> > executor explicitly sets one.
> 
> Alexander Rukletsov wrote:
> Yes, that would be ideal. However, we'll learn about kill policy only 
> later, when the task is launched. The case when the user sets both the docker 
> stop timeout and the killpolicy, and the kill policy is smaller than the 
> docker flag seems to be rare to me. Moreover, in such case we give *not less* 
> time than requested. I'd suggest to leave this as is as opposed to saving the 
> docker flag value and deciding later whether we need it or not.

Sounds good.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/#review123782
---


On March 18, 2016, 5:21 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44660/
> ---
> 
> (Updated March 18, 2016, 5:21 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.
> 
> 
> Bugs: MESOS-4909
> https://issues.apache.org/jira/browse/MESOS-4909
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The docker executor determines how much time it allots the
> underlying container to clean up (via passing the timeout to
> the docker daemon) based on both optional task's `KillPolicy`
> and optional `shutdown_grace_period` field in `ExecutorInfo`.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto deb9c0910a27afd67276f54b3f666a878212727b 
>   include/mesos/v1/mesos.proto a981e750c24cfc48177bbc9ca56f0c3ecfae1a1b 
>   src/docker/executor.cpp afc769d0887e3842106e4c350e94c95c8ffc085e 
> 
> Diff: https://reviews.apache.org/r/44660/diff/
> 
> 
> Testing
> ---
> 
> The complete chain was tested. See https://reviews.apache.org/r/44662/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 15, 2016, 4:04 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description (updated)
---

The docker executor determines how much time it allots the
underlying container to clean up (via passing the timeout to
the docker daemon) based on both optional task's `KillPolicy`
and optional `shutdown_grace_period` field in `ExecutorInfo`.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 15, 2016, 2:28 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 14, 2016, 5:50 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Re: Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

(Updated March 11, 2016, 4 p.m.)


Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov

Review Request 44660: Used `KillPolicy` and shutdown grace period in docker executor.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44660/
---

Review request for mesos, Ben Mahler, Gilbert Song, and Timothy Chen.


Bugs: MESOS-4909
https://issues.apache.org/jira/browse/MESOS-4909


Repository: mesos


Description
---

See summary.


Diffs
-

  src/docker/executor.cpp 1921d4a1ce3c45b4e2f81f0ef5914d5830da6866 

Diff: https://reviews.apache.org/r/44660/diff/


Testing
---

The complete chain was tested. See https://reviews.apache.org/r/44662/.


Thanks,

Alexander Rukletsov