Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

(Updated April 22, 2016, 4:40 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Address @neilc's comments.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs (updated)
-

  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130112
---


Fix it, then Ship it!




Ship It!


src/master/http.cpp (line 2339)


"was successful"



src/master/http.cpp (line 2455)


"was successful"


- Neil Conway


On April 22, 2016, 4:11 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

(Updated April 22, 2016, 4:11 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Address @neilc's comments.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs (updated)
-

  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

> On April 22, 2016, 3:11 p.m., Neil Conway wrote:
> >
> 
> haosdent huang wrote:
> Hi, @neilc. Thank you very much for your detail comments! I saw you use 
> `is xxed` in some comments while use `was xxed` in others. Should I change 
> all of them to `was xxed` to keep consistent?
> 
> Neil Conway wrote:
> Good point -- I don't have a strong preference on using "is" vs. "was", 
> but it would be good to pick one and use it consistently. I suppose "was" is 
> slightly more accurate?

Got it. Appreciated your comments again(you are the real author of this patch)!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---


On April 22, 2016, 3:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[Neil Conway]

> On April 22, 2016, 3:11 p.m., Neil Conway wrote:
> >
> 
> haosdent huang wrote:
> Hi, @neilc. Thank you very much for your detail comments! I saw you use 
> `is xxed` in some comments while use `was xxed` in others. Should I change 
> all of them to `was xxed` to keep consistent?

Good point -- I don't have a strong preference on using "is" vs. "was", but it 
would be good to pick one and use it consistently. I suppose "was" is slightly 
more accurate?


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---


On April 22, 2016, 3:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 3:48 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

(Updated April 22, 2016, 3:48 p.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Address @neilc's comments.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs (updated)
-

  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[Neil Conway]

> On April 22, 2016, 3:11 p.m., Neil Conway wrote:
> > src/master/http.cpp, line 1307
> > 
> >
> > "Returns 200 OK when the weight update was successful."
> 
> haosdent huang wrote:
> Should it be `the weights update` here?

Yes, thanks!


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

> On April 22, 2016, 3:11 p.m., Neil Conway wrote:
> >

Hi, @neilc. Thank you very much for your detail comments! I saw you use `is 
xxed` in some comments while use `was xxed` in others. Should I change all of 
them to `was xxed` to keep consistent?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

> On April 22, 2016, 3:11 p.m., Neil Conway wrote:
> > src/master/http.cpp, line 1307
> > 
> >
> > "Returns 200 OK when the weight update was successful."

Should it be `the weights update` here?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130099
---




src/master/http.cpp (line 335)


Can we use the same phrasing ("if the leading master cannot be found") here 
as we do below?



src/master/http.cpp (line 690)


Lowercase "r" in "redirect", here and below.



src/master/http.cpp (line 795)


"when the frameworks info is queried successfully."



src/master/http.cpp (line 1175)


"Returns 200 OK when the request is processed successfully."



src/master/http.cpp (line 1259)


"Returns 200 OK when the quota has been changed successfully."



src/master/http.cpp (line 1307)


"Returns 200 OK when the weight update was successful."



src/master/http.cpp (line 1350)


"Returns 200 OK when the state of the master was queried successfully."



src/master/http.cpp (line 1706)


"Returns 200 OK when a summary of the master's state was queried 
successfully."



src/master/http.cpp (line 1836)


"Returns 200 OK when information about roles was queried successfully."



src/master/http.cpp (line 1957)


Not years, but "Returns 200 OK if the framework was torn down successfully."



src/master/http.cpp (line 2054)


"Returns 200 OK when task information was queried successfully."



src/master/http.cpp (line 2188)


"when maintenance successfully" is ungrammatical. "when the requested 
maintenance operation was performed successfully."



src/master/http.cpp (line 2337)


"Returns 200 OK when the operation is successful."



src/master/http.cpp (line 2453)


"Returns 200 OK when the operation is successful."



src/master/http.cpp (line 2568)


"Returns 200 OK when the maintenance status was queried successfully."


- Neil Conway


On April 22, 2016, 7:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 22, 2016, 7:18 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

(Updated April 22, 2016, 7:18 a.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Fix style error and rebase.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs (updated)
-

  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

(Updated April 22, 2016, 4:10 a.m.)


Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Changes
---

Address @vinodkone's comments.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs (updated)
-

  src/master/http.cpp de06985cafc93022fffc0d13812a119ae43b7e57 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/#review130004
---




src/master/http.cpp (line 335)


s/if could not find the leading master/if the leading master cannot be 
found/

here and everywhere else.


- Vinod Kone


On April 21, 2016, 4:10 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46471/
> ---
> 
> (Updated April 21, 2016, 4:10 a.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
> Neil Conway, and Vinod Kone.
> 
> 
> Bugs: MESOS-1865
> https://issues.apache.org/jira/browse/MESOS-1865
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
> `SERVICE_UNAVAILABLE` when current master is not the leader.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 
> 
> Diff: https://reviews.apache.org/r/46471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 46471: Updated descriptions for master endpoints which may return redirect.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46471/
---

Review request for mesos, Adam B, Anand Mazumdar, Cody Maloney, Ian Downes, 
Neil Conway, and Vinod Kone.


Bugs: MESOS-1865
https://issues.apache.org/jira/browse/MESOS-1865


Repository: mesos


Description
---

Update master endpoints descriptions about `TEMPORARY_REDIRECT` and
`SERVICE_UNAVAILABLE` when current master is not the leader.


Diffs
-

  src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 

Diff: https://reviews.apache.org/r/46471/diff/


Testing
---


Thanks,

haosdent huang