Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

2016-10-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49833/#review152757
---




3rdparty/stout/tests/flags_tests.cpp (line 836)


Remove extraneous newline.



3rdparty/stout/tests/flags_tests.cpp (lines 843 - 848)


We need to remove these flags which are from `TestFlags`.


- Michael Park


On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49833/
> ---
> 
> (Updated Oct. 6, 2016, 2:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order for different `Flags` classes to be composable classes should
> always use virtual inheritance.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/flags_tests.cpp 
> 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/49833/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

2016-10-14 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49833/#review152753
---


Ship it!




Ship It!

- Michael Park


On Oct. 6, 2016, 2:58 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49833/
> ---
> 
> (Updated Oct. 6, 2016, 2:58 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3335
> https://issues.apache.org/jira/browse/MESOS-3335
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In order for different `Flags` classes to be composable classes should
> always use virtual inheritance.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/flags_tests.cpp 
> 94ba915c40836e476cf6097274a85c55acd4d73b 
>   3rdparty/stout/tests/subcommand_tests.cpp 
> 9213d6b9faec30b5be320ab37ca29c2406c964ac 
> 
> Diff: https://reviews.apache.org/r/49833/diff/
> 
> 
> Testing
> ---
> 
> Tested as part of the review chain ending in 
> https://reviews.apache.org/r/52388/ on various Linux configurations in 
> internal CI.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

2016-10-06 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49833/
---

(Updated Oct. 6, 2016, 4:58 p.m.)


Review request for mesos and Michael Park.


Changes
---

Rebased.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description (updated)
---

In order for different `Flags` classes to be composable classes should
always use virtual inheritance.


Diffs (updated)
-

  3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/49833/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier

Review Request 49833: Consistently used virtual inheritance for Flags classes in stout.

2016-09-29 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49833/
---

Review request for mesos and Michael Park.


Bugs: MESOS-3335
https://issues.apache.org/jira/browse/MESOS-3335


Repository: mesos


Description
---

In order for different `Flags` classes to be composable classes should
always use virtual inheritance. stout provides the helper template
`flags::Flags` for this purpose.

Here we use inheritance from `flags::Flags` instantiations for all
derived classes, for consistency even in cases where `Flags` classes
are currently not inherited from, or do not use multiple inheritance.


Diffs
-

  3rdparty/stout/tests/flags_tests.cpp 94ba915c40836e476cf6097274a85c55acd4d73b 
  3rdparty/stout/tests/subcommand_tests.cpp 
9213d6b9faec30b5be320ab37ca29c2406c964ac 

Diff: https://reviews.apache.org/r/49833/diff/


Testing
---

Tested as part of the review chain ending in 
https://reviews.apache.org/r/52388/ on various Linux configurations in internal 
CI.


Thanks,

Benjamin Bannier