Re: Review Request 49924: Added libprocess as a shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review148099
---



Patch looks great!

Reviews applied: [49688, 49862, 49863, 49870, 49874, 49921, 49924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 7, 2016, 6:33 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> ---
> 
> (Updated Sept. 7, 2016, 6:33 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch allow to build libprocess as shared library on OSX and Linux
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
> http_parser and libprocess to shared libraries and we are using libevent 
> shared library, zookeeper does not have a shared library in the 3rdparty (I 
> guess the code is compiled as relocatable) and did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49924: Added libprocess as a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/
---

(Updated Sept. 7, 2016, 6:33 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

This patch allow to build libprocess as shared library on OSX and Linux


Diffs (updated)
-

  3rdparty/libprocess/src/CMakeLists.txt 
d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/49924/diff/


Testing
---

cmake .. && make

With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
http_parser and libprocess to shared libraries and we are using libevent shared 
library, zookeeper does not have a shared library in the 3rdparty (I guess the 
code is compiled as relocatable) and did not have issues linking.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49924: Added libprocess as a shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review145062
---



Patch looks great!

Reviews applied: [49688, 49862, 49863, 49870, 49874, 49921, 49924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 8, 2016, 5:25 a.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> ---
> 
> (Updated Aug. 8, 2016, 5:25 a.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch allow to build libprocess as shared library on OSX and Linux
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
> http_parser and libprocess to shared libraries and we are using libevent 
> shared library, zookeeper does not have a shared library in the 3rdparty (I 
> guess the code is compiled as relocatable) and did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49924: Added libprocess as a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/
---

(Updated Aug. 8, 2016, 5:25 a.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description (updated)
---

This patch allow to build libprocess as shared library on OSX and Linux


Diffs (updated)
-

  3rdparty/libprocess/src/CMakeLists.txt 
d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/49924/diff/


Testing
---

cmake .. && make

With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
http_parser and libprocess to shared libraries and we are using libevent shared 
library, zookeeper does not have a shared library in the 3rdparty (I guess the 
code is compiled as relocatable) and did not have issues linking.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49924: Added libprocess as a shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review144586
---



Bad patch!

Reviews applied: [49924, 49921, 49874, 49870, 49863, 49862, 49688]

Failed command: ./support/apply-review.sh -n -r 49863

Error:
2016-08-03 06:14:57 URL:https://reviews.apache.org/r/49863/diff/raw/ 
[12706/12706] -> "49863.patch" [1]
error: patch failed: src/CMakeLists.txt:501
error: src/CMakeLists.txt: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/14610/console

- Mesos ReviewBot


On Aug. 2, 2016, 9:41 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> ---
> 
> (Updated Aug. 2, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libprocess as a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> d1547ef6a8762385f653d3824307727e4d0a7e71 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
> http_parser and libprocess to shared libraries and we are using libevent 
> shared library, zookeeper does not have a shared library in the 3rdparty (I 
> guess the code is compiled as relocatable) and did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49924: Added libprocess as a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/
---

(Updated Aug. 2, 2016, 9:41 p.m.)


Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added libprocess as a shared library.


Diffs (updated)
-

  3rdparty/libprocess/src/CMakeLists.txt 
d1547ef6a8762385f653d3824307727e4d0a7e71 

Diff: https://reviews.apache.org/r/49924/diff/


Testing
---

cmake .. && make

With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
http_parser and libprocess to shared libraries and we are using libevent shared 
library, zookeeper does not have a shared library in the 3rdparty (I guess the 
code is compiled as relocatable) and did not have issues linking.


Thanks,

Srinivas Brahmaroutu

Re: Review Request 49924: Added libprocess as a shared library.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review141842
---




3rdparty/libprocess/src/CMakeLists.txt (line 90)


Same question as the comment in the similar review, #49862. I will quote 
again here for posterity, in case future contributors need to know the context, 
but I expect the discussion to carry on there.

>Changing the linking structure of this project has a few very important 
implications for Windows, and we will need to proceed extremely cautiously. 
Before we get into it, could you please explain explain what the immediate 
reason for the patch is? It would be helpful also to have this justification 
captured in the commit description, so that it appears in git log.


- Alex Clemmer


On July 11, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> ---
> 
> (Updated July 11, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libprocess as a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 6641acf1a0ab62bdb836d5259b885d1a987b45f1 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
> http_parser and libprocess to shared libraries and we are using libevent 
> shared library, zookeeper does not have a shared library in the 3rdparty (I 
> guess the code is compiled as relocatable) and did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Re: Review Request 49924: Added libprocess as a shared library.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/#review141827
---



Patch looks great!

Reviews applied: [49688, 49862, 49863, 49870, 49874, 49921, 49924]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On July 11, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49924/
> ---
> 
> (Updated July 11, 2016, 8:49 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added libprocess as a shared library.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 6641acf1a0ab62bdb836d5259b885d1a987b45f1 
> 
> Diff: https://reviews.apache.org/r/49924/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
> http_parser and libprocess to shared libraries and we are using libevent 
> shared library, zookeeper does not have a shared library in the 3rdparty (I 
> guess the code is compiled as relocatable) and did not have issues linking.
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>

Review Request 49924: Added libprocess as a shared library.

[Srinivas Brahmaroutu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49924/
---

Review request for mesos, Alex Clemmer and Joseph Wu.


Bugs: MESOS-5792
https://issues.apache.org/jira/browse/MESOS-5792


Repository: mesos


Description
---

Added libprocess as a shared library.


Diffs
-

  3rdparty/libprocess/src/CMakeLists.txt 
6641acf1a0ab62bdb836d5259b885d1a987b45f1 

Diff: https://reviews.apache.org/r/49924/diff/


Testing
---

cmake .. && make

With this patch and https://reviews.apache.org/r/49862,  Converted libmesos, 
http_parser and libprocess to shared libraries and we are using libevent shared 
library, zookeeper does not have a shared library in the 3rdparty (I guess the 
code is compiled as relocatable) and did not have issues linking.


Thanks,

Srinivas Brahmaroutu