Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Vinod Kone]

> On Aug. 25, 2016, 11:42 p.m., Guangya Liu wrote:
> > src/tests/master_validation_tests.cpp, line 1811
> > 
> >
> > Here also needs an update if you quota `NetworkInfos`.

see above.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/#review146888
---


On Aug. 25, 2016, 7:34 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51437/
> ---
> 
> (Updated Aug. 25, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NetworkInfos can only be set on the task group executor.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
>   src/tests/master_validation_tests.cpp 
> 56e931c348ee7b4923e16ab8664e2b0d93bce8fc 
> 
> Diff: https://reviews.apache.org/r/51437/diff/
> 
> 
> Testing
> ---
> 
> make check -j20 GTEST_FILTER="*Validation*"
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/
---

(Updated Aug. 26, 2016, 7:07 p.m.)


Review request for mesos, Anand Mazumdar and Guangya Liu.


Changes
---

comments. NNFR.


Repository: mesos


Description
---

NetworkInfos can only be set on the task group executor.


Diffs (updated)
-

  src/master/validation.cpp 36447ffcecc94e66ee1819d5380cff541b660bef 
  src/tests/master_validation_tests.cpp 
56e931c348ee7b4923e16ab8664e2b0d93bce8fc 

Diff: https://reviews.apache.org/r/51437/diff/


Testing
---

make check -j20 GTEST_FILTER="*Validation*"


Thanks,

Vinod Kone

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Vinod Kone]

> On Aug. 25, 2016, 11:32 p.m., Guangya Liu wrote:
> > src/master/validation.cpp, line 1003
> > 
> >
> > How about
> > 
> > ```
> > return Error("'NetworkInfos' must not be set on the task");
> > ```

NetworkInfos is not a protobuf/C++ object. So didn't want to quote that.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/#review146887
---


On Aug. 25, 2016, 7:34 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51437/
> ---
> 
> (Updated Aug. 25, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NetworkInfos can only be set on the task group executor.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
>   src/tests/master_validation_tests.cpp 
> 56e931c348ee7b4923e16ab8664e2b0d93bce8fc 
> 
> Diff: https://reviews.apache.org/r/51437/diff/
> 
> 
> Testing
> ---
> 
> make check -j20 GTEST_FILTER="*Validation*"
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/#review146888
---




src/tests/master_validation_tests.cpp (line 1811)


Here also needs an update if you quota `NetworkInfos`.


- Guangya Liu


On 八月 25, 2016, 7:34 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51437/
> ---
> 
> (Updated 八月 25, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NetworkInfos can only be set on the task group executor.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
>   src/tests/master_validation_tests.cpp 
> 56e931c348ee7b4923e16ab8664e2b0d93bce8fc 
> 
> Diff: https://reviews.apache.org/r/51437/diff/
> 
> 
> Testing
> ---
> 
> make check -j20 GTEST_FILTER="*Validation*"
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/#review146887
---


Fix it, then Ship it!





src/master/validation.cpp (line 1003)


How about

```
return Error("'NetworkInfos' must not be set on the task");
```



src/tests/master_validation_tests.cpp (line 1776)


What about define a variable first and use this `resource` in both executor 
and task (#1784)?


- Guangya Liu


On 八月 25, 2016, 7:34 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51437/
> ---
> 
> (Updated 八月 25, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NetworkInfos can only be set on the task group executor.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
>   src/tests/master_validation_tests.cpp 
> 56e931c348ee7b4923e16ab8664e2b0d93bce8fc 
> 
> Diff: https://reviews.apache.org/r/51437/diff/
> 
> 
> Testing
> ---
> 
> make check -j20 GTEST_FILTER="*Validation*"
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 51437: Added validation test for task group task using NetworkInfos.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/#review146873
---



Patch looks great!

Reviews applied: [51437]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Aug. 25, 2016, 7:34 p.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51437/
> ---
> 
> (Updated Aug. 25, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NetworkInfos can only be set on the task group executor.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
>   src/tests/master_validation_tests.cpp 
> 56e931c348ee7b4923e16ab8664e2b0d93bce8fc 
> 
> Diff: https://reviews.apache.org/r/51437/diff/
> 
> 
> Testing
> ---
> 
> make check -j20 GTEST_FILTER="*Validation*"
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 51437: Added validation test for task group task using NetworkInfos.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51437/
---

Review request for mesos, Anand Mazumdar and Guangya Liu.


Repository: mesos


Description
---

NetworkInfos can only be set on the task group executor.


Diffs
-

  src/master/validation.cpp 3d2965e4cfaae075f988fd43386bd00c7d807b2e 
  src/tests/master_validation_tests.cpp 
56e931c348ee7b4923e16ab8664e2b0d93bce8fc 

Diff: https://reviews.apache.org/r/51437/diff/


Testing
---

make check -j20 GTEST_FILTER="*Validation*"


Thanks,

Vinod Kone