Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-06 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/#review179840
---


Ship it!




Ship It!

- Benjamin Hindman


On July 7, 2017, 1:02 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59127/
> ---
> 
> (Updated July 7, 2017, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 flags for Mesos agent.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
>   src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 
> 
> 
> Diff: https://reviews.apache.org/r/59127/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-06 Thread Avinash sridharan 


> On July 5, 2017, 7:57 p.m., Benjamin Hindman wrote:
> > src/slave/flags.hpp
> > Line 173 (original), 173 (patched)
> > 
> >
> > Let's keep this generic to IP not IPv4 and add validation like you did 
> > in libprocess that we currently only support IPv4.

I haven't added a validation check here since the `ip` here is just a string. 
This is anyway passed onto `libprocess` where its converted to `net::IP` and 
the validation kicks in.


> On July 5, 2017, 7:57 p.m., Benjamin Hindman wrote:
> > src/slave/flags.hpp
> > Lines 187-190 (patched)
> > 
> >
> > How about printing this out as a warning as part of some validation 
> > logic so that users that set this understand that they're not getting what 
> > they might think they're getting?

Added a `LOG(WARNING) in the flag validation.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/#review179692
---


On July 7, 2017, 1:02 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59127/
> ---
> 
> (Updated July 7, 2017, 1:02 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 flags for Mesos agent.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
>   src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 
> 
> 
> Diff: https://reviews.apache.org/r/59127/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-06 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/
---

(Updated July 7, 2017, 1:02 a.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Addressed BenH's comments.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added IPv6 flags for Mesos agent.


Diffs (updated)
-

  src/slave/flags.hpp c6803eb54e09a5497755e1e5fef2872193eacba6 
  src/slave/flags.cpp 398768656b5fa3b7c85474de2b4b008bf7b85cb3 


Diff: https://reviews.apache.org/r/59127/diff/5/

Changes: https://reviews.apache.org/r/59127/diff/4-5/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-05 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/#review179692
---




src/slave/flags.hpp
Line 173 (original), 173 (patched)


Let's keep this generic to IP not IPv4 and add validation like you did in 
libprocess that we currently only support IPv4.



src/slave/flags.hpp
Lines 181-182 (original), 181-182 (patched)


s/IPv4/IP/g



src/slave/flags.hpp
Lines 187-190 (patched)


How about printing this out as a warning as part of some validation logic 
so that users that set this understand that they're not getting what they might 
think they're getting?



src/slave/flags.cpp
Lines 1101-1104 (patched)


I'd like to make the comments be the same as for the `--ip` set of flags 
with an extra comment that currently the flag is ONLY being used to "advertise 
containers running on the IPv6 network ..." etc. Because the long term 
intention is that this will also be used for specifying a flag that we'll bind 
to?


- Benjamin Hindman


On June 29, 2017, 11:25 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59127/
> ---
> 
> (Updated June 29, 2017, 11:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 flags for Mesos agent.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
>   src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 
> 
> 
> Diff: https://reviews.apache.org/r/59127/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-06-29 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/
---

(Updated June 29, 2017, 11:25 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added IPv6 flags for Mesos agent.


Diffs (updated)
-

  src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
  src/slave/flags.cpp c84aa6724170bba46bbe8410b71d42a1626e 


Diff: https://reviews.apache.org/r/59127/diff/4/

Changes: https://reviews.apache.org/r/59127/diff/3-4/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-06-16 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/
---

(Updated June 16, 2017, 4:48 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added IPv6 flags for Mesos agent.


Diffs (updated)
-

  src/slave/flags.hpp 2f9d52e94c2c31e95208cd8b0640a5de2d2a61fd 
  src/slave/flags.cpp 93c8ffb5c822cf6c99071be7aca52a6b3d187619 


Diff: https://reviews.apache.org/r/59127/diff/3/

Changes: https://reviews.apache.org/r/59127/diff/2-3/


Testing
---

make check


Thanks,

Avinash sridharan

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-05-25 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/#review176157
---


Ship it!




Ship It!

- Benjamin Hindman


On May 10, 2017, 7:03 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59127/
> ---
> 
> (Updated May 10, 2017, 7:03 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7488
> https://issues.apache.org/jira/browse/MESOS-7488
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added IPv6 flags for Mesos agent.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd 
>   src/slave/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 
> 
> 
> Diff: https://reviews.apache.org/r/59127/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 59127: Added IPv6 flags for Mesos agent.

2017-05-10 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59127/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-7488
https://issues.apache.org/jira/browse/MESOS-7488


Repository: mesos


Description
---

Added IPv6 flags for Mesos agent.


Diffs
-

  src/slave/flags.hpp e5784ef81ad0720c7ec061ee0b28b8fadae77afd 
  src/slave/flags.cpp ed99fadbf1aa91f7f0a57c9fb351c0247a40c6f4 


Diff: https://reviews.apache.org/r/59127/diff/1/


Testing
---

make check


Thanks,

Avinash sridharan