Re: Review Request 61222: Added V1 teardown Call.

2017-08-15 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/#review182956
---


Ship it!




Ship It!

- Greg Mann


On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61222/
> ---
> 
> (Updated Aug. 3, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added V1 call support for teardown operation.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto fc5bd894ce55fe8e946d4c5b4b33d3c0505f3c2b 
>   include/mesos/v1/master/master.proto 
> c3fb31de2509adcdec8204f8bbe46b46a31540e8 
>   src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 
>   src/master/master.hpp b802fd153a10f6012cea381f153c28cc78cae995 
>   src/master/validation.cpp 279dd5137f767376db29314f116f439ad7ae342f 
> 
> 
> Diff: https://reviews.apache.org/r/61222/diff/4/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 61222: Added V1 teardown Call.

2017-08-10 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/#review182640
---




src/master/http.cpp
Lines 3766-3777 (original), 3776-3785 (patched)


Let's replace this code with

```
return __teardown(id);
```

and rename the original `_teardown()` continuation to `__teardown()`. This 
will let us avoid duplicating the `master->removeFramework` call.


- Greg Mann


On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61222/
> ---
> 
> (Updated Aug. 3, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added V1 call support for teardown operation.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983 
>   include/mesos/v1/master/master.proto 
> c04fd1602396a58086331f5fa56518c5dee9af89 
>   src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
>   src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
>   src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 
> 
> 
> Diff: https://reviews.apache.org/r/61222/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 61222: Added V1 teardown Call.

2017-08-03 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/#review182132
---




src/master/http.cpp
Lines 3776-3779 (patched)


uh oh! There is a race condition here that can crash the master. It's 
possible that the master removed the framework by the time the continuation 
function is executed :-)

Can you rename the existing teardown that exists to `__teardown` and make 
this function invoke that? Also, goes for L3751


- Anand Mazumdar


On Aug. 3, 2017, 5:56 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61222/
> ---
> 
> (Updated Aug. 3, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added V1 call support for teardown operation.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983 
>   include/mesos/v1/master/master.proto 
> c04fd1602396a58086331f5fa56518c5dee9af89 
>   src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
>   src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
>   src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 
> 
> 
> Diff: https://reviews.apache.org/r/61222/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 61222: Added V1 teardown Call.

2017-08-03 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/
---

(Updated Aug. 3, 2017, 5:56 p.m.)


Review request for mesos, Anand Mazumdar and Greg Mann.


Summary (updated)
-

Added V1 teardown Call.


Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846


Repository: mesos


Description (updated)
---

Added V1 call support for teardown operation.


Diffs (updated)
-

  include/mesos/master/master.proto 0e4c30e3df704a929a3bd2e1787a76421d14a983 
  include/mesos/v1/master/master.proto c04fd1602396a58086331f5fa56518c5dee9af89 
  src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
  src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
  src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 


Diff: https://reviews.apache.org/r/61222/diff/2/

Changes: https://reviews.apache.org/r/61222/diff/1-2/


Testing
---

make check


Thanks,

Quinn Leng

Re: Review Request 61222: Added V1 teardown call.

2017-08-02 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/#review182055
---



Thanks for addressing this tech debt! Looks good for the most part. Can you 
split the test into a separate review?


src/master/http.cpp
Lines 3791-3823 (patched)


Can this code be shared with the original `teardown()` method of the old 
API to avoid duplication?


- Anand Mazumdar


On July 28, 2017, 5:38 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61222/
> ---
> 
> (Updated July 28, 2017, 5:38 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Greg Mann.
> 
> 
> Bugs: MESOS-6846
> https://issues.apache.org/jira/browse/MESOS-6846
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added V1 call support for the teardown operation. Added test cases
> for the V1 teardown call.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 
>   include/mesos/v1/master/master.proto 
> cf88ea64fa08e4bdcf685de4def28d374eb32fdf 
>   src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
>   src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
>   src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/61222/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Review Request 61222: Added V1 teardown call.

2017-07-28 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61222/
---

Review request for mesos, Anand Mazumdar and Greg Mann.


Bugs: MESOS-6846
https://issues.apache.org/jira/browse/MESOS-6846


Repository: mesos


Description
---

Added V1 call support for the teardown operation. Added test cases
for the V1 teardown call.


Diffs
-

  include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 
  include/mesos/v1/master/master.proto cf88ea64fa08e4bdcf685de4def28d374eb32fdf 
  src/master/http.cpp 9df086c417a9392f62d600c7a6486be0a1cf7e70 
  src/master/master.hpp 84465af782d4024f22463d981ef9d0ef7827d043 
  src/master/validation.cpp 4885339b2112b6dbdc930875c20e1f5872b1edbf 
  src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 


Diff: https://reviews.apache.org/r/61222/diff/1/


Testing
---

make check


Thanks,

Quinn Leng