Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204509
---



PASS: Mesos patch 67223 was successfully built and tested.

Reviews applied: `['67157', '67223']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67223

- Mesos Reviewbot Windows


On June 8, 2018, 3:04 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67223/
> ---
> 
> (Updated June 8, 2018, 3:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8924
> https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch takes the advantages of the moving constructors of the CSI
> request protobuf messages to avoid copying the messages.
> 
> 
> Diffs
> -
> 
>   src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
>   src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
>   src/resource_provider/storage/provider.cpp 
> 36e9109d8cdc7fc1fa29582e2717b84e3e60 
> 
> 
> Diff: https://reviews.apache.org/r/67223/diff/4/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
---

(Updated June 8, 2018, 10:04 p.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.


Changes
---

Made the client call functions accept lvalues, as suggested by Benjamin.


Bugs: MESOS-8924
https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
---

This patch takes the advantages of the moving constructors of the CSI
request protobuf messages to avoid copying the messages.


Diffs (updated)
-

  src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
  src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
  src/resource_provider/storage/provider.cpp 
36e9109d8cdc7fc1fa29582e2717b84e3e60 


Diff: https://reviews.apache.org/r/67223/diff/4/

Changes: https://reviews.apache.org/r/67223/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-08 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204480
---



Patch looks great!

Reviews applied: [67164, 67190, 67191, 67154, 67155, 67156, 67158, 67157, 67223]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 8, 2018, 1:31 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67223/
> ---
> 
> (Updated June 8, 2018, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8924
> https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch takes the advantages of the moving constructors of the CSI
> request protobuf messages to avoid copying the messages.
> 
> 
> Diffs
> -
> 
>   src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
>   src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
>   src/resource_provider/storage/provider.cpp 
> 36e9109d8cdc7fc1fa29582e2717b84e3e60 
> 
> 
> Diff: https://reviews.apache.org/r/67223/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204478
---



PASS: Mesos patch 67223 was successfully built and tested.

Reviews applied: `['67157', '67223']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67223

- Mesos Reviewbot Windows


On June 8, 2018, 1:31 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67223/
> ---
> 
> (Updated June 8, 2018, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8924
> https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch takes the advantages of the moving constructors of the CSI
> request protobuf messages to avoid copying the messages.
> 
> 
> Diffs
> -
> 
>   src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
>   src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
>   src/resource_provider/storage/provider.cpp 
> 36e9109d8cdc7fc1fa29582e2717b84e3e60 
> 
> 
> Diff: https://reviews.apache.org/r/67223/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-07 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
---

(Updated June 8, 2018, 1:31 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.


Changes
---

Addressed nits pointed out by Benjamin.


Bugs: MESOS-8924
https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
---

This patch takes the advantages of the moving constructors of the CSI
request protobuf messages to avoid copying the messages.


Diffs (updated)
-

  src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
  src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
  src/resource_provider/storage/provider.cpp 
36e9109d8cdc7fc1fa29582e2717b84e3e60 


Diff: https://reviews.apache.org/r/67223/diff/3/

Changes: https://reviews.apache.org/r/67223/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-07 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
---

(Updated June 8, 2018, 1:23 a.m.)


Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.


Changes
---

Rebased.


Bugs: MESOS-8924
https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
---

This patch takes the advantages of the moving constructors of the CSI
request protobuf messages to avoid copying the messages.


Diffs (updated)
-

  src/csi/client.hpp 1c57ac52ade6295d5c45ac8a439ea572d16d7ae3 
  src/csi/client.cpp 923ee6f85dc8070d60bee9834846f859883c73df 
  src/resource_provider/storage/provider.cpp 
36e9109d8cdc7fc1fa29582e2717b84e3e60 


Diff: https://reviews.apache.org/r/67223/diff/2/

Changes: https://reviews.apache.org/r/67223/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-06-06 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review204368
---


Ship it!




This patch needs to be rebased, but LGTM.


src/csi/client.cpp
Line 59 (original), 64 (patched)


Nit: Might as well rewrap like all other function bodies.



src/csi/client.cpp
Line 227 (original), 256 (patched)


Nit: Rewrap?


- Benjamin Bannier


On May 19, 2018, 1:34 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67223/
> ---
> 
> (Updated May 19, 2018, 1:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.
> 
> 
> Bugs: MESOS-8924
> https://issues.apache.org/jira/browse/MESOS-8924
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch takes the advantages of the moving constructors of the CSI
> request protobuf messages to avoid copying the messages.
> 
> 
> Diffs
> -
> 
>   src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9 
>   src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592 
>   src/resource_provider/storage/provider.cpp 
> 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 
>   src/tests/csi_client_tests.cpp f5b9eac38a4079cc2873ce2e2de24eaf315e0bc9 
> 
> 
> Diff: https://reviews.apache.org/r/67223/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-05-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/#review203466
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67190', '67191', '67154', '67155', '67156', '67158', 
'67157', '67223']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67223

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67223/logs/stout-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(640): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(773): 
warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(798): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(808): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1092): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1092): 
warning C4267: 'initializing': conversion from 'size_t' to 'const int', 
possible loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1353): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1353): 
warning C4267: 'initializing': conversion from 'size_t' to 'const int', 
possible loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1426): 
warning C4267: 'argument': conversion from 'size_t' to 'const int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1448): 
warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1535): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\logging.cc(1548): 
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\raw_logging.cc(153):
 warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', 
possible loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj] 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
 
d:\dcos\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70\src\utilities.cc(82): 
warning C4267: 'argument': conversion from 'size_t' to 'unsigned int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\glog-da816ea70\src\glog-da816ea70-build\glog.vcxproj]

Review Request 67223: Used move constructors for making CSI gRPC calls.

2018-05-18 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67223/
---

Review request for mesos, Benjamin Bannier, Jie Yu, and Zhitao Li.


Bugs: MESOS-8924
https://issues.apache.org/jira/browse/MESOS-8924


Repository: mesos


Description
---

This patch takes the advantages of the moving constructors of the CSI
request protobuf messages to avoid copying the messages.


Diffs
-

  src/csi/client.hpp 5d846740f72125efb3654e14d763bd24634367b9 
  src/csi/client.cpp 559e8057eccce5bf758918c24e5ca8c561af6592 
  src/resource_provider/storage/provider.cpp 
63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 
  src/tests/csi_client_tests.cpp f5b9eac38a4079cc2873ce2e2de24eaf315e0bc9 


Diff: https://reviews.apache.org/r/67223/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao