Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-08 Thread Gastón Kleiman 


> On Feb. 7, 2019, 4:36 p.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 1383 (patched)
> > 
> >
> > Could you explain in this comment why the response contains no 
> > operations?

Good catch! I swear I had added this, but it either got lost when squashing the 
commits or I'm starting to imagine things ;-).


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212654
---


On Feb. 8, 2019, 3:12 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 8, 2019, 3:12 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/3/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-08 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/
---

(Updated Feb. 8, 2019, 3:12 p.m.)


Review request for mesos, Greg Mann and Joseph Wu.


Changes
---

Added comment.


Bugs: MESOS-9473
https://issues.apache.org/jira/browse/MESOS-9473


Repository: mesos


Description
---

Added tests for reconciliation of operations on agent default resources.


Diffs (updated)
-

  src/tests/operation_reconciliation_tests.cpp 
9a1fc95752c8ce7c7358561bda3659a76871f5c3 


Diff: https://reviews.apache.org/r/69911/diff/3/

Changes: https://reviews.apache.org/r/69911/diff/2-3/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
--gtest_repeat=5000 --gtest_break_on_failure` passed


Thanks,

Gastón Kleiman

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212654
---


Fix it, then Ship it!





src/tests/operation_reconciliation_tests.cpp
Lines 1383 (patched)


Could you explain in this comment why the response contains no operations?


- Greg Mann


On Feb. 7, 2019, 9:55 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 7, 2019, 9:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/2/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212647
---



PASS: Mesos patch 69911 was successfully built and tested.

Reviews applied: `['69910', '69920', '69912', '69919', '69911']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2862/mesos-review-69911

- Mesos Reviewbot Windows


On Feb. 7, 2019, 9:55 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 7, 2019, 9:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/2/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-07 Thread Gastón Kleiman 


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 945 (patched)
> > 
> >
> > Use `GetParam()` here?

Already done in https://reviews.apache.org/r/69913/. I squashed both patches.


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 984-985 (patched)
> > 
> >
> > Let's also expect that the resource provider ID is unset in the update.

Done here and elsewhere.


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 987 (patched)
> > 
> >
> > Period at the end of comment, here and elsewhere.

Also fixed already existing comments here: https://reviews.apache.org/r/69919/


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212632
---


On Feb. 7, 2019, 1:55 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 7, 2019, 1:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/2/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-07 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/
---

(Updated Feb. 7, 2019, 1:55 p.m.)


Review request for mesos, Greg Mann and Joseph Wu.


Changes
---

Addressed feedback and the original patch squashed with the one posted on 
https://reviews.apache.org/r/69913/.


Bugs: MESOS-9473
https://issues.apache.org/jira/browse/MESOS-9473


Repository: mesos


Description
---

Added tests for reconciliation of operations on agent default resources.


Diffs (updated)
-

  src/tests/operation_reconciliation_tests.cpp 
9a1fc95752c8ce7c7358561bda3659a76871f5c3 


Diff: https://reviews.apache.org/r/69911/diff/2/

Changes: https://reviews.apache.org/r/69911/diff/1-2/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
--gtest_repeat=5000 --gtest_break_on_failure` passed


Thanks,

Gastón Kleiman

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-07 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212632
---


Fix it, then Ship it!





src/tests/operation_reconciliation_tests.cpp
Lines 945 (patched)


Use `GetParam()` here?



src/tests/operation_reconciliation_tests.cpp
Lines 984-985 (patched)


Let's also expect that the resource provider ID is unset in the update.



src/tests/operation_reconciliation_tests.cpp
Lines 987 (patched)


Period at the end of comment, here and elsewhere.


- Greg Mann


On Feb. 6, 2019, 9:02 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 6, 2019, 9:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-06 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212619
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69910', '69911']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2860/mesos-review-69911

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2860/mesos-review-69911/logs/mesos-tests.log):

```
W0206 22:12:47.184478 38248 slave.cpp:3934] Ignoring shutdown framework 
d38844d9-45ca-460a-b8e8-b9f98808f760- because it is terminating
I0206 22:12:47.186475 35584 master.cpp:1269] Agent 
d38844d9-45ca-460a-b8e8-b9f98808f760-S0 at slave(487)@192.10.1.6:49856 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0206 22:12:47.186475 35584 master.cpp:3272] Disconnecting agent 
d38844d9-45ca-460a-b8e8-b9f98808f760-S0 at slave(487)@192.10.1.6:49856 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0206 22:12:47.187490 35584 master.cpp:3291] Deactivating agent 
d38844d9-45ca-460a-b8e8-b9f98808f760-S0 at slave(487)@192.10.1.6:49856 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0206 22:12:47.187490 37084 hierarchical.cpp:358] Removed framework 
d38844d9-45ca-460a-b8e8-b9f98808f760-
I0206 22:12:47.187490 37084 hierarchical.cpp:793] Agent 
d38844d9-45ca-460a-b8e8-b9f98808f760-S0 deactivated
I0206 22:12:47.188478 38064 containerizer.cpp:2477] Destroying container 
465130a8-81bb-492b-8b81-cef120f5277d in RUNNING state
I0206 22:12:47.188478 38064 containerizer.cpp:3144] Transitioning the state of 
container 465130a8-81bb-492b-8b81-cef120f5277d from RUNNING to DESTROYING
I0206 22:12:47.189537 38064 launcher.cpp:161] Asked to destroy container 
465130a8-81bb-492b-8b81-cef120f5277d
W0206 22:12:47.190480 38296 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=12688 to peer '192.10.1.6:51748': IO failed with error 
code: The specified network name is no longer available.

W0206 22:12:47.190480[   OK ] 
IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (689 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (707 ms total)

[--] Global test environment tear-down
[==] 1105 tests from 105 test cases ran. (520306 ms total)
[  PASSED  ] 1104 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

 38296 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=12752 
to peer '192.10.1.6:51749': IO failed with error code: The specified network 
name is no longer available.

I0206 22:12:47.273960 38124 containerizer.cpp:2983] Container 
465130a8-81bb-492b-8b81-cef120f5277d has exited
I0206 22:12:47.302953 38248 master.cpp:1109] Master terminating
I0206 22:12:47.304937 38064 hierarchical.cpp:644] Removed agent 
d38844d9-45ca-460a-b8e8-b9f98808f760-S0
I0206 22:12:47.770943 38296 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Feb. 6, 2019, 9:02 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> ---
> 
> (Updated Feb. 6, 2019, 9:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
> https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -
> 
>   src/tests/operation_reconciliation_tests.cpp 
> 9a1fc95752c8ce7c7358561bda3659a76871f5c3 
> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/1/
> 
> 
> Testing
> ---
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
> --gtest_repeat=5000 --gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Review Request 69911: Added tests for reconciliation of operations on agent default resources.

2019-02-06 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/
---

Review request for mesos, Greg Mann and Joseph Wu.


Bugs: MESOS-9473
https://issues.apache.org/jira/browse/MESOS-9473


Repository: mesos


Description
---

Added tests for reconciliation of operations on agent default resources.


Diffs
-

  src/tests/operation_reconciliation_tests.cpp 
9a1fc95752c8ce7c7358561bda3659a76871f5c3 


Diff: https://reviews.apache.org/r/69911/diff/1/


Testing
---

`bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" 
--gtest_repeat=5000 --gtest_break_on_failure` passed


Thanks,

Gastón Kleiman