[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12017#issuecomment-206160605 Is this PR good to go? Or we still need to update it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14217][SQL] Fix bug if parquet data has...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12017#issuecomment-206160674 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58659279
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +47,38 @@ case class AnalyzeTable(tableName: String) extends
RunnableCommand {
}
/**
- * Drops a table from the metastore and removes it if it is cached.
+ * Drops a table/view from the metastore and removes it if it is cached.
*/
private[hive]
case class DropTable(
--- End diff --
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58659242
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -68,10 +91,14 @@ case class DropTable(
// Users should be able to drop such kinds of tables regardless if
there is an error.
case e: Throwable => log.warn(s"${e.getMessage}", e)
}
-hiveContext.invalidateTable(tableName)
-hiveContext.runSqlHive(s"DROP TABLE $ifExistsClause$tableName")
-hiveContext.sessionState.catalog.dropTable(
- TableIdentifier(tableName), ignoreIfNotExists = true)
+hiveContext.invalidateTable(tableName.quotedString)
+val ifExistsClause = if (ifExists) "IF EXISTS " else ""
+if (isView) {
+ hiveContext.runSqlHive(s"DROP VIEW
$ifExistsClause${tableName.quotedString}")
+} else {
+ hiveContext.runSqlHive(s"DROP TABLE
$ifExistsClause${tableName.quotedString}")
--- End diff --
Yeah. 30 test cases failed after removing it. Still doing the
investigation. : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58659065
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/commands.scala ---
@@ -47,18 +48,40 @@ case class AnalyzeTable(tableName: String) extends
RunnableCommand {
}
/**
- * Drops a table from the metastore and removes it if it is cached.
+ * Drops a table/view from the metastore and removes it if it is cached.
*/
private[hive]
case class DropTable(
-tableName: String,
-ifExists: Boolean) extends RunnableCommand {
+tableName: TableIdentifier,
+ifExists: Boolean,
+isView: Boolean) extends RunnableCommand {
override def run(sqlContext: SQLContext): Seq[Row] = {
val hiveContext = sqlContext.asInstanceOf[HiveContext]
-val ifExistsClause = if (ifExists) "IF EXISTS " else ""
+
+// If the command DROP VIEW is to drop a table or DROP TABLE is to
drop a view
+// issue an exception.
+val catalogTable: Option[CatalogTable] = try {
+ // If the table/view does not exist, it will throw an exception:
+ // - AnalysisException, if it is from InMemoryCatalog.
+ // - NoSuchTableException, if it is from HiveExternalCatalog
+ Option(sqlContext.sessionState.catalog.getTable(tableName))
--- End diff --
Sure, will do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12569][PySpark][ML]:DecisionTreeRegress...
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12116#issuecomment-206152870 @wangmiao1981 might still be good to add a simple test? But yes we should run this in jenkins if one of the commiters can whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-3724][ML] RandomForest: More options fo...
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11989#discussion_r58657961
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala ---
@@ -422,6 +422,13 @@ class RandomForestSuite extends SparkFunSuite with
MLlibTestSparkContext {
checkFeatureSubsetStrategy(numTrees = 1, "log2",
(math.log(numFeatures) / math.log(2)).ceil.toInt)
checkFeatureSubsetStrategy(numTrees = 1, "onethird", (numFeatures /
3.0).ceil.toInt)
+checkFeatureSubsetStrategy(numTrees = 1, "0.1", (0.1 *
numFeatures).ceil.toInt)
--- End diff --
Is there a particular reason these test cases differ from the Java ones? I
notice in the Java tests we also test some of the regex like ".1" and ".10" and
"0.10".
I'm wondering if we shouldn't just have a couple test cases for the regex
edge cases here (to ensure it gets translated correctly).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [Build] [HOT] Fix compilation ag...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12201#issuecomment-206148855 cc @yhuai Sorry, I did not realize this is not allowed in Scala 2.10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [Build] [HOT] Fix compilation ag...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12201#issuecomment-206148998 **[Test build #55096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55096/consoleFull)** for PR 12201 at commit [`4036cdd`](https://github.com/apache/spark/commit/4036cdd4c49f40305fbad795b81775eff48ec2a7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [Build] [HOT] Fix compilation ag...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/12201
[SPARK-14396] [Build] [HOT] Fix compilation against Scala 2.10
What changes were proposed in this pull request?
This PR is to fix the compilation errors in Scala 2.10 build, as shown in
the link:
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-scala-2.10/735/console
```
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:266:
value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:267:
value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:293:
value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:294:
value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error] ^
[error] four errors found
[error] Compile failed at Apr 5, 2016 10:59:09 PM [10.502s]
```
How was this patch tested?
Not sure how to trigger Scala 2.10 compilation in the test environment.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark buildBreak2.10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12201
commit 4036cdd4c49f40305fbad795b81775eff48ec2a7
Author: gatorsmile
Date: 2016-04-06T06:33:33Z
build break.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206146082 **[Test build #55095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55095/consoleFull)** for PR 12199 at commit [`0619067`](https://github.com/apache/spark/commit/0619067a622f3c0285f600b9106982a371a3547f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14392][ML]CountVectorizer Estimator sho...
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12200#discussion_r58657525
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/CountVectorizerSuite.scala ---
@@ -115,6 +115,27 @@ class CountVectorizerSuite extends SparkFunSuite with
MLlibTestSparkContext
}
}
+ test("CountVectorizer with binary") {
--- End diff --
I think we can combine this test case with the binary one on L192.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-12569][PySpark][ML]:DecisionTreeRegress...
Github user wangmiao1981 commented on the pull request: https://github.com/apache/spark/pull/12116#issuecomment-206145891 @jkbradley Can you add me to white list to trigger the integration test? Thanks! Miao --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14394][SQL] Generate AggregateHashMap c...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12161#issuecomment-206142648 **[Test build #55094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55094/consoleFull)** for PR 12161 at commit [`e30d40d`](https://github.com/apache/spark/commit/e30d40db0c94b2121b6bbcb48ba1ebf7ac861246). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206142565 **[Test build #55093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55093/consoleFull)** for PR 12198 at commit [`6abe10b`](https://github.com/apache/spark/commit/6abe10b6669156bd0c089ab9667e375120eb3ae5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206141117 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12169#issuecomment-206140527
I see the problem.
```
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:266:
value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:267:
value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:293:
value contains is not a member of Option[String]
[error] assert(desc.viewText.contains("SELECT * FROM tab1"))
[error] ^
[error]
/home/jenkins/workspace/spark-master-compile-maven-scala-2.10/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala:294:
value contains is not a member of Option[String]
[error] assert(desc.viewOriginalText.contains("SELECT * FROM tab1"))
[error] ^
[error] four errors found
[error] Compile failed at Apr 5, 2016 10:59:09 PM [10.502s]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206140754 Will fix it using a PR with [HOT]. Sorry for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206140681 @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206140188 **[Test build #55092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55092/consoleFull)** for PR 12081 at commit [`8b6f86b`](https://github.com/apache/spark/commit/8b6f86bbb059699c114c2b5815850c479d00a50c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14392][ML]CountVectorizer Estimator sho...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12200#issuecomment-206140085 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14398] [SQL] Audit non-reserved keyword...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12191#issuecomment-206140194 **[Test build #55091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55091/consoleFull)** for PR 12191 at commit [`18bff08`](https://github.com/apache/spark/commit/18bff08d8aba99fb3dd902ea1a534b827e5e2855). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206139977 https://amplab.cs.berkeley.edu/jenkins/job/spark-master-compile-maven-scala-2.10/ ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206139078 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206138869 Or I need to do it in my local environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206138706 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206138708 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55090/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206138699 **[Test build #55090 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55090/consoleFull)** for PR 12199 at commit [`e54bcc6`](https://github.com/apache/spark/commit/e54bcc6d1474e9e39cb7136c4236d4c22e7a612e). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14392][ML]CountVectorizer Estimator sho...
GitHub user wangmiao1981 opened a pull request: https://github.com/apache/spark/pull/12200 [SPARK-14392][ML]CountVectorizer Estimator should include binary toggle Param ## What changes were proposed in this pull request? CountVectorizerModel has a binary toggle param. This PR is to add binary toggle param for estimator CountVectorizer. As discussed in the JIRA, instead of adding a param into CountVerctorizer, I moved the binary param to CountVectorizerParams. Therefore, the estimator inherits the binary param. ## How was this patch tested? Add a new test case, which fits the model with binary flag set to true and then check the trained model's all non-zero counts is set to 1.0. All tests in CounterVectorizerSuite.scala are passed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangmiao1981/spark binary_param Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12200.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12200 commit 65dcb0434518c1b4d18ecbc9fe47587320a798fa Author: wm...@hotmail.com Date: 2016-04-05T23:39:53Z move binary param out of CountVectorizerModel without test commit dcad7996c762c25db8b37d8a07bd9dce1a807418 Author: wm...@hotmail.com Date: 2016-04-06T06:16:53Z Add test case and revert one change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14270][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12061#issuecomment-206138275 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55087/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14270][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12061#issuecomment-206138272 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12199#issuecomment-206138185 **[Test build #55090 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55090/consoleFull)** for PR 12199 at commit [`e54bcc6`](https://github.com/apache/spark/commit/e54bcc6d1474e9e39cb7136c4236d4c22e7a612e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14426][SQL] Merge PerserUtils and Parse...
GitHub user sarutak opened a pull request: https://github.com/apache/spark/pull/12199 [SPARK-14426][SQL] Merge PerserUtils and ParseUtils ## What changes were proposed in this pull request? We have ParserUtils and ParseUtils which are both utility collections for use during the parsing process. Those name and what they are used for is very similar so I think we can merge them. Also, the original unescapeSQLString method may have a fault. When "\u0061" style character literals are passed to the method, it's not unescaped successfully. This patch fix the bug. ## How was this patch tested? Added a new test case. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sarutak/spark merge-ParseUtils-and-ParserUtils Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12199.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12199 commit e54bcc6d1474e9e39cb7136c4236d4c22e7a612e Author: Kousuke Saruta Date: 2016-04-06T06:18:59Z Merged ParserUtils and ParseUtils --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206138089 Sure. Could you show me how to find the build log? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14270][SQL] whole stage codegen support...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12061#issuecomment-206138075 **[Test build #55087 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55087/consoleFull)** for PR 12061 at commit [`98744f0`](https://github.com/apache/spark/commit/98744f056ea4ca5450137b78a6212dd7536a2615). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206137516 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206137519 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55089/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206137508 **[Test build #55089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55089/consoleFull)** for PR 12198 at commit [`a3601fb`](https://github.com/apache/spark/commit/a3601fb14fa39c1dd7b620abc2ff39d21a9a221c). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206137008 @gatorsmile Seems scala 2.10 build is broken. Can you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12198#issuecomment-206136870 **[Test build #55089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55089/consoleFull)** for PR 12198 at commit [`a3601fb`](https://github.com/apache/spark/commit/a3601fb14fa39c1dd7b620abc2ff39d21a9a221c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410] [SQL] : SessionCatalog needs to ...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12183#issuecomment-206136314 @rekhajoshm I've opened #12198 to illustrate what I mean. I don't think the changes in this patch are correct so I would recommend that we close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14410][SQL] Push functions existence ch...
GitHub user andrewor14 opened a pull request: https://github.com/apache/spark/pull/12198 [SPARK-14410][SQL] Push functions existence check into catalog ## What changes were proposed in this pull request? This is a followup to #12117 and addresses some of the TODOs introduced there. In particular, the resolution of database is now pushed into session catalog, which knows about the current database. Further, the logic for checking whether a function exists is pushed into the external catalog. No change in functionality is expected. ## How was this patch tested? `SessionCatalogSuite`, `DDLSuite` You can merge this pull request into a Git repository by running: $ git pull https://github.com/andrewor14/spark function-exists Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12198.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12198 commit 8b13b7eb5710542c8c393722a3b3b29d20a8c9f2 Author: Andrew Or Date: 2016-04-06T06:01:20Z Push resolve database from RunnableCommand to catalog commit 6e6c689e62efd69009cb5c860291884cfcb1d05e Author: Andrew Or Date: 2016-04-06T06:12:08Z Push function exists check into external catalog commit a3601fb14fa39c1dd7b620abc2ff39d21a9a221c Author: Andrew Or Date: 2016-04-06T06:12:54Z Rename: getX -> getXMetadata --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD][DOCS] Update the build do...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12197#issuecomment-206129528 **[Test build #55088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55088/consoleFull)** for PR 12197 at commit [`cb050a0`](https://github.com/apache/spark/commit/cb050a0a4708efe19b219ffea50d8889ee11c750). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD][DOCS] Update the build do...
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/12197 [SPARK-14424][BUILD][DOCS] Update the build docs to switch from assembly to package and add a no… ## What changes were proposed in this pull request? Change our build docs & shell scripts to that developers are aware of the change from "assembly" to "package" ## How was this patch tested? Manually ran ./bin/spark-shell after ./build/sbt assembly and verified error message printed, ran new suggested build target and verified ./bin/spark-shell runs after this. You can merge this pull request into a Git repository by running: $ git pull https://github.com/holdenk/spark SPARK-1424-spark-class-broken-fix-build-docs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12197.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12197 commit cb050a0a4708efe19b219ffea50d8889ee11c750 Author: Holden Karau Date: 2016-04-06T05:48:32Z Update the build docs to switch from assembly to package and add a note in spark-class if we can't find the required target --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14252] Executors do not try to download...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14252] Executors do not try to download...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12193#issuecomment-206127119 LGTM merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD] Revert "Stop building the...
Github user holdenk closed the pull request at: https://github.com/apache/spark/pull/12196 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD] Revert "Stop building the...
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12196#issuecomment-206126910 Or wait looks like just updating the build docs is the right path forward. I'll close and re-open a DOC fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12169 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14396] [SQL] Throw Exceptions for DDLs ...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12169#issuecomment-206126467 Merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206126096 Mergd into amster --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14415][SQL] Add ExpressionDescription a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12185#issuecomment-206126348 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55084/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14415][SQL] Add ExpressionDescription a...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12185#issuecomment-206126343 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14415][SQL] Add ExpressionDescription a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12185#issuecomment-206125926 **[Test build #55084 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55084/consoleFull)** for PR 12185 at commit [`2d7cee8`](https://github.com/apache/spark/commit/2d7cee8308befbbf1cf44c46d74c2f175d064e98). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13211][STREAMING] Deprecate certain con...
Github user lw-lin closed the pull request at: https://github.com/apache/spark/pull/12035 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13211][STREAMING] Deprecate certain con...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12035#issuecomment-206123094 @srowen sure, thank you for this review, :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14370][MLLIB]removed duplicate generati...
Github user pravingadakh commented on the pull request: https://github.com/apache/spark/pull/12176#issuecomment-206119313 @jkbradley Could you please flag this PR for test build? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14270][SQL] whole stage codegen support...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12061#issuecomment-206118365 **[Test build #55087 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55087/consoleFull)** for PR 12061 at commit [`98744f0`](https://github.com/apache/spark/commit/98744f056ea4ca5450137b78a6212dd7536a2615). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD] Revert "Stop building the...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12196#issuecomment-206117843 **[Test build #55086 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55086/consoleFull)** for PR 12196 at commit [`ae3998d`](https://github.com/apache/spark/commit/ae3998d2192703fec1596d0eb92bb7a58950e474). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD] Revert "Stop building the...
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/12196#issuecomment-206117606 cc @vanzin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14424][BUILD] Revert "Stop building the...
GitHub user holdenk opened a pull request: https://github.com/apache/spark/pull/12196 [SPARK-14424][BUILD] Revert "Stop building the main Spark assembly." … ## What changes were proposed in this pull request? This reverts SPARK-13579 to temporarily restore spark-class (and its consumers like spark-shell). ## How was this patch tested? ./build/sbt assembly && ./bin/spark-shell (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) …to resupport spark-class and its users (like spark-shell). This reverts commit 24d7d2e453ab5eef6099a32fb9e8ed60f6ada93a. Conflicts: project/SparkBuild.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/holdenk/spark SPARK-14424-spark-class-broken Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/12196.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #12196 commit ae3998d2192703fec1596d0eb92bb7a58950e474 Author: Holden Karau Date: 2016-04-06T04:47:10Z Revert "[SPARK-13579][BUILD] Stop building the main Spark assembly." to resupport spark-class and its users (like spark-shell). This reverts commit 24d7d2e453ab5eef6099a32fb9e8ed60f6ada93a. Conflicts: project/SparkBuild.scala --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-206116388 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-206116392 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55085/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14290][CORE][Network] avoid significant...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12083#issuecomment-206116277 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55082/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-206116242 **[Test build #55085 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55085/consoleFull)** for PR 11419 at commit [`c96ceae`](https://github.com/apache/spark/commit/c96ceae46d1c1f09b487ee7e57fea04c629402b5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14290][CORE][Network] avoid significant...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12083#issuecomment-206116274 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14290][CORE][Network] avoid significant...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12083#issuecomment-206116130 **[Test build #55082 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55082/consoleFull)** for PR 12083 at commit [`a793696`](https://github.com/apache/spark/commit/a793696fc0ba3bc14ccb403c6ddc11021de8b34b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14362] [SPARK-14406] [SQL] [WIP] DDL Na...
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r58649986
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveSqlParser.scala
---
@@ -113,7 +113,10 @@ class HiveSqlAstBuilder extends SparkSqlAstBuilder {
if (ctx.REPLICATION != null) {
logWarning("REPLICATION clause is ignored.")
}
-DropTable(visitTableIdentifier(ctx.tableIdentifier).toString,
ctx.EXISTS != null)
+DropTable(
+ visitTableIdentifier(ctx.tableIdentifier),
+ ctx.EXISTS != null,
--- End diff --
For purge, does Spark recognize `Trash` dir?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14418] [PYSPARK] fix unpersist of Broad...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12189#issuecomment-206114097 Seems this PR does not change unpersist? Is the behavior of unpersist correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14119] [SQL] Improve HashedRelation for...
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12190#issuecomment-206113594 wrong jira? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14128][SQL] Alter table DDL followup
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14128][SQL] Alter table DDL followup
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12186#issuecomment-206113198 LGTM. Merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206113036 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55077/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206113034 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206112938 **[Test build #55077 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55077/consoleFull)** for PR 12081 at commit [`3c03dbf`](https://github.com/apache/spark/commit/3c03dbfe0e5192b3a106154f2b322f74cf02d3c8). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14252] Executors do not try to download...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12193#issuecomment-206112823 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14252] Executors do not try to download...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12193#issuecomment-206112826 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55073/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14252] Executors do not try to download...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12193#issuecomment-206111910 **[Test build #55073 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55073/consoleFull)** for PR 12193 at commit [`8b1cdaa`](https://github.com/apache/spark/commit/8b1cdaad6243fdbc58f5f24e3f8d6bf52cc2301f). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206111716 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206111717 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55070/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14416][Core]Add thread-safe comments fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12188#issuecomment-206111568 **[Test build #55070 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55070/consoleFull)** for PR 12188 at commit [`33abf5c`](https://github.com/apache/spark/commit/33abf5c9dd38cfb1e422b309a4e128cda2686179). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13538][ML] Add GaussianMixture to ML
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/11419#issuecomment-206110770 **[Test build #55085 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55085/consoleFull)** for PR 11419 at commit [`c96ceae`](https://github.com/apache/spark/commit/c96ceae46d1c1f09b487ee7e57fea04c629402b5). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12087 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206110555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55079/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206110534 merging to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206110552 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206110316 **[Test build #55079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55079/consoleFull)** for PR 12087 at commit [`af0d193`](https://github.com/apache/spark/commit/af0d19312fd7dc89aed192a9787f224c9d347180). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14415][SQL] Add ExpressionDescription a...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12185#issuecomment-206110211 **[Test build #55084 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55084/consoleFull)** for PR 12185 at commit [`2d7cee8`](https://github.com/apache/spark/commit/2d7cee8308befbbf1cf44c46d74c2f175d064e98). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206110043 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55078/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206110041 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14124] [SQL] [FOLLOWUP] Implement Datab...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12081#issuecomment-206109929 **[Test build #55078 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55078/consoleFull)** for PR 12081 at commit [`8b6f86b`](https://github.com/apache/spark/commit/8b6f86bbb059699c114c2b5815850c479d00a50c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14352][SQL] approxQuantile should suppo...
Github user zhengruifeng commented on the pull request: https://github.com/apache/spark/pull/12135#issuecomment-206109616 @holdenk Ok, I will add the python API into this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14398] [SQL] Audit non-reserved keyword...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12191#issuecomment-206108421 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14398] [SQL] Audit non-reserved keyword...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12191#issuecomment-206108422 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55080/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14398] [SQL] Audit non-reserved keyword...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12191#issuecomment-206108305 **[Test build #55080 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55080/consoleFull)** for PR 12191 at commit [`c6fbf0f`](https://github.com/apache/spark/commit/c6fbf0f7cfb06a1d24430e4d23685357e9426f0a). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `public class Java8DatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase ` * `public class JavaDatasetAggregatorSuite extends JavaDatasetAggregatorSuiteBase ` * `class JavaDatasetAggregatorSuiteBase implements Serializable ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-13211] [STREAMING] StreamingContext thr...
Github user lw-lin commented on the pull request: https://github.com/apache/spark/pull/12174#issuecomment-206107803 @srowen thanks for the fix. However, instead of allowing users to call these obsolete constructors and improving the error messages, I'm inclined to guide users **not to call these `this(path: String)` constructors** but to call the better `SparkContext.getOrCreate(path, ...)`, which is also the recommended manner by our [streaming programming guide](http://spark.apache.org/docs/latest/streaming-programming-guide.html#checkpointing). `SparkContext.getOrCreate(path, ...)` was added as the major API for users to create a StreamingContext from some checkpoint path. Since it is an improved version of `this(path: String)` constructors, I couldn't think of why users still want to call `this(path: String)`. So I'm proposing let's deprecated the `this(path: String)` constructors in https://github.com/apache/spark/pull/12035. @zsxwing could you take a look at this? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206107326 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206107327 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/55076/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-14296][SQL] whole stage codegen support...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12087#issuecomment-206107113 **[Test build #55076 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55076/consoleFull)** for PR 12087 at commit [`0ce90fe`](https://github.com/apache/spark/commit/0ce90fe22da1d5887c669f859ab8af099f73e577). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class UnresolvedDeserializer(deserializer: Expression, inputAttributes: Seq[Attribute] = Nil)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
