[GitHub] [spark] AmplabJenkins removed a comment on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
AmplabJenkins removed a comment on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534878913 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
SparkQA commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534880645 **[Test build #111331 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111331/testReport)** for PR 25924 at commit [`565368d`](https://github.com/apache/spark/commit/565368d0e0c01cb77d87dd5c103c1466ea14171c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
AmplabJenkins removed a comment on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534878915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16380/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
MaxGekk commented on a change in pull request #25924: [SPARK-29237][SQL][DOC]
Avoid usage of function names in expression examples
URL: https://github.com/apache/spark/pull/25924#discussion_r327955822
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##
@@ -1732,9 +1732,9 @@ case class Left(str: Expression, len: Expression, child:
Expression) extends Run
Examples:
> SELECT _FUNC_('Spark SQL ');
10
- > SELECT CHAR_LENGTH('Spark SQL ');
+ > SELECT _FUNC_('Spark SQL ');
Review comment:
Would it be better show examples for binary data instead of demonstrating
synonyms of the function name?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
AmplabJenkins commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534878915 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16380/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
AmplabJenkins commented on issue #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924#issuecomment-534878913 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk opened a new pull request #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples
MaxGekk opened a new pull request #25924: [SPARK-29237][SQL][DOC] Avoid usage of function names in expression examples URL: https://github.com/apache/spark/pull/25924 ### What changes were proposed in this pull request? In the PR, I propose to replace function names in some expression examples by `_FUNC_`, and add a test to check that `_FUNC_` always present in all examples. ### Why are the changes needed? Binding of a function name to an expression is performed in `FunctionRegistry` which is single source of truth. Expression examples should avoid using function name directly because this can make the examples invalid in the future. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Added new test to `SQLQuerySuite` which analyses expression example, and check presence of `_FUNC_`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534876592 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111328/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534876585 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec
wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534840976 @cloud-fan > I have a slightly different proposal: when codegen Substring(a), check if there is a IsNotNull(a) predicate. If there is, codegen it first. If not, and a is a not-nullable attribute, then generate a IsNotNull(a) and codegen it first. `Substring(a)` `a` could be an expression. If we have predicates like `Substring(Substring(a))` and `IsNotNulll(Substring(a))`, we could codegen `IsNotNulll(Substring(a))` for null check first? To be more comprehensive, should we check if there is IsNotNull predicate for a predicate and all its children before generate IsNotNull for its references? But this is a little complicated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
SparkQA removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846522 **[Test build #111328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111328/testReport)** for PR 25922 at commit [`2dc9905`](https://github.com/apache/spark/commit/2dc990534d3b1bcdcc72e023ab289f6cc7cf0616). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534876585 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534876592 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111328/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec
wangshuo128 edited a comment on issue #25902: [SPARK-29213][SQL] Make it consistent when get notnull output and generate null checks in FilterExec URL: https://github.com/apache/spark/pull/25902#issuecomment-534840976 @cloud-fan > I have a slightly different proposal: when codegen Substring(a), check if there is a IsNotNull(a) predicate. If there is, codegen it first. If not, and a is a not-nullable attribute, then generate a IsNotNull(a) and codegen it first. `Substring(a)` `a` could be an expression. If we have predicates like `Substring(Substring(a))` and `IsNotNulll(Substring(a))`, we could codegen `IsNotNulll(Substring(a))` for null check first? To be more comprehensive, should we check if there is IsNotNull predicate for a predicate and all its children before generate IsNotNull for its references? But this is a little complex. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534876288 **[Test build #111328 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111328/testReport)** for PR 25922 at commit [`2dc9905`](https://github.com/apache/spark/commit/2dc990534d3b1bcdcc72e023ab289f6cc7cf0616). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
HeartSaVioR commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534874148 Regarding build failure for febac9f : https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111321/testReport ``` - org.apache.spark.sql.SQLQueryTestSuite.blacklist_sql Error Details java.io.FileNotFoundException: /home/jenkins/workspace/SparkPullRequestBuilder@3/sql/core/src/test/resources/sql-tests/results/blacklist.sql.out (No such file or directory) ``` I guess that's fixed in f714453 but let me confirm with the build result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] beliefer commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
beliefer commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534873819 @dongjoon-hyun @srowen @wangyum Thanks for all your help. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534873354 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
AmplabJenkins commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534873365 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534873354 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
AmplabJenkins removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534873371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111323/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
AmplabJenkins removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534873365 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
AmplabJenkins commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534873371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111323/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
AmplabJenkins commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534873362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111326/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
AmplabJenkins removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534873362 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111326/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
SparkQA removed a comment on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534834377 **[Test build #111323 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111323/testReport)** for PR 25661 at commit [`a119a6c`](https://github.com/apache/spark/commit/a119a6c728ffea32fc17722b6dd6c49902a4e194). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
SparkQA commented on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534872753 **[Test build #111326 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111326/testReport)** for PR 25921 at commit [`5c18013`](https://github.com/apache/spark/commit/5c180135d8a6d4069b2ff509ff34fb85185860df). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view
SparkQA removed a comment on issue #25921: [SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view URL: https://github.com/apache/spark/pull/25921#issuecomment-534839751 **[Test build #111326 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111326/testReport)** for PR 25921 at commit [`5c18013`](https://github.com/apache/spark/commit/5c180135d8a6d4069b2ff509ff34fb85185860df). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
SparkQA commented on issue #25661: [SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" URL: https://github.com/apache/spark/pull/25661#issuecomment-534872779 **[Test build #111323 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111323/testReport)** for PR 25661 at commit [`a119a6c`](https://github.com/apache/spark/commit/a119a6c728ffea32fc17722b6dd6c49902a4e194). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534870815 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16379/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534870756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16378/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534870805 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534870750 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
AmplabJenkins commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534870815 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16379/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
AmplabJenkins commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534870805 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534870756 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16378/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
AmplabJenkins removed a comment on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534645326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111288/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534870750 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect`
SparkQA commented on issue #25697: [SPARK-28997][SQL] Add `spark.sql.dialect` URL: https://github.com/apache/spark/pull/25697#issuecomment-534870434 **[Test build #111330 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111330/testReport)** for PR 25697 at commit [`82a9e4d`](https://github.com/apache/spark/commit/82a9e4d684032641a8356a5baacf5bf9d2414e6a). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534870435 **[Test build #111329 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111329/testReport)** for PR 25863 at commit [`ed2af4a`](https://github.com/apache/spark/commit/ed2af4a4b88670588f37f71d702aec4ae2351c98). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ScrapCodes commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer
ScrapCodes commented on issue #25853: [SPARK-21869][SS] Apply Apache Commons Pool to Kafka producer URL: https://github.com/apache/spark/pull/25853#issuecomment-534869968 Does the current implementation in this patch lets us share the same KafkaProducer instance by all the executor threads, what happens when borrow is called with the same key more than once? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534868965 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111321/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
AmplabJenkins removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534868947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111319/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
AmplabJenkins removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534868939 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
AmplabJenkins removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534868960 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
SparkQA removed a comment on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534831745 **[Test build #111321 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111321/testReport)** for PR 25923 at commit [`febac9f`](https://github.com/apache/spark/commit/febac9f13cdea7538fdb596f59c621da96fd052d). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
AmplabJenkins commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534868947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111319/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
AmplabJenkins commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534868960 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
AmplabJenkins commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534868939 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
AmplabJenkins commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534868965 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111321/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins
SparkQA commented on issue #25923: [DO-NOT-MERGE][WIP][MINOR][SQL][TESTS] show tests in SQLQuerySuite correctly in Jenkins URL: https://github.com/apache/spark/pull/25923#issuecomment-534868706 **[Test build #111321 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111321/testReport)** for PR 25923 at commit [`febac9f`](https://github.com/apache/spark/commit/febac9f13cdea7538fdb596f59c621da96fd052d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
SparkQA removed a comment on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534822576 **[Test build #111319 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111319/testReport)** for PR 25869 at commit [`eb1a802`](https://github.com/apache/spark/commit/eb1a802106e1ed9afe9049ec061d105b6812b37e). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file
SparkQA commented on issue #25869: [SPARK-29189][SQL] Add an option to ignore block locations when listing file URL: https://github.com/apache/spark/pull/25869#issuecomment-534868491 **[Test build #111319 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111319/testReport)** for PR 25869 at commit [`eb1a802`](https://github.com/apache/spark/commit/eb1a802106e1ed9afe9049ec061d105b6812b37e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
wangyum commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534866631 @srowen @HyukjinKwon @dongjoon-hyun The test failure fixed by https://github.com/apache/spark/pull/25775. Which one should be merged first? ``` - SPARK-8368: includes jars passed in through --jars *** FAILED *** ... 2019-09-24 20:55:40.8 - stderr> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.hive.hcatalog.data.JsonSerDe 2019-09-24 20:55:40.8 - stderr>at org.apache.hadoop.hive.ql.plan.TableDesc.getDeserializerClass(TableDesc.java:79) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.addColumnMetadataToConf(HiveTableScanExec.scala:123) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.hadoopConf$lzycompute(HiveTableScanExec.scala:101) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.hadoopConf(HiveTableScanExec.scala:98) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.hadoopReader$lzycompute(HiveTableScanExec.scala:110) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.hadoopReader(HiveTableScanExec.scala:105) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.$anonfun$doExecute$1(HiveTableScanExec.scala:188) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.util.Utils$.withDummyCallSite(Utils.scala:2488) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.hive.execution.HiveTableScanExec.doExecute(HiveTableScanExec.scala:188) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.SparkPlan.$anonfun$execute$1(SparkPlan.scala:189) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.SparkPlan.$anonfun$executeQuery$1(SparkPlan.scala:227) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:224) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:185) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.inputRDD$lzycompute(ShuffleExchangeExec.scala:64) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.inputRDD(ShuffleExchangeExec.scala:64) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.shuffleDependency$lzycompute(ShuffleExchangeExec.scala:74) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.shuffleDependency(ShuffleExchangeExec.scala:72) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.createShuffledRDD(ShuffleExchangeExec.scala:82) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.execution.exchange.ShuffleExchangeExec.$anonfun$doExecute$1(ShuffleExchangeExec.scala:93) 2019-09-24 20:55:40.8 - stderr>at org.apache.spark.sql.catalyst.errors.package$.attachTree(package.scala:52) 2019-09-24 20:55:40.8 - stderr>... 67 more 2019-09-24 20:55:40.8 - stderr> Caused by: java.lang.ClassNotFoundException: org.apache.hive.hcatalog.data.JsonSerDe 2019-09-24 20:55:40.8 - stderr>at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:471) 2019-09-24 20:55:40.8 - stderr>at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:588) 2019-09-24 20:55:40.8 - stderr>at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) 2019-09-24 20:55:40.8 - stderr>at java.base/java.lang.Class.forName0(Native Method) 2019-09-24 20:55:40.8 - stderr>at java.base/java.lang.Class.forName(Class.java:398) 2019-09-24 20:55:40.8 - stderr>at org.apache.hadoop.hive.ql.plan.TableDesc.getDeserializerClass(TableDesc.java:76) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] wangyum commented on issue #25775: [SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde
wangyum commented on issue #25775: [SPARK-29015][SQL][test-hadoop3.2] fix bug for jdk11, can't use 'add jar' jar's class as create table serde URL: https://github.com/apache/spark/pull/25775#issuecomment-534866015 @AngersZh Could you add these to **How was this patch tested?**: ```shell export JAVA_HOME=/usr/lib/jdk-11.0.3 export PATH=$JAVA_HOME/bin:$PATH build/sbt -Phive-thriftserver -Phadoop-3.2 hive/test-only *HiveSparkSubmitSuite -- -z "SPARK-8368: includes jars passed in through --jars" hive-thriftserver/test-only *HiveThriftBinaryServerSuite -- -z "test add jar" ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
turboFei commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534863001 The failed `SQLQueryTestSuite` in sql module passed locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type
ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL]
Spark sql null type incompatible with hive void type
URL: https://github.com/apache/spark/pull/25085#discussion_r327938382
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##
@@ -961,7 +961,11 @@ private[hive] object HiveClientImpl {
/** Get the Spark SQL native DataType from Hive's FieldSchema. */
private def getSparkSQLDataType(hc: FieldSchema): DataType = {
try {
- CatalystSqlParser.parseDataType(hc.getType)
+ hc.getType match {
+// SPARK-28313 compatible hive void type
+case "void" => NullType
Review comment:
Fix this point, hive void type will be converted to null type.
Such as, t1 have a void type column c1, when execute `show create table
$tbl`.
Spark:
`create table t1 (c1 null)`
Hive:
`create table t1 (c1 void)`
And without fix this point, spark will throw an exception.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861438 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861438 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
AmplabJenkins commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861440 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111317/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
AmplabJenkins removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861440 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111317/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
SparkQA removed a comment on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534817882 **[Test build #111317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111317/testReport)** for PR 25903 at commit [`31db62d`](https://github.com/apache/spark/commit/31db62d1653173475e3ab8a46e59c0e8a45cb0a8). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog
SparkQA commented on issue #25903: [SPARK-29215][SQL] current namespace should be tracked in SessionCatalog if the current catalog is session catalog URL: https://github.com/apache/spark/pull/25903#issuecomment-534861087 **[Test build #111317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111317/testReport)** for PR 25903 at commit [`31db62d`](https://github.com/apache/spark/commit/31db62d1653173475e3ab8a46e59c0e8a45cb0a8). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL] Spark sql null type incompatible with hive void type
ulysses-you commented on a change in pull request #25085: [SPARK-28313][SQL]
Spark sql null type incompatible with hive void type
URL: https://github.com/apache/spark/pull/25085#discussion_r327938382
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##
@@ -961,7 +961,11 @@ private[hive] object HiveClientImpl {
/** Get the Spark SQL native DataType from Hive's FieldSchema. */
private def getSparkSQLDataType(hc: FieldSchema): DataType = {
try {
- CatalystSqlParser.parseDataType(hc.getType)
+ hc.getType match {
+// SPARK-28313 compatible hive void type
+case "void" => NullType
Review comment:
Fix this point, hive void type will be converted to null type.
Such as, t1 have a void type column c1, when execute `show create table
$tbl`.
Spark:
`create table t1 (c1 null)`
Hive:
`create table t1 (c1 void)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859916 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111325/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859916 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111325/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859914 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
SparkQA removed a comment on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534838545 **[Test build #111325 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111325/testReport)** for PR 25863 at commit [`4640861`](https://github.com/apache/spark/commit/4640861480fd201846d87aba3ab8e756b972e814). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
AmplabJenkins commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859914 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result.
SparkQA commented on issue #25863: [WIP][SPARK-29037][CORE][SQL] For static partition overwrite, spark may give duplicate result. URL: https://github.com/apache/spark/pull/25863#issuecomment-534859719 **[Test build #111325 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111325/testReport)** for PR 25863 at commit [`4640861`](https://github.com/apache/spark/commit/4640861480fd201846d87aba3ab8e756b972e814). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE]
Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
URL: https://github.com/apache/spark/pull/25922#discussion_r327935435
##
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##
@@ -537,22 +537,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
*/
private def numExistingExecutors: Int = executorDataMap.size
- override def getExecutorIds(): Seq[String] = {
+ override def getExecutorIds(): Seq[String] = synchronized {
executorDataMap.keySet.toSeq
}
override def isExecutorActive(id: String): Boolean = synchronized {
executorDataMap.contains(id) && !executorsPendingToRemove.contains(id)
}
- override def maxNumConcurrentTasks(): Int = {
+ override def maxNumConcurrentTasks(): Int = synchronized {
executorDataMap.values.map { executor =>
executor.totalCores / scheduler.CPUS_PER_TASK
}.sum
}
// this function is for testing only
- def getExecutorAvailableResources(executorId: String): Map[String,
ExecutorResourceInfo] = {
+ def getExecutorAvailableResources(
+ executorId: String): Map[String, ExecutorResourceInfo] = synchronized {
Review comment:
Yep. No problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ConeyLiu commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
ConeyLiu commented on a change in pull request #25922: [SPARK-29236][CORE]
Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
URL: https://github.com/apache/spark/pull/25922#discussion_r327933288
##
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##
@@ -537,22 +537,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
*/
private def numExistingExecutors: Int = executorDataMap.size
- override def getExecutorIds(): Seq[String] = {
+ override def getExecutorIds(): Seq[String] = synchronized {
executorDataMap.keySet.toSeq
}
override def isExecutorActive(id: String): Boolean = synchronized {
executorDataMap.contains(id) && !executorsPendingToRemove.contains(id)
}
- override def maxNumConcurrentTasks(): Int = {
+ override def maxNumConcurrentTasks(): Int = synchronized {
executorDataMap.values.map { executor =>
executor.totalCores / scheduler.CPUS_PER_TASK
}.sum
}
// this function is for testing only
- def getExecutorAvailableResources(executorId: String): Map[String,
ExecutorResourceInfo] = {
+ def getExecutorAvailableResources(
+ executorId: String): Map[String, ExecutorResourceInfo] = synchronized {
Review comment:
Hi @dongjoon-hyun, thanks for reviewing. Only those who accessing
`executorDataMap` out of `DriverEndpoint`. I suggest this method to synchronize
too because it will not add too much overhead for the test.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111320/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
AmplabJenkins removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853802 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
dongjoon-hyun closed pull request #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853802 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
AmplabJenkins commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853811 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111320/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
dongjoon-hyun commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853560 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
SparkQA removed a comment on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534822573 **[Test build #111320 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111320/testReport)** for PR 25912 at commit [`9cbd46f`](https://github.com/apache/spark/commit/9cbd46fc8ac3e1eb83e1ec20e9b6f6110b2caa71). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities.
SparkQA commented on issue #25912: [SPARK-29226][BUILD] Upgrade jackson-databind to 2.9.10 and fix vulnerabilities. URL: https://github.com/apache/spark/pull/25912#issuecomment-534853402 **[Test build #111320 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111320/testReport)** for PR 25912 at commit [`9cbd46f`](https://github.com/apache/spark/commit/9cbd46fc8ac3e1eb83e1ec20e9b6f6110b2caa71). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION
dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL]
Support ALTER DATABASE SET LOCATION
URL: https://github.com/apache/spark/pull/25883#discussion_r327929067
##
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala
##
@@ -201,6 +202,22 @@ class VersionsSuite extends SparkFunSuite with Logging {
val database = client.getDatabase("temporary").copy(properties =
Map("flag" -> "true"))
client.alterDatabase(database)
assert(client.getDatabase("temporary").properties.contains("flag"))
+
+ // test alter database location
+ val tempDatabasePath2 = Utils.createTempDir().toURI
+ // Hive support alter database location since HIVE-8472(Hive 3.0).
Review comment:
`since HIVE-8472` is correct, but `since ...(Hive 3.0)` is incorrect.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL] Support ALTER DATABASE SET LOCATION
dongjoon-hyun commented on a change in pull request #25883: [SPARK-28476][SQL]
Support ALTER DATABASE SET LOCATION
URL: https://github.com/apache/spark/pull/25883#discussion_r327928927
##
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##
@@ -363,6 +363,12 @@ private[hive] class HiveClientImpl(
}
override def alterDatabase(database: CatalogDatabase): Unit = withHiveState {
+if (!getDatabase(database.name).locationUri.equals(database.locationUri)) {
+ if (!(version.equals(hive.v3_0) || version.equals(hive.v3_1))) {
Review comment:
Usually, we need IDed TODO here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847695 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111314/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847695 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111314/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
AmplabJenkins removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847688 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
SparkQA removed a comment on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534787764 **[Test build #111314 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111314/testReport)** for PR 25690 at commit [`e4ed806`](https://github.com/apache/spark/commit/e4ed806b65dfbf70b323e75eb10471dfd89b5c02). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
AmplabJenkins commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847688 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file
SparkQA commented on issue #25690: [SPARK-27831][FOLLOW-UP][SQL][TEST][test-maven][test-hadoop3.2][test-java11] Move Hive test jars to local file URL: https://github.com/apache/spark/pull/25690#issuecomment-534847502 **[Test build #111314 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111314/testReport)** for PR 25690 at commit [`e4ed806`](https://github.com/apache/spark/commit/e4ed806b65dfbf70b323e75eb10471dfd89b5c02). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE]
Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
URL: https://github.com/apache/spark/pull/25922#discussion_r327928252
##
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##
@@ -537,22 +537,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
*/
private def numExistingExecutors: Int = executorDataMap.size
- override def getExecutorIds(): Seq[String] = {
+ override def getExecutorIds(): Seq[String] = synchronized {
executorDataMap.keySet.toSeq
}
override def isExecutorActive(id: String): Boolean = synchronized {
executorDataMap.contains(id) && !executorsPendingToRemove.contains(id)
}
- override def maxNumConcurrentTasks(): Int = {
+ override def maxNumConcurrentTasks(): Int = synchronized {
executorDataMap.values.map { executor =>
executor.totalCores / scheduler.CPUS_PER_TASK
}.sum
}
// this function is for testing only
- def getExecutorAvailableResources(executorId: String): Map[String,
ExecutorResourceInfo] = {
+ def getExecutorAvailableResources(
+ executorId: String): Map[String, ExecutorResourceInfo] = synchronized {
Review comment:
BTW, this method is testing-only. We may not need for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
dongjoon-hyun commented on a change in pull request #25922: [SPARK-29236][CORE]
Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
URL: https://github.com/apache/spark/pull/25922#discussion_r327928039
##
File path:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
##
@@ -537,22 +537,23 @@ class CoarseGrainedSchedulerBackend(scheduler:
TaskSchedulerImpl, val rpcEnv: Rp
*/
private def numExistingExecutors: Int = executorDataMap.size
- override def getExecutorIds(): Seq[String] = {
+ override def getExecutorIds(): Seq[String] = synchronized {
executorDataMap.keySet.toSeq
}
override def isExecutorActive(id: String): Boolean = synchronized {
executorDataMap.contains(id) && !executorsPendingToRemove.contains(id)
}
- override def maxNumConcurrentTasks(): Int = {
+ override def maxNumConcurrentTasks(): Int = synchronized {
executorDataMap.values.map { executor =>
executor.totalCores / scheduler.CPUS_PER_TASK
}.sum
}
// this function is for testing only
- def getExecutorAvailableResources(executorId: String): Map[String,
ExecutorResourceInfo] = {
+ def getExecutorAvailableResources(
+ executorId: String): Map[String, ExecutorResourceInfo] = synchronized {
Review comment:
@ConeyLiu So, are these all of them which needs `synchronized`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846727 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16377/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846721 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846721 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ueshin commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions
ueshin commented on issue #25666: [SPARK-28962][SQL] Provide index argument to filter lambda functions URL: https://github.com/apache/spark/pull/25666#issuecomment-534846779 @nvander1 I'm not sure whether we also need the index argument in `exists`, `forall` and `aggregate`, but we should do it in separate PRs anyway. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846727 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16377/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
SparkQA commented on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534846522 **[Test build #111328 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/111328/testReport)** for PR 25922 at commit [`2dc9905`](https://github.com/apache/spark/commit/2dc990534d3b1bcdcc72e023ab289f6cc7cf0616). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows
AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846174 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock
AmplabJenkins removed a comment on issue #25922: [SPARK-29236][CORE] Access 'executorDataMap' out of 'DriverEndpoint' should be protected by lock URL: https://github.com/apache/spark/pull/25922#issuecomment-534819526 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows
AmplabJenkins removed a comment on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846174 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows
AmplabJenkins commented on issue #25913: [WIP][SPARK-29221][SQL] LocalTableScanExec: handle the case where executors are accessing "null" rows URL: https://github.com/apache/spark/pull/25913#issuecomment-534846178 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111315/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
