subject:"\[GitHub\] \[spark\] cloud\-fan commented on a change in pull request #26519\: \[SPARK\-29894\]\[SQL\]\[WEBUI\] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab"

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-19 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r348006808
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
 ##
 @@ -77,8 +77,9 @@ object SparkPlanGraph {
   parent: SparkPlanGraphNode,
   subgraph: SparkPlanGraphCluster,
   exchanges: mutable.HashMap[SparkPlanInfo, SparkPlanGraphNode]): Unit = {
+val WholeStageCodegenPattern = "(WholeStageCodegen.*)".r
 planInfo.nodeName match {
-  case "WholeStageCodegen" =>
 
 Review comment:
   how about `case name if name.startsWith("WholeStageCodegen")`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-18 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245919
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala
 ##
 @@ -71,6 +77,8 @@ private[execution] object SparkPlanInfo {
   plan.nodeName,
 
 Review comment:
   We can construct the name with `codegenStageId` here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-18 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245554
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
 ##
 @@ -88,7 +88,8 @@ object SparkPlanGraph {
   planInfo.nodeName,
 
 Review comment:
   We can construct the name with `codegenStageId` here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-18 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245991
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlanInfo.scala
 ##
 @@ -71,6 +77,8 @@ private[execution] object SparkPlanInfo {
   plan.nodeName,
 
 Review comment:
   then the diff can be much smaller.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-18 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245554
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
 ##
 @@ -88,7 +88,8 @@ object SparkPlanGraph {
   planInfo.nodeName,
 
 Review comment:
   We can construct the name with `codegenStageId` here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

2019-11-18 Thread GitBox

cloud-fan commented on a change in pull request #26519: 
[SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI 
SQL Tab
URL: https://github.com/apache/spark/pull/26519#discussion_r347245203
 
 

 ##
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SparkPlanGraph.scala
 ##
 @@ -189,18 +191,19 @@ private[ui] class SparkPlanGraphCluster(
 name: String,
 desc: String,
 val nodes: mutable.ArrayBuffer[SparkPlanGraphNode],
-metrics: Seq[SQLPlanMetric])
-  extends SparkPlanGraphNode(id, name, desc, metrics) {
+metrics: Seq[SQLPlanMetric],
+codegenStageId: Option[Int] = None)
 
 Review comment:
   can we include the codegen id when building the `name`? Then we don't need 
to change the class signature here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

[GitHub] [spark] cloud-fan commented on a change in pull request #26519: [SPARK-29894][SQL][WEBUI] Add Codegen Stage Id to Spark plan graphs in Web UI SQL Tab

6 matches

Site Navigation

Mail list logo

Footer information