[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox 


cloud-fan commented on a change in pull request #28671:
URL: https://github.com/apache/spark/pull/28671#discussion_r432244219



##
File path: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
##
@@ -811,6 +811,63 @@ class HiveThriftBinaryServerSuite extends 
HiveThriftJdbcTest {
   }
 }
   }
+
+  test("SPARK-31859 Thriftserver works with 
spark.sql.datetime.java8API.enabled=true") {
+withJdbcStatement() { statement =>
+  withJdbcStatement() { st =>
+st.execute("set spark.sql.datetime.java8API.enabled=true")
+val rs = st.executeQuery("select date '2020-05-28', timestamp 
'2020-05-28 00:00:00'")
+rs.next()
+assert(rs.getDate(1).toString() == "2020-05-28")
+assert(rs.getTimestamp(2).toString() == "2020-05-28 00:00:00.0")
+  }
+}
+  }
+
+  test("SPARK-31861 Thriftserver respects spark.sql.session.timeZone") {
+withJdbcStatement() { statement =>
+  withJdbcStatement() { st =>
+st.execute("set spark.sql.session.timeZone=+03:15") // different than 
Thriftserver's JVM tz
+  val rs = st.executeQuery("select timestamp '2020-05-28 10:00:00'")
+rs.next()
+val ts = rs.getTimestamp(1)
+val tsString = rs.getString(1)

Review comment:
   this is not used.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox 


cloud-fan commented on a change in pull request #28671:
URL: https://github.com/apache/spark/pull/28671#discussion_r432243974



##
File path: 
sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/ColumnValue.java
##
@@ -178,9 +178,9 @@ public static TColumnValue toTColumnValue(Type type, Object 
value) {
 case VARCHAR_TYPE:
   return stringValue((HiveVarchar)value);
 case DATE_TYPE:
-  return dateValue((Date)value);
 case TIMESTAMP_TYPE:
-  return timestampValue((Timestamp)value);

Review comment:
   shall we remove the `dateValue` and `timestampValue` methods?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox 


cloud-fan commented on a change in pull request #28671:
URL: https://github.com/apache/spark/pull/28671#discussion_r432237754



##
File path: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperationUtils.scala
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.thriftserver
+
+import org.apache.hive.service.cli.session.HiveSession
+
+import org.apache.spark.SparkContext
+import org.apache.spark.sql.{SparkSession, SQLContext}
+import org.apache.spark.sql.catalyst.catalog.CatalogTableType
+import org.apache.spark.sql.catalyst.catalog.CatalogTableType.{EXTERNAL, 
MANAGED, VIEW}
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.util.Utils
+
+/**
+ * Utils for Spark operations.
+ */
+private[hive] trait SparkOperationUtils {

Review comment:
   how about
   ```
   trait SparkOperationUtils extends Operation {
 ...
 
 abstract override def run(): Unit = {
   withLocalProperties {
 super.run()
   }
 }
   }
   ```
   
   You can try this in scala shell
   ```
   class AA {
 def f(): Int = 1
   }
   
   trait BB extends AA {
 abstract override def f(): Int = super.f() + 1
   }
   
   class CC extends AA with BB
   
   new CC().f // print 2
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #28671: [SPARK-31859][SPARK-31861][SPARK-31863] Fix Thriftserver session timezone issues

2020-05-28 Thread GitBox 


cloud-fan commented on a change in pull request #28671:
URL: https://github.com/apache/spark/pull/28671#discussion_r432237754



##
File path: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkOperationUtils.scala
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive.thriftserver
+
+import org.apache.hive.service.cli.session.HiveSession
+
+import org.apache.spark.SparkContext
+import org.apache.spark.sql.{SparkSession, SQLContext}
+import org.apache.spark.sql.catalyst.catalog.CatalogTableType
+import org.apache.spark.sql.catalyst.catalog.CatalogTableType.{EXTERNAL, 
MANAGED, VIEW}
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.util.Utils
+
+/**
+ * Utils for Spark operations.
+ */
+private[hive] trait SparkOperationUtils {

Review comment:
   how about
   ```
   trait SparkOperationUtils { this: Operation =>
 ...
 
 override def run(): Unit = {
   withLocalProperties {
 .run()
   }
 }
   }
   ```
   
   You can try this in scala shell
   ```
   class AA {
 def f(): Int = 1
   }
   
   trait BB { this: AA =>
 override def f(): Int = 2
   }
   
   class CC extends AA with BB
   
   new CC().f // print 2
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org