[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99907/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #99907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99907/testReport)** for PR 21109 at commit [`07ff4d3`](https://github.com/apache/spark/commit/07ff4d3a69967e13438dd8bd3e4130bf23b65c7d). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #99907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99907/testReport)** for PR 21109 at commit [`07ff4d3`](https://github.com/apache/spark/commit/07ff4d3a69967e13438dd8bd3e4130bf23b65c7d). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95807/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #95807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95807/testReport)** for PR 21109 at commit [`0a5c8de`](https://github.com/apache/spark/commit/0a5c8de7769315934712bf853401c332dd747a6e). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #95807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95807/testReport)** for PR 21109 at commit [`0a5c8de`](https://github.com/apache/spark/commit/0a5c8de7769315934712bf853401c332dd747a6e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user ctslater commented on the issue: https://github.com/apache/spark/pull/21109 @cloud-fan, could you point us at the papers that describe rewriting range join into equi-join? That would be a very convenient solution, but I've been digging through the literature and haven't found anything showing how to do that. All the experiments I've tried result in cartesian joins. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 Sorry, I don't quite understand your question. This already applies (only) to equijoins if there are additional range conditions on secondary columns. So if Spark rewrites those range conditions (?), and you end up with two equijoins (doesn't sound like a realistic scenario), then this doesn't apply at all. But if you have an equi-join which cannot be performed because you need to match a huge number of rows, and you can narrow down the search window using range conditions, then the advantage is that this makes it feasible and/or much, much faster. Regarding the second point, I don't want to tell you what to do, but on my part I can say that this has been tested with unit tests and on real, large datasets and I believe it should be safe to merge. But it can also wait for 2.5/3.0... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21109 What's the advantage of this feature when Spark can rewrite range join to equal join logically? BTW I also hesitate to merge such a big patch to the SQL engine since we are close to code freeze. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 I implemented spill over to disk, I added tests for spilling over and I tested it on live data. Everything works well (actually it was easier than I thought at first). I also removed the `InMemoryUnsafeRowQueue` class and implemented moving window changes in the `ExternalAppendOnlyUnsafeRowArray` class. It is no longer "append only" but I didn't want to change the name too. Unit tests are passing and it merges cleanly so I hope this can now be merged. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94631/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #94631 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94631/testReport)** for PR 21109 at commit [`af59b8a`](https://github.com/apache/spark/commit/af59b8a285ffe968d87cdf1bf9758b142e0bcfd4). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94630/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #94630 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94630/testReport)** for PR 21109 at commit [`62a8071`](https://github.com/apache/spark/commit/62a807168db9522673c194fbfa8c326c8688da82). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #94631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94631/testReport)** for PR 21109 at commit [`af59b8a`](https://github.com/apache/spark/commit/af59b8a285ffe968d87cdf1bf9758b142e0bcfd4). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #94630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94630/testReport)** for PR 21109 at commit [`62a8071`](https://github.com/apache/spark/commit/62a807168db9522673c194fbfa8c326c8688da82). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 That is a restriction if you regard this as an implementation of a range join, which it is not. This is an *optimization of an equi join*. The intention never was for it to work as a range join. I can investigate the logical rewrite approach, but as a part of a different JIRA ticket, one which would actually be related to a range join. Thanks for looking into this, though. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21109 > Regarding the second point, this is not an ordinary range join, but an equi-join with a secondary range condition. "an equi-join with a secondary range condition" is a restriction isn't it? IIRC the logical rewrite approach can work for range join without equi-join, which has broader use cases. e.g. turning a cartisian join into hash join/SMJ. I took a quick look at this patch, it's really bulky, and not safe to be turned on by default without the spill ability. And more importantly, it can't work for range join without equi-condition, which I think should be a common use case. Can you investigate the logical rewrite approach? I'll attach some related papers if I find them. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 Implementing spilling over seems a lot of work because this is a queue. If data is spilled over to disk and you need to pop from the queue, it is not clear to me what is the best way to do that. Do you spill over only one part of the queue (so that you can add or pop more efficiently)? Which part (the beginning or the end)? Or maybe the middle? What is the threshold to bring it back to memory from disk? And other similar questions... But I think it can be expected that much less memory will be consumed by the queue, compared to the original `ExternalAppendOnlyUnsafeRowArray`, because the queue's purpose IS to reduce the number of rows in memory, so spill-over would rarely be needed (that would depend, of course, to the user's range condition). That's why implementing spilling over doesn't seem critical to me. I can try and implement it, if everybody thinks it's really needed, but as I said, it's not clear (to me) what would be the best approach. Regarding the second point, this is not an ordinary range join, but an equi-join with a secondary range condition. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21109 I think range join is a very important feature, but the current implementation is not robust enough(no spilling to disk). Have you explored other simpler solutions? I vaguely remember that some papers describe a way to rewrite range join to equal-join during the logical phase. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92472/ Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92472/testReport)** for PR 21109 at commit [`39247ba`](https://github.com/apache/spark/commit/39247bac0de645aa959cc7fd11a27e36532181a5). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92472/testReport)** for PR 21109 at commit [`39247ba`](https://github.com/apache/spark/commit/39247bac0de645aa959cc7fd11a27e36532181a5). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92467/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92467/testReport)** for PR 21109 at commit [`7f7ab25`](https://github.com/apache/spark/commit/7f7ab257bc14f5b529de6c22b45f00bc2724ab20). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92467/testReport)** for PR 21109 at commit [`7f7ab25`](https://github.com/apache/spark/commit/7f7ab257bc14f5b529de6c22b45f00bc2724ab20). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92441 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92441/testReport)** for PR 21109 at commit [`a2a5f82`](https://github.com/apache/spark/commit/a2a5f82c377402348a82e5db5587504d39f5a894). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92441/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92441 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92441/testReport)** for PR 21109 at commit [`a2a5f82`](https://github.com/apache/spark/commit/a2a5f82c377402348a82e5db5587504d39f5a894). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92436/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92436 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92436/testReport)** for PR 21109 at commit [`497aa52`](https://github.com/apache/spark/commit/497aa52c9a0e15b1fdf0674c9b9510deef9e5dc1). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92436 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92436/testReport)** for PR 21109 at commit [`497aa52`](https://github.com/apache/spark/commit/497aa52c9a0e15b1fdf0674c9b9510deef9e5dc1). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92435/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92435 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92435/testReport)** for PR 21109 at commit [`48c3929`](https://github.com/apache/spark/commit/48c392906488167141355ac4e0ef41c449357280). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92435 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92435/testReport)** for PR 21109 at commit [`48c3929`](https://github.com/apache/spark/commit/48c392906488167141355ac4e0ef41c449357280). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92247: Deflake Build #92089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92247/testReport)** for PR 21109 at commit [`9889ba1`](https://github.com/apache/spark/commit/9889ba1ddbf0bfcb4d48b890634b6389ac4bd535). * This patch **fails due to an unknown error code, -9**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92247: Deflake Build #92089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92247/testReport)** for PR 21109 at commit [`9889ba1`](https://github.com/apache/spark/commit/9889ba1ddbf0bfcb4d48b890634b6389ac4bd535). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92089/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92089 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92089/testReport)** for PR 21109 at commit [`9889ba1`](https://github.com/apache/spark/commit/9889ba1ddbf0bfcb4d48b890634b6389ac4bd535). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92089 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92089/testReport)** for PR 21109 at commit [`9889ba1`](https://github.com/apache/spark/commit/9889ba1ddbf0bfcb4d48b890634b6389ac4bd535). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92071/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92071 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92071/testReport)** for PR 21109 at commit [`3ccc292`](https://github.com/apache/spark/commit/3ccc2929dfd828e333d4deaacdb993e9fc7e5f28). * This patch **fails due to an unknown error code, -9**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92071 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92071/testReport)** for PR 21109 at commit [`3ccc292`](https://github.com/apache/spark/commit/3ccc2929dfd828e333d4deaacdb993e9fc7e5f28). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92038/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92038 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92038/testReport)** for PR 21109 at commit [`66d7cbf`](https://github.com/apache/spark/commit/66d7cbf76ec0170bd8e78d4b936e6c7650998f34). * This patch **fails PySpark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92038 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92038/testReport)** for PR 21109 at commit [`66d7cbf`](https://github.com/apache/spark/commit/66d7cbf76ec0170bd8e78d4b936e6c7650998f34). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/21109 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92023/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92023/testReport)** for PR 21109 at commit [`66d7cbf`](https://github.com/apache/spark/commit/66d7cbf76ec0170bd8e78d4b936e6c7650998f34). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #92023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92023/testReport)** for PR 21109 at commit [`66d7cbf`](https://github.com/apache/spark/commit/66d7cbf76ec0170bd8e78d4b936e6c7650998f34). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91917/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91917/testReport)** for PR 21109 at commit [`8eaab13`](https://github.com/apache/spark/commit/8eaab130b9eb6b9f3224c323165b6dc2b175f8ac). * This patch **fails from timeout after a configured wait of \`300m\`**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91917 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91917/testReport)** for PR 21109 at commit [`8eaab13`](https://github.com/apache/spark/commit/8eaab130b9eb6b9f3224c323165b6dc2b175f8ac). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91913/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91913/testReport)** for PR 21109 at commit [`746fad3`](https://github.com/apache/spark/commit/746fad3f9caf5d8d43f91b66c45091ef52411ce2). * This patch **fails Scala style tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91913 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91913/testReport)** for PR 21109 at commit [`746fad3`](https://github.com/apache/spark/commit/746fad3f9caf5d8d43f91b66c45091ef52411ce2). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91912/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91912/testReport)** for PR 21109 at commit [`3e9b3e2`](https://github.com/apache/spark/commit/3e9b3e2be380d3973cb559ce88b3fff588f3dd3e). * This patch **fails Scala style tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91912/testReport)** for PR 21109 at commit [`3e9b3e2`](https://github.com/apache/spark/commit/3e9b3e2be380d3973cb559ce88b3fff588f3dd3e). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91900/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91900 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91900/testReport)** for PR 21109 at commit [`6d72fe0`](https://github.com/apache/spark/commit/6d72fe0466f210e001a67829e0f42379abc7e4f0). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91900 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91900/testReport)** for PR 21109 at commit [`6d72fe0`](https://github.com/apache/spark/commit/6d72fe0466f210e001a67829e0f42379abc7e4f0). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91824/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91824 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91824/testReport)** for PR 21109 at commit [`82c194a`](https://github.com/apache/spark/commit/82c194a8a03b6cc028de303fbc07c68d6078cc2b). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91824 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91824/testReport)** for PR 21109 at commit [`82c194a`](https://github.com/apache/spark/commit/82c194a8a03b6cc028de303fbc07c68d6078cc2b). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91785/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91785 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91785/testReport)** for PR 21109 at commit [`fb99390`](https://github.com/apache/spark/commit/fb99390a4baf62ce953be5a78c552adae98c1ffa). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91785 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91785/testReport)** for PR 21109 at commit [`fb99390`](https://github.com/apache/spark/commit/fb99390a4baf62ce953be5a78c552adae98c1ffa). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91760/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91760 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91760/testReport)** for PR 21109 at commit [`5c64b55`](https://github.com/apache/spark/commit/5c64b55766630ffec33ac3c82ce10703dc3d526c). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21109 **[Test build #91760 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91760/testReport)** for PR 21109 at commit [`5c64b55`](https://github.com/apache/spark/commit/5c64b55766630ffec33ac3c82ce10703dc3d526c). --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 There's no design doc. I didn't feel the change was big enough to warrant one. 1. Currently there is no spill-over to disk. If the range is too big, users can switch this off and use the much slower SMJ version, without an OOM. Implementing spill-over doesn't look trivial because it's more dynamic than the original version. It's not clear how to implement that. Maybe we can add that in the future, once we figure it out? 2. This whole optimization doesn't apply when there is no equal condition. 3. I didn't understand this case you're describing. Can you elaborate, please? Either way, only one pass through the data is needed, skewed or not skewed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21109 do we have a design doc? I have a couple of high-level questions: 1. what if the range is big and the queue OOM? 2. can't we apply it with cartesian join if there is no equal condition? and what about broadcast join? 3. if the equal join key is skewed, then we kind of doing this sort-merge-range-join in a single thread, even if the range join key is not skewed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 @davies pointed out that `InMemoryUnsafeRowQueue` was throwing an exception when `numRowsInMemoryBufferThreshold` was reached. That is now fixed and only a warning is logged. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 @tedyu @gatorsmile Can you please trigger the build again? It failed for some unrelated reason. Thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user zecevicp commented on the issue: https://github.com/apache/spark/pull/21109 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91534/ Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark issue #21109: [SPARK-24020][SQL] Sort-merge join inner range optimizat...
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21109 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
