[GitHub] spark issue #22463: remove annotation @Experimental

2018-11-08 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22463
  
I'd close this, evaluate which Experimental tags look clearly 'wrong' (i.e. 
something long established in a public API) and then open a JIRA targeted at 
3.0 to consider removing them.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-23 Thread srowen
Github user srowen commented on the issue:

https://github.com/apache/spark/pull/22463
  
Yeah, I think Experimental is over-used in the APIs. They just never get 
un-marked and lots of pretty old stuff, that de facto is just not changeable 
now, is still labeled this way. This seems to be more "DeveloperAPI" than 
"Experimental". Still, I also don't know the right answer for this code. Ping 
the author?

I figured we'd remove just about all current Experimental tags when, say, 
Spark 3 rolls around.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread markhamstra
Github user markhamstra commented on the issue:

https://github.com/apache/spark/pull/22463
  
Where is the discussion on these utility methods no longer being 
Experimental? I'm not saying that they are not stable, but the Kafka 0.10 API 
in general being considered to be stable doesn't preclude some Kafka-related 
methods from still being other than stable, and promoting API to stable (i.e. 
cannot be changed without a major release) is a pretty big deal.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/spark/pull/22463
  
Why don't we just leave it or mark them as deprecated.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22463
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22463
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark issue #22463: remove annotation @Experimental

2018-09-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue:

https://github.com/apache/spark/pull/22463
  
Can one of the admins verify this patch?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org