[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user avulanov commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148817255 @jkbradley According to the time taken it actually did the shuffle. However, I am not sure how useful in practice these block-diagonal matrices. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8757 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148851400 This LGTM. I'll merge it with master. Thanks for the PR! @avulanov I looked at your code, but the results seem strange to me. We'll have to look into it more, I guess. As far as utility of block-diagonal matrices, I've mainly seen them in the context of specialized applications with very structured feature interactions, but my experience there is from research, not industry. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148145424 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148145399 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148139530 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148139413 [Test build #43726 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43726/console) for PR 8757 at commit [`19c4b13`](https://github.com/apache/spark/commit/19c4b13f9ac5220e939e89d4a4be3ffca0cc3205). * This patch **fails MiMa tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148139536 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43726/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148144514 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148133941 [Test build #43726 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43726/consoleFull) for PR 8757 at commit [`19c4b13`](https://github.com/apache/spark/commit/19c4b13f9ac5220e939e89d4a4be3ffca0cc3205). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148145666 [Test build #43727 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43727/consoleFull) for PR 8757 at commit [`19c4b13`](https://github.com/apache/spark/commit/19c4b13f9ac5220e939e89d4a4be3ffca0cc3205). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148131064 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148131106 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148161067 [Test build #43727 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43727/console) for PR 8757 at commit [`19c4b13`](https://github.com/apache/spark/commit/19c4b13f9ac5220e939e89d4a4be3ffca0cc3205). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148162329 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43727/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148162325 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-10599][MLLIB] Lower communication for b...
Github user brkyvz commented on the pull request: https://github.com/apache/spark/pull/8757#issuecomment-148130199 @jkbradley Thank you for the review. Addressed your comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
