[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3558 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-126942028 This was fixed by #5806, so I think we can close this issue / PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97712608 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
GitHub user scwf opened a pull request: https://github.com/apache/spark/pull/5806 [SPARK-4699][SQL] make caseSensitive configurable in Analyzer.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/scwf/spark case Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/5806.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5806 commit 578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-02T17:33:44Z make caseSensitive configurable commit f57f15ce72652b3a04229a860a2aba22297368b8 Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-03T17:48:04Z add testcase commit 91b1b9606055211cfab409dbdecaa708aa83be34 Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-20T16:38:19Z make caseSensitive configurable in Analyzer commit e7bca31f6856a4fe2e301bc2ea608d709dcbe334 Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-20T17:25:20Z make caseSensitive configuration in Analyzer and Catalog commit fcbf0d9162574cf6f28dc703224e23d357f0aad9 Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-20T17:36:44Z fix scalastyle check commit 6332e0ffeac2180406cabfe789ef0ba697b49fa9 Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-03T13:56:51Z fix bug commit 005c56d7a4a9c0797870810efe227d3cef225b12 Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-03T14:08:27Z make SQLContext caseSensitivity configurable commit 9bf4cc7dbb069c4969c5f317590e3e9ddc4efd4f Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-03T14:39:10Z fix bug in catalyst commit 73c16b13b23e2b9e98ac6fb1864d8c98a3813dfb Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-03T17:02:17Z fix bug in sql/hive commit 05b09a3c1008869571e438c12e8593def7ecdc2c Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-19T07:42:39Z fix conflict base on the latest master branch commit dee56e9ae71ebd9c8464cf6be763895e8bcdf2e6 Author: Jacky Li jacky.li...@huawei.com Date: 2015-01-19T09:55:50Z fix test case failure commit 39e369c67f92105956486624cbc7d937627fd141 Author: Jacky Li jacky.li...@huawei.com Date: 2015-02-03T17:42:21Z fix confilct after DataFrame PR commit 12eca9a71d05fe74d44e4298f0587af31bf380d4 Author: Jacky Li jacky.li...@huawei.com Date: 2015-02-21T15:29:16Z solve conflict with master commit 664d1e9e610f2bef172cc3a10de452f1752ca51b Author: Jacky Li jacky.li...@huawei.com Date: 2015-02-21T15:30:37Z Merge branch 'master' of https://github.com/apache/spark into case commit 56034ca4baa25819b322905490cb0b75543f500c Author: wangfei wangf...@huawei.com Date: 2015-04-30T07:47:38Z fix conflicts and improve for catalystconf commit 5472b0832213aa0d7f092c06f54095477e695c93 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:17:28Z fix compile issue commit 69b3b708c2b78ed2e1061d69ef3e7c3b5e2d94c6 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:32:35Z fix AnalysisSuite commit fd30e25f84e569769519282cc3ec39e58a200e87 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:34:34Z added override commit 966e719b77e3e8e3e715e58f3a0aeed3b4aba009 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:41:13Z set CASE_SENSITIVE false in hivecontext commit 5d7c45618bcc0ba1195e406230972a9c237016c7 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:46:35Z set CASE_SENSITIVE false in TestHive commit 6ef31cfb5269e6298349cf97fbe28fcfa43c26ec Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:53:07Z revert pom changes commit eee75bad4d7eacb73cfc57ea733aed1dcd97ec11 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:55:34Z fix EmptyConf commit d5a99337c86c92e705098b95f844b928e5129213 Author: wangfei wangf...@huawei.com Date: 2015-04-30T08:59:04Z fix style --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97712629 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97712669 [Test build #31410 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31410/consoleFull) for PR 5806 at commit [`d5a9933`](https://github.com/apache/spark/commit/d5a99337c86c92e705098b95f844b928e5129213). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97732087 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31410/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97732074 [Test build #31410 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31410/consoleFull) for PR 5806 at commit [`d5a9933`](https://github.com/apache/spark/commit/d5a99337c86c92e705098b95f844b928e5129213). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class Param[T] (val parent: Params, val name: String, val doc: String, val isValid: T = Boolean)` * `class DoubleParam(parent: Params, name: String, doc: String, isValid: Double = Boolean)` * `class IntParam(parent: Params, name: String, doc: String, isValid: Int = Boolean)` * `class FloatParam(parent: Params, name: String, doc: String, isValid: Float = Boolean)` * `class LongParam(parent: Params, name: String, doc: String, isValid: Long = Boolean)` * `class BooleanParam(parent: Params, name: String, doc: String) // No need for isValid` * `case class ParamPair[T](param: Param[T], value: T) ` * `class KMeansModel (` * `trait PMMLExportable ` * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` * This patch **adds the following new dependencies:** * `jaxb-api-2.2.7.jar` * `jaxb-core-2.2.7.jar` * `jaxb-impl-2.2.7.jar` * `pmml-agent-1.1.15.jar` * `pmml-model-1.1.15.jar` * `pmml-schema-1.1.15.jar` * This patch **removes the following dependencies:** * `activation-1.1.jar` * `jaxb-api-2.2.2.jar` * `jaxb-impl-2.2.3-1.jar` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97732086 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97817791 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97817733 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97816395 [Test build #31421 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31421/consoleFull) for PR 5806 at commit [`7fc4a98`](https://github.com/apache/spark/commit/7fc4a987426974c07a10a5cd2ba2f920c5578da0). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97815883 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97818339 [Test build #31422 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31422/consoleFull) for PR 5806 at commit [`6db4bf5`](https://github.com/apache/spark/commit/6db4bf5448a9c6b7c1401b329c0fc55d6593faec). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97815915 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user scwf commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97882197 /cc @marmbrus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97855596 [Test build #31421 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31421/consoleFull) for PR 5806 at commit [`7fc4a98`](https://github.com/apache/spark/commit/7fc4a987426974c07a10a5cd2ba2f920c5578da0). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` * This patch does not change any dependencies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97855674 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31421/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97855667 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97860087 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31422/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97860080 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/5806#issuecomment-97860008 [Test build #31422 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31422/consoleFull) for PR 5806 at commit [`6db4bf5`](https://github.com/apache/spark/commit/6db4bf5448a9c6b7c1401b329c0fc55d6593faec). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` * This patch does not change any dependencies. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-89087424 ping. Thanks for working on this! However, to keep the PR queue small, I propose we close this issue until you have time to update it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3558#discussion_r27184692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import scala.collection.immutable
+
+private[spark] object CatalystConf{
+ val CASE_SENSITIVE = spark.sql.caseSensitive
+}
+
+private[spark] trait CatalystConf {
--- End diff --
Also, most interfaces in catalyst are not private since this package is not
part of our standard compatibility guarantees.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/3558#discussion_r27184671 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -39,11 +40,17 @@ object SimpleAnalyzer extends Analyzer(EmptyCatalog, EmptyFunctionRegistry, true */ class Analyzer(catalog: Catalog, --- End diff -- Existing: this indentation is wrong. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3558#discussion_r27184655
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/CatalystConf.scala ---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst
+
+import scala.collection.immutable
+
+private[spark] object CatalystConf{
+ val CASE_SENSITIVE = spark.sql.caseSensitive
+}
+
+private[spark] trait CatalystConf {
--- End diff --
I think the catalyst conf can be as simple as a set of abstract methods
that need to be implemented by some concrete conf.
```scala
trait CatalystConf {
def caseSensitiveAnalysis: Boolean
}
```
We can have a trivial one for testing: `case class
SimpleConf(caseSensitiveAnalysis: Boolean) extends CatalystConf` and SQLConf
can mix this trait in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75378106 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27815/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75378104 [Test build #27815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27815/consoleFull) for PR 3558 at commit [`12eca9a`](https://github.com/apache/spark/commit/12eca9a71d05fe74d44e4298f0587af31bf380d4). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75376674 [Test build #27815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27815/consoleFull) for PR 3558 at commit [`12eca9a`](https://github.com/apache/spark/commit/12eca9a71d05fe74d44e4298f0587af31bf380d4). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75376882 [Test build #27816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27816/consoleFull) for PR 3558 at commit [`664d1e9`](https://github.com/apache/spark/commit/664d1e9e610f2bef172cc3a10de452f1752ca51b). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75378526 [Test build #27816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27816/consoleFull) for PR 3558 at commit [`664d1e9`](https://github.com/apache/spark/commit/664d1e9e610f2bef172cc3a10de452f1752ca51b). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-75378528 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27816/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-72705867 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26660/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-72705843 [Test build #26660 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26660/consoleFull) for PR 3558 at commit [`39e369c`](https://github.com/apache/spark/commit/39e369c67f92105956486624cbc7d937627fd141). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-72698496 [Test build #26660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26660/consoleFull) for PR 3558 at commit [`39e369c`](https://github.com/apache/spark/commit/39e369c67f92105956486624cbc7d937627fd141). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user jackylk commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70803953 Please run the test again. I tested all sql and hive test case locally, and no error is reported. I am not sure why online test fails --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70459454 [Test build #25751 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25751/consoleFull) for PR 3558 at commit [`05b09a3`](https://github.com/apache/spark/commit/05b09a3c1008869571e438c12e8593def7ecdc2c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70459458 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25751/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70469261 [Test build #25755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25755/consoleFull) for PR 3558 at commit [`dee56e9`](https://github.com/apache/spark/commit/dee56e9ae71ebd9c8464cf6be763895e8bcdf2e6). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70473988 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25755/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70473982 [Test build #25755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25755/consoleFull) for PR 3558 at commit [`dee56e9`](https://github.com/apache/spark/commit/dee56e9ae71ebd9c8464cf6be763895e8bcdf2e6). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70456370 [Test build #25751 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25751/consoleFull) for PR 3558 at commit [`05b09a3`](https://github.com/apache/spark/commit/05b09a3c1008869571e438c12e8593def7ecdc2c). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user jackylk commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-70456295 I have updated the code based on SPARK-3965 (SPARK-5168) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-69476078 I think this should probably go in after #3965. We can have some parent trait in catalyst that the SQL version can extend. That way we can just pass the configuration we use in SQL back to catalyst. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68598122 [Test build #25014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25014/consoleFull) for PR 3558 at commit [`9bf4cc7`](https://github.com/apache/spark/commit/9bf4cc7dbb069c4969c5f317590e3e9ddc4efd4f). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68603019 [Test build #25015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25015/consoleFull) for PR 3558 at commit [`73c16b1`](https://github.com/apache/spark/commit/73c16b13b23e2b9e98ac6fb1864d8c98a3813dfb). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68601740 [Test build #25015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25015/consoleFull) for PR 3558 at commit [`73c16b1`](https://github.com/apache/spark/commit/73c16b13b23e2b9e98ac6fb1864d8c98a3813dfb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68603021 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25015/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68596087 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25012/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68596085 [Test build #25012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25012/consoleFull) for PR 3558 at commit [`6332e0f`](https://github.com/apache/spark/commit/6332e0ffeac2180406cabfe789ef0ba697b49fa9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68595566 [Test build #25011 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25011/consoleFull) for PR 3558 at commit [`8753610`](https://github.com/apache/spark/commit/8753610d09b9496a2d82d7348273af66960c3d2d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68596320 [Test build #25013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25013/consoleFull) for PR 3558 at commit [`005c56d`](https://github.com/apache/spark/commit/005c56d7a4a9c0797870810efe227d3cef225b12). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68595828 [Test build #25012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25012/consoleFull) for PR 3558 at commit [`6332e0f`](https://github.com/apache/spark/commit/6332e0ffeac2180406cabfe789ef0ba697b49fa9). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68595324 [Test build #25011 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25011/consoleFull) for PR 3558 at commit [`8753610`](https://github.com/apache/spark/commit/8753610d09b9496a2d82d7348273af66960c3d2d). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68596910 [Test build #25014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25014/consoleFull) for PR 3558 at commit [`9bf4cc7`](https://github.com/apache/spark/commit/9bf4cc7dbb069c4969c5f317590e3e9ddc4efd4f). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68596075 [Test build #25013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25013/consoleFull) for PR 3558 at commit [`005c56d`](https://github.com/apache/spark/commit/005c56d7a4a9c0797870810efe227d3cef225b12). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68595569 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25011/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-68394247 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741385 [Test build #24671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24671/consoleFull) for PR 3558 at commit [`91b1b96`](https://github.com/apache/spark/commit/91b1b9606055211cfab409dbdecaa708aa83be34). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741433 [Test build #24671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24671/consoleFull) for PR 3558 at commit [`91b1b96`](https://github.com/apache/spark/commit/91b1b9606055211cfab409dbdecaa708aa83be34). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741434 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24671/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741917 [Test build #24672 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24672/consoleFull) for PR 3558 at commit [`210915f`](https://github.com/apache/spark/commit/210915f58e9e541563f13999156292566b43715d). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741937 [Test build #24672 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24672/consoleFull) for PR 3558 at commit [`210915f`](https://github.com/apache/spark/commit/210915f58e9e541563f13999156292566b43715d). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67741939 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24672/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67742081 [Test build #24673 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24673/consoleFull) for PR 3558 at commit [`578d167`](https://github.com/apache/spark/commit/578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb). * This patch **does not merge cleanly**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67742900 [Test build #24674 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24674/consoleFull) for PR 3558 at commit [`e7bca31`](https://github.com/apache/spark/commit/e7bca31f6856a4fe2e301bc2ea608d709dcbe334). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67742930 [Test build #24674 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24674/consoleFull) for PR 3558 at commit [`e7bca31`](https://github.com/apache/spark/commit/e7bca31f6856a4fe2e301bc2ea608d709dcbe334). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SimpleCatalog(val conf: CatalystConf) extends Catalog ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67742932 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24674/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user jackylk commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67743335 modified according to @marmbrus, a CatalystConf trait is added and used in Analyzer and Catalog --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67743445 [Test build #24675 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24675/consoleFull) for PR 3558 at commit [`fcbf0d9`](https://github.com/apache/spark/commit/fcbf0d9162574cf6f28dc703224e23d357f0aad9). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67743788 [Test build #24675 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24675/consoleFull) for PR 3558 at commit [`fcbf0d9`](https://github.com/apache/spark/commit/fcbf0d9162574cf6f28dc703224e23d357f0aad9). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67743789 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24675/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67745351 [Test build #24673 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24673/consoleFull) for PR 3558 at commit [`578d167`](https://github.com/apache/spark/commit/578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb). * This patch **fails Spark unit tests**. * This patch **does not merge cleanly**. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67745356 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24673/ Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-67412045 I like the idea of having a configuration interface in catalyst that SQLConf can inherit from. We can then pass that into the analyzer. I do want the HiveContext to be configurable as well since it should be a super set of what you can do with SQLContext. By default it should be case insensitive to match Hive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-66291005 That's a good point, Can we make another interface that SqlConf inherit from? Or can we move the SqlConf into the module `Catalyst`? Any other idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user jackylk commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65892057 If we go for second way, it will create cyclic dependency between spark-catalyst and spark-sql sub-projects, because SQLConf and SQLContext is in spark-sql while Analyzer is in spark-catalyst. I think the current way the only drawback is that caseSensitive can only be set while initializing SQLContext, but can not be set after initialization. If client want to use case insensitive analyzer, he need to create a new SQLContext, which I think it is probably OK. I tested this way locally and it is passing SQLQuerySuite, I do not know why test case failed, as I can not access Jenkins test report now. Can anyone trigger Jenkins again, thanks. And any more suggestion for better solution? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65270774 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
GitHub user jackylk opened a pull request: https://github.com/apache/spark/pull/3558 [SPARK-4699][SQL] make caseSensitive configurable in Analyzer.scala You can merge this pull request into a Git repository by running: $ git pull https://github.com/jackylk/spark case Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/3558.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3558 commit 578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb Author: Jacky Li jacky.li...@huawei.com Date: 2014-12-02T17:33:44Z make caseSensitive configurable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65281087 Thanks for working on this! What about HiveContext? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65281098 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65281697 [Test build #24051 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24051/consoleFull) for PR 3558 at commit [`578d167`](https://github.com/apache/spark/commit/578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb). * This patch merges cleanly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65292413 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24051/ Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65292399 [Test build #24051 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24051/consoleFull) for PR 3558 at commit [`578d167`](https://github.com/apache/spark/commit/578d167bfccdc2d1d5ce9ca06cab7b7b753bb3eb). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65334620 I think we probably have to always keep the HiveContext analyzer case INSENSITIVE, See https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL, Hive will always normalizes the table/view names, columns etc. in DDL actually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65334998 The change LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user jackylk commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65340071 @chenghao-intel agreed. Besides, I think the caseSensitive passing to SimpleCatalog also needs to be changed here: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala#L61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65345962 Great, you're right, please make the change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-4699][SQL] make caseSensitive configura...
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/3558#issuecomment-65346490 And it will be nice if you can also add test suite for this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
