[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130467578 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/8143 [SPARK-9914] [ML] define setters explicitly for Java and use setParam group in RFormula The problem with defining setters in the base class is that it doesn't return the correct type in Java. @ericl You can merge this pull request into a Git repository by running: $ git pull https://github.com/mengxr/spark SPARK-9914 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/8143.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #8143 commit a49021b45d0d785cf64eafee1bd73cab7173af6e Author: Xiangrui Meng m...@databricks.com Date: 2015-08-12T22:28:42Z define setters explicitly for Java and use setParam group --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130468205 [Test build #40676 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40676/consoleFull) for PR 8143 at commit [`a49021b`](https://github.com/apache/spark/commit/a49021b45d0d785cf64eafee1bd73cab7173af6e). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130475162 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130475073 [Test build #40676 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40676/console) for PR 8143 at commit [`a49021b`](https://github.com/apache/spark/commit/a49021b45d0d785cf64eafee1bd73cab7173af6e). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class TaskSetFailed(taskSet: TaskSet, reason: String, exception: Option[Throwable])` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130467594 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/8143#discussion_r36924356
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -144,6 +145,12 @@ class RFormulaModel private[feature](
pipelineModel: PipelineModel)
extends Model[RFormulaModel] with RFormulaBase {
+ /** @group setParam */
--- End diff --
Does it make sense to have these setters for the Model? They will not take
effect for transform() since the model is already fitted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/8143#discussion_r36939962
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala
---
@@ -144,6 +145,12 @@ class RFormulaModel private[feature](
pipelineModel: PipelineModel)
extends Model[RFormulaModel] with RFormulaBase {
+ /** @group setParam */
--- End diff --
Right, we could change `featuresCol` in linear models. But the underlying
model is a pipeline. It might be hard to change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130527829 [Test build #40730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40730/consoleFull) for PR 8143 at commit [`d36c887`](https://github.com/apache/spark/commit/d36c88737742aee0c0bbab1333f92c215130ff8a). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130527782 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130527790 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130537160 [Test build #40730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40730/console) for PR 8143 at commit [`d36c887`](https://github.com/apache/spark/commit/d36c88737742aee0c0bbab1333f92c215130ff8a). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130537381 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user ericl commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130528387 Lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/8143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-9914] [ML] define setters explicitly fo...
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/8143#issuecomment-130541970 Merged into master and branch-1.5. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
