[GitHub] spark pull request #15160: [SPARK-17609][SQL] SessionCatalog.tableExists sho...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/15160


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15160: [SPARK-17609][SQL] SessionCatalog.tableExists sho...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/15160#discussion_r79669450
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala
 ---
@@ -47,15 +47,11 @@ case class CreateDataSourceTableCommand(table: 
CatalogTable, ignoreIfExists: Boo
 assert(table.provider.isDefined)
 
 val sessionState = sparkSession.sessionState
-val db = 
table.identifier.database.getOrElse(sessionState.catalog.getCurrentDatabase)
-val tableIdentWithDB = table.identifier.copy(database = Some(db))
-// Pass a table identifier with database part, so that `tableExists` 
won't check temp views
-// unexpectedly.
-if (sessionState.catalog.tableExists(tableIdentWithDB)) {
+if (sessionState.catalog.tableExists(table.identifier)) {
   if (ignoreIfExists) {
 return Seq.empty[Row]
   } else {
-throw new AnalysisException(s"Table 
${tableIdentWithDB.unquotedString} already exists.")
+throw new AnalysisException(s"Table 
${table.identifier.unquotedString} already exists.")
--- End diff --

The test failure is caused by this change. After this PR, 
`table.identifier` does not always have the database name. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #15160: [SPARK-17609][SQL] SessionCatalog.tableExists sho...

[cloud-fan]

GitHub user cloud-fan opened a pull request:

https://github.com/apache/spark/pull/15160

[SPARK-17609][SQL] SessionCatalog.tableExists should not check temp view

## What changes were proposed in this pull request?

After #15054 , there is no place in Spark SQL that need 
`SessionCatalog.tableExists` to check temp views, so this PR makes 
`SessionCatalog.tableExists` only check permanent table/view and removes some 
hacks.

This PR also improves the `getTempViewOrPermanentTableMetadata` that is 
introduced in  #15054 , to make the code simpler.

## How was this patch tested?

existing tests


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloud-fan/spark exists

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/15160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15160


commit d00860fe3cf6beeef1e431e02fb126177bc46415
Author: Wenchen Fan 
Date:   2016-09-20T13:16:42Z

SessionCatalog.tableExists should not check temp view




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org