[GitHub] spark pull request #15894: [SPARK-18188] Add checksum for shuffle blocks
Github user davies closed the pull request at: https://github.com/apache/spark/pull/15894 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15894: [SPARK-18188] Add checksum for shuffle blocks
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15894#discussion_r88551801
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -171,14 +179,30 @@ final class ShuffleBlockFetcherIterator(
override def onBlockFetchSuccess(blockId: String, buf:
ManagedBuffer): Unit = {
// Only add the buffer to results queue if the iterator is not
zombie,
// i.e. cleanup() has not been called yet.
+ val in = try {
--- End diff --
note: move this out of callback to not block network pool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15894: [SPARK-18188] Add checksum for shuffle blocks
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15894#discussion_r88207053
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/buffer/FileSegmentManagedBuffer.java
---
@@ -92,12 +91,27 @@ public ByteBuffer nioByteBuffer() throws IOException {
}
@Override
- public InputStream createInputStream() throws IOException {
+ public InputStream createInputStream(boolean checksum) throws
IOException {
--- End diff --
So, is this only for testing? because it's otherwise very expensive to
compute, requiring two passes over the file.
If so, should it not be in some more package-private method only and not
exposed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #15894: [SPARK-18188] Add checksum for shuffle blocks
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/15894 [SPARK-18188] Add checksum for shuffle blocks ## What changes were proposed in this pull request? TBD ## How was this patch tested? Existing tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/davies/spark shuffle_checksum Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/15894.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #15894 commit a68171cea01ce90ee41665bc1ee5bc6eaca03e32 Author: Davies Liu Date: 2016-11-14T23:16:10Z checksum --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
