[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[jaceklaskowski]

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/18509#discussion_r125874046
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
 ---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats: 
EventTimeStats = EventTime
 case class EventTimeWatermarkExec(
 eventTime: Attribute,
 delay: CalendarInterval,
-child: SparkPlan) extends SparkPlan {
+child: SparkPlan) extends UnaryExecNode {
--- End diff --

I disagree that the simple change requires a JIRA since it's about making 
the code more readable, but here it comes 
anyway...https://issues.apache.org/jira/browse/SPARK-21329


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[zsxwing]

Github user zsxwing commented on a diff in the pull request:

https://github.com/apache/spark/pull/18509#discussion_r125819776
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
 ---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats: 
EventTimeStats = EventTime
 case class EventTimeWatermarkExec(
 eventTime: Attribute,
 delay: CalendarInterval,
-child: SparkPlan) extends SparkPlan {
+child: SparkPlan) extends UnaryExecNode {
--- End diff --

Hm, I checked the Spark code style guide and it doesn't say anything about 
`override`. Then this is good to me.

By the way, could you spend one minute creating a JIRA ticket for this PR 
since it changes codes, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[jaceklaskowski]

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/18509#discussion_r125571708
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
 ---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats: 
EventTimeStats = EventTime
 case class EventTimeWatermarkExec(
 eventTime: Attribute,
 delay: CalendarInterval,
-child: SparkPlan) extends SparkPlan {
+child: SparkPlan) extends UnaryExecNode {
--- End diff --

@zsxwing friendly ping...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[jaceklaskowski]

Github user jaceklaskowski commented on a diff in the pull request:

https://github.com/apache/spark/pull/18509#discussion_r125353689
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
 ---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats: 
EventTimeStats = EventTime
 case class EventTimeWatermarkExec(
 eventTime: Attribute,
 delay: CalendarInterval,
-child: SparkPlan) extends SparkPlan {
+child: SparkPlan) extends UnaryExecNode {
--- End diff --

I don't see it used in the other physical operators like 
[HashAggregateExec](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala#L45)
 or 
[CoalesceExec](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala#L574)
 or 
[BroadcastExchangeExec](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala#L41)
 etc. Why would that matter here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[zsxwing]

Github user zsxwing commented on a diff in the pull request:

https://github.com/apache/spark/pull/18509#discussion_r125346130
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/EventTimeWatermarkExec.scala
 ---
@@ -81,7 +81,7 @@ class EventTimeStatsAccum(protected var currentStats: 
EventTimeStats = EventTime
 case class EventTimeWatermarkExec(
 eventTime: Attribute,
 delay: CalendarInterval,
-child: SparkPlan) extends SparkPlan {
+child: SparkPlan) extends UnaryExecNode {
--- End diff --

nit: `override val child`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18509: [SS][MINOR] Make EventTimeWatermarkExec explicitl...

[jaceklaskowski]

GitHub user jaceklaskowski opened a pull request:

https://github.com/apache/spark/pull/18509

[SS][MINOR] Make EventTimeWatermarkExec explicitly UnaryExecNode

## What changes were proposed in this pull request?

Making EventTimeWatermarkExec explicitly UnaryExecNode

/cc @tdas @zsxwing 

## How was this patch tested?

Local build.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jaceklaskowski/spark 
EventTimeWatermarkExec-UnaryExecNode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18509


commit 2cc9fdca381f50cb405bf5fbcaa7229652749a83
Author: Jacek Laskowski 
Date:   2017-07-03T07:07:12Z

[SS][MINOR] Make EventTimeWatermarkExec explicitly UnaryExecNode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org