[GitHub] spark pull request #18879: [SPARK-21662] modify the appname to [SparkSQL::lo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18879


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18879: [SPARK-21662] modify the appname to [SparkSQL::lo...

[liu-zhaokun]

Github user liu-zhaokun commented on a diff in the pull request:

https://github.com/apache/spark/pull/18879#discussion_r132126001
  
--- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
 ---
@@ -35,7 +35,7 @@ private[hive] object SparkSQLEnv extends Logging {
   def init() {
 if (sqlContext == null) {
   val sparkConf = new SparkConf(loadDefaults = true)
-  // If user doesn't specify the appName, we want to get 
[SparkSQL::localHostName] instead of
+  // If user doesn't specify the appName, we will get [SparkSQL::IP] 
instead of
--- End diff --

@srowen 
It is not accurate,because the comment is different from the appname in web 
UI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18879: [SPARK-21662] modify the appname to [SparkSQL::lo...

[srowen]

Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/18879#discussion_r132123263
  
--- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLEnv.scala
 ---
@@ -35,7 +35,7 @@ private[hive] object SparkSQLEnv extends Logging {
   def init() {
 if (sqlContext == null) {
   val sparkConf = new SparkConf(loadDefaults = true)
-  // If user doesn't specify the appName, we want to get 
[SparkSQL::localHostName] instead of
+  // If user doesn't specify the appName, we will get [SparkSQL::IP] 
instead of
--- End diff --

What is SparkSQL::IP?
I think this is not worth a JIRA / PR relative to the time spent looking at 
it
What problem does this cause a user?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18879: [SPARK-21662] modify the appname to [SparkSQL::lo...

[liu-zhaokun]

GitHub user liu-zhaokun opened a pull request:

https://github.com/apache/spark/pull/18879

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of 
[SparkSQL::lP] 


[https://issues.apache.org/jira/browse/SPARK-21662](https://issues.apache.org/jira/browse/SPARK-21662)
As it says "If user doesn't specify the appName, we want to get 
[SparkSQL::localHostName]" in SparkSqlEnv.scala,line 38,appname should be 
SparkSQL::localHostName,but it is SparkSQL::lP in fact.So I modify the 
localHostName method to get localhost with getCanonicalHostName method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liu-zhaokun/spark master0808

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18879.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18879


commit ab2248587d1a761058411c9a7f39e2da13f433bd
Author: liuzhaokun 
Date:   2017-08-08T06:37:35Z

[SPARK-21662] modify the appname to [SparkSQL::localHostName] instead of 
[SparkSQL::lP]




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org