[GitHub] spark pull request #20228: [SPARK-23036] Add withGlobalTempView for testing ...

2018-01-10 Thread dongjoon-hyun 
Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/20228#discussion_r160866670
  
--- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/GlobalTempViewSuite.scala
 ---
@@ -140,8 +140,8 @@ class GlobalTempViewSuite extends QueryTest with 
SharedSQLContext {
 
   
assert(spark.catalog.listTables(globalTempDB).collect().toSeq.map(_.name) == 
Seq("v1", "v2"))
 } finally {
-  spark.catalog.dropTempView("v1")
-  spark.catalog.dropGlobalTempView("v2")
+  spark.catalog.dropGlobalTempView("v1")
+  spark.catalog.dropTempView("v2")
--- End diff --

Hi, @xubo245 .
Could you split the bug and new improvement into two separate PR?
Then, your PR will get reviews more easily.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20228: [SPARK-23036] Add withGlobalTempView for testing ...

2018-01-10 Thread xubo245 
GitHub user xubo245 opened a pull request:

https://github.com/apache/spark/pull/20228

[SPARK-23036] Add withGlobalTempView for testing and correct some roper 
with view related method usage




## What changes were proposed in this pull request?

Add withGlobalTempView when create global temp view, like withTempView and 
withView.
And correct some improper usage.

## How was this patch tested?

no new test.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xubo245/spark DropTempView

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/20228.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20228


commit fffd109e8c084f9a4d63840bf761364f1ede5dc9
Author: xubo245 <601450868@...>
Date:   2018-01-11T03:25:17Z

[SPARK-23036] Add withGlobalTempView for testing and correct some improper 
with view related method usage

Add withGlobalTempView when create global temp view, like withTempView and 
withView.
And correct some improper usage.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org