Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]
uros-db commented on code in PR #45738:
URL: https://github.com/apache/spark/pull/45738#discussion_r1555227674
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest
testRepeat("UNICODE_CI", 3, "abc", 2)
}
+ test("substring check output type on explicitly collated string") {
Review Comment:
yeah, let's put all these tests that are specific to string functions into
the separate suite `CollationStringExpressionsSuite`
this way, `CollationSuite` won't get cluttered as we continue adding more
and more support for various string expressions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]
GideonPotok commented on code in PR #45738:
URL: https://github.com/apache/spark/pull/45738#discussion_r1555192610
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest
testRepeat("UNICODE_CI", 3, "abc", 2)
}
+ test("substring check output type on explicitly collated string") {
Review Comment:
Sorry @uros-db, I didn't realize you wanted me to add the additional edge
cases to this suite specifically. Are you sure you want me to move _all_ the
new tests to `CollationStringExpressionsSuite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47413][SQL] [WIP - DONT REVIEW] - add support to substr/left/right for collations [spark]
uros-db commented on code in PR #45738:
URL: https://github.com/apache/spark/pull/45738#discussion_r1554838890
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -86,6 +89,43 @@ class CollationStringExpressionsSuite extends QueryTest
testRepeat("UNICODE_CI", 3, "abc", 2)
}
+ test("substring check output type on explicitly collated string") {
Review Comment:
I think this will do it, thanks! Now just move over all tests to
`CollationStringExpressionsSuite`, re-run any failing CI checks, and modify the
PR title so we can open this up for review to Spark committers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
