[GitHub] [spark] AmplabJenkins commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545396244 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112522/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
AmplabJenkins removed a comment on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545396244 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112522/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
AmplabJenkins commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545396235 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly
HyukjinKwon edited a comment on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly URL: https://github.com/apache/spark/pull/26200#issuecomment-545399807 Merged to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly
HyukjinKwon closed pull request #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly URL: https://github.com/apache/spark/pull/26200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly
HyukjinKwon commented on issue #26200: [SPARK-29542][SQL][DOC] Make the descriptions of spark.sql.files.* be clearly URL: https://github.com/apache/spark/pull/26200#issuecomment-545399807 Merged to master and branch-2.4. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
shahidki31 commented on a change in pull request #26216: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r337996575
##
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala
##
@@ -384,7 +404,8 @@ private[ui] class ExecutionPagedTable(
private def descriptionCell(execution: SQLExecutionUIData): Seq[Node] = {
val details = if (execution.details != null && execution.details.nonEmpty)
{
-
[GitHub] [spark] SparkQA removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
SparkQA removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545390357 **[Test build #112538 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112538/testReport)** for PR 26110 at commit [`da4f00b`](https://github.com/apache/spark/commit/da4f00b979951e6792af8de9f821a9221f8ae850). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
SparkQA commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545406262 **[Test build #112538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112538/testReport)** for PR 26110 at commit [`da4f00b`](https://github.com/apache/spark/commit/da4f00b979951e6792af8de9f821a9221f8ae850). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase
AmplabJenkins commented on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase URL: https://github.com/apache/spark/pull/25914#issuecomment-545406690 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
AmplabJenkins commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545406769 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
AmplabJenkins commented on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545406782 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] 07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
07ARB commented on a change in pull request #26216: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r338005167
##
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##
@@ -572,4 +572,24 @@ private[spark] object UIUtils extends Logging {
def buildErrorResponse(status: Response.Status, msg: String): Response = {
Response.status(status).entity(msg).`type`(MediaType.TEXT_PLAIN).build()
}
+
+ def getHeaderNameWithTooltips(): Map[String, String] = {
+val headerNameWithTooltips: Map[String, String] = Map("ID" -> "Execution
ID of the SQL query.",
Review comment:
ok shahidki31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images
AmplabJenkins removed a comment on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images URL: https://github.com/apache/spark/pull/26224#issuecomment-545419068 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112528/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images
AmplabJenkins removed a comment on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images URL: https://github.com/apache/spark/pull/26224#issuecomment-545419063 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images
AmplabJenkins commented on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images URL: https://github.com/apache/spark/pull/26224#issuecomment-545419063 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images
AmplabJenkins commented on issue #26224: [SPARK-29567][TESTS] Update JDBC Integration Test Docker Images URL: https://github.com/apache/spark/pull/26224#issuecomment-545419068 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112528/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc
SparkQA commented on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc URL: https://github.com/apache/spark/pull/26228#issuecomment-545425987 **[Test build #112542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112542/testReport)** for PR 26228 at commit [`17c9985`](https://github.com/apache/spark/commit/17c9985cd9f0141e68db6dad3616077b295f122a). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545420371 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545426649 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc
AmplabJenkins removed a comment on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc URL: https://github.com/apache/spark/pull/26228#issuecomment-545423630 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] skonto commented on issue #26161: [SPARK-27900][K8s] Add jvm oom flag in cluster mode
skonto commented on issue #26161: [SPARK-27900][K8s] Add jvm oom flag in cluster mode URL: https://github.com/apache/spark/pull/26161#issuecomment-545425997 @holdenk gentl ping. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc
AmplabJenkins removed a comment on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc URL: https://github.com/apache/spark/pull/26228#issuecomment-545423641 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17506/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
AmplabJenkins removed a comment on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545426675 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17507/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545426661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17508/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
AmplabJenkins removed a comment on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545426664 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545426661 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17508/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins removed a comment on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545426649 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] skonto commented on issue #25870: [SPARK-27936][K8S] support python deps
skonto commented on issue #25870: [SPARK-27936][K8S] support python deps URL: https://github.com/apache/spark/pull/25870#issuecomment-545425916 @holdenk gentl ping. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545426664 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545426675 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17507/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu removed a comment on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol
AngersZh removed a comment on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol URL: https://github.com/apache/spark/pull/26221#issuecomment-545397687 @juliuszsompolski Do we need to add cpp/r/py ? Hive add all this and build a python version thrift server. If these are too redundant, I will delete them This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol
AngersZh commented on issue #26221: [WIP][SPARK-29108][SQL] Add new module sql/thriftserver and add v11 thrift protocol URL: https://github.com/apache/spark/pull/26221#issuecomment-545427371 > Could you add a README.txt like the one in Hive: > > ``` > Thrift commands to generate files from TCLIService.thrift: > > thrift --gen java:beans,hashcode -o src/gen/thrift if/TCLIService.thrift > ``` > > and keep the directory structure as created by it (i.e. code in `src/gen/thrift/gen-javabean`) > > Now after running thrift, there needs to be a manual step of moving the code again to `src/gen`, because it always generates the `gen-javabean` directory. @juliuszsompolski Done this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
SparkQA commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545426059 **[Test build #112543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112543/testReport)** for PR 26227 at commit [`41384d4`](https://github.com/apache/spark/commit/41384d45c50e31133d64690605df85f0d663916c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
SparkQA commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545426058 **[Test build #112544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112544/testReport)** for PR 26226 at commit [`6aeff3d`](https://github.com/apache/spark/commit/6aeff3d07e278ef394531e2110264bcbc169238f). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] skonto edited a comment on issue #26161: [SPARK-27900][K8s] Add jvm oom flag in cluster mode
skonto edited a comment on issue #26161: [SPARK-27900][K8s] Add jvm oom flag in cluster mode URL: https://github.com/apache/spark/pull/26161#issuecomment-545425997 @holdenk gentle ping. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] ConeyLiu commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier
ConeyLiu commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier URL: https://github.com/apache/spark/pull/26148#issuecomment-545433714 thanks all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling
AmplabJenkins commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078#issuecomment-545439387 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17509/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling
AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078#issuecomment-545439376 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc
jiangxb1987 commented on issue #26228: [SPARK-29569][BUILD][DOCS] Copy and paste minified jquery instead when post-processing badges in JavaDoc URL: https://github.com/apache/spark/pull/26228#issuecomment-545440882 Thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling
AmplabJenkins removed a comment on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078#issuecomment-545439387 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17509/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #26206: [SPARK-29551][CORE] Fix a bug about fetch failed when an executor is …
tgravescs commented on issue #26206: [SPARK-29551][CORE] Fix a bug about fetch failed when an executor is … URL: https://github.com/apache/spark/pull/26206#issuecomment-545440807 can you please add the description to the first message. Please change the title to be what is the description of change. Please specify if this is a regression from spark 2.4 or if you are proposing a new feature. You talk about the specific code in mapoutputtracker but can you please say what the user sees - does the job fail, does it hang, etc.,. fetch failed is a large category. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling
AmplabJenkins commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078#issuecomment-545439376 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling
jiangxb1987 commented on issue #26078: [SPARK-29151][CORE] Support fractional resources for task resource scheduling URL: https://github.com/apache/spark/pull/26078#issuecomment-545439629 Thanks @tgravescs I agree it should be a useful feature, but still hesitate how much Spark shall be aware of the resource scheduling. For example, do we want to handle the failure on Spark side that sometimes one task request to use a GPU but the GPU resource is busy and need to deny the request? Should the user code be able to handle that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545365990 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545365999 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17493/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML
AmplabJenkins removed a comment on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML URL: https://github.com/apache/spark/pull/17280#issuecomment-545366024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17494/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545365990 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML
AmplabJenkins commented on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML URL: https://github.com/apache/spark/pull/17280#issuecomment-545366009 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN"
AngersZh commented on issue #25854: [SPARK-29145][SQL] Spark SQL cannot handle "NOT IN" condition when using "JOIN" URL: https://github.com/apache/spark/pull/25854#issuecomment-545366245 > @AngersZh I just quickly checked the plan for following query : > > **query** > > ``` > SELECT s1.id from s1 JOIN s2 ON s1.id = s2.id and s1.id NOT IN (select id from s3) > ``` > > **plan** > > ``` > Project [id#244] > +- Join Inner, (id#244 = id#250) > :- Project [value#241 AS id#244] > : +- Join LeftAnti, ((value#241 = id#256) OR isnull((value#241 = id#256))) > : :- LocalRelation [value#241] > : +- Project [value#253 AS id#256] > :+- LocalRelation [value#253] > +- Project [value#247 AS id#250] > +- Join LeftAnti, ((value#247 = id#256) OR isnull((value#247 = id#256))) > :- LocalRelation [value#247] > +- Project [value#253 AS id#256] >+- LocalRelation [value#253] > ``` > > Thats the reason i asked to test out the outer joins. Lets please make sure that in case of Outer joins we preserve the full join condition in the main join. Lets add few tests to make sure please. Check whole process, you show is optimized plan, in analyzed plan, join condition is still in main join, after optimize, it was pushed down. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545365999 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17493/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML
AmplabJenkins commented on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML URL: https://github.com/apache/spark/pull/17280#issuecomment-545366024 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17494/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML
AmplabJenkins removed a comment on issue #17280: [SPARK-19939] [ML] Add support for association rules in ML URL: https://github.com/apache/spark/pull/17280#issuecomment-545366009 Build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
SparkQA commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545368682 **[Test build #112529 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112529/testReport)** for PR 26225 at commit [`1d4167f`](https://github.com/apache/spark/commit/1d4167fce6d19a043aff96dcaf24a1c6c8ca99a9). * This patch **fails to build**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545368719 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112529/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins commented on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545368708 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
SparkQA removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545365424 **[Test build #112529 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112529/testReport)** for PR 26225 at commit [`1d4167f`](https://github.com/apache/spark/commit/1d4167fce6d19a043aff96dcaf24a1c6c8ca99a9). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched
AmplabJenkins removed a comment on issue #26225: [SPARK-29568][SS] Stop existing running streams when a new stream is launched URL: https://github.com/apache/spark/pull/26225#issuecomment-545368708 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier
SparkQA removed a comment on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier URL: https://github.com/apache/spark/pull/26148#issuecomment-545316632 **[Test build #112524 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112524/testReport)** for PR 26148 at commit [`437aadf`](https://github.com/apache/spark/commit/437aadfcd972347a5b5a017271a5ad7f09a7cd4c). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui
uncleGen commented on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui URL: https://github.com/apache/spark/pull/26201#issuecomment-545378949 I've just updated the code, including: - refactor to better reuse code and reduce duplicate code references - add query related information on top - add some UTs Some updated UI:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier
SparkQA commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier URL: https://github.com/apache/spark/pull/26148#issuecomment-545378656 **[Test build #112524 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112524/testReport)** for PR 26148 at commit [`437aadf`](https://github.com/apache/spark/commit/437aadfcd972347a5b5a017271a5ad7f09a7cd4c). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545381735 **[Test build #112519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112519/testReport)** for PR 26183 at commit [`31bfc6f`](https://github.com/apache/spark/commit/31bfc6f5098701b70a95ac3dd4fc5b3c2ecbdee0). * This patch **fails PySpark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class CreateNamespaceStatement(` * `case class CreateNamespace(` * `case class CreateNamespaceExec(` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] weixiuli edited a comment on issue #26206: [SPARK-29551][CORE] Fix a bug about fetch failed when an executor is …
weixiuli edited a comment on issue #26206: [SPARK-29551][CORE] Fix a bug about fetch failed when an executor is … URL: https://github.com/apache/spark/pull/26206#issuecomment-545234149 When an executor lost with some reason and some things (eg:. the external shuffle service or host lost on the executor's host.) happened, and the executor loses time happens to be reduce stage `fetch failed` from it which is really bad, the previous only call `mapOutputTracker.unregisterMapOutput(shuffleId, mapIndex, bmAddress)` to mark one map as broken in the map stage at this time , but other maps on the executor are also not available which can only be resubmitted by a nest retry stage which is the regression. As we all know that the previous will call `mapOutputTracker.removeOutputsOnHost(host) `or `mapOutputTracker.removeOutputsOnExecutor(execId) ` when reduce stage fetches failed and the executor is active, while it does NOT for the above problems. So we should distinguish the failedEpoch of 'executor lost' from the fetchFailedEpoch of 'fetch failed' to solve the above problem. @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] uncleGen removed a comment on issue #24961: [SPARK-28158][SQL] Hive UDFs supports UDT type
uncleGen removed a comment on issue #24961: [SPARK-28158][SQL] Hive UDFs supports UDT type URL: https://github.com/apache/spark/pull/24961#issuecomment-543492651 ping @HyukjinKwon @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] uncleGen commented on issue #24961: [SPARK-28158][SQL] Hive UDFs supports UDT type
uncleGen commented on issue #24961: [SPARK-28158][SQL] Hive UDFs supports UDT type URL: https://github.com/apache/spark/pull/24961#issuecomment-545381366 ping @HyukjinKwon @cloud-fan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include keys that have null value for StructTypes
HyukjinKwon commented on issue #20884: [SPARK-23773][SQL] JacksonGenerator does not include keys that have null value for StructTypes URL: https://github.com/apache/spark/pull/20884#issuecomment-545388156 Ah, I just saw this. Okay, thanks for fixing it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545388174 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17501/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545388162 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545391239 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
SparkQA commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545391227 **[Test build #112537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112537/testReport)** for PR 26216 at commit [`7123a2f`](https://github.com/apache/spark/commit/7123a2f2104caf36794a45453d2df51e14443bc4). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
AmplabJenkins commented on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545391246 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112537/ Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
SparkQA removed a comment on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545390327 **[Test build #112537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112537/testReport)** for PR 26216 at commit [`7123a2f`](https://github.com/apache/spark/commit/7123a2f2104caf36794a45453d2df51e14443bc4). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
AmplabJenkins removed a comment on issue #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab. URL: https://github.com/apache/spark/pull/26216#issuecomment-545391239 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26207: [SPARK-29552][SQL] Execute the "OptimizeLocalShuffleReader" rule when creating new query stage and then can optimize the shuffle reade
AmplabJenkins removed a comment on issue #26207: [SPARK-29552][SQL] Execute the "OptimizeLocalShuffleReader" rule when creating new query stage and then can optimize the shuffle reader to local shuffle reader as much as possible. URL: https://github.com/apache/spark/pull/26207#issuecomment-545395018 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26207: [SPARK-29552][SQL] Execute the "OptimizeLocalShuffleReader" rule when creating new query stage and then can optimize the shuffle reade
AmplabJenkins removed a comment on issue #26207: [SPARK-29552][SQL] Execute the "OptimizeLocalShuffleReader" rule when creating new query stage and then can optimize the shuffle reader to local shuffle reader as much as possible. URL: https://github.com/apache/spark/pull/26207#issuecomment-545395033 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112517/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands
SparkQA commented on issue #26183: [SPARK-29513][SQL] REFRESH TABLE should look up catalog/table like v2 commands URL: https://github.com/apache/spark/pull/26183#issuecomment-545395617 **[Test build #112522 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112522/testReport)** for PR 26183 at commit [`31bfc6f`](https://github.com/apache/spark/commit/31bfc6f5098701b70a95ac3dd4fc5b3c2ecbdee0). * This patch passes all tests. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class CreateNamespaceStatement(` * `case class CreateNamespace(` * `case class CreateNamespaceExec(` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe
AmplabJenkins removed a comment on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe URL: https://github.com/apache/spark/pull/26173#issuecomment-545399441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112520/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe
AmplabJenkins removed a comment on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe URL: https://github.com/apache/spark/pull/26173#issuecomment-545399423 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
MaxGekk commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545399547 > @dongjoon-hyun do you know to run the benchmark with JDK 11? I can't find the instructions. @cloud-fan Just install JDK11 (see https://stackoverflow.com/a/47699905) and run the benchmark by the same command. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe
AmplabJenkins commented on issue #26173: [SPARK-29503][SQL] Remove conversion CreateNamedStruct to CreateNamedStructUnsafe URL: https://github.com/apache/spark/pull/26173#issuecomment-545399441 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112520/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing
SparkQA commented on issue #26190: [SPARK-29532][SQL] simplify interval string parsing URL: https://github.com/apache/spark/pull/26190#issuecomment-545402044 **[Test build #112526 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112526/testReport)** for PR 26190 at commit [`5c5e251`](https://github.com/apache/spark/commit/5c5e25154c308c9c21db5df615955edf95e89389). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] shahidki31 commented on a change in pull request #26216: [SPARK-29453][WEBUI] Improve tooltips information for SQL tab.
shahidki31 commented on a change in pull request #26216: [SPARK-29453][WEBUI]
Improve tooltips information for SQL tab.
URL: https://github.com/apache/spark/pull/26216#discussion_r337995897
##
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/ui/AllExecutionsPageSuite.scala
##
@@ -73,10 +74,36 @@ class AllExecutionsPageSuite extends SharedSparkSession
with BeforeAndAfter {
map.put("failed.sort", Array("duration"))
when(request.getParameterMap()).thenReturn(map)
val html = renderSQLPage(request, tab,
statusStore).toString().toLowerCase(Locale.ROOT)
-assert(!html.contains("IllegalArgumentException"))
+assert(!html.contains("illegalargumentexception"))
assert(html.contains("duration"))
}
+ test("Display tooltips for SQL page") {
+val statusStore = createStatusStore
+val tab = mock(classOf[SQLTab], RETURNS_SMART_NULLS)
+val request = mock(classOf[HttpServletRequest])
+
+when(tab.sqlStore).thenReturn(statusStore)
+when(tab.appName).thenReturn("testing")
+when(tab.headerTabs).thenReturn(Seq.empty)
+when(request.getParameter("failed.sort")).thenReturn("Duration")
+val map = new util.HashMap[String, Array[String]]()
+map.put("failed.sort", Array("duration"))
Review comment:
I think these lines aren't necessary.
```
when(request.getParameter("failed.sort")).thenReturn("Duration")
val map = new util.HashMap[String, Array[String]]()
map.put("failed.sort", Array("duration"))
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 closed pull request #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier
jiangxb1987 closed pull request #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier URL: https://github.com/apache/spark/pull/26148 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier
jiangxb1987 commented on issue #26148: [SPARK-29499][CORE][PYSPARK] Add mapPartitionsWithIndex for RDDBarrier URL: https://github.com/apache/spark/pull/26148#issuecomment-545404736 Thanks, merged to master! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase
AmplabJenkins commented on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase URL: https://github.com/apache/spark/pull/25914#issuecomment-545406702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17505/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
AmplabJenkins removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545406782 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112538/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase
AmplabJenkins removed a comment on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase URL: https://github.com/apache/spark/pull/25914#issuecomment-545406702 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/17505/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide
AmplabJenkins removed a comment on issue #26110: [SPARK-29126][PYSPARK][DOC] Pandas Cogroup udf usage guide URL: https://github.com/apache/spark/pull/26110#issuecomment-545406769 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase
AmplabJenkins removed a comment on issue #25914: [SPARK-29227][SS]Track rule info in optimization phase URL: https://github.com/apache/spark/pull/25914#issuecomment-545406690 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] PavithraRamachandran commented on a change in pull request #26138: [SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in JDBC/ODBC Server Tab
PavithraRamachandran commented on a change in pull request #26138:
[SPARK-29456][WebUI] Improve tooltip for Session Statistics Table column in
JDBC/ODBC Server Tab
URL: https://github.com/apache/spark/pull/26138#discussion_r338008672
##
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ToolTips.scala
##
@@ -29,4 +29,16 @@ private[ui] object ToolTips {
val THRIFT_SERVER_DURATION =
"Difference between start time and close time"
+
+ val THRIFT_SESSION_TOTAL_EXECUTE =
+"Number of operations submitted in this session."
+
+ val THRIFT_SESSION_START_TIME =
+"Session Start time,on launching the session."
+
+ val THRIFT_SESSION_FINISH_TIME =
+"Session end time, after closing the session."
+
+ val THRIFT_SESSION_DURATION =
+"Active duration of the session."
Review comment:
@wangyum in the same page statistics table does not have tooltip for all
the column. Should we address that too?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
SparkQA removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545392801 **[Test build #112539 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112539/testReport)** for PR 25926 at commit [`3000397`](https://github.com/apache/spark/commit/300039770f06eb9f7e4075b61c4203e598a66410). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
SparkQA commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545415304 **[Test build #112539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/112539/testReport)** for PR 25926 at commit [`3000397`](https://github.com/apache/spark/commit/300039770f06eb9f7e4075b61c4203e598a66410). * This patch passes all tests. * This patch merges cleanly. * This patch adds no public classes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax
maropu commented on a change in pull request #25001: [SPARK-28083][SQL] Support
LIKE ... ESCAPE syntax
URL: https://github.com/apache/spark/pull/25001#discussion_r338011227
##
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##
@@ -149,10 +153,17 @@ case class Like(left: Expression, right: Expression)
extends StringRegexExpressi
} else {
val pattern = ctx.freshName("pattern")
val rightStr = ctx.freshName("rightStr")
+ val escapeChar = escapeCharOpt.map { str =>
+if (str.equals("\"") || str.equals("\\")) {
Review comment:
I remember this is to accept [the
query](https://github.com/apache/spark/pull/25001#issuecomment-511803526). The
suggested looks nice and we need comments here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545415690 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112539/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545415685 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
AmplabJenkins commented on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545415685 Merged build finished. Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs
AmplabJenkins removed a comment on issue #25926: [SPARK-9612][ML] Add instance weight support for GBTs URL: https://github.com/apache/spark/pull/25926#issuecomment-545415690 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/112539/ Test PASSed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] stczwd opened a new pull request #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
stczwd opened a new pull request #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227 # What changes were proposed in this pull request? Add description for ignoreNullFields, which is commited in #26098 , in DataFrameWriter and readwriter.py. Enable user to use this in pyspark. ### Does this PR introduce any user-facing change? No ### How was this patch tested? run unit tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating
AmplabJenkins commented on issue #26227: [SPARK-29444][FOLLOWUP] add doc for ignoreNullFields in json generating URL: https://github.com/apache/spark/pull/26227#issuecomment-545419761 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab
AmplabJenkins commented on issue #26226: [SPARK-29452][WEebUI]Improve tooltip Storage tab URL: https://github.com/apache/spark/pull/26226#issuecomment-545419772 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
