[Citadel Development] [PATCH] webcit/dav_get.c: decode quoted-printable messages
This patch implements decoding of Quoted-Printable encoded calendar/address data - messages that have the 'Content-Transfer-Encoding: Quoted-Printable' header from MSG2 output. I'm not sure how such messages come into being, but at least this patch ensures they are properly decoded in DAV requests before being sent to the client. dav_get.diff Description: Binary data
[Citadel Development] (no subject)
That is indeed the issue. Log in button does nothing. Safari's developer
console reports an error thrown from the isSafari { } block of modal.js on
line 24 (dialog.insertBefore)
Sat Sep 29 2012 01:15:01 PM PDT from the_mgt @ Uncensored
Interesting. What were the symptoms? On 10.6, if I click on Log in,
nothing happens. This is consistent with various mobile devices, since the
modal overloads the current page with a complete new html.../html page.
It seems that this is at least odd or unconform to standards.
[Citadel Development] (no subject)
Mon Feb 06 2012 05:13:07 PM GMT from IGnatius T Foobar @ Uncensored We probably want to have a maximum concurrent background tasks setting, or something to that effect. At the moment, restarting citserver on a busy site causes the whole thing to get hammered as it attempts the entire queue at once. Retry for SMTP is at the discretion of the sender, but the way we implemented it before was to retry in (I think it was) 15 minutes, and then double the retry time after every failed attempt up to a maximum of four hours, and then keep trying every four hours until five days has passed. On the topic of SMTP retires: I've had an issue over here where my outbound SMTP queue is 'stuck' due to a failure to send the first message in it. Causes vary, but I have to restart citserver (and remove the offending message, if needed) to get messages moving again. From the above, it sounds like the message at the top of the queue has a retry timer that blows up to infinity, and stops the delivery of the remaining queue from being attempted. I have an idea of what is causing the timeouts (failed DNS resolutions), but I'd like to make Citadel behave better when this situation is encountered
[Citadel Development] serv_migrate metadata fix
The attached patch fixes a pair of issues I found while migrating comalies.citadel.org onto a new box with serv_migrate over the past two days: 1. Report Expat XML parser errors and drop out out the loop if one occurs (as expat will refuse to work after hitting an error in the source) 2. Ensure the message id is put into the imported messages MetaData - this was causing ignet and internet configs not to be loaded from Local System Configuration as CtdlForEachMessage couldn't find the MetaData struct for the message and therefore the content type it was supposed to be matching against. serv_migrate.diff Description: Binary data
[Citadel Development] Problems with SVN
Sun Dec 20 2009 12:08:30 AM from davew @ Uncensored Subject: Problems with SVN Is anyone else having problems with SVN? I keep getting an error message svn: Network connection closed unexpectedly. Sometimes it works, but mainly, for the last couple of days, it doesn't. Uncensored has an SSH connection throttle which tries to stop brute force SSH logins, but can wreak havoc with SVN as well. Ig recently mentioned using some option in SSH that tunnels new sessions on top of existing ones (i.e ssh into uncensored then svn+ssh will run ontop of that session), forgot which one exactly.
[Citadel Development] serv_funambol update
Attached is an update to serv_funambol to make sure errors reaching the Funambol server are dealt with properly,
/*
* This module implements a notifier for Funambol push email.
* Based on bits of serv_spam, serv_smtp
*/
#define FUNAMBOL_WS /funambol/services/admin
#include sysdep.h
#include stdlib.h
#include unistd.h
#include stdio.h
#include fcntl.h
#include signal.h
#include pwd.h
#include errno.h
#include sys/types.h
#if TIME_WITH_SYS_TIME
# include sys/time.h
# include time.h
#else
# if HAVE_SYS_TIME_H
# include sys/time.h
# else
# include time.h
# endif
#endif
#include sys/wait.h
#include string.h
#include limits.h
#include sys/socket.h
#include citadel.h
#include server.h
#include sysdep_decls.h
#include citserver.h
#include support.h
#include config.h
#include control.h
#include serv_extensions.h
#include room_ops.h
#include user_ops.h
#include policy.h
#include database.h
#include msgbase.h
#include tools.h
#include internet_addressing.h
#include domain.h
#include clientsocket.h
#include serv_funambol.h
/*
* Create the notify message queue
*/
void create_notify_queue(void) {
struct ctdlroom qrbuf;
create_room(FNBL_QUEUE_ROOM, 3, , 0, 1, 0, VIEW_MAILBOX);
/*
* Make sure it's set to be a system room so it doesn't show up
* in the Known rooms list for Aides.
*/
if (lgetroom(qrbuf, FNBL_QUEUE_ROOM) == 0) {
qrbuf.QRflags2 |= QR2_SYSTEM;
lputroom(qrbuf);
}
}
void do_notify_queue(void) {
static int doing_queue = 0;
/*
* This is a simple concurrency check to make sure only one queue run
* is done at a time. We could do this with a mutex, but since we
* don't really require extremely fine granularity here, we'll do it
* with a static variable instead.
*/
if (doing_queue) return;
doing_queue = 1;
/*
* Go ahead and run the queue
*/
lprintf(CTDL_INFO, serv_funambol: processing notify queue\n);
if (getroom(CC-room, FNBL_QUEUE_ROOM) != 0) {
lprintf(CTDL_ERR, Cannot find room %s\n, FNBL_QUEUE_ROOM);
return;
}
CtdlForEachMessage(MSGS_ALL, 0L, NULL,
SPOOLMIME, NULL, notify_funambol, NULL);
lprintf(CTDL_INFO, serv_funambol: queue run completed\n);
doing_queue = 0;
}
/*
* Connect to the Funambol server and scan a message.
*/
int notify_funambol(long msgnum, void *userdata) {
struct CtdlMessage *msg;
int sock = (-1);
char fnblhosts[SIZ];
int num_fnblhosts;
char buf[SIZ];
int is_spam = 0;
int fnbl;
char *msgtext;
size_t msglen;
char host[SIZ];
char SOAPHeader[SIZ];
char SOAPData[SIZ];
char port[SIZ];
/* W means 'Wireless'... */
msg = CtdlFetchMessage(msgnum, 1);
if ( msg-cm_fields['W'] == NULL) {
goto nuke;
}
/* Are we allowed to push? */
if ( strlen(config.c_funambol_host) == 0) {
goto nuke;
} else {
lprintf(CTDL_INFO, Push enabled\n);
}
sprintf(port, %d, config.c_funambol_port);
lprintf(CTDL_INFO, Connecting to Funambol at %s\n, config.c_funambol_host);
sock = sock_connect(config.c_funambol_host, port, tcp);
if (sock = 0) lprintf(CTDL_DEBUG, Connected!\n);
if (sock 0) {
/* If the service isn't running, pass for now */
return(0);
}
/* Build a SOAP message, delicately, by hand */
sprintf(SOAPData, ?xml version=\1.0\ encoding=\UTF-8\?soapenv:Envelope xmlns:soapenv=\http://schemas.xmlsoap.org/soap/envelope/\; xmlns:xsd=\http://www.w3.org/2001/XMLSchema\; xmlns:xsi=\http://www.w3.org/2001/XMLSchema-instance\;);
strcat(SOAPData, soapenv:BodysendNotificationMessages soapenv:encodingStyle=\http://schemas.xmlsoap.org/soap/encoding/\;);
strcat(SOAPData, arg0 xsi:type=\soapenc:string\ xmlns:soapenc=\http://schemas.xmlsoap.org/soap/encoding/\;);
strcat(SOAPData, msg-cm_fields['W']);
strcat(SOAPData, /arg0);
strcat(SOAPData, arg1 xsi:type=\soapenc:string\ xmlns:soapenc=\http://schemas.xmlsoap.org/soap/encoding/\;lt;?xml version=quot;1.0quot; encoding=quot;UTF-8quot;?gt;\r\n);
strcat(SOAPData, lt;java version=quot;1.5.0_10quot; class=quot;java.beans.XMLDecoderquot;gt; \r\n);
strcat(SOAPData, lt;array class=quot;com.funambol.framework.core.Alertquot; length=quot;1quot;gt;\r\n);
strcat(SOAPData, lt;void index=quot;0quot;gt;\r\n);
strcat(SOAPData,lt;object class=quot;com.funambol.framework.core.Alertquot;gt;\r\n);
strcat(SOAPData, lt;void property=quot;cmdIDquot;\r\n);
strcat(SOAPData, lt;object class=quot;com.funambol.framework.core.CmdIDquot;/gt;\r\n);
strcat(SOAPData, lt;/voidgt;);
strcat(SOAPData, lt;void property=quot;dataquot;gt;\r\n);
strcat(SOAPData, lt;intgt;210lt;/intgt;\r\n);
strcat(SOAPData, lt;/voidgt;\r\n);
strcat(SOAPData, lt;void property=quot;itemsquot;gt;\r\n);
strcat(SOAPData, lt;void method=quot;addquot;gt;\r\n);
strcat(SOAPData, lt;object class=quot;com.funambol.framework.core.Itemquot;gt;\r\n);
strcat(SOAPData,lt;void property=quot;metaquot;gt;\r\n);
strcat(SOAPData, lt;object class=quot;com.funambol.framework.core.Metaquot;gt;\r\n);
strcat(SOAPData,
[Citadel Development] (no subject)
A 'handheld' media stylesheet would be a good place to start, thanks to theirrys work this is possible now. Then again, webcit doesn't actually run that bad over GPRS (even if css/img isn't in browser cache). I'm sitting here right now on HSDPA which is even better :)Fri 03 Aug 2007 08:42:10 PM UTC from da...@uncnsrd (Uncensored) Just a thought.I think it would be better to keep the web interface as simple as possible or at least make it configurable to turn off some of the more glamorous parts like icons etc. Mobile is the current way of working and Citadel is the way to colaborate whilst mobile and mobile often means GPRS which means SLW.
[Citadel Development] (no subject)
I mean point your own webcit copy to comalies.citadel.org (./webserver comalies.citadel.org ).Fri 03 Aug 2007 11:27:05 PM UTC from da...@uncnsrd (Uncensored) matt, tried it but all I got was the Apache test page. Whats the correct URL?
[Citadel Development] (no subject)
Restarted my server for logging and the room worked.However, my Aide room is now demonstrating this problem, and webcit stops processing after asking GTSN from the server.Too tired to take a look at code now, will tomorrow.
[Citadel Development] (no subject)
Citadel SVN isn't building on OSX. I've fixed a problem with cpp not liking the #elif syntax for HAVE_DARWIN in sysdep.c, now I'm hitting problems with syntax in citadel.h, better left with others here I think :)Sysdep.c diff build log attached sysdep_osx_fix.diff Description: Binary data gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c citadel.c -o citadel.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c citadel_ipc.c -o citadel_ipc.o citadel_ipc.c: In function 'CtdlIPCStartEncryption': citadel_ipc.c:1955: warning: pointer targets in passing argument 2 of 'SSL_set_session_id_context' differ in signedness gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c client_chat.c -o client_chat.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c client_passwords.c -o client_passwords.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c commands.c -o commands.o commands.c: In function 'cmd_expand': commands.c:979: warning: unused variable 'a' gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c html.c -o html.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c ipc_c_tcp.c -o ipc_c_tcp.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c md5.c -o md5.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c messages.c -o messages.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c rooms.c -o rooms.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c routines.c -o routines.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c routines2.c -o routines2.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c screen.c -o screen.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c tools.c -o tools.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c citadel_dirs.c -o citadel_dirs.o gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c getutline.c -o getutline.o gcc citadel.o citadel_ipc.o client_chat.o client_passwords.o \ commands.o html.o ipc_c_tcp.o md5.o messages.o rooms.o routines.o \ routines2.o screen.o tools.o citadel_dirs.o getutline.o \ -L/opt/citadel//lib -o citadel -lssl -lcrypto -lpthread -lncurses /usr/bin/ld: warning multiple definitions of symbol _strcpy tools.o definition of _strcpy in section (__TEXT,__text) /usr/lib/gcc/i686-apple-darwin8/4.0.1/../../../libpthread.dylib(strcpy.So) definition of _strcpy gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c whobbs.c -o whobbs.o gcc whobbs.o ipc_c_tcp.o tools.o citadel_ipc.o citadel_dirs.o getutline.o -L/opt/citadel//lib -o whobbs -lssl -lcrypto -lpthread -lncurses /usr/bin/ld: warning multiple definitions of symbol _strcpy tools.o definition of _strcpy in section (__TEXT,__text) /usr/lib/gcc/i686-apple-darwin8/4.0.1/../../../libpthread.dylib(strcpy.So) definition of _strcpy gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT -I ./include/ -I/opt/citadel//include -I. -I ./include/ -DHAVE_CONFIG_H -c stress.c -o stress.o gcc stress.o ipc_c_tcp.o tools.o citadel_ipc.o citadel_dirs.o getutline.o -L/opt/citadel//lib -o stress -lssl -lcrypto -lpthread -lncurses /usr/bin/ld: warning multiple definitions of symbol _strcpy tools.o definition of _strcpy in section (__TEXT,__text) /usr/lib/gcc/i686-apple-darwin8/4.0.1/../../../libpthread.dylib(strcpy.So) definition of _strcpy gcc -g -O2 -Wall -Wcast-qual -Wcast-align -Wstrict-prototypes -D_REENTRANT
[Citadel Development] IMAP UID search
Gah, I've stumbled across an IMAP search bug..Palm Versamail likes to useUID SEARCH (NOT DELETED) (NOT SEEN)in order to pull up its message listUnfortunately, doesn't seem to be implemented/operational here and VersaMail ends up pulling nothing.
[Citadel Development] Citadel commit log: revision 7696
r7696 | matt | 2009-07-25 07:41:27 -0400 (Sat, 25 Jul 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js Fix shift-click behavior if no messages have been selected
[Citadel Development] (no subject)
Noted shift-select bug, I'll get it fixed tomorrow.
[Citadel Development] range select..
I usually normal-click one msg then shift-click the range. Never though about shift-click both times, silly me Fri Jul 24 2009 09:46:32 PM EST from dothebart @ Uncensored Subject: range select.. ...is even more funny if you just have 3 mails.
[Citadel Development] Citadel commit log: revision 7695
r7695 | matt | 2009-07-24 22:06:34 -0400 (Fri, 24 Jul 2009) | 2 lines Changed paths: M /trunk/webcit/groupdav_delete.c Comment out call to StrBufCutLeft, this was cutting the first character off the roomname causing groupdav delete to goto 'alendar' instead of 'Calendar' first
[Citadel Development] Citadel commit log: revision 7679
r7679 | matt | 2009-07-20 23:43:52 -0400 (Mon, 20 Jul 2009) | 2 lines Changed paths: M /trunk/webcit/static/ctdldragdrop.js * Allow dragdrop attributes to be stored as XML attributes
[Citadel Development] Citadel commit log: revision 7680
r7680 | matt | 2009-07-20 23:46:26 -0400 (Mon, 20 Jul 2009) | 3 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/msg_listview.html * Back out previous 'safe view default' * mailbox now MANY times faster
[Citadel Development] Citadel commit log: revision 7681
r7681 | matt | 2009-07-21 00:01:33 -0400 (Tue, 21 Jul 2009) | 3 lines Changed paths: M /trunk/webcit/static/summaryview.js * Fallback to eval() method for JSON loading if the native JSON object (FF 3.5, IE8) does not accept our data. * Silence any harmless errors caught in IE
[Citadel Development] mailbox changes
The mailbox view is now many times faster! So much that 'safe mode' that I introduced for lower performance browers will be renamed to 'paged mode'. If this is too close to the 7.60 release, feel fre to back it out and distribute the older version in its place.
[Citadel Development] Citadel commit log: revision 7672
r7672 | matt | 2009-07-17 21:49:26 -0400 (Fri, 17 Jul 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/msg_listview.html * Give newer, faster browsers the full at-once listview experience, older versions and M$ get paged list view
[Citadel Development] Citadel commit log: revision 7663
r7663 | matt | 2009-07-14 22:04:15 -0400 (Tue, 14 Jul 2009) | 2 lines Changed paths: M /trunk/webcit/groupdav_put.c Comment out the explicit write of Content-Type to server, as the uploaded data already has this information
[Citadel Development] js stuff
I've got some time to myself in the next two weeks so I will do some work on all the javascript stuff I did earlier this year. * There has been some concern expressed about performance of the message list view. The old server side sort is still there as 'safe mode' (check your user preferences), and its paged in groups of 100 as well. I propose making that default, newer UA's (i.e the most recent Safari, Firefox and Opera) will be opted into the full continuous list view as their javascript engines do the job really well. * I'll take a look at shift-click in list view again. If there is anything else, please bring it to my attention.
[Citadel Development] Citadel commit log: revision 7192
r7192 | matt | 2009-03-07 04:58:05 -0500 (Sat, 07 Mar 2009) | 4 lines Changed paths: M /trunk/webcit/static/summaryview.js * Fix subject/from descending sort regression * Where the room prefs have given us a sort mode to use in mailbox, actually use it
[Citadel Development] Citadel commit log: revision 7175
r7175 | matt | 2009-02-28 20:27:28 -0500 (Sat, 28 Feb 2009) | 3 lines Changed paths: M /trunk/webcit/serv_func.c M /trunk/webcit/static/webcit.css * fmout class different depending o input * text-overflow: ellpisis will truncate text in listview table in every browser but Firefox (argh)
[Citadel Development] Citadel commit log: revision 7133
r7133 | matt | 2009-02-20 08:24:25 -0500 (Fri, 20 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/wclib.js * add a strcmp function, use for mailbox subject/sender compare
[Citadel Development] Citadel commit log: revision 7117
r7117 | matt | 2009-02-16 23:55:57 -0500 (Mon, 16 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js * Use SortOrder=0 to ascend in mailbox safe mode
[Citadel Development] Citadel commit log: revision 7105
r7105 | matt | 2009-02-12 21:51:56 -0500 (Thu, 12 Feb 2009) | 3 lines Changed paths: M /trunk/webcit/static/ctdldragdrop.js M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * CtdlDragDrop library now works in IE7 and 8 * Fix iconbar roomlist floor expansion in IE7, IE6 todo
[Citadel Development] Citadel commit log: revision 7083
r7083 | matt | 2009-02-08 23:05:05 -0500 (Sun, 08 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/groupdav_delete.c * Use StrBufCutLeft to break off /groupdav/ etc.
[Citadel Development] Citadel commit log: revision 7077
r7077 | matt | 2009-02-07 06:08:37 -0500 (Sat, 07 Feb 2009) | 4 lines Changed paths: M /trunk/webcit/groupdav_get.c M /trunk/webcit/groupdav_put.c * Fix single-item groupdav requests being considered as the whole collection * Add some begin/end_burst where needed Please test with your Web/GroupDAV clients
[Citadel Development] Citadel commit log: revision 7071
r7071 | matt | 2009-02-06 04:45:47 -0500 (Fri, 06 Feb 2009) | 8 lines Changed paths: M /trunk/webcit/msg_renderers.c M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/head.html M /trunk/webcit/static/t/msg_listview.html M /trunk/webcit/static/t/roombanner.html M /trunk/webcit/static/t/who.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css M /trunk/webcit/subst.c M /trunk/webcit/subst.h M /trunk/webcit/webserver.c * iteratorstruct private again * removed HAVE_ZLIB check, Gzip encoding works * remove old cond display_msg and lastmsg, obsoleted by new iterator params * Added javascript code which will switch #global to a scrollable pane and make roombanner fixed under IE8 and the good browsers * added some conditions in head.html that deal explicitly with IE * Fixed message pane in mailbox not being cleared properly in IE prior to message refresh * Page selector in mailbox safe mode now keeps the current page selected
[Citadel Development] Citadel commit log: revision 7076
r7076 | matt | 2009-02-07 01:42:02 -0500 (Sat, 07 Feb 2009) | 3 lines Changed paths: M /trunk/webcit/pushemail.c M /trunk/webcit/static/t/pushemail.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * Fix user push email config * Roomlist styling fix: neutralize link colors, underline the current room
[Citadel Development] Citadel commit log: revision 7070
r7070 | matt | 2009-02-05 19:22:59 -0500 (Thu, 05 Feb 2009) | 3 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/webcit.css * fix zebra rows in mailbox view not working after sort/move * apply cursor: pointer to sort toggles
[Citadel Development] Citadel commit log: revision 7060
r7060 | matt | 2009-02-04 03:27:18 -0500 (Wed, 04 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/t/mailsummary_json.html ! Remove the 0 padding in iterate params, not needed thanks to last commit
[Citadel Development] Citadel commit log: revision 7061
r7061 | matt | 2009-02-04 03:50:12 -0500 (Wed, 04 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/mailsummary_json.html * Calculate a 'stopmsg' var rather than maxmsgs, fixes mailbox safe mode
[Citadel Development] Citadel commit log: revision 7066
r7066 | matt | 2009-02-04 19:51:29 -0500 (Wed, 04 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js * fix unread message not being bolded in mailbox
[Citadel Development] Citadel commit log: revision 7057
r7057 | matt | 2009-02-03 21:07:02 -0500 (Tue, 03 Feb 2009) | 5 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/mailsummary_json.html M /trunk/webcit/static/t/mailsummary_json_section.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css M /trunk/webcit/subst.c * Fix online users iconbar hover * Attempt to use new iterate code to limit summary view messages - doesn't work yet * Revert fixed table change - unbreaks the good guys but breaks IE - will fix
[Citadel Development] (no subject)
dothebart: I've just tried using the new iterate params for mailbox safe view, doesn't seem to work. When I place a breakpoint within the iterate_subtmpl loop it only seems to go over two items then stops. It should be doing 500. StopAt doesn't seem to be calculated correctly if I only specify StartAt and StepWidth
[Citadel Development] (no subject)
ok, thanks for clearing that up. Hmm, we need to be able to detect lack of B(..) as well as startmsg/maxmsgs aren't specified in default mode.
[Citadel Development] Citadel commit log: revision 7038
r7038 | matt | 2009-01-31 04:45:18 -0500 (Sat, 31 Jan 2009) | 5 lines Changed paths: M /trunk/webcit/auth.c M /trunk/webcit/msg_renderers.c M /trunk/webcit/po/da.po M /trunk/webcit/po/de.po M /trunk/webcit/po/en_GB.po M /trunk/webcit/po/es.po M /trunk/webcit/po/fr.po M /trunk/webcit/po/it.po M /trunk/webcit/po/nl.po M /trunk/webcit/po/pt_BR.po M /trunk/webcit/po/webcit.pot M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/login.html M /trunk/webcit/static/t/openid_login.html * fix preview_pane scroll memory bug * fix openid login page, but haven't been able to test * ran create-pot.sh, as I split up openid login bullets as well * update nl.po and fr.po with the two new lines
[Citadel Development] Citadel commit log: revision 7046
r7046 | matt | 2009-02-01 01:14:51 -0500 (Sun, 01 Feb 2009) | 2 lines Changed paths: M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * Fix some IE (mainly IE6) overflow issues
[Citadel Development] Citadel commit log: revision 7017
r7017 | matt | 2009-01-28 23:17:53 -0500 (Wed, 28 Jan 2009) | 2 lines Changed paths: M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/webcit.css * Encapsulate iconbar contents in another div that carries the white background. This restores previous appearance where the page background carried on below iconbar
[Citadel Development] (no subject)
I fixed a similar problem in webcit when I merged newsummaryview in - we were checking for HAVE_ZLIB when we didn't need to anymore, as libcitadel handled that... Wed Jan 28 2009 08:56:30 AM EST fromIGnatius T Foobar - --- -- -- Interestingly, if I do 'ldd citserver' I do see libz in the linkage, but perhaps the HAVE_ZLIB is not being defined in the headers? Is it possible that this broke in r6665 ?
[Citadel Development] Citadel commit log: revision 7010
r7010 | matt | 2009-01-27 21:56:19 -0500 (Tue, 27 Jan 2009) | 6 lines Changed paths: M /trunk/webcit M /trunk/webcit/roomops.c M /trunk/webcit/static/iconbaricns.css M /trunk/webcit/static/iconbarpiconly.css M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * restore context menu in online user list * fix online user in iconbar list becoming big after last commit * replace #iconbar ul li selectors with classes so IE6 can understand them, and so these changes don't cause the above
[Citadel Development] Citadel commit log: revision 6999
r6999 | matt | 2009-01-26 05:35:34 -0500 (Mon, 26 Jan 2009) | 8 lines Changed paths: M /trunk/webcit/graphics.c M /trunk/webcit/roomops.c M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/edit_message.html M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/t/preferences.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * add missing banner on preferences template * set min-height for #banner for non-room screens * update knrooms header to match room screens * summary view remembers size of list pane * fix double iconbar in graphics upload * fix enter message not being in the right div + overflowing * disable :hover rule for input fields
[Citadel Development] webcit bug wall
Here is a list of current webcit trunk bugs I know about: * iconbar buttons overflowing * IE6 iconbar buttons * iconbar roomlist failing in IE * mailbox view table not always lining up in IE, various degress of b0rkness depending on IE version * login screen input fields messed up in IE8b standards mode * rounded corners script hacks no longer work/needed for IE8b * push email config screen broken * mailbox 'safe mode' not working when viewing message list pages past 1/500 msgs * radio buttons in BBS view being wrong colour * banner icons missing from pref/admin screen since they became templating * tinymce upgrade available.
[Citadel Development] Citadel commit log: revision 6990
r6990 | matt | 2009-01-25 06:59:17 -0500 (Sun, 25 Jan 2009) | 3 lines Changed paths: M /trunk/webcit/messages.c M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/view_message.html * fix search in mailbox view * fix nodename in message display
[Citadel Development] Citadel commit log: revision 6991
r6991 | matt | 2009-01-25 08:26:26 -0500 (Sun, 25 Jan 2009) | 5 lines Changed paths: M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/t/login.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * properly check to see if user has turned on wholist-in-iconbar * Link to wiki Recommended browsers on login * Had to break bullet points on login into individual gettext calls, translators will have to split accordingly * Fix border style on iconbar logo and switch
[Citadel Development] (no subject)
Just some notes out of the last commit: * I created http://www.citadel.org/doku.php/faq:everydayuse:webcit_browser to officially state what browsers work well and why some features don't work in IE. A link to there has been placed on the login page. * Can someone more familiar with DokuWiki update the table of contents on http://www.citadel.org/doku.php/doku.php?id=faq:start so it lists everything? There are a few items such as the How do I ... in Webcit and the Recommended Browsers articles that nstoc seems to miss. * I went and broke up the notes on the login page into individual gettext calls so translators will need to split them up (does create-pot have access to strings defined in templates?) * Also regarding templates, there are some strings defined in JS (such as switch/customize) in iconbar that I will have to move into HTML. I'll do this soon. * I fixed search mode in mailbox view. For some reason there is an issue with safemode mailbox view where clearing the search and then switching to another message page shows no results. I can't see any cause for this in code, unless some additional cacheing is done when SortBy/startmsg/maxmsgs and search query are all involved.
[Citadel Development] Citadel commit log: revision 6997
r6997 | matt | 2009-01-25 20:45:30 -0500 (Sun, 25 Jan 2009) | 2 lines Changed paths: M /trunk/webcit/static/t/head.html M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/webcit.css M /trunk/webcit/webcit.c * Move iconbar out of global div so I can shuffle main content position rules
[Citadel Development] Citadel commit log: revision 6998
r6998 | matt | 2009-01-26 01:54:45 -0500 (Mon, 26 Jan 2009) | 7 lines Changed paths: M /trunk/webcit/auth.c M /trunk/webcit/iconbar.c M /trunk/webcit/static/iconbaricns.css M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/add_node.html M /trunk/webcit/static/t/aide_inetconf.html M /trunk/webcit/static/t/display_aide_menu.html M /trunk/webcit/static/t/display_ignet_confirmdelete.html M /trunk/webcit/static/t/display_main_menu.html M /trunk/webcit/static/t/display_netconf.html M /trunk/webcit/static/t/display_sitewide_config.html M /trunk/webcit/static/t/edit_message.html M /trunk/webcit/static/t/edit_node.html M /trunk/webcit/static/t/edituser_select.html M /trunk/webcit/static/t/files.html M /trunk/webcit/static/t/files_jspicview.html M /trunk/webcit/static/t/head.html M /trunk/webcit/static/t/preferences.html M /trunk/webcit/static/t/roombanner.html M /trunk/webcit/static/t/userlist_detailview.html M /trunk/webcit/static/t/who.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * fix some fallout from last commit: iconbar now in head.html so no one should call it themselves * set WC-logged_in to 0 at the top of do_logout() to surpress iconbar on logout * Fix IE6 iconbar bug, still not as good as it used to look :( * Completely rework roombanner etc. so the web browser sizes roombanner, navbar etc. itself * Added javascript hack so the new roombanner works in browsers that don't do display: table-cell;
[Citadel Development] Citadel commit log: revision 6984
r6984 | matt | 2009-01-24 03:42:14 -0500 (Sat, 24 Jan 2009) | 4 lines Changed paths: M /trunk/webcit/static/summaryview.js * multi-select in webcit is back, apologies to those who had to wait for it. * alt-click does the same as ctdl-click, this is for Macs where ctrl is usually mapped to right mouse click * TODO: turn on key bindings as alternative + for internet exploder
[Citadel Development] (no subject)
Do we have any statistics on what browsers webcit users use - say on uncensored? I'll try and get IE6 fixed, I'll need to set up another Winblows VM to test it, all I have here is 7 and 8 beta.
[Citadel Development] (no subject)
Excellent, the stats seem to be in line with statistics I've seen elsewhere. I guess all those on IE6 are at $work. I was thinking about throwing up a display-once notice in webcit recommending an upgrade for stagnating (FF 2, IE6) users who are able to upgrade. Thu Jan 22 2009 10:07:20 EST from IGnatius T Foobar - --- -- -- Do we have any statistics on what browsers webcit users use - say on uncensored? Sure, here are the statistics: Overall: Internet Exploder:46.21% Firefox: 41.15% Safari:5.15% Opera: 3.17% Chrome:1.79% (I'm omitting the rest because they're too small to be significant.) Internet Exploder: IE7: 73.73% IE6: 24.18% IE8: 1.99% IE5: 0.10% Firefox: FF 3.0.5: 74.08% FF 3.0 and 3.0.4: About 10% FF 2.x: about 7% So it looks like Firefox users are more proactive about staying upgraded than IE users are, which shouldn't be a surprise to anyone. It would seem that we can drop support for IE 5, but not for IE 6 or FF 2.
[Citadel Development] (no subject)
No, its just an XMPP extension to set up and tear down peer-to-peer video sessions, the actual video streaming happens between the clients themselves using RTP and some NAT-busting logic (ICE), so, 'SIP for XMPP' may be a better analogy. Thu Jan 22 2009 15:04:04 EST from IGnatius T Foobar - --- -- -- I'm at linux.conf.au at the moment, and the guys that are doing this presented yesterday. As noted on the page, they told me we don't have to do anything to support it, unless we wish to support mutli-user conferencing So ... they just encode each video frame as an instant message or something like that? We save every instant message as a message in the user's Sent/Received Pages room. The effect of sending video through that would be ... tragic.
[Citadel Development] Citadel commit log: revision 6970
r6970 | matt | 2009-01-20 04:09:05 -0500 (Tue, 20 Jan 2009) | 2 lines Changed paths: M /trunk/webcit/msg_renderers.c Restore mailbox view
[Citadel Development] Citadel commit log: revision 6971
r6971 | matt | 2009-01-20 18:49:26 -0500 (Tue, 20 Jan 2009) | 2 lines Changed paths: M /trunk/webcit/subst.c M /trunk/webcit/subst.h temporarily have IterateStruct in subst.h so mailbox conditionals can get at them (temporary solution only)
[Citadel Development] Citadel commit log: revision 6952
I was going to move some of the vars used by those two (num_displayed) etc. into a proper, passable struct as well. If we could find a generic solution where one could start n-rows into the map and only display a requested number that would be very nice. I'm restricted for time over the coming days but I'll try and unbreak it (for now) tomorrow Thu Jan 15 2009 10:59:14 EST from dothebart Citadel commit log: revision 6952 - --- -- -- hm, upsi. I actualy broke s.th. matt, concerning Conditional_ROOM_DISPLAY_MSG and Conditional_MAIL_SUMM_LASTMSG; we have to find a more generic way to achieve what you want to do here. two thoughts on this: we could add optional parameters to ITERATE; plus we have a way to retrieve preferences via GetTemplateTokenString If we want to limit ITERATE, we also have to find a generic way for that
[Citadel Development] Re: Citadel commit log: revision 6952
Its there, the conditional in login.html that is supposed to check if its available doesn't seem to be evaluating right.. Thu Jan 15 2009 13:37:37 EST from IGnatius T Foobar Re: Citadel commit log: revision 6952 - --- -- --So ... does anyone know why OpenID isn't offered as a login option anymore, or should I go take a look?
[Citadel Development] Citadel commit log: revision 6936
r6936 | matt | 2009-01-12 04:21:37 -0500 (Mon, 12 Jan 2009) | 8 lines Changed paths: M /branches/webcit-newsummaryview/WISHLIST M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/static/iconbaricns.css M /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/iconbar.html M /branches/webcit-newsummaryview/static/t/mailsummary_json.html M /branches/webcit-newsummaryview/static/t/roombanner.html M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/webcit.h + 'Safe mode' in summary view implemented * Search within summary view now ajax'ed * Fix the conditionals I added in msg_renderers.c so 'safe mode' works * Place a few readloop variables into wcsession to aide above, I really should make that a struct though * Place logoff button below roomlist in iconbar so it stays there * mailsummary_json now has a few variables embedded
[Citadel Development] Citadel commit log: revision 6937
r6937 | matt | 2009-01-12 04:30:17 -0500 (Mon, 12 Jan 2009) | 2 lines Changed paths: M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/webcit.c Some merges I have missed..
[Citadel Development] Citadel commit log: revision 6938
r6938 | matt | 2009-01-12 05:08:09 -0500 (Mon, 12 Jan 2009) | 3 lines Changed paths: M /branches/webcit-newsummaryview/calendar.c M /branches/webcit-newsummaryview/downloads.c M /branches/webcit-newsummaryview/fmt_date.c M /branches/webcit-newsummaryview/gettext.c A /branches/webcit-newsummaryview/paramhandling.h (from /trunk/webcit/paramhandling.h:6936) M /branches/webcit-newsummaryview/preferences.c M /branches/webcit-newsummaryview/preferences.h M /branches/webcit-newsummaryview/serv_func.c M /branches/webcit-newsummaryview/subst.c M /branches/webcit-newsummaryview/subst.h M /branches/webcit-newsummaryview/useredit.c M /branches/webcit-newsummaryview/webcit.h M /branches/webcit-newsummaryview/webserver.c and more.. add stuff which hasn't been updated since r6919
[Citadel Development] Citadel commit log: revision 6939
r6939 | matt | 2009-01-12 07:32:43 -0500 (Mon, 12 Jan 2009) | 2 lines Changed paths: M /trunk/webcit/auth.c M /trunk/webcit/context_loop.c M /trunk/webcit/iconbar.c M /trunk/webcit/messages.c M /trunk/webcit/msg_renderers.c M /trunk/webcit/roomops.c M /trunk/webcit/static/dragdrop.js M /trunk/webcit/static/iconbaricns.css A /trunk/webcit/static/summaryview.js (from /branches/webcit-newsummaryview/static/summaryview.js:6938) M /trunk/webcit/static/t/box_preferences.html M /trunk/webcit/static/t/head.html M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/t/load_attachments.html M /trunk/webcit/static/t/login.html A /trunk/webcit/static/t/mailsummary_json.html (from /branches/webcit-newsummaryview/static/t/mailsummary_json.html:6938) A /trunk/webcit/static/t/mailsummary_json_section.html (from /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html:6938) M /trunk/webcit/static/t/msg_listview.html M /trunk/webcit/static/t/richedit.html M /trunk/webcit/static/t/roombanner.html M /trunk/webcit/static/t/section_attach_select.html M /trunk/webcit/static/t/section_mailsummary.html A /trunk/webcit/static/t/subject_aiderestart.html (from /trunk/webcit/static/t/subject_aiderestart.html:6814) A /trunk/webcit/static/t/subject_floorconfig.html (from /trunk/webcit/static/t/subject_floorconfig.html:6814) A /trunk/webcit/static/t/subject_inet_aliases.html (from /trunk/webcit/static/t/subject_inet_aliases.html:6814) A /trunk/webcit/static/t/subject_pushmail.html (from /trunk/webcit/static/t/subject_pushmail.html:6814) A /trunk/webcit/static/t/subject_tuning.html (from /trunk/webcit/static/t/subject_tuning.html:6814) M /trunk/webcit/static/t/summary_header.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css M /trunk/webcit/subst.c M /trunk/webcit/subst.h M /trunk/webcit/webcit.c M /trunk/webcit/webcit.h Merge new summary view branches changes into trunk
[Citadel Development] r6936/new summary view changes
.. And there we go.. There are still some cosmetic patch ups needed, but I'd like to extinguish any possible bugs before I continue. If you are on a slower machine, or using Internet exploder, go into advanced-prefs and change to 'safe mode' to improve responsiveness with large (several thousand) sets of messages
[Citadel Development] Citadel commit log: revision 6945
r6945 | matt | 2009-01-12 18:15:26 -0500 (Mon, 12 Jan 2009) | 8 lines Changed paths: M /trunk/webcit/iconbar.c M /trunk/webcit/messages.c M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css *fix numerous regressions that I let slip: * 'customize this' now below 'log off' in iconbar * fix embedded wholist in iconbar appearing if not enabled * make drag and drop menu translucent, with no list padding * enable chat button again * no link colors for 'customize this' * try to properly detect the presence/lack of Firebug/Safari/IE8 developer console (console.log). If you see any console.log missing errors and don't have Firebug installed, please tell me
[Citadel Development] (no subject)
Do you see a request for /json_roomflr in the webcit console? Which browser version are you using? Disappearing room type images is probably a browser issue - CSS list-style-image is now used to show them, so the browser has to load each as they appear. A preloader will solve that. Noted issue with notes and calendar. Regarding your first list of regressions - are you sure iconbar had a background? looking at the CSS on uncensored, its just white
[Citadel Development] Citadel commit log: revision 6947
r6947 | matt | 2009-01-12 23:23:43 -0500 (Mon, 12 Jan 2009) | 6 lines Changed paths: M /trunk/webcit/messages.c M /trunk/webcit/roomops.c M /trunk/webcit/static/ctdldragdrop.js M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/wclib.js * move output_headers to the top of readloop, before the big switch, so wprintf outputs within body instead of above html (fixes issue where buttons blew up huge in notesview) * Only create CtdlDragDrop in summaryview, restores notes functionality for now * Check to see if iconbar wholist exists before calling Ajax.Updater-fixes error on logon screen * Fix double id definition for search form * Restore date format to -mm-dd i.e pre r6912
[Citadel Development] (no subject)
Thats another round. I'll install FF2 later on and check it out, admittedly I haven't gone back far with regards to versions of the three main 'good browsers' (FF, Safari and Opera), and Exploder is fairly consistent across each version :( Did someone attempt to activate i18n for datepicker as well? In r6912 there is a variable referenced called 'wclang', but I can't see it actually defined anywhere.
[Citadel Development] (no subject)
Also, there is now a javascript library (CtdlDragDrop) for drag-drop stuff that does things in a much more kosher way. Some time in the future I'll modify notes view to use it.
[Citadel Development] Citadel commit log: revision 6948
r6948 | matt | 2009-01-13 02:47:46 -0500 (Tue, 13 Jan 2009) | 5 lines Changed paths: M /trunk/webcit/auth.c M /trunk/webcit/messages.c M /trunk/webcit/serv_func.c M /trunk/webcit/static/summaryview.js M /trunk/webcit/static/t/iconbar.html M /trunk/webcit/static/t/login.html M /trunk/webcit/static/t/roombanner.html M /trunk/webcit/static/wclib.js M /trunk/webcit/static/webcit.css * fix issues with room list in firefox 2 (didn't detect console.log properly, again) * New JS func: WCLog * some HTML validation fixes (remove align=center, br / - br) * known issue: FF2 won't hide handle overflow text in table cells. I do have some idea of how to work around
[Citadel Development] Citadel commit log: revision 6933
r6933 | matt | 2009-01-11 03:08:00 -0500 (Sun, 11 Jan 2009) | 3 lines Changed paths: M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/webcit.c * undo previous experiment with ajax_servcmd * add some changes previously missed by me to msg_renderers.c
[Citadel Development] Citadel commit log: revision 6921
r6921 | matt | 2009-01-10 04:17:57 -0500 (Sat, 10 Jan 2009) | 2 lines Changed paths: M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/webcit.h Sort rooms in sidebar alphabetically
[Citadel Development] Citadel commit log: revision 6923
r6923 | matt | 2009-01-10 05:43:43 -0500 (Sat, 10 Jan 2009) | 2 lines Changed paths: A /trunk/webcit/wcpref.js (from /branches/webcit-newsummaryview/static/wcpref.js:6922) copy wcpref.js from wc-summ branch to trunk
[Citadel Development] Citadel commit log: revision 6924
r6924 | matt | 2009-01-10 06:07:07 -0500 (Sat, 10 Jan 2009) | 1 line Changed paths: A /branches/webcit-newsummaryview/static/t/iconbar.html Oops, this template should be committed
[Citadel Development] Citadel commit log: revision 6925
r6925 | matt | 2009-01-10 06:12:59 -0500 (Sat, 10 Jan 2009) | 2 lines Changed paths: A /trunk/webcit/static/ctdldragdrop.js (from /branches/webcit-newsummaryview/static/ctdldragdrop.js:6923) A /trunk/webcit/static/iconbaricns.css (from /branches/webcit-newsummaryview/static/iconbaricns.css:6923) A /trunk/webcit/static/iconbarpiconly.css (from /branches/webcit-newsummaryview/static/iconbarpiconly.css:6923) A /trunk/webcit/static/protoaculous1.6.packed.js (from /branches/webcit-newsummaryview/static/protoaculous1.6.packed.js:6923) A /trunk/webcit/static/roomops.js (from /branches/webcit-newsummaryview/static/roomops.js:6923) A /trunk/webcit/static/t/iconbar.html (from /branches/webcit-newsummaryview/static/t/iconbar.html:6924) A /trunk/webcit/static/t/json_floor.html (from /branches/webcit-newsummaryview/static/t/json_floor.html:6922) A /trunk/webcit/static/t/json_floors.html (from /branches/webcit-newsummaryview/static/t/json_floors.html:6922) A /trunk/webcit/static/t/json_lkra.html (from /branches/webcit-newsummaryview/static/t/json_lkra.html:6922) A /trunk/webcit/static/t/json_room.html (from /branches/webcit-newsummaryview/static/t/json_room.html:6922) A /trunk/webcit/static/t/json_roomflr.html (from /branches/webcit-newsummaryview/static/t/json_roomflr.html:6922) A /trunk/webcit/static/wcpref.js (from /trunk/webcit/wcpref.js:6923) D /trunk/webcit/wcpref.js add other statics from wc-sv branch, cutover for iconbar happens next
[Citadel Development] Citadel commit log: revision 6926
r6926 | matt | 2009-01-10 10:10:59 -0500 (Sat, 10 Jan 2009) | 2 lines Changed paths: M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html M /branches/webcit-newsummaryview/webcit.h * added COND:ROOM:DISPLAYMSG and COND:MAIL:SUMM:LASTMSG which implements the message display criteria in readloop for template iterations of the message list. We should be able to migrate other view types to pure templates as well with this..
[Citadel Development] Citadel commit log: revision 6917
r6917 | matt | 2009-01-09 21:16:31 -0500 (Fri, 09 Jan 2009) | 6 lines Changed paths: M /branches/webcit-newsummaryview/preferences.c M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/static/t/json_floor.html M /branches/webcit-newsummaryview/static/wclib.js A /branches/webcit-newsummaryview/static/wcpref.js + wcpref client-side pref storage; abstracts between cookies and HTML5 DOM storage + iconbar preference (Menu or Roomlist) now client side, persists across pages + currently expanded iconbar roomlist floor persists as well + New PREF:ROOM:VALUE property * New FLOOR:INFO and ROOM:INFO replaces temporary SVPutBuf in json_roomflr
[Citadel Development] Citadel commit log: revision 6918
r6918 | matt | 2009-01-09 21:31:00 -0500 (Fri, 09 Jan 2009) | 3 lines Changed paths: M /branches/webcit-newsummaryview/static/t M /branches/webcit-newsummaryview/static/t/aide_inetconf.html M /branches/webcit-newsummaryview/static/t/box_preferences.html M /branches/webcit-newsummaryview/static/t/display_aide_menu.html M /branches/webcit-newsummaryview/static/t/display_main_menu.html M /branches/webcit-newsummaryview/static/t/display_serverrestart.html M /branches/webcit-newsummaryview/static/t/display_serverrestartpage.html M /branches/webcit-newsummaryview/static/t/display_sitewide_config.html M /branches/webcit-newsummaryview/static/t/edituser_select.html M /branches/webcit-newsummaryview/static/t/head.html M /branches/webcit-newsummaryview/static/t/json_room.html M /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html M /branches/webcit-newsummaryview/static/t/preferences.html M /branches/webcit-newsummaryview/static/t/section_mailsummary.html M /branches/webcit-newsummaryview/static/t/section_mailsummary_m.html D /branches/webcit-newsummaryview/static/t/subj_advanced_roomcommands.html D /branches/webcit-newsummaryview/static/t/subj_basic_commands.html D /branches/webcit-newsummaryview/static/t/subj_your_info.html D /branches/webcit-newsummaryview/static/t/subject_access.html D /branches/webcit-newsummaryview/static/t/subject_aiderestart.html D /branches/webcit-newsummaryview/static/t/subject_autopurger.html D /branches/webcit-newsummaryview/static/t/subject_box_edituser_select.html D /branches/webcit-newsummaryview/static/t/subject_directory.html D /branches/webcit-newsummaryview/static/t/subject_edituser_add.html D /branches/webcit-newsummaryview/static/t/subject_floorconfig.html D /branches/webcit-newsummaryview/static/t/subject_general.html D /branches/webcit-newsummaryview/static/t/subject_global_config.html D /branches/webcit-newsummaryview/static/t/subject_indexing.html D /branches/webcit-newsummaryview/static/t/subject_inet_aliases.html D /branches/webcit-newsummaryview/static/t/subject_inet_clamav.html D /branches/webcit-newsummaryview/static/t/subject_inet_dirnames.html D /branches/webcit-newsummaryview/static/t/subject_inet_masqdomains.html D /branches/webcit-newsummaryview/static/t/subject_inet_rbldns.html D /branches/webcit-newsummaryview/static/t/subject_inet_smarthosts.html D /branches/webcit-newsummaryview/static/t/subject_inet_spamass.html D /branches/webcit-newsummaryview/static/t/subject_network.html D /branches/webcit-newsummaryview/static/t/subject_pop3.html D /branches/webcit-newsummaryview/static/t/subject_pushmail.html D /branches/webcit-newsummaryview/static/t/subject_serverrestartpage.html D /branches/webcit-newsummaryview/static/t/subject_tuning.html D /branches/webcit-newsummaryview/static/t/subject_usermanagement.html M /branches/webcit-newsummaryview/static/t/view_message.html M /branches/webcit-newsummaryview/static/t/view_message_print.html M /branches/webcit-newsummaryview/static/t/view_message_replyquote.html M /branches/webcit-newsummaryview/static/t/view_submessage.html Merge with trunk and add everything not committed
[Citadel Development] Citadel commit log: revision 6920
r6920 | matt | 2009-01-09 21:46:05 -0500 (Fri, 09 Jan 2009) | 2 lines Changed paths: M /branches/webcit-newsummaryview/static/wclib.js M /branches/webcit-newsummaryview/static/wcpref.js * Fix wcpref in Intarwebs Exploder
[Citadel Development] Citadel commit log: revision 6900
r6900 | matt | 2009-01-06 05:14:26 -0500 (Tue, 06 Jan 2009) | 3 lines Changed paths: M /trunk/libcitadel/lib/libcitadel.h M /trunk/libcitadel/lib/stringbuf.c + New function: StrECMAEscAppend, does string escaping for javascript output, things like - \ etc. ! changed the if in StrIsNumber to be the other, sensible way around.. I don't use this func anymore however.
[Citadel Development] Citadel commit log: revision 6888
r6888 | matt | 2009-01-01 08:31:15 -0500 (Thu, 01 Jan 2009) | 2 lines Changed paths: M /branches/webcit-newsummaryview/README.txt A /branches/webcit-newsummaryview/WISHLIST M /branches/webcit-newsummaryview/downloads.c M /branches/webcit-newsummaryview/html2html.c M /branches/webcit-newsummaryview/iconbar.c M /branches/webcit-newsummaryview/inetconf.c M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/netconf.c M /branches/webcit-newsummaryview/preferences.c M /branches/webcit-newsummaryview/pushemail.c M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/static/ctdldragdrop.js A /branches/webcit-newsummaryview/static/iconbaricns.css M /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/box_preferences.html A /branches/webcit-newsummaryview/static/t/files.html (from /trunk/webcit/static/t/files.html:6887) A /branches/webcit-newsummaryview/static/t/files_jspicview.html (from /trunk/webcit/static/t/files_jspicview.html:6887) M /branches/webcit-newsummaryview/static/t/head.html M /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html M /branches/webcit-newsummaryview/static/t/menu_basic_commands.html M /branches/webcit-newsummaryview/static/t/msg_listview.html A /branches/webcit-newsummaryview/static/t/section_files_onefile.html (from /trunk/webcit/static/t/section_files_onefile.html:6887) A /branches/webcit-newsummaryview/static/t/section_files_onefile_picview.html (from /trunk/webcit/static/t/section_files_onefile_picview.html:6887) M /branches/webcit-newsummaryview/static/wclib.js M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/subst.c M /branches/webcit-newsummaryview/subst.h M /branches/webcit-newsummaryview/useredit.c M /branches/webcit-newsummaryview/webcit.c M /branches/webcit-newsummaryview/webserver.c M /branches/webcit-newsummaryview/who.c Merge with trunk, iconbar redone with CSS-define images (stylesheets for text-only and icon-only not yet redefined), visual refinements to mailbox view (resize splitter back etc.), see WISHLIST for stuff I want to do before merging into trunk
[Citadel Development] Re: Citadel commit log: revision 6888
I intend to get as much as possible done in the immediate future (within the next 7 days) as I wish to move onto other projects. dothebart: I want to be able to limit the number of messages displayed, like bbsview, but still using a template iterator, the two ways I can think of: modify load_msg_ptrs so we don't add stuff to WC-summ we don't want (doesn't really work as far as sorting is concerned), or create a new HashList (like I've tried) and copy the message structs we want into that. Any ideas?
[Citadel Development] Citadel commit log: revision 6880
r6880 | matt | 2008-12-28 08:16:15 -0500 (Sun, 28 Dec 2008) | 3 lines Changed paths: M /branches/webcit-newsummaryview/README.txt M /branches/webcit-newsummaryview/auth.c M /branches/webcit-newsummaryview/availability.c M /branches/webcit-newsummaryview/calendar.c M /branches/webcit-newsummaryview/calendar_tools.c M /branches/webcit-newsummaryview/calendar_view.c M /branches/webcit-newsummaryview/context_loop.c M /branches/webcit-newsummaryview/debian/rules M /branches/webcit-newsummaryview/decode.c M /branches/webcit-newsummaryview/downloads.c M /branches/webcit-newsummaryview/event.c M /branches/webcit-newsummaryview/fmt_date.c M /branches/webcit-newsummaryview/gettext.c M /branches/webcit-newsummaryview/graphics.c M /branches/webcit-newsummaryview/groupdav_get.c M /branches/webcit-newsummaryview/groupdav_propfind.c M /branches/webcit-newsummaryview/groupdav_put.c M /branches/webcit-newsummaryview/html2html.c M /branches/webcit-newsummaryview/iconbar.c M /branches/webcit-newsummaryview/mainmenu.c M /branches/webcit-newsummaryview/messages.c A /branches/webcit-newsummaryview/messages.h (from /trunk/webcit/messages.h:6878) M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/netconf.c M /branches/webcit-newsummaryview/paramhandling.c M /branches/webcit-newsummaryview/preferences.c A /branches/webcit-newsummaryview/preferences.h (from /trunk/webcit/preferences.h:6878) M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/rss.c M /branches/webcit-newsummaryview/serv_func.c M /branches/webcit-newsummaryview/smtpqueue.c M /branches/webcit-newsummaryview/static/t/msg_listselector_bottom.html M /branches/webcit-newsummaryview/static/t/msg_listselector_top.html M /branches/webcit-newsummaryview/static/t/select_messageindex.html M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/subst.c A /branches/webcit-newsummaryview/subst.h (from /trunk/webcit/subst.h:6878) M /branches/webcit-newsummaryview/tcp_sockets.c M /branches/webcit-newsummaryview/useredit.c M /branches/webcit-newsummaryview/utils.c A /branches/webcit-newsummaryview/wc_gettext.h (from /trunk/webcit/wc_gettext.h:6878) M /branches/webcit-newsummaryview/webcit.c M /branches/webcit-newsummaryview/webcit.h M /branches/webcit-newsummaryview/webserver.c M /branches/webcit-newsummaryview/who.c Merged changes from trunk. Only other change is that rendering of the mailbox summary list json now sits in readloop And as Dogbert would say: OUT OUT YOU DEMONS OF (subversion merging) STUPIDITY!!
[Citadel Development] re: Citadel commit log: revision 6860
1. Friends of LKRA already taken care of, see
GetRoomListHashLKRA-GetRoomListHash . When someone needs to use a different
one just add another wrapper around GetRoomListHash
2. I'm aware of that, in this case its intentional as this template needs to
be evaluated at runtime, are you saying there will still be a performance
gain in this case?
3. Good question, for now I'm just building the JSON backend as a way of
presenting the server output in a nicer way to JavaScript. Shouldn't be any
need for one to build their own queries on client-side, named arrays could be
a possibility in the future.
Dec 22 0:38 from dothebart
Citadel commit log: revision 6860
-
---
--
--
Matt, three tiny comments:
* LKRA has some friends with similar syntax:
http://www.citadel.org/doku.php/documentation:appproto:rooms?s=lkra#list.comma
nds You probably should create something that can easily handle all of them
(maybe by some wrappers?
* SVPut and friends are to be avoided in favour of passing structs through
the context, and writing tiny callbacks. SVPut can't be pre-evaluated while
parsing the templates, because of they're just known at runtime, while the
callbacks are there from the start - saves one hashtable lookup per
occurance.
* more of a question... Whats to be prefered? Anonymous arrays or named
ones? Should we care?
Should the json call be able to select the collumns its wanting to see? And,
should it be able to select a vector of names to choose from to build named
arrays? ala:
ajax_servcmd?listnames=LKRAselect_columns=1,3,7g_input=LKRA
and listnames be looked up in a hashtable where we would find s.th. like
that:
struct json_token { int Type (= STR / INT); const char * Key, long
Keylen(=HKEY(JSON_FIELDNAME)}
struct json_array{ int nValues, const json_token** types};
so you could put a list of json_tokens into a json_array, and put the
json_array into the hash named by for example LKRA
the 100-evaluator could lookup them, select the columns you need, decide by
Type what it needs to do (just print the number, or rather escape a string?)
plus add the names..
[Citadel Development] Citadel commit log: revision 6846
r6846 | matt | 2008-12-18 05:04:22 -0500 (Thu, 18 Dec 2008) | 1 line Changed paths: M /branches/webcit-newsummaryview/iconbar.c M /branches/webcit-newsummaryview/messages.c A /branches/webcit-newsummaryview/static/ctdldragdrop.js M /branches/webcit-newsummaryview/static/dragdrop.js A /branches/webcit-newsummaryview/static/roomops.js M /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/head.html M /branches/webcit-newsummaryview/static/t/msg_listview.html M /branches/webcit-newsummaryview/static/wclib.js M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/subst.c Sidebar room list now entirely client side :) single message drag and drop restored, multiple message todo..
[Citadel Development] Citadel commit log: revision 6835
r6835 | matt | 2008-12-14 06:07:34 -0500 (Sun, 14 Dec 2008) | 2 lines Changed paths: A /branches/webcit-newsummaryview/static/t/mailsummary_json.html Missing template, needed to function :)
[Citadel Development] Citadel commit log: revision 6837
r6837 | matt | 2008-12-14 07:16:53 -0500 (Sun, 14 Dec 2008) | 2 lines Changed paths: M /branches/webcit-newsummaryview/roomops.c M /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/head.html M /branches/webcit-newsummaryview/static/wclib.js M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/webcit.c beginnings of drag and drop restoration, iconbar roomlist is being reimplemented (broken for now) as json-ajax as well (backend will be used for move/copy to room dialogs as well), ajax_servcmd hacked (with very bad code) to reformat output from commands like LKRN, LFLR to json. (will probably split into another func or simply template w/iterator)
[Citadel Development] Citadel commit log: revision 6838
r6838 | matt | 2008-12-14 07:25:54 -0500 (Sun, 14 Dec 2008) | 1 line Changed paths: M /trunk/libcitadel/lib/libcitadel.h M /trunk/libcitadel/lib/stringbuf.c As per dothebart's advice, revise StrBufIsNumber to check for NULL buffer, no longer use strlen
[Citadel Development] Citadel commit log: revision 6842
r6842 | matt | 2008-12-15 00:17:30 -0500 (Mon, 15 Dec 2008) | 2 lines Changed paths: M /trunk/webcit/messages.c fix (no subject) for blank message subjects
[Citadel Development] Citadel commit log: revision 6819
r6819 | matt | 2008-12-13 04:59:13 -0500 (Sat, 13 Dec 2008) | 2 lines Changed paths: M /branches/webcit-newsummaryview/static/summaryview.js Turn off JSON sanitization in prototype.js, improves load performance
[Citadel Development] Citadel commit log: revision 6826
r6826 | matt | 2008-12-13 08:43:27 -0500 (Sat, 13 Dec 2008) | 2 lines Changed paths: M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html M /branches/webcit-newsummaryview/static/t/view_message.html M /branches/webcit-newsummaryview/subst.c M /branches/webcit-newsummaryview/webcit.h merge from trunk, use the iterate:lastn conditional
[Citadel Development] Citadel commit log: revision 6815
r6815 | matt | 2008-12-12 06:27:36 -0500 (Fri, 12 Dec 2008) | 1 line Changed paths: A /branches/webcit-newsummaryview (from /trunk/webcit:6814) Branch to stage new webcit message list view amongst other things
[Citadel Development] Citadel commit log: revision 6816
r6816 | matt | 2008-12-12 06:52:34 -0500 (Fri, 12 Dec 2008) | 2 lines Changed paths: M /branches/webcit-newsummaryview/messages.c A /branches/webcit-newsummaryview/static/summaryview.js M /branches/webcit-newsummaryview/static/t/msg_listview.html M /branches/webcit-newsummaryview/static/t/roombanner.html M /branches/webcit-newsummaryview/static/wclib.js M /branches/webcit-newsummaryview/static/webcit.css Initial commit, see message in Citadel Developers for more info
[Citadel Development] (no subject)
As you can see I've created a branch to stage some changes to webcit (I suppose I could have used TECH_PREVIEW, but at least people won't scream 'revert! revert!' this way). I have completely rebuilt the message summary/listview. It now loads the message list for each room via an Ajax request to webcit, which sends the list in JSON format. Sorting operations etc. now lie with the client. Loading and sorting can be CPU intensive in browsers without a JavaScript JIT. I just loaded it up in a WebKit nightly (which has the Squirrelfish JIT) and it flew.. either way its a timesaver. Its not finished yet.. the resize grippy hasn't been put back yet, nor has drag and drop - excuse me for being naive, but can someone tell me what drag and drop is supposed to do in listview? One new thing I am experimenting is with a context menu - it pops up when the mouse button is held down for a second (right click is hard to capture properly). Functionality for the context menu hasn't been implemented, thats up next.I'm thinking of having search operations client side as well. Please try it out and give me some feedback.
[Citadel Development] Citadel commit log: revision 6818
r6818 | matt | 2008-12-12 21:44:08 -0500 (Fri, 12 Dec 2008) | 2 lines Changed paths: M /branches/webcit-newsummaryview/messages.c M /branches/webcit-newsummaryview/msg_renderers.c M /branches/webcit-newsummaryview/static/t/load_attachments.html M /branches/webcit-newsummaryview/static/t/login.html A /branches/webcit-newsummaryview/static/t/mailsummary_json_section.html M /branches/webcit-newsummaryview/static/t/richedit.html M /branches/webcit-newsummaryview/static/t/roombanner.html M /branches/webcit-newsummaryview/static/t/section_attach_select.html M /branches/webcit-newsummaryview/static/t/section_mailsummary.html M /branches/webcit-newsummaryview/static/t/summary_header.html M /branches/webcit-newsummaryview/static/webcit.css M /branches/webcit-newsummaryview/subst.c M /branches/webcit-newsummaryview/webcit.h templatized JSON output as per dothebart's suggestion, implement new subst condtional handler^Hhack to see if the row being iterated is the last one
[Citadel Development] (no subject)
dothebart: have you tried mail view with a large (1000) set of messages in a room? A few of the rooms here (such as this one, don't have autopurger on) only seem to list around that number of oldest messages. I can't find find a room on uncnsrd that big right now to make sure its not just me. webcit is definitely getting the entire list, its doing MSGS ALL|||1 like it should. Another thing, -lz needs to be added to LDFLAGS for libcitadel on OS X.
[Citadel Development] (no subject)
seems to have fixed it
[Citadel Development] Citadel commit log: revision 6707
r6707 | matt | 2008-10-31 04:01:26 -0400 (Fri, 31 Oct 2008) | 3 lines Changed paths: M /trunk/webcit/configure.ac M /trunk/webcit/webcit.h Use AC_CHECK_HEADERS rather than __DARWIN__ macro to include xlocale.h
[Citadel Development] Citadel commit log: revision 6706
r6706 | matt | 2008-10-31 00:28:33 -0400 (Fri, 31 Oct 2008) | 2 lines Changed paths: M /trunk/webcit/configure.ac M /trunk/webcit/webcit.h M /trunk/webcit/webserver.c add a few #defines to fix OS X
[Citadel Development] Citadel commit log: revision 6702
r6702 | matt | 2008-10-27 21:10:59 -0400 (Mon, 27 Oct 2008) | 2 lines Changed paths: M /trunk/citadel/docs/macintosh-readme.txt updated instructions, noting libsieve and gettext
[Citadel Development] Citadel commit log: revision 6664
r6664 | matt | 2008-10-05 07:54:14 -0400 (Sun, 05 Oct 2008) | 2 lines Changed paths: M /trunk/webcit/webcit.c add begin_burst to citadel version too low failure
