Re: [Savannah-hackers-public] New VM vcs1 to hold CVS data with working file ACLs

[Bob Proulx]

Savannah Hackers,

Bob Proulx wrote:
> I am going to disable cvs on vcs0, sync the data from old vcs over to
> new vcs1, switch the DNS names for all things cvs over to vcs1, and
> then hold my breath that everything is working moving forward.  It
> should be working okay at that point.  I'll ask for expanded testing
> then from the www team.  We have the rest of this week before the
> datacenter move and the deadline for this.

This has now been done.  The live server and backend storage for all
things cvs is now the vcs1 VM.

Bob

[savannah-help-public] [sr #109694] replace SV_THEME cookie with db stored user preference

[Peter Liscovius]

Follow-up Comment #3, sr #109694 (project administration):

Yea, extra themes in addition to a default theme is not important.

Netherless it is still very confusing together with the SV_THEME cookies on
both domains savannah.gnu.org and savannah.nongnu.org
as each stores cookie in browser separate value for the duration of the
session.

Try:

1. Clear browser cookies (or retest later without clearing them in a second
test)
2. Login on savannah.gnu.org with login to 'brother nongnu' checked box. 
3. Go straight 'My Account Conf' https://savannah.gnu.org/my/admin/ (watch
gnu/nongnu)
4. Change theme dropdown, click 'Update'. (Looks ok, it looks like savannah,
also SV_THEME of savannah.gnu.org cookie changes to Savannah)
5. Follow link to the brother site, like clicking 'Get support' for going to
https://savannah.nongnu.org/support/?group=administration
   BAM! The savannah.nongnu.org shows a different theme and SV_THME cookie of
savannah.nongnu.org is the other theme name.
6. Click 'My Account Conf' https://savannah.nongnu.org/my/admin/ (watch the
diiference to point 3.!)
7. Change theme dropdown to 'DarkSlate', click .Update'. (Looks like
DarkSlate, SV_THEME of savannah.nongnu.org cookie changed to DarkSlate)
8. Click left bottom link 'Gnu Savannah' savannah.gnu.org .
   BAM! Then savannah.gnu.org shows not the DarkSlate, but the Savannah
theme.

As both sites use the same database, it is IMHO not necessary to set any
SV_THEME cookie or read any SV_THEME cookie, as the information can be read
from savane user database (and probably possible without the cost of an extra
sql query because user info must be read in any case from database?)


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

[savannah-help-public] [sr #109711] PHP code style of savane

[Peter Liscovius]

URL:
  

 Summary: PHP code style of savane
 Project: Savannah Administration
Submitted by: peterdd
Submitted on: Wed 19 Jun 2019 09:02:37 PM CEST
Category: Savannah website
Priority: 5 - Normal
Severity: 3 - Normal
  Status: None
 Assigned to: None
Originator Email: 
Operating System: None
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Coding styles are different between programming languages, different between
companies, also different between communities of a programming language by
countries sometimes, and even change over time.

Netherless I want to point out some rules that SHOULD be applied to the PHP
code of savane when changing a file or writing a new .php file:

* Do not put any spaces between a function call and the opening parenthesis.
  It makes reading and searching sourcetrees easier (a grep -rin 'time(' would
not match 'Time to say goodbye.', but any variant of time( Time( tIME( ... 

This was the vote result for PSR-2:


function_space_after:
no: 22


Clearly.

* Always put the body following an *if* structure within curly brackets, even
if it just contains a single expression!
  Not putting curly brackets there is like laying hidden mines and provokes
hard to find bugs for any later person.
  I don't know why people still keep doing that evil shortcut. Maybe it is
from C-coders that used it 40 years ago to optimize their compiler that
couldn't optimize {} out when a single command follows? I don't know.

There is https://www.php.net/manual/en/control-structures.if.php , but that
guys are C-coders too. 
  For single expression if's there is the ternary conditional operator (but I
find it easier write and read read 'if ($x){ expression } else { expression }'
constructs) 
  'if ($x) ? expression : expression;'

This was the vote result for PSR-2:

+verbstim+
always_use_control_braces:
no: 3
yes: 19


Quite clearly.

* Please optionally put . in PHP comments only if it is *a full sentence*. I
even prefer not to put a . even for a single sentense in comment, but that is
not important.

* Do not indent curly brackets at nowhere spaces. Either align it 
  * vertical with the if/while/switch/for/..  
  * opening curly bracket at same line, ending bracket vertical aligned with
if/while/switch/for(...

The other whole bunch of coding styles are debatable, but these 4 are IMHO
important to follow.

General:

* Only change code that matches the commit message. Stick to an existing
coding style of a file. Keeps the changes to git commits small and makes
reviews/git history/git blame/ easier.

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md

There is also PSR-2 https://www.php-fig.org/psr/psr-2/, but I would not fully
agree to that standard (See the quite diverting voting results at
https://www.php-fig.org/psr/psr-2/#a1-survey-data 
https://www.php-fig.org/psr/psr-2/

I disagree to that PSR-2 rule:

-verbatim+
indent_type:
tab: 7 (I prefer this as a user of also dumb/basic editors, navigation
easier)
2 spaces: 1
4 spaces: 14


The other rules of PSR-2 are either ok or I do not care of the flavor and can
adapt to it.





___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

[savannah-help-public] [sr #109696] markdown verbatim (for code snippets) does not respect white-space

[Peter Liscovius]

Follow-up Comment #5, sr #109696 (project administration):

Someone compared available webbrowser side based javascript syntax
highlighters.

They all work on code sections in the html content wrapped by pre-tags or
combinations of pre+code-tags.

https://webdesign.tutsplus.com/articles/25-syntax-highlighters-tried-and-tested--cms-23931


Here are some links for checking out if applicable and license.


https://github.com/syntaxhighlighter (MIT License)


https://github.com/PrismJS/prism (MIT License)


https://github.com/highlightjs/highlight.js (own license)


https://github.com/ccampbell/rainbow (Apache License 2.0)


https://github.com/google/code-prettify (Apache License 2.0)



https://sourceforge.net/projects/jush/ (LICENSE not set yet)
https://github.com/vrana/jush (LICENSE not set yet)

And then there are server side parsers, which are - ummh -  special:

There is Python Pygments and PHPygments
https://github.com/capynet/PHPygments (own license)
and seems to be wide adopted according to http://pygments.org/faq/ . So a
serverside syntax highlighting is possible. Maybe not applicable due their
license or require change license needed.

My experience with GeSHi (https://github.com/GeSHi/geshi-1.0 (GPL 2) and fork
https://github.com/easybook/geshi ) which is used by Dokuwiki and Flyspray:
Slow and not solid as I wish (slowiness mitigated by caching to file/database
unless origin content changes). Probably will replace it in future.

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

[savannah-help-public] [sr #109696] markdown verbatim (for code snippets) does not respect white-space

[Peter Liscovius]

Follow-up Comment #6, sr #109696 (project administration):

There is also a project here on gnu.org: 

https://savannah.gnu.org/projects/src-highlite/

(I never tried or if applicable to savane.)

___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

[savannah-help-public] [sr #109710] reduce visual noise of 'Assigned To' in support, tasks, bugs, .. table output

[Peter Liscovius]

URL:
  

 Summary: reduce visual noise of 'Assigned To' in
support,tasks,bugs,.. table output
 Project: Savannah Administration
Submitted by: peterdd
Submitted on: Wed 19 Jun 2019 04:56:34 PM CEST
Category: None
Priority: 5 - Normal
Severity: 3 - Normal
  Status: None
 Assigned to: None
Originator Email: 
Operating System: None
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Hello Ineiev,

here a simple suggestion (hope you are not too upset from my comment in 
support #109696):

Remove the text 'None' from the output column 'Assigned To' (for instance
https://savannah.nongnu.org/support/?group=administration ) when there is no
one assigned to a support/task/bug/patch/cookbook .

This way it is much easier to see if someone is assigned to something or not.
The word 'None' does not add value compared to nothing but distracts from
absorbing information of the shown table.





___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

[savannah-help-public] [sr #109696] markdown verbatim (for code snippets) does not respect white-space

[Peter Liscovius]

Follow-up Comment #4, sr #109696 (project administration):

Hello Ineiev,

this is not solved yet.

It converts tabs to  too.

As the verbatim section is for nonmodifying code sections that can be copied
simple by selection areas with mouse for instance, I really suggest using the
pre tag and only cleanup for output with something like htmlspecialchars().

Using the pre tag here is better than p paragraph tag (semantic and by default
css of web browsers)

Please do not fiddle with the content inside the verbatim tag if possible.

As I suggested earlier, layout breaks by nasty long or height code sections
can be tamed by CSS.

If this is not convincing enough, take a look at other webbased trackers.


___

Reply to this item at:

  

___
  Message sent via Savannah
  https://savannah.nongnu.org/

Re: [Savannah-hackers-public] Getting started

[Bob Proulx]

Nassima Mellal wrote:
> I'm interesting to test the AWN, and use the Aramorph. I have installed the
> AWN and it works well, but I need to test it through a java example. I have
> no reference to begin.  I would be grateful if you could send me some java
> examples.

Hello!  You seem to be talking about a project that I do not recognize
but you have emailed the Savannah Hacker team.  I am thinking you
meant to email the AWN or the Aramorph folks perhaps?  We are not
them.  We don't know anything about them here.  I searched around and
I don't find any project that is either Aramorph or AWN.  You will
need to locate the project you were intending to contact and then
email them.

Good luck! :-)
Bob