[jira] [Updated] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit updated MAILBOX-11: -- Attachment: (was: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch) MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Norman Maurer Fix For: 0.6 MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1683057 - in /james/mailbox/trunk: api/src/test/java/org/apache/james/mailbox/ memory/ memory/src/main/java/org/apache/james/mailbox/inmemory/mail/ memory/src/test/java/org/apache/james/m
Author: eric
Date: Tue Jun 2 08:11:56 2015
New Revision: 1683057
URL: http://svn.apache.org/r1683057
Log:
MailboxQuery ignore namespace, patch contributed by Benoit Tellier (MAILBOX-11)
Modified:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
james/mailbox/trunk/memory/pom.xml
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxManagerTest.java
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Modified:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java?rev=1683057r1=1683056r2=1683057view=diff
==
---
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
(original)
+++
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
Tue Jun 2 08:11:56 2015
@@ -45,8 +45,8 @@ import org.slf4j.LoggerFactory;
*/
public abstract class AbstractMailboxManagerTest {
-private final static String USER_1 = USER_1;
-private final static String USER_2 = USER_2;
+public final static String USER_1 = USER_1;
+public final static String USER_2 = USER_2;
/**
* The mailboxManager that needs to get instanciated
Modified: james/mailbox/trunk/memory/pom.xml
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/memory/pom.xml?rev=1683057r1=1683056r2=1683057view=diff
==
--- james/mailbox/trunk/memory/pom.xml (original)
+++ james/mailbox/trunk/memory/pom.xml Tue Jun 2 08:11:56 2015
@@ -70,5 +70,10 @@
groupIdjunit/groupId
artifactIdjunit/artifactId
/dependency
+dependency
+groupIdorg.assertj/groupId
+artifactIdassertj-core/artifactId
+scopetest/scope
+/dependency
/dependencies
/project
Modified:
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java?rev=1683057r1=1683056r2=1683057view=diff
==
---
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java
(original)
+++
james/mailbox/trunk/memory/src/main/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java
Tue Jun 2 08:11:56 2015
@@ -79,13 +79,19 @@ public class InMemoryMailboxMapper imple
final String regex = path.getName().replace(%, .*);
ListMailboxLong results = new ArrayListMailboxLong();
for (final MailboxLong mailbox:mailboxesById.values()) {
-if (mailbox.getName().matches(regex)) {
+if (mailboxMatchesRegex(mailbox, path, regex)) {
results.add(mailbox);
}
}
return results;
}
+private boolean mailboxMatchesRegex(MailboxLong mailbox, MailboxPath
path, String regex) {
+return mailbox.getNamespace().equals(path.getNamespace())
+ mailbox.getUser().equals(path.getUser())
+ mailbox.getName().matches(regex);
+}
+
/**
* @see
org.apache.james.mailbox.store.mail.MailboxMapper#save(org.apache.james.mailbox.store.mail.model.Mailbox)
*/
Modified:
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxManagerTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxManagerTest.java?rev=1683057r1=1683056r2=1683057view=diff
==
---
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxManagerTest.java
(original)
+++
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxManagerTest.java
Tue Jun 2 08:11:56 2015
@@ -18,6 +18,8 @@
/
package org.apache.james.mailbox.inmemory;
+import static org.assertj.core.api.Assertions.assertThat;
+
import org.apache.james.mailbox.AbstractMailboxManagerTest;
import org.apache.james.mailbox.MailboxSession;
import org.apache.james.mailbox.acl.GroupMembershipResolver;
@@ -26,17 +28,25 @@ import org.apache.james.mailbox.acl.Simp
import org.apache.james.mailbox.acl.UnionMailboxACLResolver;
import
[jira] [Closed] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Charles closed MAILBOX-11. --- Resolution: Fixed Assignee: Eric Charles (was: Norman Maurer) Committed, Thx Benoit. MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tellier Benoit updated MAILBOX-11: -- Attachment: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch Sorry. Here is the rebased patch. MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Norman Maurer Fix For: 0.6 Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1683157 - in /james/mailbox/trunk: memory/src/test/java/org/apache/james/mailbox/inmemory/mail/ store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Author: eric
Date: Tue Jun 2 18:42:12 2015
New Revision: 1683157
URL: http://svn.apache.org/r1683157
Log:
Add back the 2 test classes remove in MAILBOX-11
Added:
james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Added:
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java?rev=1683157view=auto
==
---
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
(added)
+++
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Tue Jun 2 18:42:12 2015
@@ -0,0 +1,648 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * License); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the*
+ * specific language governing permissions and limitations *
+ * under the License. *
+ /
+
+package org.apache.james.mailbox.store;
+
+import org.apache.james.mailbox.MailboxListener;
+import org.apache.james.mailbox.MailboxManager;
+import org.apache.james.mailbox.MailboxPathLocker;
+import org.apache.james.mailbox.MailboxPathLocker.LockAwareExecution;
+import org.apache.james.mailbox.MailboxSession;
+import org.apache.james.mailbox.MailboxSession.SessionType;
+import org.apache.james.mailbox.MailboxSessionIdGenerator;
+import org.apache.james.mailbox.RequestAware;
+import org.apache.james.mailbox.StandardMailboxMetaDataComparator;
+import org.apache.james.mailbox.acl.GroupMembershipResolver;
+import org.apache.james.mailbox.acl.MailboxACLResolver;
+import org.apache.james.mailbox.exception.BadCredentialsException;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.mailbox.exception.MailboxExistsException;
+import org.apache.james.mailbox.exception.MailboxNotFoundException;
+import org.apache.james.mailbox.model.MailboxACL;
+import org.apache.james.mailbox.model.MailboxConstants;
+import org.apache.james.mailbox.model.MailboxMetaData;
+import org.apache.james.mailbox.model.MailboxMetaData.Selectability;
+import org.apache.james.mailbox.model.MailboxPath;
+import org.apache.james.mailbox.model.MailboxQuery;
+import org.apache.james.mailbox.model.MessageRange;
+import org.apache.james.mailbox.model.SimpleMailboxACL;
+import org.apache.james.mailbox.store.mail.MailboxMapper;
+import org.apache.james.mailbox.store.mail.model.Mailbox;
+import org.apache.james.mailbox.store.mail.model.impl.SimpleMailbox;
+import org.apache.james.mailbox.store.search.ListeningMessageSearchIndex;
+import org.apache.james.mailbox.store.search.MessageSearchIndex;
+import org.apache.james.mailbox.store.search.SimpleMessageSearchIndex;
+import org.apache.james.mailbox.store.transaction.Mapper;
+import org.apache.james.mailbox.store.transaction.TransactionalMapper;
+import org.slf4j.Logger;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Locale;
+import java.util.Random;
+
+/**
+ * This base class of an {@link MailboxManager} implementation provides a
high-level api for writing your own
+ * {@link MailboxManager} implementation. If you plan to write your own {@link
MailboxManager} its most times so easiest
+ * to extend just this class or use it directly.
+ * p/
+ * If you need a more low-level api just implement {@link MailboxManager}
directly
+ *
+ * @param Id
+ */
+public class StoreMailboxManagerId implements MailboxManager {
+
+public static final char SQL_WILDCARD_CHAR = '%';
+public static final int DEFAULT_FETCH_BATCH_SIZE = 200;
+
+private MailboxEventDispatcherId dispatcher;
+private AbstractDelegatingMailboxListener delegatingListener = null;
+private final
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569549#comment-14569549 ] Eric Charles commented on MAILBOX-11: - I have added them back. MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Jenkins build is still unstable: james-server-trunk » Apache James :: Server :: POP3 #5269
See https://builds.apache.org/job/james-server-trunk/org.apache.james$james-server-protocols-pop3/5269/ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Jenkins build is still unstable: james-server-trunk #5269
See https://builds.apache.org/job/james-server-trunk/5269/ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Our pending reviews - Updated
Hi, Thanks for MAILBOX-11 I am sorry, I didn't notice it for MAILBOX-73... I'll comment on JAMES-1579 right now. Regards, Benoit Tellier On 02/06/15 14:55, Eric Charles wrote: Thx Benoit. I have committed MAILBOX -11 MAILBOX-73 was already done Can you comment on JAMES-1579? I am not sure what you mean. On 2015-05-29 18:35, Benoit Tellier wrote: Hi, Thank you so much Eric for taking the time to have a look at our patchs. Just a little note : the reporter on the JIRA ticket is not always the one that wrote the patch. In such case, the patch writer is mentioned in the comments. Finally, here are our pending reviews : MAILBOX-11 We added filter on namespace and user at the store level and corrected the memory implementation. We run tests on MPT and validate that we solved the problem MAILBOX-73 We added generic tests on mappers and run it on Cassandra back end JAMES-1579 Part of a patch from JAMES-1578 that was not applied. We still need jar on which SieveManagerMailet relies to be imported. MAILBOX-219 Warning !!! Two patchs here. ( A bug can hide another ) We are writing failing test on current ACL system and then corrected it. MAILBOX-232 MAILET-95 MIM4J-245 JAMES-1310 Check the return value of file operations. ( We did it in other James sub projects ) Regards, Benoit Tellier - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-11) MailboxQuery ignore namespace
[ https://issues.apache.org/jira/browse/MAILBOX-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569161#comment-14569161 ] Tellier Benoit commented on MAILBOX-11: --- I have errors when I rebase on trunk... Seems that : james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/StoreMailboxManagerTest.java james/mailbox/trunk/memory/src/test/java/org/apache/james/mailbox/inmemory/mail/InMemoryMailboxMapper.java Are missing... Benoit MailboxQuery ignore namespace - Key: MAILBOX-11 URL: https://issues.apache.org/jira/browse/MAILBOX-11 Project: James Mailbox Issue Type: Bug Environment: Linux, JDK 1.6 Reporter: François-Denis Gonthier Assignee: Eric Charles Fix For: 0.6 Attachments: 0001-MAILBOX-11-Add-filters-on-namespace-and-user-for-sea.patch MailboxQuery doesn't pay any attention to namespace of the mailbox it is based on. For example, Mozilla Thunderbird might to mailbox search with expressions like #private.%. That expression is passed directly to the isExpressionMatch method of the MailboxQuery class. This has obviously incorrect results. Arguments to the isExpressionMatch method should be parsed to separate the namespace from the mailbox name or isExpressionMatch should do the parsing itself. In that case the argument name should be renamed to something like 'searchExpression' instead of 'name' which doesn't convey the right meaning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Our pending reviews - Updated
Thx Benoit. I have committed MAILBOX -11 MAILBOX-73 was already done Can you comment on JAMES-1579? I am not sure what you mean. On 2015-05-29 18:35, Benoit Tellier wrote: Hi, Thank you so much Eric for taking the time to have a look at our patchs. Just a little note : the reporter on the JIRA ticket is not always the one that wrote the patch. In such case, the patch writer is mentioned in the comments. Finally, here are our pending reviews : MAILBOX-11 We added filter on namespace and user at the store level and corrected the memory implementation. We run tests on MPT and validate that we solved the problem MAILBOX-73 We added generic tests on mappers and run it on Cassandra back end JAMES-1579 Part of a patch from JAMES-1578 that was not applied. We still need jar on which SieveManagerMailet relies to be imported. MAILBOX-219 Warning !!! Two patchs here. ( A bug can hide another ) We are writing failing test on current ACL system and then corrected it. MAILBOX-232 MAILET-95 MIM4J-245 JAMES-1310 Check the return value of file operations. ( We did it in other James sub projects ) Regards, Benoit Tellier - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1578) Problems compiling James
[ https://issues.apache.org/jira/browse/JAMES-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569209#comment-14569209 ] Tellier Benoit commented on JAMES-1578: --- If I do not have this patch, our build is failing, using OpenJDK 8 and maven 3. It fails in : [INFO] Apache James :: Server :: Data :: JCR Persistence .. SUCCESS [ 4.394 s] And the exact error is : [INFO] [INFO] --- maven-war-plugin:2.3:war (make-war) @ james-server-app --- [INFO] Packaging webapp [INFO] Assembling webapp [james-server-app] in [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Processing war project [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/config/war] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] As /james-parent/modules/james/app/src/main/config/war does not exists, we get a compilation error that make our build fail. Problems compiling James Key: JAMES-1578 URL: https://issues.apache.org/jira/browse/JAMES-1578 Project: James Server Issue Type: Bug Reporter: Tellier Benoit Attachments: 0001-JWC-111-Add-missing-directory.patch On modern JDK, James compilation fails if a directoy is not present in /app -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Comment Edited] (JAMES-1578) Problems compiling James
[ https://issues.apache.org/jira/browse/JAMES-1578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14569209#comment-14569209 ] Tellier Benoit edited comment on JAMES-1578 at 6/2/15 2:56 PM: --- If I do not have this patch, our build is failing, using OpenJDK 8 and maven 3. It fails in : [INFO] Apache James :: Server :: App .. FAILURE [ 13.900 s] And the exact error is : [INFO] [INFO] --- maven-war-plugin:2.3:war (make-war) @ james-server-app --- [INFO] Packaging webapp [INFO] Assembling webapp [james-server-app] in [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Processing war project [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/config/war] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] As /james-parent/modules/james/app/src/main/config/war does not exists, we get a compilation error that make our build fail. So yes, we need it to be applied... was (Author: btellier): If I do not have this patch, our build is failing, using OpenJDK 8 and maven 3. It fails in : [INFO] Apache James :: Server :: Data :: JCR Persistence .. SUCCESS [ 4.394 s] And the exact error is : [INFO] [INFO] --- maven-war-plugin:2.3:war (make-war) @ james-server-app --- [INFO] Packaging webapp [INFO] Assembling webapp [james-server-app] in [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Processing war project [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/resources] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] [INFO] Copying webapp webResources [/james-parent/modules/james/app/src/main/config/war] to [/james-parent/modules/james/app/target/james-server-app-3.0.0-beta5-SNAPSHOT] As /james-parent/modules/james/app/src/main/config/war does not exists, we get a compilation error that make our build fail. Problems compiling James Key: JAMES-1578 URL: https://issues.apache.org/jira/browse/JAMES-1578 Project: James Server Issue Type: Bug Reporter: Tellier Benoit Attachments: 0001-JWC-111-Add-missing-directory.patch On modern JDK, James compilation fails if a directoy is not present in /app -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
