Re: squid3_logdaemon work (round 1) complete, again!
On Mon, May 21, 2007, Alex Rousskov wrote: You have not mentioned any bugs that this change fixes. From the discussion on this list, it looks like the change is far from trivial and is more complex than you originally thought. UDP logging, the primary factor for doing this changes (as far as I can guess), is not a part of the proposed commit. Thats because it doesn't. Well, it doesn't besides fixing buffered_logs to work with access.log and other logs as well as the debug.log. Why do we need this feature in Squid 3.0? Can this wait until 3.0 is branched out? The primary factor for doing this change is to implement an external logging helper process to get around blocking IO in a portable fashion (a la s26_logfile_daemon work on Sourceforge) but I didn't want to implement that until this was committed and 3.0 was branched. It can wait until 3.0 is branched. Adrian
Re: squid3_logdaemon work (round 1) complete, again!
Hi Adrian, At 04.11 19/05/2007, Adrian Chadd wrote: On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the current codebase does. Improvements can come later. I've been running it for half a day under a ~ 250 req/sec load. It seems to be doing fine. I'd like to commit this to squid-3 in the next couple of days. Please let me know if there are any objections. Just run a build test on Windows, and is seems to build fine. Please verify if my change for the build error when using --enable-icmp is fine. Regards Guido - Guido Serassio Acme Consulting S.r.l. - Microsoft Certified Partner Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY Tel. : +39.011.9530135 Fax. : +39.011.9781115 Email: [EMAIL PROTECTED] WWW: http://www.acmeconsulting.it/
Re: squid3_logdaemon work (round 1) complete, again!
On Sat, May 19, 2007, Guido Serassio wrote: Just run a build test on Windows, and is seems to build fine. Please verify if my change for the build error when using --enable-icmp is fine. Thanks for that! It looks fine. Adrian
Re: squid3_logdaemon work (round 1) complete, again!
On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the current codebase does. Improvements can come later. I've been running it for half a day under a ~ 250 req/sec load. It seems to be doing fine. I'd like to commit this to squid-3 in the next couple of days. Please let me know if there are any objections. Adrian
Re: squid3_logdaemon work (round 1) complete, again!
Adrian Chadd wrote: On Fri, May 18, 2007, Adrian Chadd wrote: I've mostly copied over the older buffering thats in squid-2.6 and squid-3 logfile.c(c). Please review and provide feedback. I'm not going to try and improve the logfile writing in LogFileBlocking; I just want it to mimic what the current codebase does. Improvements can come later. I've been running it for half a day under a ~ 250 req/sec load. It seems to be doing fine. I'd like to commit this to squid-3 in the next couple of days. Please let me know if there are any objections. Adrian Now that you can I think you should take the opportunity to make it string-safe. Amos
Re: squid3_logdaemon work (round 1) complete
tor 2007-05-17 klockan 08:19 +0800 skrev Adrian Chadd: Hm, which modern platforms are going to have trouble with stdio using FD 256 -and- C++ ? Solaris stdio is one. stdio is C not C++. No difference only because you compile C++ using stdio.. still C linked to a C++ program. C++ ostream reportedly do not have the same problem on Solaris. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: squid3_logdaemon work (round 1) complete
ons 2007-05-16 klockan 21:59 +0800 skrev Adrian Chadd: I've completed the first round logfile code shifting. * use stdio for logfile writing; isn't going to be worse than how it was done before (still sync) C stdio, or C++ OStream? stdio fails quite badly on some OS:es if using more than 256 filedescriptors.. Regards Henrik signature.asc Description: Detta är en digitalt signerad meddelandedel
Re: squid3_logdaemon work (round 1) complete
Hi Adrian, At 15.59 16/05/2007, Adrian Chadd wrote: I've completed the first round logfile code shifting. * use stdio for logfile writing; isn't going to be worse than how it was done before (still sync) * write LogFile class with basic interfaces * convert code to use LogFile methods * break out syslog and blocking into LogFileSyslog and LogFileBlocking * tested syslog and blocking code, they both seem to work fine. I'd like to commit this to squid-3 soon. I'll then work on the logfile helper and Wikipedia UDP banger stuff but I won't aim to include that in squid-3 until after squid-3.0.STABLE1 as its new functionality. Any objections? Currently I'm too busy, so I don't have still looked into the code. But it will work on Windows ? Regards Guido - Guido Serassio Acme Consulting S.r.l. - Microsoft Certified Partner Via Lucia Savarino, 1 10098 - Rivoli (TO) - ITALY Tel. : +39.011.9530135 Fax. : +39.011.9781115 Email: [EMAIL PROTECTED] WWW: http://www.acmeconsulting.it/
