Re: [twdev] Re: First call for planned release of v5.1.20

2019-06-18 Thread bimlas
I'm very sorry, but it was a false alarm, 
see https://github.com/Jermolene/TiddlyWiki5/issues/3998#issuecomment-503312664

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/d977557c-566a-40ab-b7e1-b47010e26133%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [twdev] Re: First call for planned release of v5.1.20

2019-06-18 Thread Jeremy Ruston
Hi Bimlas

Thanks, that’s very helpful. This may get quite involved so I’ve created a 
GitHub ticket for further discussion:

https://github.com/Jermolene/TiddlyWiki5/issues/3998 


Best wishes

Jeremy

> On 18 Jun 2019, at 11:29, bimlas  wrote:
> 
> The results of the first two case are above, so I just doing the test again 
> on prerelease with disabled indexing:
> 
> Chrome:
> Prerelease
> mainRefresh: 1206.61ms
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
> avgTime 300.819991727; totalTime 902.45997518; percentTime 
> 82.29843968466753
> Firefox
> Prerelease
> mainRefresh: 1141.00ms
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
> avgTime 275; totalTime 825; percentTime 47.79837775202781
> The results of Firefox are almost the same, but percentTime differs a much! 
> Tried to run the filter again multiple times (indexing still disabled):
> 
> Chrome:
> Prerelease
> mainRefresh: 1285.50ms 
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 15; 
> avgTime 523.386669201; totalTime 7850.80003801; percentTime 
> 88.23785602723082
> Firefox
> Prerelease
> mainRefresh: 1078.00ms
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 15; 
> avgTime 376.94; totalTime 5654; percentTime 81.83528730641193
> 
> 
> 2019. június 18., kedd 10:59:26 UTC+2 időpontban Jeremy Ruston a következőt 
> írta:
> Hi Bimlas
> 
> Thanks for the report, that’s very helpful.
> 
> There’s quite a lot that’s changed between v5.1.19 and the current 
> prerelease, not just the indexing. One quick thing to try might be to make 
> some more timings while manually enabling and disabling the indexing 
> mechanism in the prerelease.
> 
> The easiest way to disable the indexing is to overwrite the following two 
> tiddlers with new tiddlers that don’t have a module-type field:
> 
> $:/core/modules/indexers/field-indexer.js
> $:/core/modules/indexers/tag-indexer.js
> 
> Then we’d be able to compare three timings:
> 
> * v5.1.19
> * v5.1.20-prerelease (including indexing)
> * v5.1.20-prerelease (without indexing)
> 
> Many thanks,
> 
> Jeremy.
> 
>> On 18 Jun 2019, at 07:30, bimlas gmail.com > 
>> wrote:
>> 
>> Maybe it's just the plugin's fault, but it seems that for some reason the 
>> Kin filter is slower on prerelease (heavily using cache mechanism). I don't 
>> know if it's a new indexing system or a performance log issue.
>> 
>> The code of the filter: 
>> https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js
>>  
>> 
>> 
>> Steps of testing:
>> Download current and prerelease
>> Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/ 
>> 
>> Enable performance instrumentation
>> Save and reload wikis
>> Close all opened tiddlers and open "Open" sidebar
>> Open Developer Tools Console
>> Use "[kin::to[TableOfContents]]" filter in Advanced Search
>> Results for me on Windows:
>> Chrome 75.0.3770.90
>> Current:
>> mainRefresh: 861.93ms 
>> +filter: 691.76ms
>> Prerelease
>> mainRefresh: 1317.06ms 
>> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
>> avgTime 331.3600013155; totalTime 994.080003946; percentTime 
>> 78.02397042426841
>> Firefox 67.0.2
>> Current
>> mainRefresh: 890.00ms
>> +filter: 657.00ms 
>> Prerelease
>> mainRefresh: 1108.00ms 
>> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
>> avgTime 270; totalTime 810; percentTime 71.87222715173026
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "TiddlyWikiDev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to tiddly...@ <>googlegroups.com .
>> To post to this group, send email to tiddly...@ <>googlegroups.com 
>> .
>> Visit this group at https://groups.google.com/group/tiddlywikidev 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com
>>  
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email 

Re: [twdev] Warning: Potential Security Risk Ahead - accessing upgrade page

2019-06-18 Thread Jeremy Ruston
Just adding that this turns out to be a common problem when hosting HTTPS sites 
on GitHub Pages:

https://github.community/t5/GitHub-Pages/Does-GitHub-Pages-Support-HTTPS-for-www-and-subdomains/td-p/7116
 


Best wishes

Jeremy

> On 20 May 2019, at 04:32, TonyM  wrote:
> 
> Jeremy,
> 
> Thanks. I would not normally add www to such a link myself, so perhaps it is 
> coded somewhere and should be changed.
> 
> Just FYI
> 
> Regards
> Tony
> 
> On Sunday, May 19, 2019 at 8:28:55 PM UTC+10, Jeremy Ruston wrote:
> Hi Tony
> 
> The problem appears when you use www.tiddlywiki.com 
>  instead of plain tiddlywiki.com 
> ; if you try https://tiddlywiki.com/upgrade.html 
>  then things work OK.
> 
> I think this is something to do with GitHub Pages hosting; it is supposed to 
> redirect www. to the plain URL, but it seems to only do that properly when 
> accessing the top level URI
> 
> Best wishes
> 
> Jeremy.
> 
>> On 19 May 2019, at 08:48, TonyM > wrote:
>> 
>> I detected this in the latest General release of FireFox accessing 
>> https://www.tiddlywiki.com/upgrade.html 
>> 
>> 
>> Firefox detected a potential security threat and did not continue to 
>> www.tiddlywiki.com . If you visit this site, 
>> attackers could try to steal information like your passwords, emails, or 
>> credit card details.
>> 
>> Websites prove their identity via certificates. Firefox does not trust this 
>> site because it uses a certificate that is not valid for www.tiddlywiki.com 
>> . The certificate is only valid for the 
>> following names: www.github.com , *.github.io 
>> , *.githubusercontent.com 
>> , *.github.com , 
>> github.com , github.io , 
>> githubusercontent.com  Error code: 
>> SSL_ERROR_BAD_CERT_DOMAIN
>> 
>> Snapshot of certificate attached
>> 
>> Regards
>> Tony
>> 
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "TiddlyWikiDev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to tiddly...@googlegroups.com <>.
>> To post to this group, send email to tiddly...@googlegroups.com <>.
>> Visit this group at https://groups.google.com/group/tiddlywikidev 
>> .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/tiddlywikidev/5156cf8a-fa52-4e55-8d0e-e1082174f28e%40googlegroups.com
>>  
>> .
>> For more options, visit https://groups.google.com/d/optout 
>> .
>> 
> 
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/86bb6d2e-187a-4bf6-b227-a9618c8f6253%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/547FDD1C-61C0-424C-B858-53B152A32A36%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [twdev] Re: First call for planned release of v5.1.20

2019-06-18 Thread bimlas
The results of the first two case are above, so I just doing the test again 
on prerelease with disabled indexing:


   - Chrome:
  - Prerelease
 - mainRefresh: 1206.61ms
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 3; avgTime 300.819991727; totalTime 902.45997518; 
 percentTime 82.29843968466753
 - Firefox
  - Prerelease
 - mainRefresh: 1141.00ms
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 3; avgTime 275; totalTime 825; percentTime 
 47.79837775202781
 
The results of Firefox are almost the same, but percentTime differs a much! 
Tried to run the filter again multiple times (indexing still disabled):


   - Chrome:
  - Prerelease
 - mainRefresh: 1285.50ms 
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 15; avgTime 523.386669201; totalTime 
7850.80003801; 
 percentTime 88.23785602723082
 - Firefox
  - Prerelease
 - mainRefresh: 1078.00ms
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 15; avgTime 376.94; totalTime 5654; 
 percentTime 81.83528730641193
  


2019. június 18., kedd 10:59:26 UTC+2 időpontban Jeremy Ruston a következőt 
írta:
>
> Hi Bimlas
>
> Thanks for the report, that’s very helpful.
>
> There’s quite a lot that’s changed between v5.1.19 and the current 
> prerelease, not just the indexing. One quick thing to try might be to make 
> some more timings while manually enabling and disabling the indexing 
> mechanism in the prerelease.
>
> The easiest way to disable the indexing is to overwrite the following two 
> tiddlers with new tiddlers that don’t have a module-type field:
>
> $:/core/modules/indexers/field-indexer.js
> $:/core/modules/indexers/tag-indexer.js
>
> Then we’d be able to compare three timings:
>
> * v5.1.19
> * v5.1.20-prerelease (including indexing)
> * v5.1.20-prerelease (without indexing)
>
> Many thanks,
>
> Jeremy.
>
> On 18 Jun 2019, at 07:30, bimlas > wrote:
>
> Maybe it's just the plugin's fault, but it seems that for some reason the 
> Kin filter is slower on prerelease (heavily using cache mechanism). I don't 
> know if it's a new indexing system or a performance log issue.
>
> The code of the filter: 
> https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js
>
> Steps of testing:
>
>- Download current and prerelease
>- Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/
>- Enable performance instrumentation
>- Save and reload wikis
>- Close all opened tiddlers and open "Open" sidebar
>- Open Developer Tools Console
>- Use "[kin::to[TableOfContents]]" filter in Advanced Search
>
> Results for me on Windows:
>
>- Chrome 75.0.3770.90
>   - Current:
>  - mainRefresh: 861.93ms 
>  - +filter: 691.76ms
>   - Prerelease
>  - mainRefresh: 1317.06ms 
>  - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
>  invocations 3; avgTime 331.3600013155; totalTime 
> 994.080003946; 
>  percentTime 78.02397042426841
>  - Firefox 67.0.2
>   - Current
>  - 
>  - mainRefresh: 890.00ms
>  - +filter: 657.00ms 
>   - Prerelease
>  - mainRefresh: 1108.00ms 
>  - 
>  - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
>  invocations 3; avgTime 270; totalTime 810; percentTime 
> 71.87222715173026
>   
>
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddly...@googlegroups.com .
> To post to this group, send email to tiddly...@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com
>  
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/9f1ddb56-9ca6-4133-9e64-c8625036ae32%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [twdev] Re: First call for planned release of v5.1.20

2019-06-18 Thread Jeremy Ruston
Hi Bimlas

Thanks for the report, that’s very helpful.

There’s quite a lot that’s changed between v5.1.19 and the current prerelease, 
not just the indexing. One quick thing to try might be to make some more 
timings while manually enabling and disabling the indexing mechanism in the 
prerelease.

The easiest way to disable the indexing is to overwrite the following two 
tiddlers with new tiddlers that don’t have a module-type field:

$:/core/modules/indexers/field-indexer.js
$:/core/modules/indexers/tag-indexer.js

Then we’d be able to compare three timings:

* v5.1.19
* v5.1.20-prerelease (including indexing)
* v5.1.20-prerelease (without indexing)

Many thanks,

Jeremy.

> On 18 Jun 2019, at 07:30, bimlas  wrote:
> 
> Maybe it's just the plugin's fault, but it seems that for some reason the Kin 
> filter is slower on prerelease (heavily using cache mechanism). I don't know 
> if it's a new indexing system or a performance log issue.
> 
> The code of the filter: 
> https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js
> 
> Steps of testing:
> Download current and prerelease
> Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/
> Enable performance instrumentation
> Save and reload wikis
> Close all opened tiddlers and open "Open" sidebar
> Open Developer Tools Console
> Use "[kin::to[TableOfContents]]" filter in Advanced Search
> Results for me on Windows:
> Chrome 75.0.3770.90
> Current:
> mainRefresh: 861.93ms 
> +filter: 691.76ms
> Prerelease
> mainRefresh: 1317.06ms 
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
> avgTime 331.3600013155; totalTime 994.080003946; percentTime 
> 78.02397042426841
> Firefox 67.0.2
> Current
> mainRefresh: 890.00ms
> +filter: 657.00ms 
> Prerelease
> mainRefresh: 1108.00ms 
> (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; invocations 3; 
> avgTime 270; totalTime 810; percentTime 71.87222715173026
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to tiddlywikidev+unsubscr...@googlegroups.com 
> .
> To post to this group, send email to tiddlywikidev@googlegroups.com 
> .
> Visit this group at https://groups.google.com/group/tiddlywikidev 
> .
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com
>  
> .
> For more options, visit https://groups.google.com/d/optout 
> .

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/549AE8F6-2B77-4A3E-8914-E3323EB34641%40gmail.com.
For more options, visit https://groups.google.com/d/optout.


[twdev] Re: First call for planned release of v5.1.20

2019-06-18 Thread bimlas
Maybe it's just the plugin's fault, but it seems that for some reason the 
Kin filter is slower on prerelease (heavily using cache mechanism). I don't 
know if it's a new indexing system or a performance log issue.

The code of the 
filter: 
https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js

Steps of testing:

   - Download current and prerelease
   - Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/
   - Enable performance instrumentation
   - Save and reload wikis
   - Close all opened tiddlers and open "Open" sidebar
   - Open Developer Tools Console
   - Use "[kin::to[TableOfContents]]" filter in Advanced Search

Results for me on Windows:

   - Chrome 75.0.3770.90
  - Current:
 - mainRefresh: 861.93ms 
 - +filter: 691.76ms
  - Prerelease
 - mainRefresh: 1317.06ms 
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 3; avgTime 331.3600013155; totalTime 
994.080003946; 
 percentTime 78.02397042426841
 - Firefox 67.0.2
  - Current
 - 
 - mainRefresh: 890.00ms
 - +filter: 657.00ms 
  - Prerelease
 - mainRefresh: 1108.00ms 
 - 
 - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]"; 
 invocations 3; avgTime 270; totalTime 810; percentTime 
71.87222715173026
  

-- 
You received this message because you are subscribed to the Google Groups 
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to tiddlywikidev+unsubscr...@googlegroups.com.
To post to this group, send email to tiddlywikidev@googlegroups.com.
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.