The results of the first two case are above, so I just doing the test again
on prerelease with disabled indexing:
- Chrome:
- Prerelease
- mainRefresh: 1206.61ms
- (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
invocations 3; avgTime 300.8199999991727; totalTime 902.459999997518;
percentTime 82.29843968466753
- Firefox
- Prerelease
- mainRefresh: 1141.00ms
- (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
invocations 3; avgTime 275; totalTime 825; percentTime
47.79837775202781
The results of Firefox are almost the same, but percentTime differs a much!
Tried to run the filter again multiple times (indexing still disabled):
- Chrome:
- Prerelease
- mainRefresh: 1285.50ms
- (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
invocations 15; avgTime 523.3866666669201; totalTime
7850.800000003801;
percentTime 88.23785602723082
- Firefox
- Prerelease
- mainRefresh: 1078.00ms
- (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
invocations 15; avgTime 376.93333333333334; totalTime 5654;
percentTime 81.83528730641193
2019. június 18., kedd 10:59:26 UTC+2 időpontban Jeremy Ruston a következőt
írta:
>
> Hi Bimlas
>
> Thanks for the report, that’s very helpful.
>
> There’s quite a lot that’s changed between v5.1.19 and the current
> prerelease, not just the indexing. One quick thing to try might be to make
> some more timings while manually enabling and disabling the indexing
> mechanism in the prerelease.
>
> The easiest way to disable the indexing is to overwrite the following two
> tiddlers with new tiddlers that don’t have a module-type field:
>
> $:/core/modules/indexers/field-indexer.js
> $:/core/modules/indexers/tag-indexer.js
>
> Then we’d be able to compare three timings:
>
> * v5.1.19
> * v5.1.20-prerelease (including indexing)
> * v5.1.20-prerelease (without indexing)
>
> Many thanks,
>
> Jeremy.
>
> On 18 Jun 2019, at 07:30, bimlas <[email protected] <javascript:>> wrote:
>
> Maybe it's just the plugin's fault, but it seems that for some reason the
> Kin filter is slower on prerelease (heavily using cache mechanism). I don't
> know if it's a new indexing system or a performance log issue.
>
> The code of the filter:
> https://github.com/bimlas/tw5-kin-filter/blob/66e2cbbf85761daa4c33e9c422db0fce3b6ea6f9/plugins/kin-filter/kin.js
>
> Steps of testing:
>
> - Download current and prerelease
> - Install Kin filter from https://bimlas.gitlab.io/tw5-kin-filter/
> - Enable performance instrumentation
> - Save and reload wikis
> - Close all opened tiddlers and open "Open" sidebar
> - Open Developer Tools Console
> - Use "[kin::to[TableOfContents]]" filter in Advanced Search
>
> Results for me on Windows:
>
> - Chrome 75.0.3770.90
> - Current:
> - mainRefresh: 861.93ms
> - +filter: 691.76ms
> - Prerelease
> - mainRefresh: 1317.06ms
> - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
> invocations 3; avgTime 331.36000000013155; totalTime
> 994.0800000003946;
> percentTime 78.02397042426841
> - Firefox 67.0.2
> - Current
> -
> - mainRefresh: 890.00ms
> - +filter: 657.00ms
> - Prerelease
> - mainRefresh: 1108.00ms
> -
> - (from $tw.perf.log()) filter "[kin::to[TableOfContents]]";
> invocations 3; avgTime 270; totalTime 810; percentTime
> 71.87222715173026
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "TiddlyWikiDev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected] <javascript:>.
> To post to this group, send email to [email protected]
> <javascript:>.
> Visit this group at https://groups.google.com/group/tiddlywikidev.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com
>
> <https://groups.google.com/d/msgid/tiddlywikidev/f549acfa-fc56-4826-9d7a-bac9bd63aa93%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
> For more options, visit https://groups.google.com/d/optout.
>
>
>
--
You received this message because you are subscribed to the Google Groups
"TiddlyWikiDev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/tiddlywikidev.
To view this discussion on the web visit
https://groups.google.com/d/msgid/tiddlywikidev/9f1ddb56-9ca6-4133-9e64-c8625036ae32%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
