Please update your addressbook to Elarg-Taiex@cec.eu.int
Dear sender, Please replace [EMAIL PROTECTED] with [EMAIL PROTECTED] in your addressbook for your future correspondence. Kind regards, European Commission Directorate-General Enlargement Technical Assistance Information Exchange Unit CHAR 5/74 BE - 1049 Bruxelles/Brussels Tel: +32-2-299 11 11 Fax: +32-2-296 68 40
Re: FW: JK 1.2.7 Problem?
William A. Rowe, Jr. wrote: At 05:51 AM 12/14/2004, Allistair Crossley wrote: Copying in DEV on this JK issue/solution on Mladen's request. The release build worked fine. Seems that the problem is caused by the fact that beta3 binaries are compiled as 'debug' so tolower function is issuing an assertion. I'll make a release build and sent it to your email directly. Can you check the results with release build? Mladen. FYI - you are familiar with the fact that you do not need to build 'debug' in order to obtain useful info? Yep, like said in some other thread... It was build like that by mistake :). Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32746] New: - InputStream not closed in o.a.j.c.JDTCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32746. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32746 Summary: InputStream not closed in o.a.j.c.JDTCompiler Product: Tomcat 5 Version: 5.5.6 Platform: PC OS/Version: All Status: NEW Severity: major Priority: P2 Component: Jasper AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] I keep investigating the cause of the jar locking and I found that the InputStream in an anonymous inner class INameEnvironment in method findType(String) is not closed. Is this intended to be so or a developer's overlook? -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: JK throws java.lang.NumberFormatException when JSP is not found. (tomcat debug logging)
Hi, No problem. Here is the debug logging from Tomcat. DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - read() [EMAIL PROTECTED] 8192 0 4 = 4 DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - Received 723 18 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - read() [EMAIL PROTECTED] 8192 4 723 = 723 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - Call next 0 [EMAIL PROTECTED] DEBUG TP-Processor3 org.apache.jk.common.HandlerRequest - Handling 2 DEBUG TP-Processor3 org.apache.jk.common.HandlerRequest - R( /nosuchjsp.jsp) DEBUG TP-Processor3 org.apache.jk.common.HandlerRequest - Calling next container org.apache.jk.server.JkCoyoteHandler DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - Invoke R( /nosuchjsp.jsp) [EMAIL PROTECTED] /nosuchjsp.jsp DEBUG TP-Processor3 org.apache.catalina.connector.CoyoteAdapter - Requested cookie session id is 6BDBFA4CF3E0A578CCAEC8CBD66F74DA DEBUG TP-Processor3 org.apache.catalina.connector.CoyoteAdapter - Requested cookie session id is 6BDBFA4CF3E0A578CCAEC8CBD66F74DA DEBUG TP-Processor3 org.apache.catalina.core.StandardWrapper - Returning non-STM instance DEBUG TP-Processor3 org.apache.catalina.core.StandardWrapper - Returning non-STM instance DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - ACK DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - JspEngine -- /nosuchjsp.jsp DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - ServletPath: /nosuchjsp.jsp DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - PathInfo: null DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - RealPath: d:\jakarta-tomcat\webapps\ROOT\nosuchjsp.jsp DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - RequestURI: /nosuchjsp.jsp DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - QueryString: null DEBUG TP-Processor3 org.apache.jasper.servlet.JspServlet - Request Params: DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - COMMIT DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - COMMIT sending headers [EMAIL PROTECTED] === MimeHeaders === DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - send() 90 4 DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - doWrite 0 992 0 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - send() 1000 3 DEBUG TP-Processor3 org.apache.jk.server.JkCoyoteHandler - CLOSE DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - send() 6 5 DEBUG TP-Processor3 org.apache.jk.REQ_TIME - Time pre=0/ service=0 992 /nosuchjsp.jsp DEBUG TP-Processor3 org.apache.jk.common.HandlerRequest - Invoke returned 0 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - receive() DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - read() [EMAIL PROTECTED] 8192 0 4 = 4 DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - Received 328 18 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - read() [EMAIL PROTECTED] 8192 4 328 = 328 DEBUG TP-Processor3 org.apache.jk.common.ChannelSocket - Call next 0 [EMAIL PROTECTED] DEBUG TP-Processor3 org.apache.jk.common.HandlerRequest - Handling 2 ERROR TP-Processor3 org.apache.jk.common.HandlerRequest - Error decoding request java.lang.NumberFormatException at org.apache.tomcat.util.buf.Ascii.parseInt(Ascii.java:145) at org.apache.tomcat.util.buf.ByteChunk.getInt(ByteChunk.java:491) at org.apache.tomcat.util.buf.MessageBytes.getInt(MessageBytes.java:645) at org.apache.jk.common.HandlerRequest.decodeHeaders(HandlerRequest.java:682) at org.apache.jk.common.HandlerRequest.decodeRequest(HandlerRequest.java:504) at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:361) at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:745) at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:675) at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:868) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595) DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - Incomming message: [EMAIL PROTECTED] 98/332 DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 12 34 01 48 02 02 00 08 48 54 54 50 2f 31 2e 31 | .4.HHTTP/1.1 DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 00 00 0e 2f 6e 6f 73 75 63 68 6a 73 70 2e 6a 73 | .../nosuchjsp.js DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 70 00 00 0f 31 35 30 2e 31 35 30 2e 31 35 33 2e | p...150.150.153. DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 31 32 32 00 00 0f 31 35 30 2e 31 35 30 2e 31 35 | 122...150.150.15 DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 33 2e 31 32 32 00 00 0c 69 6e 74 72 61 74 65 73 | 3.122...intrates DEBUG TP-Processor3 org.apache.jk.common.MsgAjp - 74 67 62 72 00 00 50 00 00 08 a0 01 00 03 2a 2f | tgbr..P...?...*/
Tagging JK_1_2_8_RC_1 today 18:00 GMT
Hi, Just to keep the rhythm of releases :). The 1.2.7 release has done it's share of work by testing all those new features added. The 1.2.8-rc-1 will add no new features. There are still one potential bug present, reported by Henri Gomez with Tomcat 3.3.2. The other issue is to see the URL rewriting problem reported by Derrick Koes. Since there is the possibility that they are related, I'll leave that for 1.2.8 final. Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
mturk 2004/12/17 01:01:18 Modified:jk/xdocs changelog.xml Log: Latest changes to the 1.2.7 Revision ChangesPath 1.6 +22 -1 jakarta-tomcat-connectors/jk/xdocs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/changelog.xml,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- changelog.xml 13 Dec 2004 14:32:56 - 1.5 +++ changelog.xml 17 Dec 2004 09:01:18 - 1.6 @@ -25,12 +25,33 @@ br / subsection name=Native changelog + update + Make load balancer algorithm thread safe by introducing mutex + to the load balancer worker. (mturk) + /update + fix + Fix sending error pages for IIS to client by adding Content-Type header + using correct api function all. (mturk) + /fix + fix + bug32696/bug: Prevent IIS from crushing when web-inf url was requested. (mturk) + /fix + update + Use default cachesize for servers that support discovering the number of + threads per child process. (mturk). + /update + fix + Fix Apache content-length header parsing using case insensitive compare. (billbarker) + /fix + fix + Fix parsing AJP headers using case insensitive compare. (mturk) + /fix fix Use infinite socket timeout if socket_timeout is set to zero or less then zero. (mturk) /fix update Change bbalanced_workers/b to bbalance_workers/b but keep - backward compatibility preserving old directive. (mturk). + backward compatibility preserving the old directive. (mturk). /update fix Fix ajp initialization for workers with cache_size set to zero. (mturk) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@brutus]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-native : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: Build) Work ended in a state of : Failed Elapsed: 12 secs Command Line: make [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native] - gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_util.c -fPIC -DPIC -o .libs/jk_util.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_util.c -o jk_util.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c -fPIC -DPIC -o .libs/jk_ajp13.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c -o jk_ajp13.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c -fPIC -DPIC -o .libs/jk_pool.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c -o jk_pool.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_worker.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mturk 2004/12/17 00:28:20
Modified:jk/native/apache-2.0 mod_jk.c
Log:
Query mpm to obtain the real default cache size.
Revision ChangesPath
1.111 +13 -5 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.110
retrieving revision 1.111
diff -u -r1.110 -r1.111
--- mod_jk.c 17 Dec 2004 03:14:56 - 1.110
+++ mod_jk.c 17 Dec 2004 08:28:20 - 1.111
@@ -38,6 +38,7 @@
#include http_main.h
#include http_log.h
#include util_script.h
+#include ap_mpm.h
#ifdef AS400
#include ap_charset.h
@@ -1851,9 +1852,9 @@
JK_TRACE_EXIT(xconf-log);
return r-status;
}
-jk_log(xconf-log, JK_LOG_INFO, Service returned error=%d
+jk_log(xconf-log, JK_LOG_DEBUG, Service finished
with status=%d for worker=%s\n,
- rc, r-status, worker_name);
+ r-status, worker_name);
JK_TRACE_EXIT(xconf-log);
return OK; /* NOT r-status, even if it has changed. */
}
@@ -2179,9 +2180,18 @@
static void jk_child_init(apr_pool_t * pconf, server_rec * s)
{
jk_server_conf_t *conf;
+int mpm_threads = 1;
+
conf = ap_get_module_config(s-module_config, jk_module);
+
JK_TRACE_ENTER(conf-log);
+/* Set default connection cache size for worker mpm */
+#if APR_HAS_THREADS
+ap_mpm_query(AP_MPMQ_MAX_THREADS, mpm_threads);
+#endif
+if (mpm_threads 0)
+jk_set_worker_def_cache_size(mpm_threads);
jk_log(conf-log, JK_LOG_DEBUG, Initialized %s\n, JK_EXPOSED_VERSION);
JK_TRACE_EXIT(conf-log);
}
@@ -2224,9 +2234,7 @@
worker_env.server_name = (char *)ap_get_server_version();
if (wc_open(init_map, worker_env, conf-log)) {
ap_add_version_component(pconf, JK_EXPOSED_VERSION);
-return;
}
-return;
}
static int jk_post_config(apr_pool_t * pconf,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_ajp_common.c
mturk 2004/12/17 00:37:16
Modified:jk/native/common jk_ajp_common.c
Log:
Fix cache by removing reuse flag on reset endpoint.
Reset endpoint only when it will be stored in the cache. In case the
endpoit can not be stored in the cache it will be closed anyhow.
Revision ChangesPath
1.71 +41 -44
jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c
Index: jk_ajp_common.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_ajp_common.c,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -r1.70 -r1.71
--- jk_ajp_common.c 16 Dec 2004 09:56:31 - 1.70
+++ jk_ajp_common.c 17 Dec 2004 08:37:16 - 1.71
@@ -680,7 +680,6 @@
static void ajp_reset_endpoint(ajp_endpoint_t * ae)
{
-ae-reuse = JK_FALSE;
jk_reset_pool((ae-pool));
}
@@ -692,15 +691,13 @@
{
JK_TRACE_ENTER(l);
-jk_close_pool((ae-pool));
-
if (ae-sd 0) {
jk_close_socket(ae-sd);
jk_log(l, JK_LOG_DEBUG,
closed sd = %d\n, ae-sd);
-ae-sd = -1;/* just to avoid twice close */
}
+jk_close_pool((ae-pool));
free(ae);
JK_TRACE_EXIT(l);
}
@@ -714,6 +711,10 @@
{
ajp_worker_t *aw = ae-worker;
+/* Close existing endpoint socket */
+jk_close_socket(ae-sd);
+ae-sd = -1;
+
if (aw-ep_cache_sz) {
int rc;
JK_ENTER_CS(aw-cs, rc);
@@ -721,7 +722,8 @@
unsigned i;
for (i = 0; i aw-ep_cache_sz; i++) {
-if (aw-ep_cache[i]) {
+/* Find cache slot with usable socket */
+if (aw-ep_cache[i] aw-ep_cache[i]-sd 0) {
ae-sd = aw-ep_cache[i]-sd;
aw-ep_cache[i]-sd = -1;
ajp_close_endpoint(aw-ep_cache[i], l);
@@ -867,6 +869,7 @@
int ajp_connection_tcp_send_message(ajp_endpoint_t * ae,
jk_msg_buf_t *msg, jk_logger_t *l)
{
+int rc;
JK_TRACE_ENTER(l);
if (ae-proto == AJP13_PROTO) {
@@ -884,15 +887,16 @@
return JK_FALSE;
}
-if (0
-jk_tcp_socket_sendfull(ae-sd, jk_b_get_buff(msg),
- jk_b_get_len(msg))) {
+if ((rc = jk_tcp_socket_sendfull(ae-sd, jk_b_get_buff(msg),
+ jk_b_get_len(msg))) 0) {
JK_TRACE_EXIT(l);
-return JK_FALSE;
+return JK_TRUE;
}
+jk_log(l, JK_LOG_ERROR,
+ sendfull returned %d with errno=%d \n, rc, errno);
JK_TRACE_EXIT(l);
-return JK_TRUE;
+return JK_FALSE;
}
/*
@@ -1140,13 +1144,10 @@
/* If we got an error or can't send data, then try to get a pooled
* connection and try again. If we are succesful, break out of this
* loop. */
-if (err
-|| ajp_connection_tcp_send_message(ae, op-request,
- l) == JK_FALSE) {
-jk_log(l, JK_LOG_INFO,
+if (err ||
+(ajp_connection_tcp_send_message(ae, op-request, l) ==
JK_FALSE)) {
+jk_log(l, JK_LOG_ERROR,
Error sending request try another pooled connection\n);
-jk_close_socket(ae-sd);
-ae-sd = -1;
ajp_reuse_connection(ae, l);
}
else
@@ -1165,7 +1166,7 @@
* After we are connected, each error that we are going to
* have is probably unrecoverable
*/
-if (!ajp_connection_tcp_send_message(ae, op-request, l)) {
+if (ajp_connection_tcp_send_message(ae, op-request, l) ==
JK_FALSE) {
jk_log(l, JK_LOG_INFO,
Error sending request on a fresh connection\n);
JK_TRACE_EXIT(l);
@@ -1200,7 +1201,7 @@
postlen = jk_b_get_len(op-post);
if (postlen AJP_HEADER_LEN) {
-if (!ajp_connection_tcp_send_message(ae, op-post, l)) {
+if (ajp_connection_tcp_send_message(ae, op-post, l) == JK_FALSE) {
jk_log(l, JK_LOG_ERROR, Error resending request body (%d)\n,
postlen);
JK_TRACE_EXIT(l);
@@ -1215,7 +1216,7 @@
postlen = jk_b_get_len(s-reco_buf);
if (postlen AJP_HEADER_LEN) {
-if (!ajp_connection_tcp_send_message(ae, s-reco_buf, l)) {
+if (ajp_connection_tcp_send_message(ae, s-reco_buf, l) ==
JK_FALSE) {
jk_log(l, JK_LOG_ERROR,
Error resending request body (lb mode) (%d)\n,
postlen);
@@ -1260,7 +1261,7 @@
}
s-content_read = len;
-
JDTCompiler and locked jar files *again*
I think I finally found it. And fixed it.
JDTCompiler uses JasperLoader.getResourceAsStream() which is *not*
overriden in JasperLoader and uses getResourceAsStream() derived from
java.net.URLClassLoader (in fact from java.lang.ClassLoader).
j.l.ClassLoader's getResourceAsStream() implementation does not
setUseCaches(false), therefore causes locking. I suggest overriding
getResourceAsStream in JasperLoader by adding the following (or similar)
method:
public InputStream getResourceAsStream(String name) {
URL url = getResource(name);
if (url != null) {
try {
URLConnection urlc = url.openConnection();
urlc.setUseCaches(false);
return urlc.getInputStream();
} catch (IOException e) {
return null;
}
}
return null;
}
This actually *WORKS* for me.
cheers
/dd
PS. I hope that I don't get cursed again.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JK 1.2.7 beta 3 + URL rewriting scheme issue
Derrick Koes wrote: I *think*, from quick source code scanning, that JK does not call SetHeader with the correct/complete URL, whereas JK2 does. Could yo check the CVS HEAD now? I have just commited a probable fix for that. The problem was that the url rewrite has removed the sessionid to find a worker, but never restored the url, and it should. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Dominik Drzewiecki wrote:
I think I finally found it. And fixed it.
JDTCompiler uses JasperLoader.getResourceAsStream() which is *not*
overriden in JasperLoader and uses getResourceAsStream() derived from
java.net.URLClassLoader (in fact from java.lang.ClassLoader).
j.l.ClassLoader's getResourceAsStream() implementation does not
setUseCaches(false), therefore causes locking. I suggest overriding
getResourceAsStream in JasperLoader by adding the following (or similar)
method:
public InputStream getResourceAsStream(String name) {
URL url = getResource(name);
if (url != null) {
try {
URLConnection urlc = url.openConnection();
urlc.setUseCaches(false);
return urlc.getInputStream();
} catch (IOException e) {
return null;
}
}
return null;
}
This actually *WORKS* for me.
It's a hack though. JasperLoader shouldn't have the JARs in its
repositories, so it is supposed to delegate.
PS. I hope that I don't get cursed again.
It's easy: don't be annoying, and avoid whining.
For example, what's up with that bug ?
http://issues.apache.org/bugzilla/show_bug.cgi?id=32746
Is it relevant or not ?
Rmy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/xdocs/install iis.xml
mturk 2004/12/17 01:19:33 Modified:jk/xdocs/install iis.xml Log: Update IIS build notes. Revision ChangesPath 1.2 +17 -4 jakarta-tomcat-connectors/jk/xdocs/install/iis.xml Index: iis.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/install/iis.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- iis.xml 18 Nov 2004 18:31:37 - 1.1 +++ iis.xml 17 Dec 2004 09:19:33 - 1.2 @@ -16,9 +16,22 @@ section name=Building ISAPI redirector p The redirector was developed using Visual C++ Ver.6.0, so having this environment is a prereq if you want -to perform a custom build. You should also have IIS developer SDK - -The steps that you need to take are: +to perform a custom build. You should also have Platform SDK from January 2003 or later or +at least IIS developer SDK. +/p +p +The easiest way to build the isapi redirector is to use Microsoft Visual Studio +and open the bjk/native/iis/isapi.dsp/b file. +/p +pIt is recommended that you use bVisual Studio 2003/b +or later for building isapi redirector, to be able to use the TRACE logging +features. +/p +pIf using Visual Studio 6.0 then it is recommended that you download +Visual Studio Service Pack 5 or any later version. +/p +p +The steps that you need to take are if wish to build from command line: ul li Change directory to the isapi plugins source directory. @@ -29,7 +42,7 @@ /ul screen noteChange directory to the isapi plugins source directory/note -typedoscd c:\home\apache\jk\isapi/typedos +typedoscd c:\jakarta-tomcat-connectors\jk\native\iis/typedos noteBuild the sources using MSDEV/note typedosMSDEV isapi.dsp /MAKE ALL/typedos /screen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: PersistentManagerBase (etc) Patches
Jess Holle wrote: [Yes, the Request change would still be necessary to prevent the chance of requests randomly getting their sessions passivated and recycle after they findSession() but before access().] A session can be passivated at any (bad) time (which will screw up requests), and we already do plenty of on access checks. I don't see what it adds. As I said, the patch ideas look fine, but I do have questions: - Why do you really need methods named preAccess and access on the manager ? The first one seems to be designed to do swap ins while the second one keeps usage stats, so maybe this could be more elegant. Or maybe not. - Keeping session skeletons around will eat resources. I understand this will improve performance, but is that really a good idea ? I'm asking for your experience after the change here (is memory usage much higher, etc). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
mturk 2004/12/17 03:24:38
Modified:jk/native/common jk_uri_worker_map.c
Log:
Fix url rewrite for jksessionid. It should fix all jksessionid bugs, cause
previous implemantation didn't handle that properly.
Revision ChangesPath
1.39 +19 -8
jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c
Index: jk_uri_worker_map.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_uri_worker_map.c,v
retrieving revision 1.38
retrieving revision 1.39
diff -u -r1.38 -r1.39
--- jk_uri_worker_map.c 13 Dec 2004 16:59:58 - 1.38
+++ jk_uri_worker_map.c 17 Dec 2004 11:24:38 - 1.39
@@ -659,7 +659,9 @@
unsigned int i;
int best_match = -1;
unsigned int longest_match = 0;
-char *url_rewrite;
+char *url_rewrite = NULL;
+char rewrite_char;
+char *rv = NULL;
JK_TRACE_ENTER(l);
if (!uw_map || !uri) {
@@ -675,6 +677,7 @@
}
url_rewrite = strstr(uri, JK_PATH_SESSION_IDENTIFIER);
if (url_rewrite) {
+rewrite_char = *url_rewrite;
*url_rewrite = '\0';
}
jk_no2slash(uri);
@@ -686,7 +689,7 @@
if (uw_map-no_size is_nomap_match(uw_map, uri, l)) {
/* Found a no match */
JK_TRACE_EXIT(l);
-return NULL;
+goto cleanup;;
}
for (i = 0; i uw_map-size; i++) {
uri_worker_record_t *uwr = uw_map-maps[i];
@@ -713,7 +716,8 @@
Found a wildchar match %s - %s\n,
uwr-worker_name, uwr-context);
JK_TRACE_EXIT(l);
-return wname;
+rv = wname;
+goto cleanup;
}
}
else if (JK_STRNCMP(uwr-context, uri, uwr-ctxt_len) == 0) {
@@ -723,7 +727,8 @@
Found an exact match %s - %s\n,
uwr-worker_name, uwr-context);
JK_TRACE_EXIT(l);
-return uwr-worker_name;
+rv = uwr-worker_name;
+goto cleanup;
}
}
else if (uwr-match_type == MATCH_TYPE_CONTEXT) {
@@ -792,7 +797,8 @@
if (best_match != -1) {
JK_TRACE_EXIT(l);
-return uw_map-maps[best_match]-worker_name;
+rv = uw_map-maps[best_match]-worker_name;
+goto cleanup;
}
else {
/*
@@ -810,9 +816,14 @@
Found a security fraud in '%s'\n,
uri);
JK_TRACE_EXIT(l);
-return uw_map-maps[fraud]-worker_name;
+rv = uw_map-maps[fraud]-worker_name;
+goto cleanup;
}
}
JK_TRACE_EXIT(l);
-return NULL;
+
+cleanup:
+if (url_rewrite)
+*url_rewrite = rewrite_char;
+return rv;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
mturk 2004/12/17 04:28:12 Modified:jk/xdocs changelog.xml Log: Log the fix about url rewriting. Revision ChangesPath 1.7 +4 -0 jakarta-tomcat-connectors/jk/xdocs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/changelog.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- changelog.xml 17 Dec 2004 09:01:18 - 1.6 +++ changelog.xml 17 Dec 2004 12:28:12 - 1.7 @@ -25,6 +25,10 @@ br / subsection name=Native changelog + fix + Fix url rewriting by restoring the inplace uri from which the + jsessionid was removed. (mturk) + /fix update Make load balancer algorithm thread safe by introducing mutex to the load balancer worker. (mturk) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler JDTCompiler.java
remm2004/12/17 04:39:56
Modified:jasper2/src/share/org/apache/jasper/compiler
JDTCompiler.java
Log:
- 32746: Close the input stream we get from getResourceAsStream.
Revision ChangesPath
1.8 +10 -2
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java
Index: JDTCompiler.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- JDTCompiler.java 5 Oct 2004 19:06:31 - 1.7
+++ JDTCompiler.java 17 Dec 2004 12:39:55 - 1.8
@@ -185,6 +185,7 @@
private NameEnvironmentAnswer findType(String className) {
+InputStream is = null;
try {
if (className.equals(targetClassName)) {
ICompilationUnit compilationUnit =
@@ -194,8 +195,7 @@
}
String resourceName =
className.replace('.', '/') + .class;
-InputStream is =
-classLoader.getResourceAsStream(resourceName);
+is = classLoader.getResourceAsStream(resourceName);
if (is != null) {
byte[] classBytes;
byte[] buf = new byte[8192];
@@ -218,6 +218,14 @@
log.error(Compilation error, exc);
} catch
(org.eclipse.jdt.internal.compiler.classfmt.ClassFormatException exc) {
log.error(Compilation error, exc);
+} finally {
+if (is != null) {
+try {
+is.close();
+} catch (IOException exc) {
+// Ignore
+}
+}
}
return null;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Remy Maucherat [EMAIL PROTECTED] wrote:
It's a hack though. JasperLoader shouldn't have the JARs in its
repositories, so it is supposed to delegate.
It *does* delegate to its parent classloader (which is WebappClassLoader)
The only difference is that my solution sets useCaches to false on obtained
URLConnection before opening an InputStream.
There are no repositories related with JasperLoader.
Look:
in o.a.j.c.JDTCompiler there is such an invocation in findType(String)
is = classLoader.getResourceAsStream(resourceName);
classLoader is an instance of JasperLoader, which does not override
j.n.URLClassLoader.getResourceAsStream(String)
Since there is also no getResourceAsStream in its superclass
j.n.URLClasLoader, ClassLoader's implementation getResourceAsStream(String)
is used
It (java.lang.ClassLoader) is implemented like this:
public InputStream getResourceAsStream(String name) {
URL url = getResource(name);
try {
return url != null ? url.openStream() : null;
} catch (IOException e) {
return null;
}
}
Notice that openStream() is a short for getConnection().getInputStream().
As you can clearly see after applying my hack after an invocation of
is = classLoader.getResourceAsStream(resourceName);
is is assigned an InputStream opened on an *uncached* JarURLConnection.
Te question arises - is there any benefit of having cached
JarURLConnection??
I haven't checked that in the sources of jdk as java.net.JarURLConnection
is abstract and implemented in sun.net.www.protocol.jar.JarURLConnection.
PS. I hope that I don't get cursed again.
It's easy: don't be annoying, and avoid whining.
I try hard not to be annoying.
And I'am not whining - I try to be helpfull.
For example, what's up with that bug ?
http://issues.apache.org/bugzilla/show_bug.cgi?id=32746
Is it relevant or not ?
It is. It is an outcome of my investigation. Fixing it (closing the stream),
however, does no good.
But I'm pretty sure it is a good habit to cleanup.
cheers,
/dd
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_lb_worker.c
mturk 2004/12/17 00:33:43
Modified:jk/native/common jk_lb_worker.c
Log:
Search for domain types 3 and 4 only if the worker has local workers
defined. They'll return null worker if not defined in any case.
Revision ChangesPath
1.38 +22 -18jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c
Index: jk_lb_worker.c
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_lb_worker.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- jk_lb_worker.c16 Dec 2004 15:07:55 - 1.37
+++ jk_lb_worker.c17 Dec 2004 08:33:43 - 1.38
@@ -392,7 +392,8 @@
found domain %s in route %s\n,
session_domain, session_route);
-rc = get_suitable_worker(p, 2, session_domain, 0,
p-num_of_workers, 1, domain_id, l);
+rc = get_suitable_worker(p, 2, session_domain, 0,
p-num_of_workers,
+ 1, domain_id, l);
if (rc) {
JK_TRACE_EXIT(l);
return rc;
@@ -403,25 +404,28 @@
}
+if (p-num_of_local_workers) {
+rc = get_suitable_worker(p, 3, any, 0, p-num_of_local_workers,
+ 1, domain_id, l);
+if (rc) {
+JK_TRACE_EXIT(l);
+return rc;
+}
-rc = get_suitable_worker(p, 3, any, 0, p-num_of_local_workers, 1,
domain_id, l);
-if (rc) {
-JK_TRACE_EXIT(l);
-return rc;
-}
-
-if (p-local_worker_only) {
-JK_TRACE_EXIT(l);
-return NULL;
-}
+if (p-local_worker_only) {
+JK_TRACE_EXIT(l);
+return NULL;
+}
-rc = get_suitable_worker(p, 4, any, p-num_of_local_workers,
p-num_of_workers, 1, domain_id, l);
-if (rc) {
-JK_TRACE_EXIT(l);
-return rc;
+rc = get_suitable_worker(p, 4, any, p-num_of_local_workers,
+ p-num_of_workers, 1, domain_id, l);
+if (rc) {
+JK_TRACE_EXIT(l);
+return rc;
+}
}
-
-rc = get_suitable_worker(p, 5, any, p-num_of_local_workers,
p-num_of_workers, 1, domain_id, l);
+rc = get_suitable_worker(p, 5, any, p-num_of_local_workers,
p-num_of_workers,
+ 1, domain_id, l);
JK_TRACE_EXIT(l);
return rc;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_util.c jk_util.h
mturk 2004/12/17 00:31:25
Modified:jk/native/common jk_util.c jk_util.h
Log:
Add setter and getter for default cache size.
It is implemented on Apache2 for now, and will set default cache size
acording to number of thread per child
Revision ChangesPath
1.50 +18 -1 jakarta-tomcat-connectors/jk/native/common/jk_util.c
Index: jk_util.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_util.c,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- jk_util.c 13 Dec 2004 07:51:28 - 1.49
+++ jk_util.c 17 Dec 2004 08:31:25 - 1.50
@@ -438,6 +438,23 @@
return jk_map_get_int(m, buf, def);
}
+static int def_cache_size = -1;
+int jk_get_worker_def_cache_size(int protocol)
+{
+if (def_cache_size 0) {
+if (protocol == AJP14_PROTO)
+def_cache_size = AJP14_DEF_CACHE_SZ;
+else
+def_cache_size = AJP13_DEF_CACHE_SZ;
+}
+return def_cache_size;
+}
+
+void jk_set_worker_def_cache_size(int sz)
+{
+def_cache_size = sz;
+}
+
int jk_get_worker_cache_size(jk_map_t *m, const char *wname, int def)
{
char buf[1024];
1.23 +5 -1 jakarta-tomcat-connectors/jk/native/common/jk_util.h
Index: jk_util.h
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_util.h,v
retrieving revision 1.22
retrieving revision 1.23
diff -u -r1.22 -r1.23
--- jk_util.h 7 Dec 2004 12:24:53 - 1.22
+++ jk_util.h 17 Dec 2004 08:31:25 - 1.23
@@ -131,6 +131,10 @@
void jk_init_ws_service(jk_ws_service_t *s);
+void jk_set_worker_def_cache_size(int sz);
+
+int jk_get_worker_def_cache_size(int protocol);
+
#define TC32_BRIDGE_TYPE32
#define TC33_BRIDGE_TYPE33
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32746] - InputStream not closed in o.a.j.c.JDTCompiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32746. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32746 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-12-17 13:58 --- It definitely doesn't hurt to fix this. Thanks. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Dominik Drzewiecki wrote:
Remy Maucherat [EMAIL PROTECTED] wrote:
It *does* delegate to its parent classloader (which is WebappClassLoader)
The only difference is that my solution sets useCaches to false on obtained
URLConnection before opening an InputStream.
There are no repositories related with JasperLoader.
Look:
in o.a.j.c.JDTCompiler there is such an invocation in findType(String)
is = classLoader.getResourceAsStream(resourceName);
classLoader is an instance of JasperLoader, which does not override
j.n.URLClassLoader.getResourceAsStream(String)
Since there is also no getResourceAsStream in its superclass
j.n.URLClasLoader, ClassLoader's implementation getResourceAsStream(String)
is used
It (java.lang.ClassLoader) is implemented like this:
public InputStream getResourceAsStream(String name) {
URL url = getResource(name);
try {
return url != null ? url.openStream() : null;
} catch (IOException e) {
return null;
}
}
Notice that openStream() is a short for getConnection().getInputStream().
As you can clearly see after applying my hack after an invocation of
is = classLoader.getResourceAsStream(resourceName);
is is assigned an InputStream opened on an *uncached* JarURLConnection.
There are other solutions:
- modify findType to use getResource instead of getResourceAsStream
- have JasperLoader.getResourceAsSteam (and possibly getResource as
well) do nothing and delegate to parent.getResourceAsStream (and
getResource)
I think I like the second one.
I didn't quite realize how this was working with the dependecies. The
use of getResource would prevent caching (although the JAR wouldn't need
to be found again), while using the parent's getResourceAsStream should
speed up compilation a little (since the binary content of the class is
only loaded once).
Te question arises - is there any benefit of having cached
JarURLConnection??
Well, it locks your files, therefore hinting that you should be using
Linux or something.
Seriously, I don't know the answer to that, but I imagine it could have
consequences (the amount of accesses is not insignificant if there are
lots of depedencies).
I haven't checked that in the sources of jdk as java.net.JarURLConnection
is abstract and implemented in sun.net.www.protocol.jar.JarURLConnection.
Rmy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Remy Maucherat [EMAIL PROTECTED] wrote:
There are other solutions:
- modify findType to use getResource instead of getResourceAsStream
- have JasperLoader.getResourceAsSteam (and possibly getResource as
well) do nothing and delegate to parent.getResourceAsStream (and
getResource)
I think I like the second one.
So do I as that is exacly what my proposed hack does.
There is no need to provide JasperLoader.getResource(String) as the
inherited from java.lang.ClassLoader getResource(String) is cool, it
already delegates to parent first if there is one. Here it is, as
implemented in java.lang.ClassLoader:
public URL getResource(String name) {
URL url;
if (parent != null) {
url = parent.getResource(name);
} else {
url = getBootstrapResource(name);
}
if (url == null) {
url = findResource(name);
}
return url;
}
So it is enough to provide only JasperLoader.getResourceAsStream(String)
which in turn invokes getResource(String) to obtain URL to requested
resource. As there is no implementation of such method provided in
JasperLoader, the implementation of ClassLoader is used (which delegates to
parent). I hope I made myself clear (I realize that a patch is worth
thousand words ;)
It's not that hacky after all, is it?
cheers,
/dd
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
mod_jk error handling question
I apologize for the cross post, but I didn't receive any responses from the user list so I thought I'd try here. Environment: Apache 2.0.52 mod_jk 1.2.7-beta-2 Tomcat 5.5.4 I've set up Tomcat with and AJP1.3 Connector to handle requests for web apps from Apache. I'd like to be able to set up an ErrorDocument directive for apache to forward the user to a custom error page when tomcat is unavailable. This page would inform the user that maintenance is being performed on the web app and so on. When I test this, the http status code that gets returned by mod_jk is 500 (internal server error). This seems too generic to me as it encompasses all kinds of other errors that mod_jk could experience. I was thinking that mod_jk should return 503 (service unavailable) instead when tomcat cannot be contacted. I modified apache-2.0/mod_jk.c (line 1858) to return HTTP_SERVICE_UNAVAILABLE instead of HTTP_INTERNAL_SERVICE_ERROR. With this change mod_jk now returns 503 when tomcat cannot be contacted, but I have no idea if this is the right place to make this change. Is there a better way to handle this or is this an acceptable change? I'd like to fix it with an Apache source code change as a last resort if possible. Any insight is appreciated. Regards, Jay - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java
remm2004/12/17 06:55:30
Modified:jasper2/src/share/org/apache/jasper/servlet
JasperLoader.java
Log:
- Override getResourceAsStream to prevent locking.
- Based on a patch submitted by Dominik Drzewiecki.
Revision ChangesPath
1.17 +24 -2
jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java
Index: JasperLoader.java
===
RCS file:
/home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperLoader.java,v
retrieving revision 1.16
retrieving revision 1.17
diff -u -r1.16 -r1.17
--- JasperLoader.java 22 Nov 2004 16:35:52 - 1.16
+++ JasperLoader.java 17 Dec 2004 14:55:30 - 1.17
@@ -16,6 +16,8 @@
package org.apache.jasper.servlet;
+import java.io.IOException;
+import java.io.InputStream;
import java.net.URL;
import java.net.URLClassLoader;
import java.security.AccessController;
@@ -27,8 +29,6 @@
import org.apache.jasper.Constants;
-import org.apache.jasper.security.SecurityUtil;
-
/**
* Class loader for loading servlet class files (corresponding to JSP files)
* and tag handler class files (corresponding to tag files).
@@ -158,6 +158,28 @@
return findClass(name);
}
+
+/**
+ * Delegate to parent
+ *
+ * @see java.lang.ClassLoader#getResourceAsStream(java.lang.String)
+ */
+public InputStream getResourceAsStream(String name) {
+InputStream is = parent.getResourceAsStream(name);
+if (is == null) {
+URL url = findResource(name);
+if (url != null) {
+try {
+is = url.openStream();
+} catch (IOException e) {
+is = null;
+}
+}
+}
+return is;
+}
+
+
/**
* Get the Permissions for a CodeSource.
*
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: mod_jk error handling question
Paulsen, Jay M wrote: I apologize for the cross post, but I didn't receive any responses from the user list so I thought I'd try here. Don't apologize :). I saw you post, but just didn't catch the time to answer. Is there a better way to handle this or is this an acceptable change? I'd like to fix it with an Apache source code change as a last resort if possible. Not right now. I agree that server_busy would better explain the status of the JK in that case. The problem is that it can be either server_error or server_busy. Discovering something like that is planned for the next release of mod_jk (1.2.10). Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java
[EMAIL PROTECTED] wrote: remm2004/12/17 06:55:30 Modified:jasper2/src/share/org/apache/jasper/servlet JasperLoader.java Log: - Override getResourceAsStream to prevent locking. - Based on a patch submitted by Dominik Drzewiecki. Revision ChangesPath 1.17 +24 -2 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperL oader.java FYI, it works for me. No nasty JAR locking anymore! /dd - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32754] New: - Can't modify thread configuration attributes of AJP connector MBean
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32754. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32754 Summary: Can't modify thread configuration attributes of AJP connector MBean Product: Tomcat 5 Version: 5.0.30 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Connector:AJP AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Try to modify the minSpareThreads, maxSpareThreads and maxThreads attributes of a AJP connector MBean by accessing the JMX server, but do not succeed: 1/ Read the value of one of the above attributes by calling getAttribute() method. 2/ Modify the value by calling setAttribute() method with the new desired value 3/ Read the attribute's value by calling getAttribute() method and find the initial value (obtained in step 1) and not the desired value. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32753] New: - Missing configuration attributes for HTTP connector, when persisting the configuration
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32753. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32753 Summary: Missing configuration attributes for HTTP connector, when persisting the configuration Product: Tomcat 5 Version: 5.0.30 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Connector:HTTP AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] When creating a new HTTP connector the values provided for minSpareThreads, maxSpareThreads and maxThreads attributes are lost in the server.xml file after commiting changes. Steps to reproduce: 1/ Create a HTTP connector with the Tomcat Administration Tool. Feel in values for the minSpareThreads, maxSpareThreads and maxThreads attributes. 2/ Click on Save button 3/ Click on Commit Changes button 4/ Check newly created connector item in server.xml file: missing above configuration attributes -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, December 17, 2004 3:24 AM Subject: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c mturk 2004/12/17 03:24:38 Modified:jk/native/common jk_uri_worker_map.c Log: Fix url rewrite for jksessionid. It should fix all jksessionid bugs, cause previous implemantation didn't handle that properly. I'm -1 on this patch. map_uri_to_worker doesn't need all of this spaghetti just because IIS is broken. This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: PersistentManagerBase (etc) Patches
Remy Maucherat wrote:
Jess Holle wrote:
[Yes, the Request change would still be necessary to prevent the
chance of requests randomly getting their sessions passivated and
recycle after they findSession() but before access().]
A session can be passivated at any (bad) time (which will screw up
requests), and we already do plenty of on access checks. I don't see
what it adds.
A session must not be passivated at just *any* bad time -- that's part
of what I'm fixing.
For the case where one has many valid sessions, many of which are
passivated due to a maximum active sessions constraint, there is likely
to be some level of thrashing such that it is entirely too likely that a
session which has only been idle for a short while is getting passivated
between the findSession() and the access() call. This will result in an
otherwise fine request going horribly wrong from a user's perspective
(assuming the state data in the session was at all critical).
If Request is left as is, then it user's will inappropriately get new
sessions in such cases. If it is changed without the preAccess()
addition, the user will get an invalidated session instead.
As I said, the patch ideas look fine, but I do have questions:
- Why do you really need methods named preAccess and access on the
manager ? The first one seems to be designed to do swap ins while the
second one keeps usage stats, so maybe this could be more elegant. Or
maybe not.
The attached patch has some clarifying comments.
preAccess() is intended to fix the race condition case. It should
rarely do more than check isValid and return, but without it user
requests can go awry for no reason as they see it.
access() move the accessed session to the front of the LinkedHashMap
thereby maintaining sorting. The attached patch also uses this sorting
to reduce the overhead of processMaxIdleSwaps() by breaking from the
loop as newer sessions are encountered. [Yes, I know this may mean some
old sessions are not passivated when a session access on a very old
session occurs between findSessions() and this check, but that's better
than running through all sessions every processing interval.
processMaxIdleSwaps() should be a best reasonable effort.]
- Keeping session skeletons around will eat resources. I understand
this will improve performance, but is that really a good idea ? I'm
asking for your experience after the change here (is memory usage much
higher, etc).
I am working all of this on 2 fronts here: trying to get an acceptable
patch together, incorporate any feedback, etc, and get this tested
against real world scenarios where we're having issues.
Our issue involves various web apps that keep large amounts of session
data for all users -- and a corresponding inability to scale beyond a
few users. I am certain all of these changes put together will not
suffice to totally fix this problem -- and efforts to improve the web
apps are therefore also planned.
I'll certainly provide feedback (and further patches if/where
appropriate) as I gain more real world experience with this approach.
--
Jess Holle
Index: PersistentManagerBase.java
===
RCS file:
/home/cvspublic/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/session/PersistentManagerBase.java,v
retrieving revision 1.25
diff -u -r1.25 PersistentManagerBase.java
--- PersistentManagerBase.java 22 Nov 2004 16:35:18 - 1.25
+++ PersistentManagerBase.java 17 Dec 2004 15:41:30 -
@@ -20,6 +20,11 @@
import java.beans.PropertyChangeEvent;
import java.beans.PropertyChangeListener;
import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.Comparator;
+import java.util.LinkedHashMap;
+import java.util.Map;
import java.security.AccessController;
import java.security.PrivilegedActionException;
import java.security.PrivilegedExceptionAction;
@@ -204,17 +209,44 @@
protected long processingTime = 0;
-// - Properties
+/**
+ * Whether session should be synchronously swapped out immediately upon
+ * exceeding maxActiveSessions. Defaults to 'false'.
+ */
+protected boolean immediateSwapOnMaxActiveExceeded = false;
+
+
+// -
Constructors
+
+
+public PersistentManagerBase() {
+sessions = new LinkedHashMap() {
+protected boolean removeEldestEntry(Map.Entry eldest) {
+if ( immediateSwapOnMaxActiveExceeded ) {
+ int maxActiveSessions = getMaxActiveSessions();
+ if ( maxActiveSessions = 0 )
+ if ( size() maxActiveSessions )
+ if ( isStarted() )
+ // try to swap out oldest entry; if entry is
still too fresh then processMaxActiveSwaps() will swap out
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: I'm -1 on this patch. map_uri_to_worker doesn't need all of this spaghetti just because IIS is broken. No, it's not related to IIS at all. The previous implementation was taking the uri an cut out the ';jseessionid=...' from the url. Take a look at JK2 and it's jk_uriMap.c: url is rewritten, but restored on exit that jk did not do. That is exactly what this patch does. Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32757] New: - 4.1.31: NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32757. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32757 Summary: 4.1.31: NullPointerException Product: Tomcat 4 Version: 4.1.31 Platform: PC OS/Version: Windows XP Status: NEW Severity: critical Priority: P1 Component: Connector:Coyote HTTP/1.1 AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] 2004-12-06 11:29:26 CoyoteAdapter An exception or error occurred in the container during the request processing java.lang.NullPointerException at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:117) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNext(StandardPipeline.java:596) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:433) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:948) at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:152) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:799) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnection(Http11Protocol.java:705) at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java:577) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683) at java.lang.Thread.run(Thread.java:534) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: I'm -1 on this patch. map_uri_to_worker doesn't need all of this spaghetti just because IIS is broken. Continuing from last reply... Also, I'm stunned with the fact that there is no reports in Bugzilla about that. I mean we have used the uri: /uri;jsessionid=?params and made: url_rewrite = strstr(uri, ;jsessionid') then *url = '\0'; Thus cutting everything including jsessionid. The JK2 allways restored that on exit (take a look at '*url_rewrite = origChar'). Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Dominik Drzewiecki wrote:
Remy Maucherat [EMAIL PROTECTED] wrote:
So do I as that is exacly what my proposed hack does.
The WCL doesn't do the same thing when you call getResource or
getResourceAsStream. Using getResource is less efficient. That's the idea.
There is no need to provide JasperLoader.getResource(String) as the
inherited from java.lang.ClassLoader getResource(String) is cool, it
already delegates to parent first if there is one. Here it is, as
implemented in java.lang.ClassLoader:
public URL getResource(String name) {
URL url;
if (parent != null) {
url = parent.getResource(name);
} else {
url = getBootstrapResource(name);
}
if (url == null) {
url = findResource(name);
}
return url;
}
So it is enough to provide only JasperLoader.getResourceAsStream(String)
which in turn invokes getResource(String) to obtain URL to requested
resource. As there is no implementation of such method provided in
JasperLoader, the implementation of ClassLoader is used (which delegates to
parent). I hope I made myself clear (I realize that a patch is worth
thousand words ;)
What I plan to commit is add:
public InputStream getResourceAsStream(String name) {
return parent.getResourceAsStream(name);
}
and possibly, since we never need to search the internal repositories:
public URL getResource(String name) {
return parent.getResource(name);
}
It's not that hacky after all, is it?
It might make getResourceAsStream more expensive, that's the problem.
(and stop posting your messages multiple times)
Rmy
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: I'm -1 on this patch. map_uri_to_worker doesn't need all of this spaghetti just because IIS is broken. Also you can see the difference with Apache2. Open http://host/servlets-examples/servlet/SessionExample Now, click on the 'Url encoded' link. You will see the ';jsessionid=' in the url. Click the 'refresh' without the patch and you'll loose everything after ';'. Use the patch, and the url will be preserved. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, December 17, 2004 8:06 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c Bill Barker wrote: I'm -1 on this patch. map_uri_to_worker doesn't need all of this spaghetti just because IIS is broken. No, it's not related to IIS at all. Of course it is related to IIS, since IIS is the only one that (wrongly) doesn't pass a copy of the URI to map_uri_to_worker The previous implementation was taking the uri an cut out the ';jseessionid=...' from the url. Take a look at JK2 and it's jk_uriMap.c: url is rewritten, but restored on exit that jk did not do. That is exactly what this patch does. Yeah, well, JK2 is hardly a shining example of how things should be done ;-). jk_uriMap.c is well known to be seriously broken. Regards, Mladen - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32757] - 4.1.31: NullPointerException
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32757. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32757 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2004-12-17 17:24 --- Please use tomcat-user to debug first to get more detail. The information provided is insuffient to fix this issue. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: No, it's not related to IIS at all. Of course it is related to IIS, since IIS is the only one that (wrongly) doesn't pass a copy of the URI to map_uri_to_worker OK. Seems that you catch me on that :). But since the request is supposed to be atomic why to strdup an uri? I'd rather remove char *uri = apr_pstrdup(r-pool, r-uri); before calling map_uri_to_worker then adding strdup to IIS. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml
Thanks, I'll give this a test. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Friday, December 17, 2004 7:28 AM To: [EMAIL PROTECTED] Subject: cvs commit: jakarta-tomcat-connectors/jk/xdocs changelog.xml mturk 2004/12/17 04:28:12 Modified:jk/xdocs changelog.xml Log: Log the fix about url rewriting. Revision ChangesPath 1.7 +4 -0 jakarta-tomcat-connectors/jk/xdocs/changelog.xml Index: changelog.xml === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/xdocs/changelog.xml,v retrieving revision 1.6 retrieving revision 1.7 diff -u -r1.6 -r1.7 --- changelog.xml 17 Dec 2004 09:01:18 - 1.6 +++ changelog.xml 17 Dec 2004 12:28:12 - 1.7 @@ -25,6 +25,10 @@ br / subsection name=Native changelog + fix + Fix url rewriting by restoring the inplace uri from which the + jsessionid was removed. (mturk) + /fix update Make load balancer algorithm thread safe by introducing mutex to the load balancer worker. (mturk) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-1.3 mod_jk.c
mturk 2004/12/17 10:16:39
Modified:jk/native/apache-1.3 mod_jk.c
Log:
Remove duplicating uri because map_uri now properly reverts the
changes made when jsessionid is found.
Revision ChangesPath
1.61 +3 -4 jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-1.3/mod_jk.c,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- mod_jk.c 17 Dec 2004 03:14:56 - 1.60
+++ mod_jk.c 17 Dec 2004 18:16:39 - 1.61
@@ -1926,8 +1926,7 @@
if (conf) {
jk_logger_t *l = conf-log ? conf-log : main_log;
-char *uri = ap_pstrdup(r-pool, r-uri);
-char *worker = map_uri_to_worker(conf-uw_map, uri, l);
+char *worker = map_uri_to_worker(conf-uw_map, r-uri, l);
/* Don't know the worker, ForwardDirectories is set, there is a
* previous request for which the handler is JK_HANDLER (as set
by
@@ -1950,7 +1949,7 @@
ap_table_setn(r-notes, JK_WORKER_ID, worker);
}
else if (conf-alias_dir != NULL) {
-char *clean_uri = uri;
+char *clean_uri = ap_pstrdup(r-pool, r-uri);
ap_no2slash(clean_uri);
/* Automatically map uri to a context static file */
jk_log(l, JK_LOG_DEBUG,
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_version.h
mturk 2004/12/17 10:17:43 Modified:jk/native/common jk_version.h Log: Increment the version to 1.2.8-rc-1 Revision ChangesPath 1.30 +4 -3 jakarta-tomcat-connectors/jk/native/common/jk_version.h Index: jk_version.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_version.h,v retrieving revision 1.29 retrieving revision 1.30 diff -u -r1.29 -r1.30 --- jk_version.h 16 Dec 2004 09:25:15 - 1.29 +++ jk_version.h 17 Dec 2004 18:17:43 - 1.30 @@ -33,8 +33,8 @@ #define JK_BETASTRING 0 /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */ #define JK_VERISRELEASE 0 -#define JK_VERRC0 -#define JK_RCSTRING 0 +#define JK_VERRC1 +#define JK_RCSTRING 1 /** END OF AREA TO MODIFY BEFORE RELEASING */ @@ -60,6 +60,7 @@ #endif #if (JK_VERRC != 0) +#undef JK_EXPOSED_VERSION #define JK_EXPOSED_VERSION JK_RELEASE_STR -rc- JK_RCSTRING #endif - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
mturk 2004/12/17 10:08:52
Modified:jk/native/apache-2.0 mod_jk.c
Log:
Remove duplicating uri because map_uri now properly reverts the
changes made when jsessionid is found.
Revision ChangesPath
1.113 +2 -3 jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c
Index: mod_jk.c
===
RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/mod_jk.c,v
retrieving revision 1.112
retrieving revision 1.113
diff -u -r1.112 -r1.113
--- mod_jk.c 17 Dec 2004 14:58:37 - 1.112
+++ mod_jk.c 17 Dec 2004 18:08:52 - 1.113
@@ -1701,8 +1701,7 @@
worker_env.num_of_workers);
}
else {
-char *uri = apr_pstrdup(r-pool, r-uri);
-worker_name = map_uri_to_worker(xconf-uw_map, uri, xconf-log);
+worker_name = map_uri_to_worker(xconf-uw_map, r-uri,
xconf-log);
if (worker_name == NULL)
worker_name = worker_env.first_worker;
if (JK_IS_DEBUG_LEVEL(xconf-log))
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/common jk_version.h
mturk 2004/12/17 10:38:50 Modified:jk/native/common jk_version.h Log: Remove tagged rc-1 flag. Revision ChangesPath 1.31 +3 -3 jakarta-tomcat-connectors/jk/native/common/jk_version.h Index: jk_version.h === RCS file: /home/cvs/jakarta-tomcat-connectors/jk/native/common/jk_version.h,v retrieving revision 1.30 retrieving revision 1.31 diff -u -r1.30 -r1.31 --- jk_version.h 17 Dec 2004 18:17:43 - 1.30 +++ jk_version.h 17 Dec 2004 18:38:50 - 1.31 @@ -33,8 +33,8 @@ #define JK_BETASTRING 0 /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */ #define JK_VERISRELEASE 0 -#define JK_VERRC1 -#define JK_RCSTRING 1 +#define JK_VERRC0 +#define JK_RCSTRING 0 /** END OF AREA TO MODIFY BEFORE RELEASING */ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: JDTCompiler and locked jar files *again*
Remy Maucherat wrote: (and stop posting your messages multiple times) It must have been my webmail agent or mail server or both. Sorry. /dd - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, December 17, 2004 9:34 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c Bill Barker wrote: No, it's not related to IIS at all. Of course it is related to IIS, since IIS is the only one that (wrongly) doesn't pass a copy of the URI to map_uri_to_worker OK. Seems that you catch me on that :). But since the request is supposed to be atomic why to strdup an uri? I'd rather remove char *uri = apr_pstrdup(r-pool, r-uri); before calling map_uri_to_worker then adding strdup to IIS. It was done to fix a '//' bypass traversal bug (e.g. http://myserver/myapp//foo.jsp would serve the source of the JSP). map_uri_to_worker calls jk_no2slash, which modifies the URI in ways that are hard to undo. The reason that the call is done outside of map_uri_to_worker is simply that apr_pstrdup is better than jk_pool_strdup. Otherwise, it's trying to be like location_walk in Apache. In the case of IIS, something like: char temp_uri[INTERNET_MAX_URL_LENGTH]; strcpy(temp_uri, uri); worker = map_uri_to_worker(uw_map, temp_uri, logger); is probably no worse than the rest of the code :). However, I kept breaking IIS whenever I tried to change things in it, so I just gave up at some point. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet JasperLoader.java
Dominik Drzewiecki wrote: [EMAIL PROTECTED] wrote: remm2004/12/17 06:55:30 Modified:jasper2/src/share/org/apache/jasper/servlet JasperLoader.java Log: - Override getResourceAsStream to prevent locking. - Based on a patch submitted by Dominik Drzewiecki. Revision ChangesPath 1.17 +24 -2 jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/servlet/JasperL oader.java FYI, it works for me. No nasty JAR locking anymore! That's good. It ended being very similar to your patch, as I had forgotten local repository lookup was needed for tag files. Rmy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
- Original Message - From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Friday, December 17, 2004 10:08 AM Subject: cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c mturk 2004/12/17 10:08:52 Modified:jk/native/apache-2.0 mod_jk.c Log: Remove duplicating uri because map_uri now properly reverts the changes made when jsessionid is found. This is a very big -1. map_uri_to_worker is going to modify the uri that gets passed in, so it absolutely *must* be duped. This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: But since the request is supposed to be atomic why to strdup an uri? I'd rather remove char *uri = apr_pstrdup(r-pool, r-uri); before calling map_uri_to_worker then adding strdup to IIS. It was done to fix a '//' bypass traversal bug (e.g. http://myserver/myapp//foo.jsp would serve the source of the JSP). Yep, but is that really the responsibility of the JK? The jk is supposed to be a proxy, so as less intervention in the protocol the better results will be. I have comment out the jk_no2slash checking inside map_uri_to_worker cause found no difference with or without it. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 mod_jk.c
Bill Barker wrote:
Remove duplicating uri because map_uri now properly reverts the
changes made when jsessionid is found.
This is a very big -1. map_uri_to_worker is going to modify the uri that
gets passed in, so it absolutely *must* be duped.
Yes, but it will revert the changes made.
It's like:
void test(char *str)
{
char save = str[2];
str[2] = '\0';
...
str[2] = save;
}
char some_string[] = abcd;
test(some_string);
After the call it will still be like before.
Since the call to 'test(some_string)' is assured to be thread safe,
why dupping that string and then releasing it after the call?
Mladen.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, December 17, 2004 11:59 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c Bill Barker wrote: But since the request is supposed to be atomic why to strdup an uri? I'd rather remove char *uri = apr_pstrdup(r-pool, r-uri); before calling map_uri_to_worker then adding strdup to IIS. It was done to fix a '//' bypass traversal bug (e.g. http://myserver/myapp//foo.jsp would serve the source of the JSP). Yep, but is that really the responsibility of the JK? The jk is supposed to be a proxy, so as less intervention in the protocol the better results will be. It's consistant with location_walk in Apache, so at least for mod_jk.so is seems to be pretty important that the uri mapping rules work the same way. Without the consistancy, configuration for JK becomes even harder than for JK2 :(. I have comment out the jk_no2slash checking inside map_uri_to_worker cause found no difference with or without it. Try with only: JkMount /myapp/*.jsp and requesting: http://myserver//myapp/index.jsp Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
another data point RE: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
The fix made early this morning (~7-8am Eastern) works to fix the problem I was having with URL rewriting. I'll grab the latest code set again soon and retry. Thanks for your fast response on this Mladen. JK2s eol is the impetus for my usage of JK and this is the one glaring defect/difference I've found to this point. Derrick -Original Message- From: Mladen Turk [mailto:[EMAIL PROTECTED] Sent: Friday, December 17, 2004 2:59 PM To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c Bill Barker wrote: But since the request is supposed to be atomic why to strdup an uri? I'd rather remove char *uri = apr_pstrdup(r-pool, r-uri); before calling map_uri_to_worker then adding strdup to IIS. It was done to fix a '//' bypass traversal bug (e.g. http://myserver/myapp//foo.jsp would serve the source of the JSP). Yep, but is that really the responsibility of the JK? The jk is supposed to be a proxy, so as less intervention in the protocol the better results will be. I have comment out the jk_no2slash checking inside map_uri_to_worker cause found no difference with or without it. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: Try with only: JkMount /myapp/*.jsp and requesting: http://myserver//myapp/index.jsp Yes I did, and it really doesn't mater. Well my jsp's are inside tomcat application, so I admit there can be problems if the .jsp is hanging around somewhere outside web application :). Also I've tried that with 5.0/5.5, so if it breaks some older tomcat versions feel free to include the jk_no2slash checking again, and compare every char with the slash in the uri on the each request made. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: another data point RE: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Derrick Koes wrote: The fix made early this morning (~7-8am Eastern) works to fix the problem I was having with URL rewriting. I'll grab the latest code set again soon and retry. Cool, those are really good news! Glad that it works finally :). Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
- Original Message - From: Mladen Turk [EMAIL PROTECTED] To: Tomcat Developers List [EMAIL PROTECTED] Sent: Friday, December 17, 2004 12:47 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c Bill Barker wrote: Try with only: JkMount /myapp/*.jsp and requesting: http://myserver//myapp/index.jsp Yes I did, and it really doesn't mater. Well my jsp's are inside tomcat application, so I admit there can be problems if the .jsp is hanging around somewhere outside web application :). It's for when you want Apache to act as the default servlet, so you have: Alias /myapp/ /path/to/myapp/ JkMount /myapp/*.jsp ajp13 Also I've tried that with 5.0/5.5, so if it breaks some older tomcat versions feel free to include the jk_no2slash checking again, and compare every char with the slash in the uri on the each request made. All of the Tomcat mappers from 3.3 up will handle the request fine if it ever sees it. However, with the code as it is now, mod_jk will refuse the request. Now that mod_jk is hopelessly broken, I guess I'll just have to wait for proxy_ajp before upgrading. Regards, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] This message is intended only for the use of the person(s) listed above as the intended recipient(s), and may contain information that is PRIVILEGED and CONFIDENTIAL. If you are not an intended recipient, you may not read, copy, or distribute this message or any attachment. If you received this communication in error, please notify us immediately by e-mail and then delete all copies of this message and any attachments. In addition you should be aware that ordinary (unencrypted) e-mail sent through the Internet is not secure. Do not send confidential or sensitive information, such as social security numbers, account numbers, personal identification numbers and passwords, to us via ordinary (unencrypted) e-mail. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Online JK Docs - Updates needed
Greetings All, Can the online JTC properties docs be brought up to speed with recent changes to the module, please? TIA, Norm - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_uri_worker_map.c
Bill Barker wrote: and requesting: http://myserver//myapp/index.jsp Yes I did, and it really doesn't mater. Well my jsp's are inside tomcat application, so I admit there can be problems if the .jsp is hanging around somewhere outside web application :). It's for when you want Apache to act as the default servlet, so you have: Alias /myapp/ /path/to/myapp/ JkMount /myapp/*.jsp ajp13 First of all it has nothing to do with the two slashes in the url. I agree: Alias /foo/ /opt/tomcat/webapps/jsp-examples JkMount /foo/*.jsp wlb Produces Tomcat returning 404 error page (Tomcat). But that is exactly how jk 1.2.6 behaves. So I really do not understand your post. Regrads, Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Mod_Jk -- Latest CVS
Greetings All, Just built the latest Mod_Jk from CVS with Apache2.1 on Win for NetWare, and with only the three 'mandatory' settings for worker1 of type, host and port, all I'm getting is Internal Server Error, and the Jk logs do not show good signs of matching URL's to the worker1... Norm [Sat Dec 18 08:00:53 2004] [76:0] [debug] mod_jk.c (1719): Into handler r-proxyreq=0 r-handler=jakarta-servlet r-notes=-834738016 worker=worker1 [Sat Dec 18 08:00:53 2004] [76:0] [debug] jk_worker.c (88): did not find a worker worker1 [Sat Dec 18 08:01:11 2004] [76:0] [debug] jk_uri_worker_map.c (573): Attempting to map URI '/manager/html/' from 5 maps [Sat Dec 18 08:01:11 2004] [76:0] [debug] jk_uri_worker_map.c (583): Attempting to map context URI '/servlet/*' [Sat Dec 18 08:01:11 2004] [76:0] [debug] jk_uri_worker_map.c (583): Attempting to map context URI '/manager/*' [Sat Dec 18 08:01:11 2004] [76:0] [debug] jk_uri_worker_map.c (636): Found a context match worker1 - /manager/ [Sat Dec 18 08:01:11 2004] [76:0] [debug] mod_jk.c (1719): Into handler r-proxyreq=0 r-handler=jakarta-servlet r-notes=-2125483840 worker=worker1 [Sat Dec 18 08:01:11 2004] [76:0] [debug] jk_worker.c (88): did not find a worker worker1 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Online JK Docs - Updates needed
NormW wrote: Greetings All, Can the online JTC properties docs be brought up to speed with recent changes to the module, please? They are in sync (well, except some default values). Tomorrow, OK 8)? Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Mod_Jk -- Latest CVS
NormW wrote: Greetings All, Just built the latest Mod_Jk from CVS with Apache2.1 on Win for NetWare, and with only the three 'mandatory' settings for worker1 of type, host and port, all I'm getting is Internal Server Error, and the Jk logs do not show good signs of matching URL's to the worker1... You have a syntax error in the workers.properties. When ever you find: [debug] jk_worker.c (88): did not find a worker worker1 It means: Uri is parsed for worker1, but the worker1 was failed to create. The problem is that when the worker is created (when reading config) the mod_jk.log is not jet present. I'll try to use apache logger for that, but It'll have to wait for 1.2.9. Just post those three lines :) Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Mod_Jk -- Latest CVS
Mladen Turk wrote: NormW wrote: Greetings All, Just built the latest Mod_Jk from CVS with Apache2.1 on Win for NetWare, and with only the three 'mandatory' settings for worker1 of type, host and port, all I'm getting is Internal Server Error, and the Jk logs do not show good signs of matching URL's to the worker1... You have a syntax error in the workers.properties. Just post those three lines :) Or perhaps you don't have a fourth line ? workers.list=worker1 Without that it will not work. Look at: http://jakarta.apache.org/tomcat/connectors-doc/config/workers.html (Section: Defining Workers) Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Error Tomcat
I use an application in I java with Tomcat3.2 and MySQL. I had jdk1.2 and update it to jdk1.3. However not all functions work fine as used to. When the system is working with port 8080 the whole system work as it should. If I decide to work with if without the 8080 port some functionally doesn't work at all. Below I am directing some errors found my isapi's log: [jk_uri_worker_map.c (334)]: jk_uri_worker_map_t::uri_worker_map_close, NULL parameter [jk_uri_worker_map.c (184)]: In jk_uri_worker_map_t::uri_worker_map_free, NULL parameters [jk_connect.c (143)]: jk_open_socket, connect() failed errno = 61 [jk_ajp12_worker.c (152)]: In jk_endpoint_t::service, Error sd = -1 [jk_isapi_plugin.c (554)]: HttpExtensionProc error, service() failed [jk_connect.c (143)]: jk_open_socket, connect() failed errno = 61 [jk_ajp12_worker.c (152)]: In jk_endpoint_t::service, Error sd = -1 [jk_isapi_plugin.c (554)]: HttpExtensionProc error, service() failed [jk_connect.c (143)]: jk_open_socket, connect() failed errno = 61 [jk_ajp12_worker.c (152)]: In jk_endpoint_t::service, Error sd = -1 [jk_isapi_plugin.c (554)]: HttpExtensionProc error, service() failed [jk_connect.c (143)]: jk_open_socket, connect() failed errno = 61 [jk_ajp12_worker.c (152)]: In jk_endpoint_t::service, Error sd = -1 [jk_isapi_plugin.c (554)]: HttpExtensionProc error, service() failed [jk_uri_worker_map.c (334)]: jk_uri_worker_map_t::uri_worker_map_close, NULL parameter [jk_uri_worker_map.c (184)]: In jk_uri_worker_map_t::uri_worker_map_free, NULL parameters [jk_uri_worker_map.c (334)]: jk_uri_worker_map_t::uri_worker_map_close, NULL parameter [jk_uri_worker_map.c (184)]: In jk_uri_worker_map_t::uri_worker_map_free, NULL parameters [jk_uri_worker_map.c (334)]: jk_uri_worker_map_t::uri_worker_map_close, NULL parameter [jk_uri_worker_map.c (184)]: In jk_uri_worker_map_t::uri_worker_map_free, NULL parameters [jk_uri_worker_map.c (334)]: jk_uri_worker_map_t::uri_worker_map_close, NULL parameter [jk_uri_worker_map.c (184)]: In jk_uri_worker_map_t::uri_worker_map_free, NULL parameters [jk_isapi_plugin.c (355)]: jk_ws_service_t::write, WriteClient failed [jk_ajp12_worker.c (596)]: ajpv12_handle_response, error writing back to server [jk_isapi_plugin.c (355)]: jk_ws_service_t::write, WriteClient failed [jk_ajp12_worker.c (596)]: ajpv12_handle_response, error writing back to server [jk_isapi_plugin.c (355)]: jk_ws_service_t::write, WriteClient failed [jk_ajp12_worker.c (596)]: ajpv12_handle_response, error writing back to server [jk_isapi_plugin.c (355)]: jk_ws_service_t::write, WriteClient failed [jk_ajp12_worker.c (596)]: ajpv12_handle_response, error writing back to server [jk_isapi_plugin.c (355)]: jk_ws_service_t::write, WriteClient failed [jk_ajp12_worker.c (596)]: ajpv12_handle_response, error writing back to server Some idea of how to proceed? Thank for the attention I´m sorry, but my English is not very good. Igor
JK 1.2.7 Beta3 Page Fault
Greetings, I did a clean co of jtc w/ JK_1_2_7_BETA_3 tag. I am building for NetWare with ap2.0.52. Running stress test on a 2 procs machine. Doing request to simple JSPs and servlets using WebBench with up to 250 virtual clients. It takes between few minutes and an hour to reproduce, this is the stack: ajp_reset_endpoint + 4 ajp_close_endpoint + 36 ajp_get_endpoint + E3 ajp_worker_factory%12 + 119B jk_set_options + 649 The ajp_endpoint_t pointer passed in ajp_reset_endpoint is a valid address but the reuse field is NULL. Setting up reuse to JK_FALSE seg fault the server. Since I inherited responsibility of mod_jk few weeks ago, and had my first look at the code 2 days ago, help would probably be usefull to resolve this problem. Any explanation of why this will happen? Any more information that I could provide to help narrow down that problem? Next Monday, I will try to reproduce that problem with the newly tagged 1.2.8rc1. Thanks, Jean-Jacques
DO NOT REPLY [Bug 27398] - org.apache.jasper.JasperException: Failed to load or instantiate TagExtraInfo class: org.apache.struts.taglib.html.MessagesTei
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=27398. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=27398 [EMAIL PROTECTED] changed: What|Removed |Added Status|RESOLVED|REOPENED OS/Version||All Resolution|INVALID | --- Additional Comments From [EMAIL PROTECTED] 2004-12-18 04:03 --- I've found a workaround: edit the tld files. Yes, it is the most-not recommended practice, but it worked. First of all I took out all taglibl mention in struts-html.tld file. Then I added .html to much lines. Some like org.apache.struts.taglib.MessageTei became org.apache.struts.taglib.html.MessageTei And it worked!!! I was getting mad when I started to work with tiles. Now everything works!!! Herman Gomez C. Spain. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: jakarta-tomcat-connectors/jk/native/apache-2.0 Makefile.in
billbarker2004/12/17 19:49:04
Modified:jk/native/apache-2.0 Makefile.in
Log:
Fix build for --with-apache=/path/to/apache-src
Reported By: Gump [EMAIL PROTECTED]
Revision ChangesPath
1.16 +1 -0
jakarta-tomcat-connectors/jk/native/apache-2.0/Makefile.in
Index: Makefile.in
===
RCS file:
/home/cvs/jakarta-tomcat-connectors/jk/native/apache-2.0/Makefile.in,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -r1.15 -r1.16
--- Makefile.in 9 Sep 2002 15:35:49 - 1.15
+++ Makefile.in 18 Dec 2004 03:49:04 - 1.16
@@ -8,6 +8,7 @@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
[EMAIL PROTECTED]@
# Defaults
libexecdir=${APACHE_DIR}/modules
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[GUMP@brutus]: Project jakarta-tomcat-jk-native (in module jakarta-tomcat-connectors) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-jk-native has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-jk-native : Connectors to various web servers Full details are available at: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/jakarta-tomcat-connectors/jakarta-tomcat-jk-native/gump_work/build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native.html Work Name: build_jakarta-tomcat-connectors_jakarta-tomcat-jk-native (Type: Build) Work ended in a state of : Failed Elapsed: 11 secs Command Line: make [Working Directory: /usr/local/gump/public/workspace/jakarta-tomcat-connectors/jk/native] - /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c -fPIC -DPIC -o .libs/jk_ajp13.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_ajp13.c -o jk_ajp13.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c -fPIC -DPIC -o .libs/jk_pool.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_pool.c -o jk_pool.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_worker.c gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_worker.c -fPIC -DPIC -o .libs/jk_worker.o gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I /opt/jdk1.4/include/ -c jk_worker.c -o jk_worker.o /dev/null 21 /bin/sh ../libtool --mode=compile gcc -I/usr/local/gump/public/workspace/apache-httpd/include -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr/include -I/usr/local/gump/public/workspace/apache-httpd/os/unix -I/usr/local/gump/public/workspace/apache-httpd/srclib/apr-util/include -g -O2 -g -O2 -I /opt/jdk1.4/include -I
Re: Online JK Docs - Updates needed
Mladen Turk wrote: NormW wrote: Greetings All, Can the online JTC properties docs be brought up to speed with recent changes to the module, please? They are in sync (well, except some default values). Tomorrow, OK 8)? Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] . Good evening from Au. Thanks for the reply... if that's all that's changed, great! I only build the executable and its a lot easier to read the docs in html than xml... Thanks! Norm - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Mod_Jk -- Latest CVS
Mladen Turk wrote: NormW wrote: Greetings All, Just built the latest Mod_Jk from CVS with Apache2.1 on Win for NetWare, and with only the three 'mandatory' settings for worker1 of type, host and port, all I'm getting is Internal Server Error, and the Jk logs do not show good signs of matching URL's to the worker1... You have a syntax error in the workers.properties. When ever you find: [debug] jk_worker.c (88): did not find a worker worker1 It means: Uri is parsed for worker1, but the worker1 was failed to create. The problem is that when the worker is created (when reading config) the mod_jk.log is not jet present. I'll try to use apache logger for that, but It'll have to wait for 1.2.9. Just post those three lines :) Mladen. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] . Good evening [still...], I'm still using the JkWorkerProperty directive in the Apache conf for all the worker settings, but either way ought to be the same (I guess) so will more closely review the settings and see what difference[s] (if any) I can note using both methods. Thanks again, Norm - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
